[Impala-ASF-CR] IMPALA-11459: Use new LLVM Pass Manager

2023-06-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20014 ) Change subject: IMPALA-11459: Use new LLVM Pass Manager .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4530: Implement in-memory merge of quicksorted runs

2023-06-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18393 ) Change subject: IMPALA-4530: Implement in-memory merge of quicksorted runs .. IMPALA-4530: Implement in-memory merge of

[Impala-ASF-CR] IMPALA-4530: Implement in-memory merge of quicksorted runs

2023-06-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18393 ) Change subject: IMPALA-4530: Implement in-memory merge of quicksorted runs .. Patch Set 28: Verified+1 Code-Review+2 The failure in

[Impala-ASF-CR] IMPALA-4530: Implement in-memory merge of quicksorted runs

2023-06-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has removed a vote on this change. Change subject: IMPALA-4530: Implement in-memory merge of quicksorted runs .. Removed Verified-1 by Impala Public Jenkins -- To view, visit

[Impala-ASF-CR] IMPALA-11877: (part 1) Add support for DELETE statements for UNPARTITIONED Iceberg tables

2023-06-07 Thread Anonymous Coward (Code Review)
lipeng...@apache.org has posted comments on this change. ( http://gerrit.cloudera.org:8080/19776 ) Change subject: IMPALA-11877: (part 1) Add support for DELETE statements for UNPARTITIONED Iceberg tables .. Patch Set 11: (1

[Impala-ASF-CR] IMPALA-11535: Skip older events in the event processor based on the latestRefreshEventID

2023-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20022 ) Change subject: IMPALA-11535: Skip older events in the event processor based on the latestRefreshEventID .. Patch Set 1:

[Impala-ASF-CR] IMPALA-11535: Skip older events in the event processor based on the latestRefreshEventID

2023-06-07 Thread Sai Hemanth Gantasala (Code Review)
Sai Hemanth Gantasala has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20022 Change subject: IMPALA-11535: Skip older events in the event processor based on the latestRefreshEventID .. IMPALA-11535: Skip

[Impala-ASF-CR] IMPALA-12185: Don't install snappy-devel for Red Hat derivatives

2023-06-07 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20021 ) Change subject: IMPALA-12185: Don't install snappy-devel for Red Hat derivatives .. Patch Set 1: Code-Review+2 Found snappy-devel

[Impala-ASF-CR] IMPALA-12183: Fix cardinality clamping across aggregation phases

2023-06-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20009 ) Change subject: IMPALA-12183: Fix cardinality clamping across aggregation phases .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-4530: Implement in-memory merge of quicksorted runs

2023-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18393 ) Change subject: IMPALA-4530: Implement in-memory merge of quicksorted runs .. Patch Set 28: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-12176: Improve client fetch metrics

2023-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19966 ) Change subject: IMPALA-12176: Improve client fetch metrics .. Patch Set 13: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12176: Improve client fetch metrics

2023-06-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19966 ) Change subject: IMPALA-12176: Improve client fetch metrics .. Patch Set 13: Code-Review+2 This looks good to me. I started a GVO job

[Impala-ASF-CR] IMPALA-12150: Use protocol version to isolate cluster components

2023-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19959 ) Change subject: IMPALA-12150: Use protocol version to isolate cluster components .. Patch Set 12: Build Successful

[Impala-ASF-CR] IMPALA-12150: Use protocol version to isolate cluster components

2023-06-07 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/19959 ) Change subject: IMPALA-12150: Use protocol version to isolate cluster components .. IMPALA-12150: Use protocol version to isolate cluster

[Impala-ASF-CR] IMPALA-12183: Fix cardinality clamping across aggregation phases

2023-06-07 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/20009 ) Change subject: IMPALA-12183: Fix cardinality clamping across aggregation phases .. Patch Set 5: Code-Review+1 (1 comment) LGTM. Will

[Impala-ASF-CR] IMPALA-11877: (part 1) Add support for DELETE statements for UNPARTITIONED Iceberg tables

2023-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19776 ) Change subject: IMPALA-11877: (part 1) Add support for DELETE statements for UNPARTITIONED Iceberg tables .. Patch Set 11:

[Impala-ASF-CR] IMPALA-12182: Add CPU utilization chart for RuntimeProfile's sampled metrics

2023-06-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20008 ) Change subject: IMPALA-12182: Add CPU utilization chart for RuntimeProfile's sampled metrics .. Patch Set 1: (1 comment)

[Impala-ASF-CR] [DO-NOT-MERGE] Experimental link time optimization

2023-06-07 Thread Michael Smith (Code Review)
Michael Smith has abandoned this change. ( http://gerrit.cloudera.org:8080/18131 ) Change subject: [DO-NOT-MERGE] Experimental link time optimization .. Abandoned Rerun shows very marginal change (only significant improvement

[Impala-ASF-CR] IMPALA-11877: (part 1) Add support for DELETE statements for UNPARTITIONED Iceberg tables

2023-06-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19776 ) Change subject: IMPALA-11877: (part 1) Add support for DELETE statements for UNPARTITIONED Iceberg tables .. Patch Set 11: (10

[Impala-ASF-CR] IMPALA-11877: (part 1) Add support for DELETE statements for UNPARTITIONED Iceberg tables

2023-06-07 Thread Zoltan Borok-Nagy (Code Review)
Hello Andrew Sherman, Tamas Mate, Gabor Kaszab, lipeng...@apache.org, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19776 to look at the new patch set (#11). Change subject: IMPALA-11877: (part 1) Add support for DELETE statements

[Impala-ASF-CR] IMPALA-11877: (part 1) Add support for DELETE statements for UNPARTITIONED Iceberg tables

2023-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19776 ) Change subject: IMPALA-11877: (part 1) Add support for DELETE statements for UNPARTITIONED Iceberg tables .. Patch Set 11:

[Impala-ASF-CR] IMPALA-12185: Don't install snappy-devel for Red Hat derivatives

2023-06-07 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20021 ) Change subject: IMPALA-12185: Don't install snappy-devel for Red Hat derivatives .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12183: Fix cardinality clamping across aggregation phases

2023-06-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20009 ) Change subject: IMPALA-12183: Fix cardinality clamping across aggregation phases .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-12183: Fix cardinality clamping across aggregation phases

2023-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20009 ) Change subject: IMPALA-12183: Fix cardinality clamping across aggregation phases .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-12171: Optimize delimited output

2023-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19894 ) Change subject: IMPALA-12171: Optimize delimited output .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-12171: Optimize delimited output

2023-06-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19894 ) Change subject: IMPALA-12171: Optimize delimited output .. Patch Set 8: (8 comments)

[Impala-ASF-CR] IMPALA-12171: Optimize delimited output

2023-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19894 ) Change subject: IMPALA-12171: Optimize delimited output .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-12183: Fix cardinality clamping across aggregation phases

2023-06-07 Thread Riza Suminto (Code Review)
Hello Aman Sinha, Kurt Deschler, Abhishek Rawat, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20009 to look at the new patch set (#5). Change subject: IMPALA-12183: Fix cardinality clamping across aggregation phases

[Impala-ASF-CR] IMPALA-12171: Optimize delimited output

2023-06-07 Thread Csaba Ringhofer (Code Review)
Hello Quanlong Huang, Daniel Becker, Jason Fehr, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19894 to look at the new patch set (#8). Change subject: IMPALA-12171: Optimize delimited output

[Impala-ASF-CR] IMPALA-12171: Optimize delimited output

2023-06-07 Thread Csaba Ringhofer (Code Review)
Hello Quanlong Huang, Daniel Becker, Jason Fehr, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19894 to look at the new patch set (#7). Change subject: IMPALA-12171: Optimize delimited output

[Impala-ASF-CR] IMPALA-12171: Optimize delimited output

2023-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19894 ) Change subject: IMPALA-12171: Optimize delimited output .. Patch Set 7: (3 comments)

[Impala-ASF-CR] IMPALA-4530: Implement in-memory merge of quicksorted runs

2023-06-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18393 ) Change subject: IMPALA-4530: Implement in-memory merge of quicksorted runs .. Patch Set 27: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4530: Implement in-memory merge of quicksorted runs

2023-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18393 ) Change subject: IMPALA-4530: Implement in-memory merge of quicksorted runs .. Patch Set 28: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4530: Implement in-memory merge of quicksorted runs

2023-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18393 ) Change subject: IMPALA-4530: Implement in-memory merge of quicksorted runs .. Patch Set 28: Build started:

[Impala-ASF-CR] IMPALA-12189: updateCatalog should handle failures in createTblTransaction

2023-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20020 ) Change subject: IMPALA-12189: updateCatalog should handle failures in createTblTransaction .. Patch Set 4: Verified+1 -- To

[Impala-ASF-CR] IMPALA-12189: updateCatalog should handle failures in createTblTransaction

2023-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20020 ) Change subject: IMPALA-12189: updateCatalog should handle failures in createTblTransaction .. IMPALA-12189:

[Impala-ASF-CR] IMPALA-12176: Improve client fetch metrics

2023-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19966 ) Change subject: IMPALA-12176: Improve client fetch metrics .. Patch Set 13: Build started:

[Impala-ASF-CR] IMPALA-4530: Implement in-memory merge of quicksorted runs

2023-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18393 ) Change subject: IMPALA-4530: Implement in-memory merge of quicksorted runs .. Patch Set 27: Build Successful

[Impala-ASF-CR] IMPALA-4530: Implement in-memory merge of quicksorted runs

2023-06-07 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#27). ( http://gerrit.cloudera.org:8080/18393 ) Change subject: IMPALA-4530: Implement in-memory merge of quicksorted runs .. IMPALA-4530: Implement in-memory merge of quicksorted

[Impala-ASF-CR] IMPALA-12183: Fix cardinality clamping across aggregation phases

2023-06-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20009 ) Change subject: IMPALA-12183: Fix cardinality clamping across aggregation phases .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-12185: Don't install snappy-devel for Red Hat derivatives

2023-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20021 ) Change subject: IMPALA-12185: Don't install snappy-devel for Red Hat derivatives .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-12185: Don't install snappy-devel for Red Hat derivatives

2023-06-07 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20021 Change subject: IMPALA-12185: Don't install snappy-devel for Red Hat derivatives .. IMPALA-12185: Don't install snappy-devel for Red Hat

[Impala-ASF-CR] IMPALA-4530: Implement in-memory merge of quicksorted runs

2023-06-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18393 ) Change subject: IMPALA-4530: Implement in-memory merge of quicksorted runs .. Patch Set 25: -Code-Review (1 comment)

[Impala-ASF-CR] IMPALA-4530: Implement in-memory merge of quicksorted runs

2023-06-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18393 ) Change subject: IMPALA-4530: Implement in-memory merge of quicksorted runs .. Patch Set 25: Code-Review+2 (6 comments)

[Impala-ASF-CR] IMPALA-4530: Implement in-memory merge of quicksorted runs

2023-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18393 ) Change subject: IMPALA-4530: Implement in-memory merge of quicksorted runs .. Patch Set 25: Build Successful

[Impala-ASF-CR] IMPALA-4530: Implement in-memory merge of quicksorted runs

2023-06-07 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#25). ( http://gerrit.cloudera.org:8080/18393 ) Change subject: IMPALA-4530: Implement in-memory merge of quicksorted runs .. IMPALA-4530: Implement in-memory merge of quicksorted

[Impala-ASF-CR] IMPALA-12189: updateCatalog should handle failures in createTblTransaction

2023-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20020 ) Change subject: IMPALA-12189: updateCatalog should handle failures in createTblTransaction .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-12189: updateCatalog should handle failures in createTblTransaction

2023-06-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20020 ) Change subject: IMPALA-12189: updateCatalog should handle failures in createTblTransaction .. Patch Set 4: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-12189: updateCatalog should handle failures in createTblTransaction

2023-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20020 ) Change subject: IMPALA-12189: updateCatalog should handle failures in createTblTransaction .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-12189: updateCatalog should handle failures in createTblTransaction

2023-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20020 ) Change subject: IMPALA-12189: updateCatalog should handle failures in createTblTransaction .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-12189: updateCatalog should handle failures in createTblTransaction

2023-06-07 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20020 ) Change subject: IMPALA-12189: updateCatalog should handle failures in createTblTransaction .. Patch Set 3: (1 comment) Thanks for

[Impala-ASF-CR] IMPALA-12189: updateCatalog should handle failures in createTblTransaction

2023-06-07 Thread Quanlong Huang (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20020 to look at the new patch set (#4). Change subject: IMPALA-12189: updateCatalog should handle failures in createTblTransaction

[Impala-ASF-CR] IMPALA-12189: updateCatalog should handle failures in createTblTransaction

2023-06-07 Thread Quanlong Huang (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20020 to look at the new patch set (#3). Change subject: IMPALA-12189: updateCatalog should handle failures in createTblTransaction

[Impala-ASF-CR] IMPALA-12189: updateCatalog should handle failures in createTblTransaction

2023-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20020 ) Change subject: IMPALA-12189: updateCatalog should handle failures in createTblTransaction .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-12189: updateCatalog should handle failures in createTblTransaction

2023-06-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20020 ) Change subject: IMPALA-12189: updateCatalog should handle failures in createTblTransaction .. Patch Set 2: Code-Review+2 (1

[Impala-ASF-CR] IMPALA-12189: updateCatalog should handle failures in createTblTransaction

2023-06-07 Thread Quanlong Huang (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20020 to look at the new patch set (#2). Change subject: IMPALA-12189: updateCatalog should handle failures in createTblTransaction

[Impala-ASF-CR] IMPALA-12178: Refined alignment for timeticks in query timeline

2023-06-07 Thread Surya Hebbar (Code Review)
Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/19997 ) Change subject: IMPALA-12178: Refined alignment for timeticks in query timeline .. Patch Set 1: > The code change looks good to me. >

[Impala-ASF-CR] IMPALA-12182: Add CPU utilization chart for RuntimeProfile's sampled metrics

2023-06-07 Thread Surya Hebbar (Code Review)
Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/20008 ) Change subject: IMPALA-12182: Add CPU utilization chart for RuntimeProfile's sampled metrics .. Patch Set 1: (13 comments) > (8