[Impala-ASF-CR] IMPALA-13093: Fix failure in inserting into OBS tables

2024-05-17 Thread Xiang Yang (Code Review)
Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21438 ) Change subject: IMPALA-13093: Fix failure in inserting into OBS tables .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-17 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 2: (1 comment) > Patch Set 1:

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-17 Thread Yifan Zhang (Code Review)
Hello Daniel Becker, Gabor Kaszab, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21441 to look at the new patch set (#2). Change subject: IMPALA-12562: Cast double and float to string with exact

[Impala-ASF-CR] IMPALA-13083: Clarify REASON MEM LIMIT TOO LOW FOR RESERVATION

2024-05-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21436 ) Change subject: IMPALA-13083: Clarify REASON_MEM_LIMIT_TOO_LOW_FOR_RESERVATION .. Patch Set 1: (15 comments) I like this change a

[native-toolchain-CR] IMPALA-12886: Bump GoogleTest version to 1.14.0

2024-05-17 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21133 ) Change subject: IMPALA-12886: Bump GoogleTest version to 1.14.0 .. IMPALA-12886: Bump GoogleTest version to 1.14.0 This is to

[native-toolchain-CR] IMPALA-12886: Bump GoogleTest version to 1.14.0

2024-05-17 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21133 ) Change subject: IMPALA-12886: Bump GoogleTest version to 1.14.0 .. Patch Set 4: Code-Review+2 Carry +2 from Joe -- To view, visit

[native-toolchain-CR] IMPALA-12886: Bump GoogleTest version to 1.14.0

2024-05-17 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21133 ) Change subject: IMPALA-12886: Bump GoogleTest version to 1.14.0 .. Patch Set 4: Verified+1 Built successfully on private infrastructure

[Impala-ASF-CR] xxxx HA

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21418 ) Change subject: HA .. Patch Set 5: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/16185/ :

[Impala-ASF-CR] IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21437 ) Change subject: IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off .. Patch Set 1: Build

[Impala-ASF-CR] IMPALA-13034: Add logs and counters for HTTP profile requests blocking client fetches

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21412 ) Change subject: IMPALA-13034: Add logs and counters for HTTP profile requests blocking client fetches .. Patch Set 3: Build

[Impala-ASF-CR] IMPALA-13093: Fix failure in inserting into OBS tables

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21438 ) Change subject: IMPALA-13093: Fix failure in inserting into OBS tables .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 1: Build Failed

[Impala-ASF-CR] IMPALA-12935: First pass on Calcite planner functions

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21357 ) Change subject: IMPALA-12935: First pass on Calcite planner functions .. Patch Set 11: Build Successful

[Impala-ASF-CR] IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off

2024-05-17 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21437 ) Change subject: IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. IMPALA-13020 (part 2): Split

[Impala-ASF-CR] IMPALA-13020 (part 1): Change thrift rpc max message size to int64 t

2024-05-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21367 ) Change subject: IMPALA-13020 (part 1): Change thrift_rpc_max_message_size to int64_t .. IMPALA-13020 (part 1): Change

[Impala-ASF-CR] IMPALA-13020 (part 1): Change thrift rpc max message size to int64 t

2024-05-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21367 ) Change subject: IMPALA-13020 (part 1): Change thrift_rpc_max_message_size to int64_t .. Patch Set 5: Verified+1 Code-Review+2 I'm

[Impala-ASF-CR] IMPALA-13017: Add S3 bucket endpoint parameters for the minicluster

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21442 ) Change subject: IMPALA-13017: Add S3 bucket endpoint parameters for the minicluster .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-13091: query test.test iceberg.TestIcebergV2Table.test metadata tables fails on an expected constant

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21440 ) Change subject: IMPALA-13091: query_test.test_iceberg.TestIcebergV2Table.test_metadata_tables fails on an expected constant ..

[Impala-ASF-CR] IMPALA-13040: (addendum) Inject larger delay for sanitized build

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21439 ) Change subject: IMPALA-13040: (addendum) Inject larger delay for sanitized build .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 3: Build

[Impala-ASF-CR] IMPALA-13020 (part 1): Change thrift rpc max message size to int64 t

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21367 ) Change subject: IMPALA-13020 (part 1): Change thrift_rpc_max_message_size to int64_t .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-13017: Add S3 bucket endpoint parameters for the minicluster

2024-05-17 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21442 Change subject: IMPALA-13017: Add S3 bucket endpoint parameters for the minicluster .. IMPALA-13017: Add S3 bucket endpoint parameters

[Impala-ASF-CR] IMPALA-13017: Add S3 bucket endpoint parameters for the minicluster

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21442 ) Change subject: IMPALA-13017: Add S3 bucket endpoint parameters for the minicluster .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-12935: First pass on Calcite planner functions

2024-05-17 Thread Steve Carlin (Code Review)
Hello Aman Sinha, Joe McDonnell, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21357 to look at the new patch set (#11). Change subject: IMPALA-12935: First pass on Calcite planner functions

[Impala-ASF-CR] IMPALA-12935: First pass on Calcite planner functions

2024-05-17 Thread Steve Carlin (Code Review)
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21357 ) Change subject: IMPALA-12935: First pass on Calcite planner functions .. Patch Set 10: (2 comments)

[Impala-ASF-CR] IMPALA-13020 (part 1): Change thrift rpc max message size to int64 t

2024-05-17 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21367 ) Change subject: IMPALA-13020 (part 1): Change thrift_rpc_max_message_size to int64_t .. Patch Set 5: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-17 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 3: Code-Review+2 (1

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-17 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 1: Code-Review+1 (1 comment) Thanks

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-17 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-13034: Add logs and counters for HTTP profile requests blocking client fetches

2024-05-17 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21412 ) Change subject: IMPALA-13034: Add logs and counters for HTTP profile requests blocking client fetches .. Patch Set 3: Code-Review+1

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-17 Thread Yifan Zhang (Code Review)
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21441 Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. IMPALA-12562: Cast double and float to string with

[Impala-ASF-CR] IMPALA-13091: query test.test iceberg.TestIcebergV2Table.test metadata tables fails on an expected constant

2024-05-17 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21440 ) Change subject: IMPALA-13091: query_test.test_iceberg.TestIcebergV2Table.test_metadata_tables fails on an expected constant .. Patch

[Impala-ASF-CR] IMPALA-13040: (addendum) Inject larger delay for sanitized build

2024-05-17 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21439 ) Change subject: IMPALA-13040: (addendum) Inject larger delay for sanitized build .. Patch Set 2: Code-Review+2 Thanks Csaba! Carry +2.

[Impala-ASF-CR] IMPALA-13040: (addendum) Inject larger delay for sanitized build

2024-05-17 Thread Riza Suminto (Code Review)
Hello Laszlo Gaal, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21439 to look at the new patch set (#2). Change subject: IMPALA-13040: (addendum) Inject larger delay for sanitized build

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-17 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 3: Code-Review+1 > Patch

[Impala-ASF-CR] IMPALA-13055: Some Iceberg metadata table tests don't assert

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21394 ) Change subject: IMPALA-13055: Some Iceberg metadata table tests don't assert .. IMPALA-13055: Some Iceberg metadata

[Impala-ASF-CR] IMPALA-13055: Some Iceberg metadata table tests don't assert

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21394 ) Change subject: IMPALA-13055: Some Iceberg metadata table tests don't assert .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-13029: Tests for multi format equality deletes

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21348 ) Change subject: IMPALA-13029: Tests for multi format equality deletes .. Patch Set 5: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-13091: query test.test iceberg.TestIcebergV2Table.test metadata tables fails on an expected constant

2024-05-17 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21440 Change subject: IMPALA-13091: query_test.test_iceberg.TestIcebergV2Table.test_metadata_tables fails on an expected constant ..

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 3: Verified+1 --

[Impala-ASF-CR] IMPALA-13040: (addendum) Inject larger delay for sanitized build

2024-05-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21439 ) Change subject: IMPALA-13040: (addendum) Inject larger delay for sanitized build .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-13034: Add logs and counters for HTTP profile requests blocking client fetches

2024-05-17 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21412 ) Change subject: IMPALA-13034: Add logs and counters for HTTP profile requests blocking client fetches .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-13034: Add logs and counters for HTTP profile requests blocking client fetches

2024-05-17 Thread Quanlong Huang (Code Review)
Hello Kurt Deschler, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21412 to look at the new patch set (#3). Change subject: IMPALA-13034: Add logs and counters for HTTP profile requests blocking

[Impala-ASF-CR] IMPALA-13055: Some Iceberg metadata table tests don't assert

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21394 ) Change subject: IMPALA-13055: Some Iceberg metadata table tests don't assert .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-13055: Some Iceberg metadata table tests don't assert

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21394 ) Change subject: IMPALA-13055: Some Iceberg metadata table tests don't assert .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-13029: Tests for multi format equality deletes

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21348 ) Change subject: IMPALA-13029: Tests for multi format equality deletes .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-13029: Tests for multi format equality deletes

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21348 ) Change subject: IMPALA-13029: Tests for multi format equality deletes .. Patch Set 5: Build started: