[Impala-ASF-CR] IMPALA-9980: Remove jersey* jars from maven exclusions

2020-07-20 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/16225 ) Change subject: IMPALA-9980: Remove jersey* jars from maven exclusions .. Patch Set 2: Makes sense. Thanks. -- To view,

[Impala-ASF-CR] IMPALA-9980: Remove jersey* jars from maven exclusions

2020-07-20 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/16225 ) Change subject: IMPALA-9980: Remove jersey* jars from maven exclusions .. Patch Set 2: Could we just add jersey-server.jar and

[Impala-ASF-CR] IMPALA-9980: Remove jersey* jars from maven exclusions

2020-07-20 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/16225 ) Change subject: IMPALA-9980: Remove jersey* jars from maven exclusions .. Patch Set 2: (1 comment) Instead of removing all

[Impala-ASF-CR] IMPALA-9980: Remove jersey* jars from maven exclusions

2020-07-20 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16225 ) Change subject: IMPALA-9980: Remove jersey* jars from maven exclusions .. IMPALA-9980: Remove jersey* jars from maven exclusions

[Impala-ASF-CR] IMPALA-9980: Remove jersey* jars from maven exclusions

2020-07-20 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16225 Change subject: IMPALA-9980: Remove jersey* jars from maven exclusions .. IMPALA-9980: Remove jersey* jars from maven exclusions

[Impala-ASF-CR] IMPALA-9913: Use table id to match the table in drop table event

2020-06-30 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/16129 ) Change subject: IMPALA-9913: Use table id to match the table in drop table event .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-9858: Fix wrong partition metrics in LocalCatalog profile

2020-06-15 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/16080 ) Change subject: IMPALA-9858: Fix wrong partition metrics in LocalCatalog profile .. Patch Set 1: Code-Review+2 (2 comments)

[Impala-ASF-CR] Filter out "Checksum validation failed" messages during the maven build

2020-06-05 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15775 ) Change subject: Filter out "Checksum validation failed" messages during the maven build .. Patch Set 4: Code-Review+2 -- To

[Impala-ASF-CR] Filter out "Checksum validation failed" messages during the maven build

2020-06-05 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15775 ) Change subject: Filter out "Checksum validation failed" messages during the maven build .. Filter out "Checksum

[Impala-ASF-CR](asf-site) Add link to slack channel on community

2020-06-03 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/16024 ) Change subject: Add link to slack channel on community .. Patch Set 1: Also, we need to add this url. Thanks. -- To view,

[Impala-ASF-CR](asf-site) Add link to slack channel on community

2020-06-03 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has removed a vote on this change. Change subject: Add link to slack channel on community .. Removed Code-Review+2 by Anurag Mantripragada -- To view, visit http://gerrit.cloudera.org:8080/16024 To

[Impala-ASF-CR](asf-site) Add link to slack channel on community

2020-06-03 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/16024 ) Change subject: Add link to slack channel on community .. Patch Set 1: Code-Review+2 This worked for me, thanks. Can we make

[Impala-ASF-CR](asf-site) Add link to slack channel on community

2020-06-03 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/16024 ) Change subject: Add link to slack channel on community .. Patch Set 1: Is this an "invite-only" workspace? I couldn't log in

[Impala-ASF-CR] IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API

2020-06-01 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/16008 ) Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API .. Patch Set 2: (8 comments) I did the

[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.

2020-05-29 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 ) Change subject: IMPALA-9749: ASAN builds should not run FE tests. .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.

2020-05-29 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/15921 ) Change subject: IMPALA-9749: ASAN builds should not run FE tests. .. IMPALA-9749: ASAN builds should not run FE tests.

[Impala-ASF-CR] IMPALA-9787: fix spinning thread with memory-based table invalidation

2020-05-28 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15994 ) Change subject: IMPALA-9787: fix spinning thread with memory-based table invalidation .. Patch Set 2: Code-Review+2 Hmm,

[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.

2020-05-23 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 ) Change subject: IMPALA-9749: ASAN builds should not run FE tests. .. Patch Set 4: The precommits as well as ASAN private

[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.

2020-05-22 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 ) Change subject: IMPALA-9749: ASAN builds should not run FE tests. .. Patch Set 4: (1 comment) Made the changes suggested by

[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.

2020-05-22 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15921 ) Change subject: IMPALA-9749: ASAN builds should not run FE tests. .. IMPALA-9749: ASAN builds should not run FE tests.

[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.

2020-05-19 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/15921 ) Change subject: IMPALA-9749: ASAN builds should not run FE tests. .. IMPALA-9749: ASAN builds should not run FE tests.

[Impala-ASF-CR] [WIP] IMPALA-9433: File handle cache improvements.

2020-05-18 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15699 Change subject: [WIP] IMPALA-9433: File handle cache improvements. .. [WIP] IMPALA-9433: File handle cache improvements.

[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.

2020-05-18 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 ) Change subject: IMPALA-9749: ASAN builds should not run FE tests. .. Patch Set 2: Looks like the environment variable is

[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.

2020-05-14 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15921 Change subject: IMPALA-9749: ASAN builds should not run FE tests. .. IMPALA-9749: ASAN builds should not run FE tests.

[Impala-ASF-CR] IMPALA-9669: Fix wrong table types for GET TABLES in LocalCatalog

2020-05-12 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15887 ) Change subject: IMPALA-9669: Fix wrong table types for GET_TABLES in LocalCatalog .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-9365: Disable acid-negative.test on non-HDFS filesystems

2020-05-04 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15862 ) Change subject: IMPALA-9365: Disable acid-negative.test on non-HDFS filesystems .. Patch Set 1: Code-Review+1 Thanks for the

[Impala-ASF-CR] IMPALA-9677: Fix frontend tests using a non-existent S3 bucket

2020-04-24 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15799 ) Change subject: IMPALA-9677: Fix frontend tests using a non-existent S3 bucket .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-9574: support ubuntu 18.04 base image

2020-04-21 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15765 ) Change subject: IMPALA-9574: support ubuntu 18.04 base image .. Patch Set 2: Code-Review+1 Looks good to me. -- To view,

[Impala-ASF-CR] IMPALA-9574: support ubuntu 18.04 base image

2020-04-20 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15765 ) Change subject: IMPALA-9574: support ubuntu 18.04 base image .. Patch Set 1: Is this a part of a bigger change? I do not see

[Impala-ASF-CR] IMPALA-9663: Fix for NPE in fire listener events

2020-04-16 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15745 ) Change subject: IMPALA-9663: Fix for NPE in fire listener events .. Patch Set 2: Code-Review+1 (1 comment) Thanks for the

[Impala-ASF-CR] IMPALA-9663: Fix for NPE in fire listener events

2020-04-16 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15745 ) Change subject: IMPALA-9663: Fix for NPE in fire listener events .. Patch Set 2: Thanks. -- To view, visit

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2020-04-12 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14272 ) Change subject: IMPALA-8795 : Enable event polling by default in dockerized tests. .. Patch Set 13: A couple of important

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2020-04-12 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/14272 ) Change subject: IMPALA-8795 : Enable event polling by default in dockerized tests. .. IMPALA-8795 : Enable event polling by

[Impala-ASF-CR] IMPALA-8632: Add support for self-event detection for insert events

2020-04-07 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15648 ) Change subject: IMPALA-8632: Add support for self-event detection for insert events .. Patch Set 5: Code-Review+1 Thanks for

[Impala-ASF-CR] IMPALA-8632: Add support for self-event detection for insert events

2020-04-07 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15648 ) Change subject: IMPALA-8632: Add support for self-event detection for insert events .. Patch Set 4: (15 comments) Thanks for

[Impala-ASF-CR] IMPALA-8857: Fix flaky Kudu tests with external inserts

2020-04-07 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15633 ) Change subject: IMPALA-8857: Fix flaky Kudu tests with external inserts .. Patch Set 1: Change looks good to me. Just curious

[Impala-ASF-CR] IMPALA-8857: Fix flaky Kudu tests with external inserts

2020-04-07 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15633 ) Change subject: IMPALA-8857: Fix flaky Kudu tests with external inserts .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8005: Randomize partitioning exchanges.

2020-03-26 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/15497 ) Change subject: IMPALA-8005: Randomize partitioning exchanges. .. IMPALA-8005: Randomize partitioning exchanges. Currently, we

[Impala-ASF-CR] IMPALA-8005: Randomize partitioning exchanges.

2020-03-26 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15497 ) Change subject: IMPALA-8005: Randomize partitioning exchanges. .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-9549: Handle catalogd startup delays when using local catalog

2020-03-26 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15561 ) Change subject: IMPALA-9549: Handle catalogd startup delays when using local catalog .. Patch Set 2: Code-Review+1 Thanks for

[Impala-ASF-CR] IMPALA-8005: Randomize partitioning exchanges.

2020-03-21 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15497 ) Change subject: IMPALA-8005: Randomize partitioning exchanges. .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-8005: Randomize partitioning exchanges.

2020-03-21 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15497 ) Change subject: IMPALA-8005: Randomize partitioning exchanges. .. IMPALA-8005: Randomize partitioning exchanges. Currently, we

[Impala-ASF-CR] IMPALA-8005: Randomize partitioning exchanges.

2020-03-19 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/15497 ) Change subject: IMPALA-8005: Randomize partitioning exchanges. .. IMPALA-8005: Randomize partitioning exchanges. Currently, we

[Impala-ASF-CR] IMPALA-8005: Randomize partitioning exchanges.

2020-03-19 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15497 ) Change subject: IMPALA-8005: Randomize partitioning exchanges. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8005: Randomize partitioning exchanges.

2020-03-19 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/15497 ) Change subject: IMPALA-8005: Randomize partitioning exchanges. .. IMPALA-8005: Randomize partitioning exchanges. Currently, we

[Impala-ASF-CR] IMPALA-8005: Randomize partitioning exchanges.

2020-03-19 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15497 Change subject: IMPALA-8005: Randomize partitioning exchanges. .. IMPALA-8005: Randomize partitioning exchanges. Currently, we

[Impala-ASF-CR] IMPALA-9369: Make createInsertEvents() async.

2020-03-09 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/15263 ) Change subject: IMPALA-9369: Make createInsertEvents() async. .. IMPALA-9369: Make createInsertEvents() async. This patch makes

[Impala-ASF-CR] IMPALA-9369: Make createInsertEvents() async.

2020-03-09 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15263 ) Change subject: IMPALA-9369: Make createInsertEvents() async. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-9357: Fix race condition in alter database event

2020-03-05 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15260 ) Change subject: IMPALA-9357: Fix race condition in alter_database event .. Patch Set 5: Code-Review+1 (1 comment) Thanks!

[Impala-ASF-CR] IMPALA-8738: "show extended tables" to return more than the table name

2020-03-04 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14422 ) Change subject: IMPALA-8738: "show extended tables" to return more than the table name .. Patch Set 8: Should we abandon this

[Impala-ASF-CR] IMPALA-9369: Make createInsertEvents() async.

2020-03-01 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15263 ) Change subject: IMPALA-9369: Make createInsertEvents() async. .. Patch Set 2: Thanks for researching CompletableFuture :) I

[Impala-ASF-CR] IMPALA-9369: Make createInsertEvents() async.

2020-03-01 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/15263 ) Change subject: IMPALA-9369: Make createInsertEvents() async. .. IMPALA-9369: Make createInsertEvents() async. This patch makes

[Impala-ASF-CR] IMPALA-9357: Fix race condition in alter database event

2020-02-21 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15260 ) Change subject: IMPALA-9357: Fix race condition in alter_database event .. Patch Set 1: Code-Review+1 LGTM. -- To view,

[Impala-ASF-CR] IMPALA-8852: Skip short-circuit config check for dedicated coordinator

2020-02-21 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 ) Change subject: IMPALA-8852: Skip short-circuit config check for dedicated coordinator .. Patch Set 10: Code-Review+1 LGTM!

[Impala-ASF-CR] IMPALA-9369: Make createInsertEvents() async.

2020-02-20 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15263 ) Change subject: IMPALA-9369: Make createInsertEvents() async. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-9369: Make createInsertEvents() async.

2020-02-20 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15263 Change subject: IMPALA-9369: Make createInsertEvents() async. .. IMPALA-9369: Make createInsertEvents() async. This patch makes

[Impala-ASF-CR] IMPALA-6689: Speed up point lookup for Kudu primary key

2020-02-20 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15250 ) Change subject: IMPALA-6689: Speed up point lookup for Kudu primary key .. Patch Set 2: I agree that these optimizations could

[Impala-ASF-CR] IMPALA-9386: Remove hive-metastore dependency from hive-3 profile

2020-02-19 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15223 ) Change subject: IMPALA-9386: Remove hive-metastore dependency from hive-3 profile .. Patch Set 2: Abandon this? -- To view,

[Impala-ASF-CR] IMPALA-9256: Refactor constraint information into a separate class.

2020-02-14 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15213 ) Change subject: IMPALA-9256: Refactor constraint information into a separate class. .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-9256: Refactor constraint information into a separate class.

2020-02-14 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15213 ) Change subject: IMPALA-9256: Refactor constraint information into a separate class. .. IMPALA-9256: Refactor constraint

[Impala-ASF-CR] IMPALA-9256: Refactor constraint information into a separate class.

2020-02-14 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/15213 ) Change subject: IMPALA-9256: Refactor constraint information into a separate class. .. IMPALA-9256: Refactor constraint

[Impala-ASF-CR] IMPALA-9256: Refactor constraint information into a separate class.

2020-02-13 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15213 ) Change subject: IMPALA-9256: Refactor constraint information into a separate class. .. Patch Set 1: The build errors are due

[Impala-ASF-CR] IMPALA-9256: Refactor constraint information into a separate class.

2020-02-12 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15213 Change subject: IMPALA-9256: Refactor constraint information into a separate class. .. IMPALA-9256: Refactor constraint

[Impala-ASF-CR] IMPALA-8852: Skip short-circuit config check for coordinator-only mode

2020-02-09 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 ) Change subject: IMPALA-8852: Skip short-circuit config check for coordinator-only mode .. Patch Set 4: Code-Review+1 LGTM.

[Impala-ASF-CR] IMPALA-8852: Skip short-circuit config check for coordinator-only mode

2020-02-07 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 ) Change subject: IMPALA-8852: Skip short-circuit config check for coordinator-only mode .. Patch Set 3: Code-Review+1 (1

[Impala-ASF-CR] IMPALA-9358: Query slowdown with inline views and hundreds of columns

2020-02-07 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15157 ) Change subject: IMPALA-9358: Query slowdown with inline views and hundreds of columns .. Patch Set 3: Code-Review+1 -- To

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2020-02-06 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/14272 ) Change subject: IMPALA-8795 : Enable event polling by default in dockerized tests. .. IMPALA-8795 : Enable event polling by

[Impala-ASF-CR] IMPALA-8852: Skipping short-circuit config check for coordinator only

2020-02-06 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 ) Change subject: IMPALA-8852: Skipping short-circuit config check for coordinator only .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8852: Skipping short-circuit config check for coordinator only

2020-02-06 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 ) Change subject: IMPALA-8852: Skipping short-circuit config check for coordinator only .. Patch Set 2: (5 comments) Thanks

[Impala-ASF-CR] IMPALA-9358: Query slowdown with inline views and hundreds of columns

2020-02-05 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15157 ) Change subject: IMPALA-9358: Query slowdown with inline views and hundreds of columns .. Patch Set 2: Code-Review+1 LGTM! I

[Impala-ASF-CR] IMPALA-9358: Query slowdown with inline views and hundreds of columns

2020-02-04 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15157 ) Change subject: IMPALA-9358: Query slowdown with inline views and hundreds of columns .. Patch Set 1: (2 comments) Thanks

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints

2020-02-03 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15146 ) Change subject: IMPALA-9336: [DOCS] constraints .. Patch Set 4: Code-Review+1 Looks good to me. -- To view, visit

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints

2020-02-02 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15146 ) Change subject: IMPALA-9336: [DOCS] constraints .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-9330: Resolve nested types of masked tables

2020-02-02 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15108 ) Change subject: IMPALA-9330: Resolve nested types of masked tables .. Patch Set 7: Code-Review+1 (1 comment) The patch makes

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints

2020-02-02 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15146 ) Change subject: IMPALA-9336: [DOCS] constraints .. Patch Set 2: (1 comment) Thanks for addressing my comments. Another minor

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints

2020-02-01 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15146 ) Change subject: IMPALA-9336: [DOCS] constraints .. Patch Set 1: (5 comments) Thanks for making these changes to the docs. I

[Impala-ASF-CR] IMPALA-9311: Store SQLPrimaryKeys in canonical order.

2020-01-27 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15106 ) Change subject: IMPALA-9311: Store SQLPrimaryKeys in canonical order. .. Patch Set 1: Could you also please merge this, Tim?

[Impala-ASF-CR] IMPALA-9329: Don't add nested columns in TableMaskingView

2020-01-27 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15108 ) Change subject: IMPALA-9329: Don't add nested columns in TableMaskingView .. Patch Set 4: Code-Review+1 The patch looks good

[Impala-ASF-CR] IMPALA-9311: Store SQLPrimaryKeys in canonical order.

2020-01-24 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15106 Change subject: IMPALA-9311: Store SQLPrimaryKeys in canonical order. .. IMPALA-9311: Store SQLPrimaryKeys in canonical order.

[Impala-ASF-CR] IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode.

2020-01-17 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/14731 ) Change subject: IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode. .. IMPALA-9158: Support

[Impala-ASF-CR] IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode.

2020-01-17 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14731 ) Change subject: IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode. .. Patch Set 7: (5

[Impala-ASF-CR] IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode.

2020-01-16 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14731 ) Change subject: IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode. .. Patch Set 6: (1

[Impala-ASF-CR] IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode.

2020-01-16 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/14731 ) Change subject: IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode. .. IMPALA-9158: Support

[Impala-ASF-CR] IMPALA-9101: Add support for detecting self-events on partition events

2020-01-08 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14799 ) Change subject: IMPALA-9101: Add support for detecting self-events on partition events .. Patch Set 5: Code-Review+1 (1

[Impala-ASF-CR] IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode.

2020-01-08 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/14731 ) Change subject: IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode. .. IMPALA-9158: Support

[Impala-ASF-CR] IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode.

2020-01-08 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14731 ) Change subject: IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode. .. Patch Set 4: (8

[Impala-ASF-CR] IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode.

2020-01-08 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/14731 ) Change subject: IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode. .. IMPALA-9158: Support

[Impala-ASF-CR] IMPALA-9257: Last event id should be advanced if all events are skipped

2019-12-17 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14916 ) Change subject: IMPALA-9257: Last event id should be advanced if all events are skipped .. Patch Set 2: Code-Review+1 -- To

[Impala-ASF-CR] IMPALA-9257: Last event id should be advanced if all events are skipped

2019-12-17 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14916 ) Change subject: IMPALA-9257: Last event id should be advanced if all events are skipped .. Patch Set 1: (1 comment) Looks

[Impala-ASF-CR] IMPALA-9101: Add support for detecting self-events on partition events

2019-12-17 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14799 ) Change subject: IMPALA-9101: Add support for detecting self-events on partition events .. Patch Set 2: (3 comments) Thanks

[Impala-ASF-CR] IMPALA-9188: Composite primary keys should use same constraint name

2019-11-24 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14792 ) Change subject: IMPALA-9188: Composite primary keys should use same constraint name .. Patch Set 1: Code-Review+1 Thanks for

[Impala-ASF-CR] IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server.

2019-11-21 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14720 ) Change subject: IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server. .. Patch Set 12: The test

[Impala-ASF-CR] IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server.

2019-11-21 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/14720 ) Change subject: IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server. .. IMPALA-9104: Support

[Impala-ASF-CR] IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server.

2019-11-20 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/14720 ) Change subject: IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server. .. IMPALA-9104: Support

[Impala-ASF-CR] IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server.

2019-11-20 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14720 ) Change subject: IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server. .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server.

2019-11-20 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14720 ) Change subject: IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server. .. Patch Set 10: (2 comments)

[Impala-ASF-CR] IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server.

2019-11-20 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/14720 ) Change subject: IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server. .. IMPALA-9104: Support

[Impala-ASF-CR] IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server.

2019-11-20 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/14720 ) Change subject: IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server. .. IMPALA-9104: Support retrieval

[Impala-ASF-CR] IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server.

2019-11-20 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14720 ) Change subject: IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server. .. Patch Set 9: (13 comments)

[Impala-ASF-CR] IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server.

2019-11-19 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14720 ) Change subject: IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server. .. Patch Set 8: (13 comments)

  1   2   3   4   >