[Impala-ASF-CR] [DOCS] An upgrade consideratiobn for IMPALA-7800

2019-07-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13879 ) Change subject: [DOCS] An upgrade consideratiobn for IMPALA-7800 .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] [WIP] IMPALA-8339: Add local node blacklist to coordinators

2019-07-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13868 ) Change subject: [WIP] IMPALA-8339: Add local node blacklist to coordinators .. Patch Set 1: (16 comments) Some comments on the first

[Impala-ASF-CR] IMPALA-8656: Re-factor PlanRootSink into blocking and buffered implementations

2019-07-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13873 ) Change subject: IMPALA-8656: Re-factor PlanRootSink into blocking and buffered implementations .. Patch Set 7: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-8656: Re-factor PlanRootSink into blocking and buffered implementations

2019-07-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13873 ) Change subject: IMPALA-8656: Re-factor PlanRootSink into blocking and buffered implementations .. Patch Set 6: Code-Review+2 (2

[Impala-ASF-CR] IMPALA-8543: More diagnostics for TAcceptQueueServer

2019-07-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13790 ) Change subject: IMPALA-8543: More diagnostics for TAcceptQueueServer .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-8543: More diagnostics for TAcceptQueueServer

2019-07-09 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13790 ) Change subject: IMPALA-8543: More diagnostics for TAcceptQueueServer .. IMPALA-8543: More diagnostics for TAcceptQueueServer This change

[Impala-ASF-CR] IMPALA-8732: Use a serialized descriptor table in TQueryCtx

2019-07-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13772 ) Change subject: IMPALA-8732: Use a serialized descriptor table in TQueryCtx .. Patch Set 4: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8748: Always pass hostname to RpcMgr::GetProxy()

2019-07-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13818 ) Change subject: IMPALA-8748: Always pass hostname to RpcMgr::GetProxy() .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8748: Always pass hostname to RpcMgr::GetProxy()

2019-07-08 Thread Michael Ho (Code Review)
Hello Thomas Tauber-Marshall, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13818 to look at the new patch set (#4). Change subject: IMPALA-8748: Always pass hostname to RpcMgr::GetProxy()

[Impala-ASF-CR] IMPALA-8748: Always pass hostname to RpcMgr::GetProxy()

2019-07-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13818 ) Change subject: IMPALA-8748: Always pass hostname to RpcMgr::GetProxy() .. Patch Set 2: Code-Review+2 Carry Todd's +2 -- To view,

[Impala-ASF-CR] IMPALA-8748: Always pass hostname to RpcMgr::GetProxy()

2019-07-08 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13818 ) Change subject: IMPALA-8748: Always pass hostname to RpcMgr::GetProxy() .. IMPALA-8748: Always pass hostname to RpcMgr::GetProxy() This

[Impala-ASF-CR] IMPALA-8748: Always pass hostname to RpcMgr::GetProxy()

2019-07-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13818 ) Change subject: IMPALA-8748: Always pass hostname to RpcMgr::GetProxy() .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-8744: Fix test session expiration.py to work with Python 2.6

2019-07-08 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13819 Change subject: IMPALA-8744: Fix test_session_expiration.py to work with Python 2.6 .. IMPALA-8744: Fix test_session_expiration.py to

[Impala-ASF-CR] IMPALA-8748: Always pass hostname to RpcMgr::GetProxy()

2019-07-08 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13818 Change subject: IMPALA-8748: Always pass hostname to RpcMgr::GetProxy() .. IMPALA-8748: Always pass hostname to RpcMgr::GetProxy() This

[Impala-ASF-CR] IMPALA-8341: [DOCS] Added a note about the experiemental feature

2019-07-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13788 ) Change subject: IMPALA-8341: [DOCS] Added a note about the experiemental feature .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8732: Use a serialized descriptor table in TQueryCtx

2019-07-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13772 ) Change subject: IMPALA-8732: Use a serialized descriptor table in TQueryCtx .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-8543: More diagnostics for TAcceptQueueServer

2019-07-02 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13790 Change subject: IMPALA-8543: More diagnostics for TAcceptQueueServer .. IMPALA-8543: More diagnostics for TAcceptQueueServer This change

[Impala-ASF-CR] IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced

2019-07-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13762 ) Change subject: IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

2019-07-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13768 ) Change subject: Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95 .. Patch Set 1: Code-Review+2 Didn't look too much into the

[Impala-ASF-CR] IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced

2019-06-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13762 ) Change subject: IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Update kudu/security from 9ebcb77aa911aae76c48e717af24e643cb81908d

2019-06-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13767 ) Change subject: Update kudu/security from 9ebcb77aa911aae76c48e717af24e643cb81908d .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6159 / KUDU-2192: Enable TCP keepalive for all outbound connections

2019-06-28 Thread Michael Ho (Code Review)
Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13764 ) Change subject: IMPALA-6159 / KUDU-2192: Enable TCP keepalive for all outbound connections .. Removed reviewer Kudu Jenkins. --

[Impala-ASF-CR] IMPALA-6159 / KUDU-2192: Enable TCP keepalive for all outbound connections

2019-06-28 Thread Michael Ho (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13764 to review the following change. Change subject: IMPALA-6159 / KUDU-2192: Enable TCP keepalive for all outbound connections

[Impala-ASF-CR] IMPALA-8341: [DOCS] Describe the setting for remote data caching

2019-06-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13724 ) Change subject: IMPALA-8341: [DOCS] Describe the setting for remote data caching .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8341: [DOCS] Describe the settings for remote data caching

2019-06-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13724 ) Change subject: IMPALA-8341: [DOCS] Describe the settings for remote data caching .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7802: Close connections of idle client sessions

2019-06-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13607 ) Change subject: IMPALA-7802: Close connections of idle client sessions .. Patch Set 4: Code-Review+2 Carry Thomas' +2 -- To view,

[Impala-ASF-CR] IMPALA-7802: Close connections of idle client sessions

2019-06-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13607 ) Change subject: IMPALA-7802: Close connections of idle client sessions .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7802: Close connections of idle client sessions

2019-06-20 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/13607 ) Change subject: IMPALA-7802: Close connections of idle client sessions .. IMPALA-7802: Close connections of idle client sessions

[Impala-ASF-CR] IMPALA-7802: Close connections of idle client sessions

2019-06-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13607 ) Change subject: IMPALA-7802: Close connections of idle client sessions .. Patch Set 3: Code-Review+1 Carry Tim's +1. -- To view, visit

[Impala-ASF-CR] IMPALA-7467: Port ExecQueryFInstances to krpc

2019-06-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13583 ) Change subject: IMPALA-7467: Port ExecQueryFInstances to krpc .. Patch Set 3: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-8542. Add an access trace for the data cache

2019-06-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13425 ) Change subject: IMPALA-8542. Add an access trace for the data cache .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7802: Close connections of idle client sessions

2019-06-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13607 ) Change subject: IMPALA-7802: Close connections of idle client sessions .. Patch Set 2: (10 comments)

[Impala-ASF-CR] IMPALA-7802: Close connections of idle client sessions

2019-06-17 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13607 ) Change subject: IMPALA-7802: Close connections of idle client sessions .. IMPALA-7802: Close connections of idle client sessions

[Impala-ASF-CR] IMPALA-8542. Add an access trace for the data cache

2019-06-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13425 ) Change subject: IMPALA-8542. Add an access trace for the data cache .. Patch Set 5: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7802: Close connections of idle client sessions

2019-06-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13607 ) Change subject: IMPALA-7802: Close connections of idle client sessions .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-7467: Ported ExecQueryFInstances over to krpc

2019-06-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13583 ) Change subject: IMPALA-7467: Ported ExecQueryFInstances over to krpc .. Patch Set 1: (9 comments)

[Impala-ASF-CR] IMPALA-7802: Close connections of idle client sessions

2019-06-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13607 ) Change subject: IMPALA-7802: Close connections of idle client sessions .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7802: Close connections of idle client sessions

2019-06-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13607 ) Change subject: IMPALA-7802: Close connections of idle client sessions .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7802: Close connections of idle client sessions

2019-06-12 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13607 Change subject: IMPALA-7802: Close connections of idle client sessions .. IMPALA-7802: Close connections of idle client sessions

[Impala-ASF-CR] IMPALA-8659: Allow self-RPCs for KRPC to go via loopback

2019-06-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13592 ) Change subject: IMPALA-8659: Allow self-RPCs for KRPC to go via loopback .. Patch Set 8: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-06-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 12: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1)

2019-06-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13522 ) Change subject: IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1) .. Patch Set 4: Code-Review+2 (3 comments) Thanks for

[Impala-ASF-CR] IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges

2019-06-04 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/13369 ) Change subject: IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges .. IMPALA-8562: Data cache should skip insertion

[Impala-ASF-CR] IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges

2019-06-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13369 ) Change subject: IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges

2019-06-03 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13369 ) Change subject: IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges .. IMPALA-8562: Data cache should skip insertion

[Impala-ASF-CR] IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges

2019-06-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13369 ) Change subject: IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges

2019-06-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13369 ) Change subject: IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges .. Patch Set 2: Code-Review+1 Carry Lars' +1

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-06-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 11: Code-Review+2 (6 comments) LGTM. Please address the nits.

[Impala-ASF-CR] IMPALA-8542. Add an access trace for the data cache

2019-06-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13425 ) Change subject: IMPALA-8542. Add an access trace for the data cache .. Patch Set 3: (8 comments) LGTM. Mostly nits.

[Impala-ASF-CR] IMPALA-8562: Data cache should skip insertion of illegitimate ScanRanges

2019-05-17 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13369 Change subject: IMPALA-8562: Data cache should skip insertion of illegitimate ScanRanges .. IMPALA-8562: Data cache should skip insertion

[Impala-ASF-CR] IMPALA-8563: Update SSL ciphers used in BE tests

2019-05-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13364 ) Change subject: IMPALA-8563: Update SSL ciphers used in BE tests .. Patch Set 1: Code-Review+1 Thanks for fixing it. -- To view, visit

[Impala-ASF-CR] Allow data cache to be enabled optionally when running tests

2019-05-16 Thread Michael Ho (Code Review)
Hello Lars Volker, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13330 to look at the new patch set (#4). Change subject: Allow data cache to be enabled optionally when running tests

[Impala-ASF-CR] Allow data cache to be enabled optionally when running tests

2019-05-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13330 ) Change subject: Allow data cache to be enabled optionally when running tests .. Patch Set 3: (2 comments)

[Impala-ASF-CR] Allow data cache to be enabled optionally when running tests

2019-05-16 Thread Michael Ho (Code Review)
Hello Lars Volker, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13330 to look at the new patch set (#3). Change subject: Allow data cache to be enabled optionally when running tests

[Impala-ASF-CR] IMPALA-1653: Don't close hiveserver2 session when connection is closed

2019-05-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13306 ) Change subject: IMPALA-1653: Don't close hiveserver2 session when connection is closed .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-1653: Don't close hiveserver2 session when connection is closed

2019-05-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13306 ) Change subject: IMPALA-1653: Don't close hiveserver2 session when connection is closed .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4356,IMPALA-7331: codegen all ScalarExprs

2019-05-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12797 ) Change subject: IMPALA-4356,IMPALA-7331: codegen all ScalarExprs .. Patch Set 13: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-1653: Don't close hiveserver2 session when connection is closed

2019-05-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13306 ) Change subject: IMPALA-1653: Don't close hiveserver2 session when connection is closed .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-05-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13020 ) Change subject: IMPALA-8344: Add support for running the minicluster with S3Guard .. Patch Set 4: Code-Review+1 -- To view, visit

[Impala-ASF-CR] Enable data cache by default for all S3 builds

2019-05-14 Thread Michael Ho (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13330 to look at the new patch set (#2). Change subject: Enable data cache by default for all S3 builds

[Impala-ASF-CR] Enable data cache by default for all S3 builds

2019-05-14 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13330 Change subject: Enable data cache by default for all S3 builds .. Enable data cache by default for all S3 builds Change-Id:

[Impala-ASF-CR] Prototype for a remote read byte cache.

2019-05-10 Thread Michael Ho (Code Review)
Michael Ho has abandoned this change. ( http://gerrit.cloudera.org:8080/12683 ) Change subject: Prototype for a remote read byte cache. .. Abandoned See https://gerrit.cloudera.org/#/c/12987/ -- To view, visit

[Impala-ASF-CR] IMPALA-4356,IMPALA-7331: codegen all ScalarExprs

2019-05-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12797 ) Change subject: IMPALA-4356,IMPALA-7331: codegen all ScalarExprs .. Patch Set 12: (12 comments) Thanks for the explanation. Can you

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-05-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-7176: Increase wait time in test insert mem limit

2019-05-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13292 ) Change subject: IMPALA-7176: Increase wait time in test_insert_mem_limit .. Patch Set 1: Didn't know you were working on the same thing.

[Impala-ASF-CR] IMPALA-7176: Increase wait time in test insert mem limit

2019-05-08 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13292 Change subject: IMPALA-7176: Increase wait time in test_insert_mem_limit .. IMPALA-7176: Increase wait time in test_insert_mem_limit

[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13271 ) Change subject: IMPALA-8512: Disable certain tests on Centos6 .. Patch Set 4: GVO failed due to IMPALA-8527 -- To view, visit

[Impala-ASF-CR] IMPALA-7665: Fix unwarranted query cancellation on statestore restart

2019-05-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13061 ) Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart .. Patch Set 5: Code-Review+1 Not sure if Lars

[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-07 Thread Michael Ho (Code Review)
Hello Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13271 to look at the new patch set (#3). Change subject: IMPALA-8512: Disable certain tests on Centos6

[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13271 ) Change subject: IMPALA-8512: Disable certain tests on Centos6 .. Patch Set 3: Code-Review+2 Carry Tim's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-07 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13271 ) Change subject: IMPALA-8512: Disable certain tests on Centos6 .. IMPALA-8512: Disable certain tests on Centos6 The data cache related

[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13271 ) Change subject: IMPALA-8512: Disable certain tests on Centos6 .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13271 ) Change subject: IMPALA-8512: Disable certain tests on Centos6 .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-07 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13271 Change subject: IMPALA-8512: Disable certain tests on Centos6 .. IMPALA-8512: Disable certain tests on Centos6 The data cache related

[Impala-ASF-CR] IMPALA-7665: Fix unwarranted query cancellation on statestore restart

2019-05-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13061 ) Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart .. Patch Set 4: (3 comments) Thanks for fixing

[Impala-ASF-CR] IMPALA-8496: Fix flakiness of test data cache.py

2019-05-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13242 ) Change subject: IMPALA-8496: Fix flakiness of test_data_cache.py .. Patch Set 4: Code-Review+2 (3 comments) Carry Lars' +2.

[Impala-ASF-CR] IMPALA-8496: Fix flakiness of test data cache.py

2019-05-04 Thread Michael Ho (Code Review)
Hello Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13242 to look at the new patch set (#4). Change subject: IMPALA-8496: Fix flakiness of test_data_cache.py

[Impala-ASF-CR] IMPALA-8496: Fix flakiness of test data cache.py

2019-05-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13242 ) Change subject: IMPALA-8496: Fix flakiness of test_data_cache.py .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-8496: Fix flakiness of test data cache.py

2019-05-04 Thread Michael Ho (Code Review)
Hello Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13242 to look at the new patch set (#3). Change subject: IMPALA-8496: Fix flakiness of test_data_cache.py

[Impala-ASF-CR] IMPALA-8496: Fix flakiness of test data cache.py

2019-05-04 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13242 ) Change subject: IMPALA-8496: Fix flakiness of test_data_cache.py .. IMPALA-8496: Fix flakiness of test_data_cache.py test_data_cache.py

[Impala-ASF-CR] IMPALA-8496: Fix flakiness of test data cache.py

2019-05-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13242 ) Change subject: IMPALA-8496: Fix flakiness of test_data_cache.py .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-8496: Fix flakiness of test data cache.py

2019-05-04 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13242 Change subject: IMPALA-8496: Fix flakiness of test_data_cache.py .. IMPALA-8496: Fix flakiness of test_data_cache.py test_data_cache.py

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 10: Code-Review+2 (1 comment) Carry Todd's +2

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-02 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. IMPALA-8341: Data cache for remote reads This is a patch based on PhilZ's

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 9: Code-Review+1 Carry Lars' +1 -- To view, visit

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-01 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. IMPALA-8341: Data cache for remote reads This is a patch based on PhilZ's

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 8: (5 comments) Accidentally pushed a draft. Will push PS9.

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-05-01 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. IMPALA-8341: Data cache for remote reads This is a patch based on PhilZ's

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 7: (41 comments)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-30 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Lars Volker, David Rorke, Sahil Takiar, Todd Lipcon, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12987 to look at the new patch set (#7). Change subject: IMPALA-8341: Data

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-04-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13020 ) Change subject: IMPALA-8344: Add support for running the minicluster with S3Guard .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-29 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Lars Volker, David Rorke, Sahil Takiar, Todd Lipcon, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12987 to look at the new patch set (#6). Change subject: IMPALA-8341: Data

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-27 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. IMPALA-8341: Data cache for remote reads This is a patch based on PhilZ's

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 5: (32 comments)

[Impala-ASF-CR] IMPALA-2990: timeout unresponsive queries in coordinator

2019-04-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12299 ) Change subject: IMPALA-2990: timeout unresponsive queries in coordinator .. Patch Set 9: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8295: Fix flakiness in TestAdmissionControllerStress

2019-04-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13103 ) Change subject: IMPALA-8295: Fix flakiness in TestAdmissionControllerStress .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8295: Fix flakiness in TestAdmissionControllerStress

2019-04-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13103 ) Change subject: IMPALA-8295: Fix flakiness in TestAdmissionControllerStress .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-2990: timeout unresponsive queries in coordinator

2019-04-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12299 ) Change subject: IMPALA-2990: timeout unresponsive queries in coordinator .. Patch Set 8: (8 comments)

[Impala-ASF-CR] IMPALA-4356,IMPALA-7331: codegen all ScalarExprs

2019-04-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12797 ) Change subject: IMPALA-4356,IMPALA-7331: codegen all ScalarExprs .. Patch Set 10: (12 comments)

<    1   2   3   4   5   6   7   8   9   10   >