[Impala-ASF-CR] IMPALA-9188: Composite primary keys should use same constraint name

2019-11-25 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14792 ) Change subject: IMPALA-9188: Composite primary keys should use same constraint name .. Patch Set 3: Code-Review+2 Carrying +2 -- To

[Impala-ASF-CR] IMPALA-9181: Serialize TQueryCtx once per query

2019-11-25 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14777 ) Change subject: IMPALA-9181: Serialize TQueryCtx once per query .. Patch Set 1: (6 comments) first pass http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-9188: Composite primary keys should use same constraint name

2019-11-25 Thread Sahil Takiar (Code Review)
Hello Anurag Mantripragada, Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14792 to look at the new patch set (#3). Change subject: IMPALA-9188: Composite primary keys should use same constraint name

[Impala-ASF-CR] IMPALA-9188: Composite primary keys should use same constraint name

2019-11-25 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14792 ) Change subject: IMPALA-9188: Composite primary keys should use same constraint name .. Patch Set 2: Code-Review+2 (1 comment) Carryin

[Impala-ASF-CR] IMPALA-9188: Composite primary keys should use same constraint name

2019-11-25 Thread Sahil Takiar (Code Review)
Hello Anurag Mantripragada, Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14792 to look at the new patch set (#2). Change subject: IMPALA-9188: Composite primary keys should use same constraint name

[Impala-ASF-CR] IMPALA-9188: Composite primary keys should use same constraint name

2019-11-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14792 Change subject: IMPALA-9188: Composite primary keys should use same constraint name .. IMPALA-9188: Composite primary keys should use sa

[Impala-ASF-CR] IMPALA-6894: Use an internal representation of query states in ClientRequestState

2019-11-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14744 ) Change subject: IMPALA-6894: Use an internal representation of query states in ClientRequestState .. Patch Set 3: (1 comment) http://

[Impala-ASF-CR] IMPALA-9188: Revert "IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server."

2019-11-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has abandoned this change. ( http://gerrit.cloudera.org:8080/14791 ) Change subject: IMPALA-9188: Revert "IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server." .. Abandoned -- To view, vi

[Impala-ASF-CR] IMPALA-9188: Revert "IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server."

2019-11-22 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14791 ) Change subject: IMPALA-9188: Revert "IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server." .. Patch Set 1: S

[Impala-ASF-CR] IMPALA-9188: Revert "IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server."

2019-11-22 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14791 Change subject: IMPALA-9188: Revert "IMPALA-9104: Support retrieval of PK/FK information through impala-hs2-server." .. IMPALA-9188: Rev

[Impala-ASF-CR] IMPALA-6894: Use an internal representation of query states in ClientRequestState

2019-11-21 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14744 ) Change subject: IMPALA-6894: Use an internal representation of query states in ClientRequestState .. Patch Set 3: (4 comments) http:/

[Impala-ASF-CR] IMPALA-6894: Use an internal representation of query states in ClientRequestState

2019-11-21 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14744 to look at the new patch set (#3). Change subject: IMPALA-6894: Use an internal representation of query states in ClientRe

[Impala-ASF-CR] IMPALA-9124: ImpalaServer and ClientRequestState refactoring

2019-11-21 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14755 ) Change subject: IMPALA-9124: ImpalaServer and ClientRequestState refactoring .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-9124: ImpalaServer and ClientRequestState refactoring

2019-11-21 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14755 to look at the new patch set (#2). Change subject: IMPALA-9124: ImpalaServer and ClientRequestState refactoring ..

[Impala-ASF-CR] IMPALA-9124: ImpalaServer and ClientRequestState refactoring

2019-11-20 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14755 Change subject: IMPALA-9124: ImpalaServer and ClientRequestState refactoring .. IMPALA-9124: ImpalaServer and ClientRequestState refactor

[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh

2019-11-19 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14741 ) Change subject: IMPALA-9165: Add timeout for create-load-data.sh .. Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-19 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14635 ) Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread .. Patch Set 7: Code-Review+2 Carrying +2. -- To

[Impala-ASF-CR] IMPALA-8525: Bump CDP build number to 1617729

2019-11-19 Thread Sahil Takiar (Code Review)
Sahil Takiar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14732 ) Change subject: IMPALA-8525: Bump CDP build number to 1617729 .. IMPALA-8525: Bump CDP build number to 1617729 This pulls in so

[Impala-ASF-CR] IMPALA-6894: Use an internal representation of query states in ClientRequestState

2019-11-19 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14744 to look at the new patch set (#2). Change subject: IMPALA-6894: Use an internal representation of query states in ClientRe

[Impala-ASF-CR] IMPALA-6894: Use an internal representation of query states in ClientRequestState

2019-11-19 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14744 ) Change subject: IMPALA-6894: Use an internal representation of query states in ClientRequestState .. Patch Set 2: Re-based and added s

[Impala-ASF-CR] IMPALA-6894: Use an internal representation of query states in ClientRequestState

2019-11-19 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14744 Change subject: IMPALA-6894: Use an internal representation of query states in ClientRequestState .. IMPALA-6894: Use an internal repres

[Impala-ASF-CR] IMPALA-9165: Add timeout for create-load-data.sh

2019-11-19 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14741 ) Change subject: IMPALA-9165: Add timeout for create-load-data.sh .. Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-9137, IMPALA-9138: Mark failed RPCs as retryable and update blacklist

2019-11-18 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14677 to look at the new patch set (#5). Change subject: IMPALA-9137, IMPALA-9138: Mark failed RPCs as retryable and update blacklist ..

[Impala-ASF-CR] IMPALA-9137, IMPALA-9138: Mark failed RPCs as retryable and update blacklist

2019-11-18 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14677 ) Change subject: IMPALA-9137, IMPALA-9138: Mark failed RPCs as retryable and update blacklist .. Patch Set 4: (7 comments) http://gerr

[Impala-ASF-CR] IMPALA-8525: Bump CDP build number to 1617729

2019-11-18 Thread Sahil Takiar (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14732 to look at the new patch set (#3). Change subject: IMPALA-8525: Bump CDP build number to 1617729 ...

[Impala-ASF-CR] IMPALA-9137, IMPALA-9138: Mark failed RPCs as retryable and update blacklist

2019-11-18 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14677 to look at the new patch set (#4). Change subject: IMPALA-9137, IMPALA-9138: Mark failed RPCs as retryable and update blacklist ..

[Impala-ASF-CR] IMPALA-8525: Bump CDP build number to 1617729

2019-11-17 Thread Sahil Takiar (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14732 to look at the new patch set (#2). Change subject: IMPALA-8525: Bump CDP build number to 1617729 .. IMPALA

[Impala-ASF-CR] IMPALA-8525: Bump CDP build number to 1617729

2019-11-17 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14732 Change subject: IMPALA-8525: Bump CDP build number to 1617729 .. IMPALA-8525: Bump CDP build number to 1617729 This pulls in some change

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-15 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14635 ) Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread .. Patch Set 6: This is going to require upgrading

[Impala-ASF-CR] IMPALA-9137, IMPALA-9138: Mark failed RPCs as retryable and update blacklist

2019-11-13 Thread Sahil Takiar (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14677 to look at the new patch set (#3). Change subject: IMPALA-9137, IMPALA-9138: Mark failed RPCs as retryable and update blacklist ..

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-11-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14641 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 5: Code-Review+1 Carrying +1. -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-11-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14641 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 4: Code-Review+1 LGTM. Patch looks like it needs to be re-b

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-12 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14635 ) Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread .. Patch Set 1: (2 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-12 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14635 to look at the new patch set (#5). Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread .

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-12 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14635 to look at the new patch set (#4). Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread .

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-11-12 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14641 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/14641/

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-11-12 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14641 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/14641/

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-11-12 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14641 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 3: (3 comments) A few more comments. Planning to take anot

[Impala-ASF-CR] IMPALA-9137, IMPALA-9138: Mark failed RPC as retryable, add dst node to blacklist

2019-11-09 Thread Sahil Takiar (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14677 to look at the new patch set (#2). Change subject: IMPALA-9137, IMPALA-9138: Mark failed RPC as retryable, add dst node to blacklist .

[Impala-ASF-CR] IMPALA-9137, IMPALA-9138: Mark failed RPC as retryable, add dst node to blacklist

2019-11-08 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14677 Change subject: IMPALA-9137, IMPALA-9138: Mark failed RPC as retryable, add dst node to blacklist .. IMPALA-9137, IMPALA-9138: Mark fail

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-08 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14635 ) Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread .. Patch Set 2: (3 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-08 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14635 to look at the new patch set (#3). Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread .

[Impala-ASF-CR] IMPALA-9085: [DOCS] Refactored impala s3.xml

2019-11-07 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14627 ) Change subject: IMPALA-9085: [DOCS] Refactored impala_s3.xml .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-11-07 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14641 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 2: (12 comments) First pass. Mostly clarification question

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-06 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14635 ) Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread .. Patch Set 1: (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-06 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14635 to look at the new patch set (#2). Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread .

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-06 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14635 ) Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread .. Patch Set 1: (2 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-9117, IMPALA-7726: Fixed a few unit tests for ABFS

2019-11-05 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14636 ) Change subject: IMPALA-9117, IMPALA-7726: Fixed a few unit tests for ABFS .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-9117, IMPALA-7726: Fixed a few unit tests for ABFS

2019-11-05 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14636 Change subject: IMPALA-9117, IMPALA-7726: Fixed a few unit tests for ABFS .. IMPALA-9117, IMPALA-7726: Fixed a few unit tests for ABFS T

[Impala-ASF-CR] IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread

2019-11-05 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14635 Change subject: IMPALA-8525: preads should use hdfsPreadFully rather than hdfsPread .. IMPALA-8525: preads should use hdfsPreadFully rat

[Impala-ASF-CR] IMPALA-8557: Add '.txt' to text files, remove '.' at end of filenames

2019-11-04 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14621 ) Change subject: IMPALA-8557: Add '.txt' to text files, remove '.' at end of filenames .. Patch Set 3: (1 comment) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8557: Add '.txt' to text files, remove '.' at end of filenames

2019-11-04 Thread Sahil Takiar (Code Review)
Hello Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14621 to look at the new patch set (#4). Change subject: IMPALA-8557: Add '.txt' to text files, remove '.' at end of filenames .

[Impala-ASF-CR] IMPALA-8557: Add '.txt' to text files, remove '.' at end of filenames

2019-11-02 Thread Sahil Takiar (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14621 to look at the new patch set (#3). Change subject: IMPALA-8557: Add '.txt' to text files, remove '.' at end of filenames ..

[Impala-ASF-CR] IMPALA-8557: Add '.txt' to text files, remove '.' at end of filenames

2019-11-02 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14621 ) Change subject: IMPALA-8557: Add '.txt' to text files, remove '.' at end of filenames .. Patch Set 2: (1 comment) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8557: Add '.txt' to text files, remove '.' at end of filenames

2019-11-02 Thread Sahil Takiar (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14621 to look at the new patch set (#2). Change subject: IMPALA-8557: Add '.txt' to text files, remove '.' at end of filenames ..

[Impala-ASF-CR] IMPALA-8557: Add '.txt' to text files, remove '.' at end of filenames

2019-11-02 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14621 Change subject: IMPALA-8557: Add '.txt' to text files, remove '.' at end of filenames .. IMPALA-8557: Add '.txt' to text files, remove '

[Impala-ASF-CR] IMPALA-9073: fix test executor concurrency flakiness

2019-11-01 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14606 ) Change subject: IMPALA-9073: fix test_executor_concurrency flakiness .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-8525: Bump CDH BUILD NUMBER to 1582079

2019-11-01 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14612 Change subject: IMPALA-8525: Bump CDH_BUILD_NUMBER to 1582079 .. IMPALA-8525: Bump CDH_BUILD_NUMBER to 1582079 This pulls in some change

[Impala-ASF-CR] IMPALA-9026: Use resolved IP address for statestore subscriber

2019-10-28 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14388 ) Change subject: IMPALA-9026: Use resolved IP address for statestore subscriber .. Patch Set 4: Code-Review+2 -- To view, visit http://

[Impala-ASF-CR] IMPALA-8950: Set overwrite to False by default in fs client.copy

2019-10-14 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14432 Change subject: IMPALA-8950: Set overwrite to False by default in fs_client.copy .. IMPALA-8950: Set overwrite to False by default in fs_

[Impala-ASF-CR] IMPALA-9026: Use resolved IP address for statestore subscriber

2019-10-09 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14388 ) Change subject: IMPALA-9026: Use resolved IP address for statestore subscriber .. Patch Set 2: (3 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp

2019-10-04 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14311 ) Change subject: IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp .. Patch Set 8: Thanks for reviews teams. I re-ran exhau

[Impala-ASF-CR] IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp

2019-10-04 Thread Sahil Takiar (Code Review)
Hello Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14311 to look at the new patch set (#8). Change subject: IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp .

[Impala-ASF-CR] IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp

2019-10-04 Thread Sahil Takiar (Code Review)
Hello Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14311 to look at the new patch set (#7). Change subject: IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp .

[Impala-ASF-CR] IMPALA-8962: FETCH ROWS TIMEOUT MS should apply before rows are available

2019-10-03 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14332 ) Change subject: IMPALA-8962: FETCH_ROWS_TIMEOUT_MS should apply before rows are available .. Patch Set 4: (2 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-8962: FETCH ROWS TIMEOUT MS should apply before rows are available

2019-10-03 Thread Sahil Takiar (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14332 to look at the new patch set (#5). Change subject: IMPALA-8962: FETCH_ROWS_TIMEOUT_MS should apply before rows are available ..

[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling

2019-10-03 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 ) Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling .. Patch Set 5: Code-Review+2 -- To view, visit h

[Impala-ASF-CR] IMPALA-8971: [DOCS] Documented the new query option for Parquet split size

2019-10-03 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14338 ) Change subject: IMPALA-8971: [DOCS] Documented the new query option for Parquet split size .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling

2019-10-03 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 ) Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling .. Patch Set 4: Code-Review+2 (1 comment) Minor c

[Impala-ASF-CR] IMPALA-8971: [DOCS] Documented the new query option for Parquet split size

2019-10-03 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14338 ) Change subject: IMPALA-8971: [DOCS] Documented the new query option for Parquet split size .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests

2019-10-03 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14337 ) Change subject: IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests .. Patch Set 4: Code-Review+2 Bumped timeout to 60s. Carrying

[Impala-ASF-CR] IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests

2019-10-03 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14337 to look at the new patch set (#4). Change subject: IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests ..

[Impala-ASF-CR] IMPALA-8962: FETCH ROWS TIMEOUT MS should apply before rows are available

2019-10-02 Thread Sahil Takiar (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14332 to look at the new patch set (#4). Change subject: IMPALA-8962: FETCH_ROWS_TIMEOUT_MS should apply before rows are available ..

[Impala-ASF-CR] IMPALA-8962: FETCH ROWS TIMEOUT MS should apply before rows are available

2019-10-02 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14332 ) Change subject: IMPALA-8962: FETCH_ROWS_TIMEOUT_MS should apply before rows are available .. Patch Set 3: (2 comments) Addressed comm

[Impala-ASF-CR] IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests

2019-10-02 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14337 ) Change subject: IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests

2019-10-02 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14337 ) Change subject: IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp

2019-10-02 Thread Sahil Takiar (Code Review)
Hello Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14311 to look at the new patch set (#6). Change subject: IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp .

[Impala-ASF-CR] IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp

2019-10-02 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14311 ) Change subject: IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp

2019-10-02 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14311 ) Change subject: IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp .. Patch Set 4: (2 comments) Addressed comments + fixed

[Impala-ASF-CR] IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp

2019-10-02 Thread Sahil Takiar (Code Review)
Hello Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14311 to look at the new patch set (#5). Change subject: IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp .

[Impala-ASF-CR] IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests

2019-10-01 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14337 ) Change subject: IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests

2019-10-01 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14337 to look at the new patch set (#2). Change subject: IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests ..

[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling

2019-10-01 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 ) Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling .. Patch Set 3: (8 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests

2019-10-01 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14337 Change subject: IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests .. IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests D

[Impala-ASF-CR] IMPALA-8962: FETCH ROWS TIMEOUT MS should apply before rows are available

2019-10-01 Thread Sahil Takiar (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14332 to look at the new patch set (#3). Change subject: IMPALA-8962: FETCH_ROWS_TIMEOUT_MS should apply before rows are available ..

[Impala-ASF-CR] IMPALA-8962: FETCH ROWS TIMEOUT MS should apply before rows are available

2019-10-01 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14332 ) Change subject: IMPALA-8962: FETCH_ROWS_TIMEOUT_MS should apply before rows are available .. Patch Set 1: (6 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-8962: FETCH ROWS TIMEOUT MS should apply before rows are available

2019-10-01 Thread Sahil Takiar (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14332 to look at the new patch set (#2). Change subject: IMPALA-8962: FETCH_ROWS_TIMEOUT_MS should apply before rows are available ..

[Impala-ASF-CR] IMPALA-8962: FETCH ROWS TIMEOUT MS should apply before rows are available

2019-10-01 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14332 Change subject: IMPALA-8962: FETCH_ROWS_TIMEOUT_MS should apply before rows are available .. IMPALA-8962: FETCH_ROWS_TIMEOUT_MS should a

[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling

2019-09-30 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 ) Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling .. Patch Set 1: (12 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp

2019-09-26 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14311 ) Change subject: IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp .. Patch Set 2: (4 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp

2019-09-26 Thread Sahil Takiar (Code Review)
Hello Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14311 to look at the new patch set (#4). Change subject: IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp .

[Impala-ASF-CR] IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp

2019-09-26 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14311 ) Change subject: IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp .. Patch Set 2: (1 comment) Removed the Python-based im

[Impala-ASF-CR] IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp

2019-09-26 Thread Sahil Takiar (Code Review)
Hello Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14311 to look at the new patch set (#3). Change subject: IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp .

[Impala-ASF-CR] IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp

2019-09-26 Thread Sahil Takiar (Code Review)
Hello Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14311 to look at the new patch set (#2). Change subject: IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp .

[Impala-ASF-CR] IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp

2019-09-26 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14311 ) Change subject: IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp .. Patch Set 1: (2 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp

2019-09-26 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14311 Change subject: IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp .. IMPALA-8950: Add -d, -f options to hdfs copyFromLocal,

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 6: Code-Review+2 Carrying +2 -- To view, visit http://

[Impala-ASF-CR] IMPALA-8926, IMPALA-8957: Fix result spooling flaky tests

2019-09-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14275 ) Change subject: IMPALA-8926, IMPALA-8957: Fix result spooling flaky tests .. Patch Set 3: Code-Review+2 Carrying +2. -- To view, visi

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 5: Code-Review+2 Oh and looks like this needs to be reba

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 3: (2 comments) LGTM pending the test updates / doc upd

<    2   3   4   5   6   7   8   9   10   11   >