[Impala-ASF-CR] IMPALA-11050: Skip filemetadata reloading in processing AlterPartition event from event processor

2022-01-27 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/18083 ) Change subject: IMPALA-11050: Skip filemetadata reloading in processing AlterPartition event from event processor .. Patch Set

[Impala-ASF-CR] IMPALA-11091: Update documentation of event polling

2022-01-26 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18173 ) Change subject: IMPALA-11091: Update documentation of event polling .. IMPALA-11091: Update documentation of event

[Impala-ASF-CR] IMPALA-11091: Update documentation of event polling

2022-01-26 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/18173 ) Change subject: IMPALA-11091: Update documentation of event polling .. Patch Set 1: Thanks Shajini for the quick review.

[Impala-ASF-CR] IMPALA-11091: Update documentation of event polling

2022-01-26 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/18173 ) Change subject: IMPALA-11091: Update documentation of event polling .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-11091: Update documentation of event polling

2022-01-26 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18173 Change subject: IMPALA-11091: Update documentation of event polling .. IMPALA-11091: Update documentation of event polling

[Impala-ASF-CR] IMPALA-11075: Use latest API for get partitions ps with auth()

2022-01-19 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18157 ) Change subject: IMPALA-11075: Use latest API for get_partitions_ps_with_auth() .. IMPALA-11075: Use latest API for

[Impala-ASF-CR] IMPALA-11075: Use latest API for get partitions ps with auth()

2022-01-19 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/18157 ) Change subject: IMPALA-11075: Use latest API for get_partitions_ps_with_auth() .. Patch Set 1: Code-Review+2 Change looks good

[Impala-ASF-CR] IMPALA-11050: Skip filemetadata reloading in processing AlterPartition event from event processor

2022-01-06 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/18083 ) Change subject: IMPALA-11050: Skip filemetadata reloading in processing AlterPartition event from event processor .. Patch Set

[Impala-ASF-CR] IMPALA-10926: Improve catalogd consistency and self events detection

2021-12-13 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17859 ) Change subject: IMPALA-10926: Improve catalogd consistency and self events detection .. Patch Set 41: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-10886: Fix loss of createEventId for INSERT created partitions

2021-12-03 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/18066 ) Change subject: IMPALA-10886: Fix loss of createEventId for INSERT created partitions .. Patch Set 2: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-10886: Fix loss of createEventId for INSERT created partitions

2021-12-03 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18066 ) Change subject: IMPALA-10886: Fix loss of createEventId for INSERT created partitions .. IMPALA-10886: Fix loss of

[Impala-ASF-CR] IMPALA-10886: Fix loss of createEventId for INSERT created partitions

2021-12-03 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/18066 ) Change subject: IMPALA-10886: Fix loss of createEventId for INSERT created partitions .. Patch Set 2: Code-Review+2 (1

[Impala-ASF-CR] IMPALA-10886: Fix loss of createEventId for INSERT created partitions

2021-12-03 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#2) to the change originally created by Quanlong Huang. ( http://gerrit.cloudera.org:8080/18066 ) Change subject: IMPALA-10886: Fix loss of createEventId for INSERT created partitions

[Impala-ASF-CR] IMPALA-10886: Fix lossing createEventId for INSERT created partitions

2021-12-03 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/18066 ) Change subject: IMPALA-10886: Fix lossing createEventId for INSERT created partitions .. Patch Set 1: Code-Review+2 (1

[Impala-ASF-CR] IMPALA-10926: Improve catalogd consistency and self events detection

2021-12-01 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17859 ) Change subject: IMPALA-10926: Improve catalogd consistency and self events detection .. Patch Set 36: You probably have to

[Impala-ASF-CR] IMPALA-10926: Improve catalogd consistency and self events detection

2021-12-01 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17859 ) Change subject: IMPALA-10926: Improve catalogd consistency and self events detection .. Patch Set 36: Code-Review+2 The patch

[Impala-ASF-CR] IMPALA-11032: Automatic Refresh of Metadata for Local Catalog after Compaction

2021-11-30 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/18043 ) Change subject: IMPALA-11032: Automatic Refresh of Metadata for Local Catalog after Compaction .. Patch Set 5: Looks like the

[Impala-ASF-CR] IMPALA-11032: Automatic Refresh of Metadata for Local Catalog after Compaction

2021-11-30 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/18043 ) Change subject: IMPALA-11032: Automatic Refresh of Metadata for Local Catalog after Compaction .. Patch Set 5: Code-Review+2

[Impala-ASF-CR] IMPALA-11032: Automatic Refresh of Metadata for Local Catalog after Compaction

2021-11-29 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/18043 ) Change subject: IMPALA-11032: Automatic Refresh of Metadata for Local Catalog after Compaction .. Patch Set 4: Code-Review+2

[Impala-ASF-CR] IMPALA-11032: Automatic Refresh of Metadata for Local Catalog after Compaction

2021-11-29 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/18043 ) Change subject: IMPALA-11032: Automatic Refresh of Metadata for Local Catalog after Compaction .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-10871: Add MetastoreShim to support Apache Hive 3.1.2

2021-11-24 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17774 ) Change subject: IMPALA-10871: Add MetastoreShim to support Apache Hive 3.1.2 .. Patch Set 9: (3 comments) Thanks a lot for

[Impala-ASF-CR] IMPALA-11032: Automatic Refresh of Metadata for Local Catalog after Compaction

2021-11-24 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/18043 ) Change subject: IMPALA-11032: Automatic Refresh of Metadata for Local Catalog after Compaction .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-11028: Table loading can fail when events are cleaned up

2021-11-22 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/18038 ) Change subject: IMPALA-11028: Table loading can fail when events are cleaned up .. Patch Set 15: Code-Review+2 (4 comments)

[Impala-ASF-CR] IMPALA-11028: Table loading can fail when events are cleaned up

2021-11-22 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/18038 ) Change subject: IMPALA-11028: Table loading can fail when events are cleaned up .. IMPALA-11028: Table loading can fail when

[Impala-ASF-CR] IMPALA-11028: Table loading can fail when events are cleaned up

2021-11-22 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/18038 ) Change subject: IMPALA-11028: Table loading can fail when events are cleaned up .. IMPALA-11028: Table loading can fail when

[Impala-ASF-CR] IMPALA-11028: Table loading can fail when events are cleaned up

2021-11-22 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/18038 ) Change subject: IMPALA-11028: Table loading can fail when events are cleaned up .. IMPALA-11028: Table loading can fail when

[Impala-ASF-CR] IMPALA-11028: Table loading can fail when events are cleaned up

2021-11-22 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/18038 ) Change subject: IMPALA-11028: Table loading can fail when events are cleaned up .. IMPALA-11028: Table loading can fail when

[Impala-ASF-CR] IMPALA-11028: Table loading can fail when events are cleaned up

2021-11-22 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/18038 ) Change subject: IMPALA-11028: Table loading can fail when events are cleaned up .. IMPALA-11028: Table loading can fail when

[Impala-ASF-CR] IMPALA-11028: Table loading can fail when events are cleaned up

2021-11-21 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/18038 ) Change subject: IMPALA-11028: Table loading can fail when events are cleaned up .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-11028: Table loading can fail when events are cleaned up

2021-11-21 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/18038 ) Change subject: IMPALA-11028: Table loading can fail when events are cleaned up .. IMPALA-11028: Table loading can fail when

[Impala-ASF-CR] IMPALA-10923: Fine grained table refreshing at partition level events for transactional tables

2021-11-18 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17858 ) Change subject: IMPALA-10923: Fine grained table refreshing at partition level events for transactional tables ..

[Impala-ASF-CR] IMPALA-10923: Fine grained table refreshing at partition level events for transactional tables

2021-11-18 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17858 ) Change subject: IMPALA-10923: Fine grained table refreshing at partition level events for transactional tables .. Patch Set 17:

[Impala-ASF-CR] IMPALA-10923: Fine grained table refreshing at partition level events for transactional tables

2021-11-18 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17858 ) Change subject: IMPALA-10923: Fine grained table refreshing at partition level events for transactional tables .. Patch Set 17:

[Impala-ASF-CR] IMPALA-10923: Fine grained table refreshing at partition level events for transactional tables

2021-11-18 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17858 ) Change subject: IMPALA-10923: Fine grained table refreshing at partition level events for transactional tables .. Patch Set 17:

[Impala-ASF-CR] IMPALA-11028: Table loading can fail when events are cleaned up

2021-11-18 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18038 Change subject: IMPALA-11028: Table loading can fail when events are cleaned up .. IMPALA-11028: Table loading can fail when

[Impala-ASF-CR] IMPALA-10926: Improve catalogd consistency and self events detection

2021-11-02 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17859 ) Change subject: IMPALA-10926: Improve catalogd consistency and self events detection .. Patch Set 26: (7 comments) The patch

[Impala-ASF-CR] IMPALA-10923: Fine grained table refreshing at partition level events for transactional tables

2021-10-29 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17858 ) Change subject: IMPALA-10923: Fine grained table refreshing at partition level events for transactional tables .. Patch Set 11:

[Impala-ASF-CR] IMPALA-10926: Sync db/table in catalog cache to latest HMS event id when performing DDL operations via catalog HMS endpoints

2021-10-21 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17859 ) Change subject: IMPALA-10926: Sync db/table in catalog cache to latest HMS event id when performing DDL operations via catalog HMS endpoints

[Impala-ASF-CR] IMPALA-10972: Fixup test behavior to work with HIVE-24920

2021-10-21 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17956 ) Change subject: IMPALA-10972: Fixup test behavior to work with HIVE-24920 .. Patch Set 1: Thanks a lot Joe for taking this up.

[Impala-ASF-CR] IMPALA-10972: Fixup test behavior to work with HIVE-24920

2021-10-21 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17956 ) Change subject: IMPALA-10972: Fixup test behavior to work with HIVE-24920 .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10975: Refactor alter table ddl operation

2021-10-21 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17919 ) Change subject: IMPALA-10975: Refactor alter table ddl operation .. IMPALA-10975: Refactor alter table ddl operation

[Impala-ASF-CR] IMPALA-10975: Refactor alter table ddl operation

2021-10-21 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17919 ) Change subject: IMPALA-10975: Refactor alter table ddl operation .. Patch Set 7: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10975: Refactor alter table ddl operation

2021-10-21 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17919 ) Change subject: IMPALA-10975: Refactor alter table ddl operation .. Patch Set 7: Giving a +1 verified since there were only

[Impala-ASF-CR] IMPALA-10975: Refactor alter table ddl operation

2021-10-21 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17919 ) Change subject: IMPALA-10975: Refactor alter table ddl operation .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10975: Minor refactoring in alter table ddl op in CatalogOpExecutor

2021-10-20 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17919 ) Change subject: IMPALA-10975: Minor refactoring in alter table ddl op in CatalogOpExecutor .. Patch Set 6: (2 comments) I can

[Impala-ASF-CR] IMPALA-10923: Fine grained table refreshing at partition level events for transactional tables

2021-10-19 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17858 ) Change subject: IMPALA-10923: Fine grained table refreshing at partition level events for transactional tables .. Patch Set 6:

[Impala-ASF-CR] IMPALA-10958: Decouple getConstraintsInformation from hive.ql.metadata.Table

2021-10-18 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17910 ) Change subject: IMPALA-10958: Decouple getConstraintsInformation from hive.ql.metadata.Table .. Patch Set 2: Code-Review+2 --

[Impala-ASF-CR] IMPALA-10958: Decouple getConstraintsInformation from hive.ql.metadata.Table

2021-10-18 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17910 ) Change subject: IMPALA-10958: Decouple getConstraintsInformation from hive.ql.metadata.Table .. IMPALA-10958: Decouple

[Impala-ASF-CR] IMPALA-10959: Reload MV as ACID tables

2021-10-18 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17911 ) Change subject: IMPALA-10959: Reload MV as ACID tables .. IMPALA-10959: Reload MV as ACID tables We observed that the

[Impala-ASF-CR] IMPALA-10959: Reload MV as ACID tables

2021-10-18 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17911 ) Change subject: IMPALA-10959: Reload MV as ACID tables .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10926: Sync db/table in catalog cache to latest HMS event id when performing DDL operations via catalog HMS endpoints

2021-10-05 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17859 ) Change subject: IMPALA-10926: Sync db/table in catalog cache to latest HMS event id when performing DDL operations via catalog HMS endpoints

[Impala-ASF-CR] IMPALA-10907: Refactor MetastoreEvents class

2021-10-04 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17833 ) Change subject: IMPALA-10907: Refactor MetastoreEvents class .. Patch Set 1: There are some more critical fixes and

[Impala-ASF-CR] IMPALA-9857: Batching of consecutive partition events

2021-10-04 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17848 ) Change subject: IMPALA-9857: Batching of consecutive partition events .. IMPALA-9857: Batching of consecutive partition

[Impala-ASF-CR] IMPALA-10923: Fine grained table refreshing at partition level events for transactional tables

2021-10-01 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17858 ) Change subject: IMPALA-10923: Fine grained table refreshing at partition level events for transactional tables .. Patch Set 1:

[Impala-ASF-CR] IMPALA-9857: Batching of consecutive partition events

2021-10-01 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17848 ) Change subject: IMPALA-9857: Batching of consecutive partition events .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-9857: Batching of consecutive partition events

2021-10-01 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17848 ) Change subject: IMPALA-9857: Batching of consecutive partition events .. Patch Set 11: > Build failed:

[Impala-ASF-CR] IMPALA-9857: Batching of consecutive partition events

2021-09-30 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/17848 ) Change subject: IMPALA-9857: Batching of consecutive partition events .. IMPALA-9857: Batching of consecutive partition events

[Impala-ASF-CR] Bump up the GBN to 17296101

2021-09-30 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17874 ) Change subject: Bump up the GBN to 17296101 .. Patch Set 2: Code-Review+2 (1 comment) LGTM.

[Impala-ASF-CR] Bump up the GBN to 17296101

2021-09-28 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17874 ) Change subject: Bump up the GBN to 17296101 .. Patch Set 1: (1 comment) LGTM. I left a minor comment below. I can +2 this once

[Impala-ASF-CR] IMPALA-9857: Batching of consecutive partition events

2021-09-28 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/17848 ) Change subject: IMPALA-9857: Batching of consecutive partition events .. IMPALA-9857: Batching of consecutive partition events

[Impala-ASF-CR] IMPALA-9857: Batching of consecutive partition events

2021-09-23 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/17848 ) Change subject: IMPALA-9857: Batching of consecutive partition events .. IMPALA-9857: Batching of consecutive partition events

[Impala-ASF-CR] IMPALA-9857: Batching of consecutive partition events

2021-09-23 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17848 ) Change subject: IMPALA-9857: Batching of consecutive partition events .. Patch Set 7: (3 comments) > Build failed:

[Impala-ASF-CR] IMPALA-9857: Batching of consecutive partition events

2021-09-22 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17848 ) Change subject: IMPALA-9857: Batching of consecutive partition events .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-9857: Batching of consecutive partition events

2021-09-22 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/17848 ) Change subject: IMPALA-9857: Batching of consecutive partition events .. IMPALA-9857: Batching of consecutive partition events

[Impala-ASF-CR] [WIP]: Initial commit: Add logic to sync to latest event id

2021-09-20 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17756 ) Change subject: [WIP]: Initial commit: Add logic to sync to latest event id .. Patch Set 31: (12 comments) I will take another

[Impala-ASF-CR] IMPALA-10914: Consistently schedule scan ranges for Iceberg tables

2021-09-20 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17857 ) Change subject: IMPALA-10914: Consistently schedule scan ranges for Iceberg tables .. Patch Set 1: (7 comments)

[Impala-ASF-CR] IMPALA-9857: Batching of consecutive partition events

2021-09-16 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/17848 ) Change subject: IMPALA-9857: Batching of consecutive partition events .. IMPALA-9857: Batching of consecutive partition events

[Impala-ASF-CR] IMPALA-9857: Batching of consecutive partition events

2021-09-16 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/17848 ) Change subject: IMPALA-9857: Batching of consecutive partition events .. IMPALA-9857: Batching of consecutive partition events

[Impala-ASF-CR] IMPALA-9857: Batching of consecutive partition events

2021-09-16 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17848 ) Change subject: IMPALA-9857: Batching of consecutive partition events .. IMPALA-9857: Batching of consecutive partition events

[Impala-ASF-CR] IMPALA-9857: Batching of consecutive partition events

2021-09-16 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17848 ) Change subject: IMPALA-9857: Batching of consecutive partition events .. Patch Set 2: (7 comments)

[Impala-ASF-CR] IMPALA-9857: Batching of consecutive partition events

2021-09-15 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has removed Zoltan Borok-Nagy from this change. ( http://gerrit.cloudera.org:8080/17848 ) Change subject: IMPALA-9857: Batching of consecutive partition events .. Removed reviewer Zoltan Borok-Nagy. -- To

[Impala-ASF-CR] IMPALA-9857: Batching of consecutive partition events

2021-09-15 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17848 Change subject: IMPALA-9857: Batching of consecutive partition events .. IMPALA-9857: Batching of consecutive partition events

[Impala-ASF-CR] IMPALA-10907: Refactor MetastoreEvents class

2021-09-07 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17833 Change subject: IMPALA-10907: Refactor MetastoreEvents class .. IMPALA-10907: Refactor MetastoreEvents class This is a refactor

[Impala-ASF-CR] IMPALA-10885: Deflake test get table req without fallback

2021-08-30 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17817 ) Change subject: IMPALA-10885: Deflake test_get_table_req_without_fallback .. Patch Set 3: Code-Review+2 self-reviewing this

[Impala-ASF-CR] IMPALA-10885: Deflake test get table req without fallback

2021-08-30 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17817 Change subject: IMPALA-10885: Deflake test_get_table_req_without_fallback .. IMPALA-10885: Deflake

[Impala-ASF-CR] IMPALA-10888: sort partitions by name before comparing in test

2021-08-27 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17812 ) Change subject: IMPALA-10888: sort partitions by name before comparing in test .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10888: sort partitions by name before comparing in test

2021-08-27 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17812 ) Change subject: IMPALA-10888: sort partitions by name before comparing in test .. IMPALA-10888: sort partitions by name before

[Impala-ASF-CR] IMPALA-10888: getPartitionsByNames should return sorted partitions

2021-08-27 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17812 ) Change subject: IMPALA-10888: getPartitionsByNames should return sorted partitions .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-10888: getPartitionsByNames should return sorted partitions

2021-08-26 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17812 ) Change subject: IMPALA-10888: getPartitionsByNames should return sorted partitions .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10888: getPartitionsByNames should return sorted partitions

2021-08-26 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17812 ) Change subject: IMPALA-10888: getPartitionsByNames should return sorted partitions .. IMPALA-10888: getPartitionsByNames should

[Impala-ASF-CR] IMPALA-10888: getPartitionsByNames should return sorted partitions

2021-08-26 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17812 Change subject: IMPALA-10888: getPartitionsByNames should return sorted partitions .. IMPALA-10888: getPartitionsByNames should

[Impala-ASF-CR] [WIP]: Initial commit: Add logic to sync to latest event id

2021-08-25 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17756 ) Change subject: [WIP]: Initial commit: Add logic to sync to latest event id .. Patch Set 19: (14 comments) I took a first pass

[Impala-ASF-CR] IMPALA-9057: Disable test transactional insert events

2021-08-18 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17788 Change subject: IMPALA-9057: Disable test_transactional_insert_events .. IMPALA-9057: Disable test_transactional_insert_events

[Impala-ASF-CR] IMPALA-10858: HMS request for acid fds fixed.

2021-08-18 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17760 ) Change subject: IMPALA-10858: HMS request for acid fds fixed. .. IMPALA-10858: HMS request for acid fds fixed. This

[Impala-ASF-CR] IMPALA-10858: HMS request for acid fds fixed.

2021-08-18 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17760 ) Change subject: IMPALA-10858: HMS request for acid fds fixed. .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10858: HMS request for acid fds fixed.

2021-08-17 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17760 ) Change subject: IMPALA-10858: HMS request for acid fds fixed. .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-10858: HMS request for acid fds fixed.

2021-08-17 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17760 ) Change subject: IMPALA-10858: HMS request for acid fds fixed. .. Patch Set 4: (3 comments) The patch looks good to me. I have

[Impala-ASF-CR] IMPALA-10746: Drop table/db from catalog cache when drop table/db HMS apis are accessed from catalog's metastore server.

2021-08-11 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17576 ) Change subject: IMPALA-10746: Drop table/db from catalog cache when drop table/db HMS apis are accessed from catalog's metastore server.

[Impala-ASF-CR] IMPALA-10746: Drop table/db from catalog cache when drop table/db HMS apis are accessed from catalog's metastore server.

2021-08-11 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17576 ) Change subject: IMPALA-10746: Drop table/db from catalog cache when drop table/db HMS apis are accessed from catalog's metastore server.

[Impala-ASF-CR] IMPALA-10746: Drop table/db from catalog cache when drop table/db HMS apis are accessed from catalog's metastore server.

2021-08-11 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has removed a vote on this change. Change subject: IMPALA-10746: Drop table/db from catalog cache when drop table/db HMS apis are accessed from catalog's metastore server. .. Removed Verified-1 by Impala

[Impala-ASF-CR] IMPALA-8795: (Addendum) Fix test hms integration flakiness

2021-08-11 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17767 Change subject: IMPALA-8795: (Addendum) Fix test_hms_integration flakiness .. IMPALA-8795: (Addendum) Fix test_hms_integration

[Impala-ASF-CR] IMPALA-10746: Drop table/db from catalog cache when drop table/db HMS apis are accessed from catalog's metastore server.

2021-08-11 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17576 ) Change subject: IMPALA-10746: Drop table/db from catalog cache when drop table/db HMS apis are accessed from catalog's metastore server.

[Impala-ASF-CR] IMPALA-10746: Drop table/db from catalog cache when drop table/db HMS apis are accessed from catalog's metastore server.

2021-08-10 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17576 ) Change subject: IMPALA-10746: Drop table/db from catalog cache when drop table/db HMS apis are accessed from catalog's metastore server.

[Impala-ASF-CR] IMPALA-10801: Check the latest compaction Id before serving ACID table

2021-08-10 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17697 ) Change subject: IMPALA-10801: Check the latest compaction Id before serving ACID table .. IMPALA-10801: Check the

[Impala-ASF-CR] IMPALA-10801: Check the latest compaction Id before serving ACID table

2021-08-10 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17697 ) Change subject: IMPALA-10801: Check the latest compaction Id before serving ACID table .. Patch Set 16: Verified+1

[Impala-ASF-CR] IMPALA-10801: Check the latest compaction Id before serving ACID table

2021-08-10 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17697 ) Change subject: IMPALA-10801: Check the latest compaction Id before serving ACID table .. Patch Set 14: (2 comments) Thanks

[Impala-ASF-CR] IMPALA-10746: Drop table/db from catalog cache when drop table/db HMS apis are accessed from catalog's metastore server.

2021-08-10 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17576 ) Change subject: IMPALA-10746: Drop table/db from catalog cache when drop table/db HMS apis are accessed from catalog's metastore server.

[Impala-ASF-CR] IMPALA-10746: Drop table/db from catalog cache when drop table/db HMS apis are accessed from catalog's metastore server.

2021-08-09 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17576 ) Change subject: IMPALA-10746: Drop table/db from catalog cache when drop table/db HMS apis are accessed from catalog's metastore server.

[Impala-ASF-CR] IMPALA-8795: Turn on events processing by default

2021-08-09 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17612 ) Change subject: IMPALA-8795: Turn on events processing by default .. IMPALA-8795: Turn on events processing by default

[Impala-ASF-CR] IMPALA-8795: Turn on events processing by default

2021-08-07 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17612 ) Change subject: IMPALA-8795: Turn on events processing by default .. Patch Set 14: (1 comment)

  1   2   3   4   5   6   7   8   9   10   >