[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-06-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 5: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-29 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 5: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 5: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-24 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 5: > Patch Set 4: > > > Patch Set 4:

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-24 Thread Yifan Zhang (Code Review)
Hello Daniel Becker, Gabor Kaszab, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21441 to look at the new patch set (#5). Change subject: IMPALA-12562: Cast double and float to string with exact

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-23 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 4: > Patch Set 4: Verified-1 > >

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-23 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 4: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-23 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-22 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-22 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-22 Thread Yifan Zhang (Code Review)
Hello Daniel Becker, Gabor Kaszab, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21441 to look at the new patch set (#3). Change subject: IMPALA-12562: Cast double and float to string with exact

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 2: (3 comments) Looks great!

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-17 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 2: (1 comment) > Patch Set 1:

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-17 Thread Yifan Zhang (Code Review)
Hello Daniel Becker, Gabor Kaszab, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21441 to look at the new patch set (#2). Change subject: IMPALA-12562: Cast double and float to string with exact

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 1: Build Failed

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-17 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 1: Code-Review+1 (1 comment) Thanks

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-17 Thread Yifan Zhang (Code Review)
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21441 Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. IMPALA-12562: Cast double and float to string with