Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 23:
This change did not cherrypick
Tim Armstrong has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
IMPALA-5216: Make admission control queuing async
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 22:
exhaustive tests passed too.
--
To view, visit
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 22: Verified+1
--
To view, visit
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 22:
Build started:
Tim Armstrong has uploaded a new patch set (#22) to the change originally
created by Bikramjeet Vig. ( http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
IMPALA-5216:
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 21: Verified-1
Build failed:
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 21:
Build started:
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 21: Code-Review+2
--
To view, visit
Dan Hecht has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 20: Code-Review+2
--
To view, visit
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 20:
Dan, it's probably worth looking at PS19->20. It's
Tim Armstrong has uploaded a new patch set (#20) to the change originally
created by Bikramjeet Vig. ( http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
IMPALA-5216:
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 19:
So it turns out the test was already broken - the
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 19:
Another clang-tidy error in promise-test and a
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 19: Verified-1
Build failed:
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 18:
Build started:
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 19: Code-Review+2
--
To view, visit
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 19:
Build started:
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 17: Verified-1
Build failed:
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 17:
Build started:
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 17: Code-Review+2
--
To view, visit
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 16:
Build started:
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 16: Code-Review+1
--
To view, visit
Dan Hecht has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 16: Code-Review+2
Tim, do you have any more comments?
--
Dan Hecht has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 16:
> - GetOperationStatus() after rejection should show
Bikramjeet Vig has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 15:
> Could you file a JIRA for that? We probably
Hello Tim Armstrong, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10060
to look at the new patch set (#16).
Change subject: IMPALA-5216: Make admission control queuing async
Dan Hecht has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 15:
> (2 comments)
>
> > Do we have sufficient test
Hello Tim Armstrong, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10060
to look at the new patch set (#15).
Change subject: IMPALA-5216: Make admission control queuing async
Bikramjeet Vig has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 14:
(2 comments)
> Do we have sufficient test
Bikramjeet Vig has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 14:
(1 comment)
Just rebased in patchset 14, will
Hello Tim Armstrong, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10060
to look at the new patch set (#14).
Change subject: IMPALA-5216: Make admission control queuing async
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 12:
(2 comments)
Dan Hecht has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 12:
(1 comment)
Hello Tim Armstrong, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10060
to look at the new patch set (#13).
Change subject: IMPALA-5216: Make admission control queuing async
Bikramjeet Vig has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 12:
(3 comments)
Dan Hecht has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 12:
(5 comments)
Looks nice. Please go ahead and rebase
Hello Tim Armstrong, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10060
to look at the new patch set (#12).
Change subject: IMPALA-5216: Make admission control queuing async
Bikramjeet Vig has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 11:
(30 comments)
Dan Hecht has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 11:
(29 comments)
That looks good. My review comments are
Hello Tim Armstrong, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10060
to look at the new patch set (#11).
Change subject: IMPALA-5216: Make admission control queuing async
Bikramjeet Vig has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 10:
(1 comment)
Bikramjeet Vig has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 10:
> Uploaded patch set 10.
No notable conflicts
Hello Tim Armstrong, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10060
to look at the new patch set (#10).
Change subject: IMPALA-5216: Make admission control queuing async
Bikramjeet Vig has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 9:
> > (2 comments)
> >
> > will rebase in next
Dan Hecht has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 9:
> (2 comments)
>
> will rebase in next patch, please
Bikramjeet Vig has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 9:
(2 comments)
will rebase in next patch, please
Hello Tim Armstrong, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10060
to look at the new patch set (#9).
Change subject: IMPALA-5216: Make admission control queuing async
..
Dan Hecht has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 7:
(1 comment)
Bikramjeet Vig has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 8:
(3 comments)
Just wanted to get the replay
Bikramjeet Vig has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 8:
(1 comment)
Bikramjeet Vig has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 8:
(1 comment)
Bikramjeet Vig has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 7:
(40 comments)
Hello Tim Armstrong, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10060
to look at the new patch set (#8).
Change subject: IMPALA-5216: Make admission control queuing async
..
Dan Hecht has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 7:
(8 comments)
I think these are my final comments for
Dan Hecht has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 7:
(1 comment)
Dan Hecht has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 7:
(5 comments)
Will have some more comments but wanted
Dan Hecht has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 7:
(27 comments)
I need to dig into the details some more
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 7:
(2 comments)
Hello Tim Armstrong, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10060
to look at the new patch set (#7).
Change subject: IMPALA-5216: Make admission control queuing async
..
Bikramjeet Vig has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 5:
(6 comments)
Hello Tim Armstrong, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10060
to look at the new patch set (#6).
Change subject: IMPALA-5216: Make admission control queuing async
..
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async
..
Patch Set 5:
(5 comments)
I'm ready to +1 after these issues
Hello Tim Armstrong, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10060
to look at the new patch set (#5).
Change subject: IMPALA-5216: Make admission control queuing async
..
64 matches
Mail list logo
