[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 21: Awesome work, Quanlong! Thanks for your contribution.

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 21: Thank you, Tim, Dan, and Joe! I do appreciate your

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 20: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. IMPALA-5717: Support for reading ORC data files

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 20: Code-Review+2 You'll still be the author of the

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-10 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 20: Code-Review+1 LGTM. Thank you Tim! The errors now

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 20: Build started:

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 18: I made a couple of changes to the error handling to

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#19) to the change originally created by Quanlong Huang. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. IMPALA-5717:

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-10 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 18: Hi all, this patch is ready to be reviewed. -- To

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-09 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 18: The bug I mentioned before is due to stale data read

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-09 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 17: Sorry that I find a bug in this patch. Please wait

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-09 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 17: Refactor exceptions to fix clang-tidy warnings --

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-09 Thread Quanlong Huang (Code Review)
Hello Tim Armstrong, Joe McDonnell, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9134 to look at the new patch set (#17). Change subject: IMPALA-5717: Support for reading ORC data files

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 16: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 16: Build started:

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 16: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-05 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 14: Fixed some compiler warnings. I can build with

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-05 Thread Quanlong Huang (Code Review)
Hello Tim Armstrong, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9134 to look at the new patch set (#14). Change subject: IMPALA-5717: Support for reading ORC data files

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 13: Actually I think the ASAN build is just slow - not

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 13: Code-Review+2 I'm still in the process of running

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-05 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 13: (4 comments) Sure, Tim. Thank you for doing local

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-05 Thread Quanlong Huang (Code Review)
Hello Tim Armstrong, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9134 to look at the new patch set (#13). Change subject: IMPALA-5717: Support for reading ORC data files

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 12: (4 comments) Had some minor comments, but I'm ready

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-04 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 11: The reason that test_codegen.py fails is that I

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-03 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 11: Just find that test_codegen.py is broken. Will fix

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-03 Thread Quanlong Huang (Code Review)
Hello Tim Armstrong, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9134 to look at the new patch set (#11). Change subject: IMPALA-5717: Support for reading ORC data files

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-30 Thread Quanlong Huang (Code Review)
Hello Tim Armstrong, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9134 to look at the new patch set (#9). Change subject: IMPALA-5717: Support for reading ORC data files

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 8: (4 comments) I think we're close to the point where

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 5: (2 comments) Answered your questions (sorry it took

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-25 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 8: Just rebase the patch -- To view, visit

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-25 Thread Quanlong Huang (Code Review)
Hello Tim Armstrong, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9134 to look at the new patch set (#8). Change subject: IMPALA-5717: Support for reading ORC data files

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-22 Thread Quanlong Huang (Code Review)
Hello Tim Armstrong, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9134 to look at the new patch set (#7). Change subject: IMPALA-5717: Support for reading ORC data files

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-22 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 6: (4 comments) Sorry that some tests were failed. I've

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 6: (1 comment) Thank you for refactoring the nested

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-21 Thread Quanlong Huang (Code Review)
Hello Tim Armstrong, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9134 to look at the new patch set (#6). Change subject: IMPALA-5717: Support for reading ORC data files

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-21 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 5: (4 comments) I've refactored the previous patch.

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 5: Thanks for addressing all those comments! I'll take a

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-20 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 5: (36 comments) Updates: I'm currently working on

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-15 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-15 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 5: (1 comment) Thanks for your detailed comments, Tim!

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 5: (39 comments) Finally made time to do another

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 5: (3 comments) Thanks for the new patchset. I need to

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-12 Thread Quanlong Huang (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9134 to look at the new patch set (#5). Change subject: IMPALA-5717: Support for reading ORC data files ..

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-12 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-10 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 4: pre-review test for this patch:

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-09 Thread Quanlong Huang (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9134 to look at the new patch set (#4). Change subject: IMPALA-5717: Support for reading ORC data files .. IMPALA-5717: