[Impala-ASF-CR] IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

2018-02-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9211 Change subject: IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution .. IMPALA-5191,

[Impala-ASF-CR] IMPALA-6473: Fix analytic fn that partitions and orders on same expr

2018-02-05 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9218 ) Change subject: IMPALA-6473: Fix analytic fn that partitions and orders on same expr .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6473: Fix analytic fn that partitions and orders on same expr

2018-02-05 Thread Thomas Tauber-Marshall (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9218 to look at the new patch set (#2). Change subject: IMPALA-6473: Fix analytic fn that partitions and orders on same expr

[native-toolchain-CR](cdh5.x) Bump Kudu version to b315d0e

2018-02-05 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9220 ) Change subject: Bump Kudu version to b315d0e .. Patch Set 1: Code-Review+2 Clean cherry-pick -- To view, visit

[Impala-ASF-CR] IMPALA-6473: Fix analytic fn that partitions and orders on same expr

2018-02-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9218 ) Change subject: IMPALA-6473: Fix analytic fn that partitions and orders on same expr .. Patch Set 2: Code-Review+2 -- To view, visit

[native-toolchain-CR](cdh5.x) Bump Kudu version to b315d0e

2018-02-05 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9220 ) Change subject: Bump Kudu version to b315d0e .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6473: Fix analytic fn that partitions and orders on same expr

2018-02-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9218 ) Change subject: IMPALA-6473: Fix analytic fn that partitions and orders on same expr .. Patch Set 2: Build started:

[native-toolchain-CR](cdh5.x) Bump Kudu version to b315d0e

2018-02-05 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9220 Change subject: Bump Kudu version to b315d0e .. Bump Kudu version to b315d0e Change-Id:

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-02-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 10: (19 comments)

[Impala-ASF-CR] IMPALA-6437: separate AC/scheduler from catalog topic updates

2018-02-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9123 ) Change subject: IMPALA-6437: separate AC/scheduler from catalog topic updates .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-6437: separate AC/scheduler from catalog topic updates

2018-02-05 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Dimitris Tsirogiannis, Alex Behm, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9123 to look at the new patch set (#14). Change subject: IMPALA-6437: separate AC/scheduler from catalog topic updates

[Impala-ASF-CR] IMPALA-6437: separate AC/scheduler from catalog topic updates

2018-02-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9123 ) Change subject: IMPALA-6437: separate AC/scheduler from catalog topic updates .. Patch Set 14: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6437: separate AC/scheduler from catalog topic updates

2018-02-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9123 ) Change subject: IMPALA-6437: separate AC/scheduler from catalog topic updates .. Patch Set 11: (1 comment) Carry +1

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-02-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 15: Code-Review+2 Thanks for fixing it and running

[Impala-ASF-CR] Bump Kudu version to b315d0e

2018-02-05 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9217 Change subject: Bump Kudu version to b315d0e .. Bump Kudu version to b315d0e Change-Id:

[Impala-ASF-CR] IMPALA-6449: Use CLOCK MONOTONIC in ConditionVariable

2018-02-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9158 ) Change subject: IMPALA-6449: Use CLOCK_MONOTONIC in ConditionVariable .. Patch Set 2: Build started:

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9214 Change subject: Force inlining of BloomFilter::MakeMask .. Force inlining of BloomFilter::MakeMask I noticed that this function was

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-05 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9192 ) Change subject: IMPALA-6204: Remove external DataSource .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-6437: separate AC/scheduler from catalog topic updates

2018-02-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9123 ) Change subject: IMPALA-6437: separate AC/scheduler from catalog topic updates .. Patch Set 11: (13 comments) Addressed most of the

[Impala-ASF-CR] IMPALA-6437: separate AC/scheduler from catalog topic updates

2018-02-05 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Dimitris Tsirogiannis, Alex Behm, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9123 to look at the new patch set (#13). Change subject: IMPALA-6437: separate AC/scheduler from catalog topic updates

[Impala-ASF-CR] IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

2018-02-05 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9211 ) Change subject: IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution .. Patch Set 1: Looping in

[native-toolchain-CR] Bump Kudu version to b315d0e

2018-02-05 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9212 ) Change subject: Bump Kudu version to b315d0e .. Patch Set 1: This is just so that Impala will be getting developed against a

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9192 ) Change subject: IMPALA-6204: Remove external DataSource .. Patch Set 4: (1 comment) I've been generally hesitant of removing

[native-toolchain-CR] Quiet down file transfers, rename target platform variable

2018-02-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9149 ) Change subject: Quiet down file transfers, rename target platform variable .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-05 Thread Philip Zeyliger (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9192 to look at the new patch set (#4). Change subject: IMPALA-6204: Remove external DataSource .. IMPALA-6204:

[native-toolchain-CR] Bump Kudu version to b315d0e

2018-02-05 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9212 Change subject: Bump Kudu version to b315d0e .. Bump Kudu version to b315d0e Change-Id:

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Force inlining of BloomFilter::MakeMask I noticed that this function was

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-05 Thread Philip Zeyliger (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, Zach Amsden, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9192 to look at the new patch set (#5). Change subject: IMPALA-6204: Remove external DataSource

[Impala-ASF-CR] IMPALA-6473: Fix analytic fn that partitions and orders on same expr

2018-02-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9218 ) Change subject: IMPALA-6473: Fix analytic fn that partitions and orders on same expr .. IMPALA-6473: Fix analytic fn

[Impala-ASF-CR] IMPALA-6473: Fix analytic fn that partitions and orders on same expr

2018-02-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9218 ) Change subject: IMPALA-6473: Fix analytic fn that partitions and orders on same expr .. Patch Set 2: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-5037: Default PARQUET ARRAY RESOLUTION=THREE LEVEL

2018-02-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9210 ) Change subject: IMPALA-5037: Default PARQUET_ARRAY_RESOLUTION=THREE_LEVEL .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-02-05 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/8949 ) Change subject: IMPALA-6075: Add Impala daemon metric for catalog version. .. Patch Set 8: > Looks like the API for Metric changed >

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-02-05 Thread Pranay Singh (Code Review)
Hello Dimitris Tsirogiannis, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8949 to look at the new patch set (#9). Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.

[Impala-ASF-CR] IMPALA-5037: Default PARQUET ARRAY RESOLUTION=THREE LEVEL

2018-02-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9210 ) Change subject: IMPALA-5037: Default PARQUET_ARRAY_RESOLUTION=THREE_LEVEL .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5037: Default PARQUET ARRAY RESOLUTION=THREE LEVEL

2018-02-05 Thread Alex Behm (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9210 to look at the new patch set (#2). Change subject: IMPALA-5037: Default PARQUET_ARRAY_RESOLUTION=THREE_LEVEL ..

[Impala-ASF-CR] IMPALA-5269: Fix issue with final line of query followed by a comment

2018-02-05 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9191 ) Change subject: IMPALA-5269: Fix issue with final line of query followed by a comment .. Patch Set 4: Code-Review+1 -- To

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9192 ) Change subject: IMPALA-6204: Remove external DataSource .. Patch Set 4: Given that data sources weren't persisted to the HMS, why do we

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9192 ) Change subject: IMPALA-6204: Remove external DataSource .. Patch Set 4: (2 comments) High-level questions: - Why are we still keeping

[native-toolchain-CR] Bump Kudu version to b315d0e

2018-02-05 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9212 ) Change subject: Bump Kudu version to b315d0e .. Bump Kudu version to b315d0e Change-Id:

[Impala-ASF-CR] IMPALA-6448: Re-enable kerberized testing with KRPC

2018-02-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9164 ) Change subject: IMPALA-6448: Re-enable kerberized testing with KRPC .. Patch Set 4: Build started:

[native-toolchain-CR] Bump Kudu version to b315d0e

2018-02-05 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9212 ) Change subject: Bump Kudu version to b315d0e .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6448: Re-enable kerberized testing with KRPC

2018-02-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9164 ) Change subject: IMPALA-6448: Re-enable kerberized testing with KRPC .. Patch Set 4: Code-Review+2 GVO failed due to an unrelated flaky

[native-toolchain-CR] Bump Kudu version to b315d0e

2018-02-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9212 ) Change subject: Bump Kudu version to b315d0e .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9212 To

[Impala-ASF-CR] IMPALA-6473: Fix analytic fn that partitions and orders on same expr

2018-02-05 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9218 Change subject: IMPALA-6473: Fix analytic fn that partitions and orders on same expr .. IMPALA-6473: Fix analytic fn that

[Impala-ASF-CR] IMPALA-6473: Fix analytic fn that partitions and orders on same expr

2018-02-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9218 ) Change subject: IMPALA-6473: Fix analytic fn that partitions and orders on same expr .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6448: Re-enable kerberized testing with KRPC

2018-02-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9164 ) Change subject: IMPALA-6448: Re-enable kerberized testing with KRPC .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-02-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 11: (24 comments)

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-02-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9032 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. IMPALA-6219: Use AES-GCM for spill-to-disk

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-02-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 15: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6448: Re-enable kerberized testing with KRPC

2018-02-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9164 ) Change subject: IMPALA-6448: Re-enable kerberized testing with KRPC .. IMPALA-6448: Re-enable kerberized testing with

[Impala-ASF-CR] IMPALA-6456: Add flags to configure rpc negotiation timeout ms and negotiation thread count in KRPC

2018-02-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9186 ) Change subject: IMPALA-6456: Add flags to configure rpc_negotiation_timeout_ms and negotiation thread count in KRPC .. Patch Set 2: (4

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9192 ) Change subject: IMPALA-6204: Remove external DataSource .. Patch Set 4:

[Impala-ASF-CR] IMPALA-6449: Use CLOCK MONOTONIC in ConditionVariable

2018-02-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9158 ) Change subject: IMPALA-6449: Use CLOCK_MONOTONIC in ConditionVariable .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6449: Use CLOCK MONOTONIC in ConditionVariable

2018-02-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9158 ) Change subject: IMPALA-6449: Use CLOCK_MONOTONIC in ConditionVariable .. Patch Set 2: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9192 ) Change subject: IMPALA-6204: Remove external DataSource .. Patch Set 5: Code-Review+1 (1 comment) lgtm, will give others a chance to look

[Impala-ASF-CR] IMPALA-5690: Upgrade thrift to 0.9.3-p3

2018-02-05 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/9168 ) Change subject: IMPALA-5690: Upgrade thrift to 0.9.3-p3 .. IMPALA-5690: Upgrade thrift to 0.9.3-p3 Dependency changes: - BE and python use

[Impala-ASF-CR] IMPALA-6449: Use CLOCK MONOTONIC in ConditionVariable

2018-02-05 Thread Michael Ho (Code Review)
Hello Jim Apple, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9158 to look at the new patch set (#2). Change subject: IMPALA-6449: Use CLOCK_MONOTONIC in ConditionVariable

[Impala-ASF-CR] IMPALA-6437: separate AC/scheduler from catalog topic updates

2018-02-05 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9123 ) Change subject: IMPALA-6437: separate AC/scheduler from catalog topic updates .. Patch Set 13: Code-Review+1 (2 comments)