[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-07 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#8). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-07 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#7). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-7082: Show human readable size in query backend page

2018-06-07 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10523 ) Change subject: IMPALA-7082: Show human readable size in query backend page .. Patch Set 6: Thanks for your reviews and your recent

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 8: (1 comment) Thanks for your

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 9: Code-Review+1 > (1 comment) >

[Impala-ASF-CR] IMPALA-7143: disable affected describe formatted/extended tests

2018-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10635 Change subject: IMPALA-7143: disable affected describe formatted/extended tests .. IMPALA-7143: disable affected describe

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-7143: disable affected describe formatted/extended tests

2018-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10635 ) Change subject: IMPALA-7143: disable affected describe formatted/extended tests .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-07 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-07 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 5: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 9: Patchset 9 is a rebase -- To

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. IMPALA-2751: Matching quotes are not required in comments

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-07 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#9). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 2: (14 comments) made an

[Impala-ASF-CR] IMPALA-7143: disable affected describe formatted/extended tests

2018-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10635 ) Change subject: IMPALA-7143: disable affected describe formatted/extended tests .. Patch Set 1: Verified+1 The FE tests passed. --

[Impala-ASF-CR] IMPALA-7143: disable affected describe formatted/extended tests

2018-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10635 ) Change subject: IMPALA-7143: disable affected describe formatted/extended tests .. Patch Set 2: This change did not

[Impala-ASF-CR] IMPALA-3040: Print logs around removeDirective()

2018-06-07 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10640 Change subject: IMPALA-3040: Print logs around removeDirective() .. IMPALA-3040: Print logs around removeDirective() I observed that

[Impala-ASF-CR] IMPALA-7143: disable affected describe formatted/extended tests

2018-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10635 ) Change subject: IMPALA-7143: disable affected describe formatted/extended tests .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-06-07 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. Patch Set 13: (8 comments) I checked out your patch and ran

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 5: Code-Review-2 Let's not merge for now. This

[Impala-ASF-CR] IMPALA-3040: Print logs around removeDirective()

2018-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10640 ) Change subject: IMPALA-3040: Print logs around removeDirective() .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-5737: Tighten minicluster memory limit

2018-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10277 ) Change subject: IMPALA-5737: Tighten minicluster memory limit .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-7044: Prevent overflow when computing Parquet block size

2018-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10483 ) Change subject: IMPALA-7044: Prevent overflow when computing Parquet block size .. Patch Set 6: (1 comment) Do you want to go ahead

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

2018-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10517 ) Change subject: IMPALA-7071: make get_fs_path() idempotent .. Patch Set 3: Do you want to go ahead and merge this? Seems low risk.

[Impala-ASF-CR] IMPALA-3040: Print logs around removeDirective()

2018-06-07 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10640 ) Change subject: IMPALA-3040: Print logs around removeDirective() .. IMPALA-3040: Print logs around removeDirective() I observed that some

[Impala-ASF-CR] IMPALA-7146: log session to query mapping

2018-06-07 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10638 ) Change subject: IMPALA-7146: log session to query mapping .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR](2.x) Ignore "IMPALA-7143: disable affected describe formatted/extended tests"

2018-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has removed Lars Volker from this change. ( http://gerrit.cloudera.org:8080/10639 ) Change subject: Ignore "IMPALA-7143: disable affected describe formatted/extended tests" .. Removed reviewer Lars Volker. --

[Impala-ASF-CR] IMPALA-7146: log session to query mapping

2018-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10638 ) Change subject: IMPALA-7146: log session to query mapping .. IMPALA-7146: log session to query mapping Example output:

[Impala-ASF-CR] IMPALA-7146: log session to query mapping

2018-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10638 ) Change subject: IMPALA-7146: log session to query mapping .. Patch Set 1: Verified+1 $ ./bin/compare_branches.py 2018-06-07

[Impala-ASF-CR] IMPALA-3040: Print logs around removeDirective()

2018-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10640 ) Change subject: IMPALA-3040: Print logs around removeDirective() .. Patch Set 2: Code-Review+2 Makes sense. Let's merge this so we

[Impala-ASF-CR] IMPALA-7143: disable affected describe formatted/extended tests

2018-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10635 ) Change subject: IMPALA-7143: disable affected describe formatted/extended tests .. Patch Set 1: Code-Review+2 I'll +2 for now just to

[Impala-ASF-CR] IMPALA-7143: disable affected describe formatted/extended tests

2018-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10635 ) Change subject: IMPALA-7143: disable affected describe formatted/extended tests .. IMPALA-7143: disable affected describe

[Impala-ASF-CR](2.x) Ignore "IMPALA-7143: disable affected describe formatted/extended tests"

2018-06-07 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10639 ) Change subject: Ignore "IMPALA-7143: disable affected describe formatted/extended tests" .. Patch Set 1: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-7108: IllegalStateException hit during CardinalityCheckNode.

2018-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10605 ) Change subject: IMPALA-7108: IllegalStateException hit during CardinalityCheckNode. .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5737: Tighten minicluster memory limit

2018-06-07 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10277 ) Change subject: IMPALA-5737: Tighten minicluster memory limit .. Patch Set 7: > Patch Set 7: Verified-1 > > Build failed:

[Impala-ASF-CR] IMPALA-7146: log session to query mapping

2018-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10638 Change subject: IMPALA-7146: log session to query mapping .. IMPALA-7146: log session to query mapping Example output: I0607

[Impala-ASF-CR](2.x) Ignore "IMPALA-7143: disable affected describe formatted/extended tests"

2018-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10639 Change subject: Ignore "IMPALA-7143: disable affected describe formatted/extended tests" .. Ignore "IMPALA-7143: disable affected

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-06-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. Patch Set 16: (8 comments)

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-06-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#16). ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. IMPALA-5552: Add support for authorized proxy groups The patch

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 9: Verified-1 FYI, apparently

[Impala-ASF-CR] IMPALA-7146: log session to query mapping

2018-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10638 ) Change subject: IMPALA-7146: log session to query mapping .. Patch Set 2: Oops verified the wrong thing... I guess leaving it is less

[Impala-ASF-CR] IMPALA-5737: Tighten minicluster memory limit

2018-06-07 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/10277 ) Change subject: IMPALA-5737: Tighten minicluster memory limit .. IMPALA-5737: Tighten minicluster memory limit This patch limits

[Impala-ASF-CR] IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function

2018-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10488 ) Change subject: IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function .. Patch Set 3: I think the risk is limited here,

[Impala-ASF-CR] IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function

2018-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10488 ) Change subject: IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function

2018-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10488 ) Change subject: IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. IMPALA-6917: Implement COMMENT ON TABLE/VIEW This patch implements

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 5: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-07 Thread Mostafa Mokhtar (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10415 to look at the new patch set (#4). Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-07 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 3: (22 comments)

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-06-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. Patch Set 8: Rebased. -- To view, visit

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-06-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. IMPALA-7106: Print rewritten SQL correctly when

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 2: (4 comments) Responded to the

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 5: > Patch Set 5: Verified-1 > > Build failed:

[Impala-ASF-CR] IMPALA-7144: Re-enable TestDescribeTableResults

2018-06-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10643 Change subject: IMPALA-7144: Re-enable TestDescribeTableResults .. IMPALA-7144: Re-enable TestDescribeTableResults This patch makes the

[Impala-ASF-CR] IMPALA-7016: Implement ALTER DATABASE SET OWNER

2018-06-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/10471 ) Change subject: IMPALA-7016: Implement ALTER DATABASE SET OWNER .. IMPALA-7016: Implement ALTER DATABASE SET OWNER Alter the database

[Impala-ASF-CR] IMPALA-7016: Implement ALTER DATABASE SET OWNER

2018-06-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10471 ) Change subject: IMPALA-7016: Implement ALTER DATABASE SET OWNER .. Patch Set 9: Rebased -- To view, visit

[Impala-ASF-CR] IMPALA-6035: Add query options to limit thread reservation

2018-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10365 ) Change subject: IMPALA-6035: Add query options to limit thread reservation .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-7108: IllegalStateException hit during CardinalityCheckNode.

2018-06-07 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/10605 ) Change subject: IMPALA-7108: IllegalStateException hit during CardinalityCheckNode. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-06-07 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. IMPALA-3307: Add support for IANA time-zone db Impala currently uses

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-06-07 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 11: (2 comments) Added some tests for extracting files

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

2018-06-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10517 ) Change subject: IMPALA-7071: make get_fs_path() idempotent .. Patch Set 4: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

2018-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10517 ) Change subject: IMPALA-7071: make get_fs_path() idempotent .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

2018-06-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10517 ) Change subject: IMPALA-7071: make get_fs_path() idempotent .. Patch Set 3: Sure -- To view, visit http://gerrit.cloudera.org:8080/10517

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 6: Rebased -- To view, visit

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. IMPALA-2751: Matching quotes are not required in comments

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. Patch Set 7: Rebased. Can anyone carry +2 for this? -- To view,

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-06-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. IMPALA-2195: Improper handling of comments in queries This

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-06-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. Patch Set 14: (8 comments) Fixed all the flake8 errors and

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 2: (10 comments)

[Impala-ASF-CR] IMPALA-6953: part 2: clean up DiskIoMgr

2018-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10479 ) Change subject: IMPALA-6953: part 2: clean up DiskIoMgr .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-6953: part 2: clean up DiskIoMgr

2018-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10479 ) Change subject: IMPALA-6953: part 2: clean up DiskIoMgr .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-6953: part 2: clean up DiskIoMgr

2018-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10479 ) Change subject: IMPALA-6953: part 2: clean up DiskIoMgr .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-07 Thread Todd Lipcon (Code Review)
Hello Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10611 to look at the new patch set (#3). Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources

2018-06-07 Thread Todd Lipcon (Code Review)
Hello Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10626 to look at the new patch set (#2). Change subject: IMPALA-7128 (part 2): add an interface for data sources ..

[Impala-ASF-CR] IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog

2018-06-07 Thread Todd Lipcon (Code Review)
Hello Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10630 to look at the new patch set (#2). Change subject: IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 3: Code-Review+2 thanks for the

[Impala-ASF-CR] IMPALA-7102: Disable support of erasure coding by default

2018-06-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10646 Change subject: IMPALA-7102: Disable support of erasure coding by default .. IMPALA-7102: Disable support of erasure coding by

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

2018-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10517 ) Change subject: IMPALA-7071: make get_fs_path() idempotent .. IMPALA-7071: make get_fs_path() idempotent This avoids

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

2018-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10517 ) Change subject: IMPALA-7071: make get_fs_path() idempotent .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7099: Don't set FILESYSTEM PREFIX for s3

2018-06-07 Thread Dan Hecht (Code Review)
Hello Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10595 to look at the new patch set (#3). Change subject: IMPALA-7099: Don't set FILESYSTEM_PREFIX for s3

[Impala-ASF-CR] IMPALA-7149: Skip q7 in test mem usage scaling in erasure coding build

2018-06-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10647 Change subject: IMPALA-7149: Skip q7 in test_mem_usage_scaling in erasure coding build .. IMPALA-7149: Skip q7 in

[Impala-ASF-CR] IMPALA-3040: Print logs around removeDirective()

2018-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10640 ) Change subject: IMPALA-3040: Print logs around removeDirective() .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3040: Print logs around removeDirective()

2018-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10640 ) Change subject: IMPALA-3040: Print logs around removeDirective() .. IMPALA-3040: Print logs around removeDirective()

[Impala-ASF-CR] IMPALA-6953: part 2: clean up DiskIoMgr

2018-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10479 ) Change subject: IMPALA-6953: part 2: clean up DiskIoMgr .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7137. Support configuring Frontend to use LocalCatalog

2018-06-07 Thread Todd Lipcon (Code Review)
Hello Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10629 to look at the new patch set (#2). Change subject: IMPALA-7137. Support configuring Frontend to use LocalCatalog

[Impala-ASF-CR] IMPALA-7141. Extract interfaces for partition pruning without loading

2018-06-07 Thread Todd Lipcon (Code Review)
Hello Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10631 to look at the new patch set (#2). Change subject: IMPALA-7141. Extract interfaces for partition pruning without loading

[Impala-ASF-CR] IMPALA-7135. Skeleton implementation of LocalCatalog

2018-06-07 Thread Todd Lipcon (Code Review)
Hello Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10627 to look at the new patch set (#2). Change subject: IMPALA-7135. Skeleton implementation of LocalCatalog ..

[Impala-ASF-CR] IMPALA-7099: Don't set FILESYSTEM PREFIX for s3

2018-06-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10595 ) Change subject: IMPALA-7099: Don't set FILESYSTEM_PREFIX for s3 .. Patch Set 3: Validated using an S3 core build. The standard GVO

[Impala-ASF-CR] IMPALA-7099: Don't set FILESYSTEM PREFIX for s3

2018-06-07 Thread Dan Hecht (Code Review)
Dan Hecht has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10595 ) Change subject: IMPALA-7099: Don't set FILESYSTEM_PREFIX for s3 .. IMPALA-7099: Don't set FILESYSTEM_PREFIX for s3 When S3

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-06-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has removed a vote on this change. Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. Removed Code-Review+1 by Fredy Wijaya -- To view, visit http://gerrit.cloudera.org:8080/10442 To

[Impala-ASF-CR] IMPALA-5737: Tighten minicluster memory limit

2018-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10277 ) Change subject: IMPALA-5737: Tighten minicluster memory limit .. Patch Set 8: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5737: Tighten minicluster memory limit

2018-06-07 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10277 ) Change subject: IMPALA-5737: Tighten minicluster memory limit .. Patch Set 8: > Patch Set 8: Verified-1 > > Build failed:

[Impala-ASF-CR] IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function

2018-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10488 ) Change subject: IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7144: Re-enable TestDescribeTableResults

2018-06-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10643 ) Change subject: IMPALA-7144: Re-enable TestDescribeTableResults .. Patch Set 2: (11 comments)

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 2: (3 comments) thanks for the

[Impala-ASF-CR] IMPALA-7099: Don't set FILESYSTEM PREFIX for s3

2018-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10595 ) Change subject: IMPALA-7099: Don't set FILESYSTEM_PREFIX for s3 .. Patch Set 2: Do you want to go ahead and start this merge? It

  1   2   >