[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. Patch Set 17: Build started:

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10654 ) Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable .. Patch Set 2: (1 comment) Thanks for taking a look Todd and Tim!

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 11: (2 comments)

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. Patch Set 17: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-14 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#11). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10654 ) Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable .. Patch Set 3: Code-Review+1 Patch set 3 is a rebase. (Carry +1)

[Impala-ASF-CR] IMPALA-7141 (part 1): clean up handling of default/dummy partition

2018-06-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10711 ) Change subject: IMPALA-7141 (part 1): clean up handling of default/dummy partition .. Patch Set 1: Code-Review+1 (3 comments) I

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-14 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, Todd Lipcon, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10654 to look at the new patch set (#3). Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-06-14 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 2: In order to reduce flakiness while we wait for a fix for the

[Impala-ASF-CR] IMPALA-7141 (part 1): clean up handling of default/dummy partition

2018-06-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10711 ) Change subject: IMPALA-7141 (part 1): clean up handling of default/dummy partition .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-7141 (part 1): clean up handling of default/dummy partition

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10711 ) Change subject: IMPALA-7141 (part 1): clean up handling of default/dummy partition .. Patch Set 1: Code-Review+2 (1 comment) nice

[Impala-ASF-CR] IMPALA-7141 (part 1): clean up handling of default/dummy partition

2018-06-14 Thread Todd Lipcon (Code Review)
Hello Gabor Kaszab, Zoltan Borok-Nagy, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10711 to look at the new patch set (#2). Change subject: IMPALA-7141 (part 1): clean up handling of default/dummy partition

[Impala-ASF-CR] IMPALA-7141 (part 2). Extract interfaces for partition pruning without loading

2018-06-14 Thread Todd Lipcon (Code Review)
Hello Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10631 to look at the new patch set (#7). Change subject: IMPALA-7141 (part 2). Extract interfaces for partition pruning without loading

[Impala-ASF-CR](2.x) IMPALA-5216: Make admission control queuing async

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10715 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 2: Build started:

[Impala-ASF-CR] Revert "IMPALA-5893: Remove old kinit code for Impala 3"

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10563 ) Change subject: Revert "IMPALA-5893: Remove old kinit code for Impala 3" .. Patch Set 1: I think you'll need to add a couple of

[Impala-ASF-CR](2.x) IMPALA-5216: Make admission control queuing async

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10715 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 2: Code-Review+2 Fix a clang-tidy issue in kinit code

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 11: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-7046: introduce "global" debug actions

2018-06-14 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10690 Change subject: IMPALA-7046: introduce "global" debug_actions .. IMPALA-7046: introduce "global" debug_actions The motivation is to add

[Impala-ASF-CR] IMPALA-7046: introduce "global" debug actions

2018-06-14 Thread Dan Hecht (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10690 to look at the new patch set (#5). Change subject: IMPALA-7046: introduce "global" debug_actions .. IMPALA-7046:

[Impala-ASF-CR] IMPALA-7016: Implement ALTER DATABASE SET OWNER

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10471 ) Change subject: IMPALA-7016: Implement ALTER DATABASE SET OWNER .. Patch Set 12: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10703 ) Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition pruning .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-5216: Make admission control queuing async

2018-06-14 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10715 to look at the new patch set (#2). Change subject: IMPALA-5216: Make admission control queuing async

[Impala-ASF-CR] [DOCS] Fixed a typo for missing 'not'

2018-06-14 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10657 ) Change subject: [DOCS] Fixed a typo for missing 'not' .. Patch Set 2: Hi Balazs, Could you review and approve this? Thanks! -- To

[Impala-ASF-CR] IMPALA-7050: [DOCS] Document the max serialized incremental stat size setting

2018-06-14 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10457 ) Change subject: IMPALA-7050: [DOCS] Document the max serialized incremental stat size setting .. Patch Set 5: Balazs, This one needs

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10654 ) Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-06-14 Thread Thomas Marshall (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10503 to look at the new patch set (#2). Change subject: IMPALA-6812: Fix flaky Kudu scan tests

[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10703 ) Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition pruning .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-06-14 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#19). ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. IMPALA-3307: Add support for IANA time-zone db Impala currently uses

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-06-14 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 10: (3 comments)

[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-14 Thread Alex Rodoni (Code Review)
Hello Henry Robinson, Gabor Kaszab, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10703 to look at the new patch set (#4). Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10703 ) Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition pruning .. IMPALA-7165: [DOCS] Correct

[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10703 ) Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition pruning .. Patch Set 4: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-7115: set a default THREAD RESERVATION LIMIT value

2018-06-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10628 ) Change subject: IMPALA-7115: set a default THREAD_RESERVATION_LIMIT value .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7016: Implement ALTER DATABASE SET OWNER

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10471 ) Change subject: IMPALA-7016: Implement ALTER DATABASE SET OWNER .. Patch Set 12: Build started:

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. Patch Set 17: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6816: minimise calls to GetMinSubscriberTopicVersion()

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10705 ) Change subject: IMPALA-6816: minimise calls to GetMinSubscriberTopicVersion() .. IMPALA-6816: minimise calls to

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-14 Thread Mostafa Mokhtar (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10415 to look at the new patch set (#5). Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-7137. Support configuring Frontend to use LocalCatalog

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10629 ) Change subject: IMPALA-7137. Support configuring Frontend to use LocalCatalog .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-7135. Skeleton implementation of LocalCatalog

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10627 ) Change subject: IMPALA-7135. Skeleton implementation of LocalCatalog .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6942: Reword error message to be say "Failed" rather than "Cancelled"

2018-06-14 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10717 Change subject: IMPALA-6942: Reword error message to be say "Failed" rather than "Cancelled" .. IMPALA-6942: Reword error message to be

[Impala-ASF-CR] IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10630 ) Change subject: IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6942: Reword error message to be say "Failed" rather than "Cancelled"

2018-06-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10717 ) Change subject: IMPALA-6942: Reword error message to be say "Failed" rather than "Cancelled" .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"

2018-06-14 Thread Dan Hecht (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10717 to look at the new patch set (#2). Change subject: IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-06-14 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10421 to look at the new patch set (#8). Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send()

[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 ) Change subject: IMPALA-7128 (part 2): add an interface for data sources .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 ) Change subject: IMPALA-7128 (part 2): add an interface for data sources .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] [DOCS] Wording changes in DPP examples for clarity

2018-06-14 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10718 Change subject: [DOCS] Wording changes in DPP examples for clarity .. [DOCS] Wording changes in DPP examples for clarity Change-Id:

[Impala-ASF-CR] [DOCS] Wording changes in DPP examples for clarity

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10718 ) Change subject: [DOCS] Wording changes in DPP examples for clarity .. Patch Set 1: Build started:

[Impala-ASF-CR](2.x) IMPALA-5216: Make admission control queuing async

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10715 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] Optimize dependencies for Codegen

2018-06-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10688 ) Change subject: Optimize dependencies for Codegen .. Patch Set 1: Looks like the current way was done as a result of IMPALA-1896. Could

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-14 Thread Mostafa Mokhtar (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10415 to look at the new patch set (#6). Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-06-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 9: Code-Review+2 Fixed another

[Impala-ASF-CR] IMPALA-7141 (part 2). Extract interfaces for partition pruning without loading

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10631 ) Change subject: IMPALA-7141 (part 2). Extract interfaces for partition pruning without loading .. Patch Set 7: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-06-14 Thread Thomas Marshall (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10503 to look at the new patch set (#3). Change subject: IMPALA-6812: Fix flaky Kudu scan tests

[Impala-ASF-CR] IMPALA-7174: xfail test admission controller.test cancellation

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10719 ) Change subject: IMPALA-7174: xfail test_admission_controller.test_cancellation .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7174: xfail test admission controller.test cancellation

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10719 Change subject: IMPALA-7174: xfail test_admission_controller.test_cancellation .. IMPALA-7174: xfail

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 3: (1 comment) Thanks for doing this, seems like a really

[Impala-ASF-CR] IMPALA-7016: Implement ALTER DATABASE SET OWNER

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10471 ) Change subject: IMPALA-7016: Implement ALTER DATABASE SET OWNER .. Patch Set 12: Verified+1 -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-5216: Make admission control queuing async

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10715 ) Change subject: IMPALA-5216: Make admission control queuing async .. IMPALA-5216: Make admission control queuing async

[Impala-ASF-CR] IMPALA-7016: Implement ALTER DATABASE SET OWNER

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10471 ) Change subject: IMPALA-7016: Implement ALTER DATABASE SET OWNER .. IMPALA-7016: Implement ALTER DATABASE SET OWNER

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 5: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-7141 (part 1): clean up handling of default/dummy partition

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10711 ) Change subject: IMPALA-7141 (part 1): clean up handling of default/dummy partition .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"

2018-06-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10717 ) Change subject: IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled" .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] [DOCS] Wording changes in DPP examples for clarity

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10718 ) Change subject: [DOCS] Wording changes in DPP examples for clarity .. [DOCS] Wording changes in DPP examples for

[Impala-ASF-CR] IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10717 ) Change subject: IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled" .. Patch Set 3: Code-Review+2 --

[Impala-ASF-CR] [DOCS] Wording changes in DPP examples for clarity

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10718 ) Change subject: [DOCS] Wording changes in DPP examples for clarity .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10717 ) Change subject: IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled" .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6942: Reword error message to be say "Failed" rather than "Cancelled"

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10717 ) Change subject: IMPALA-6942: Reword error message to be say "Failed" rather than "Cancelled" .. Patch Set 1: Code-Review+2 I agree

[Impala-ASF-CR] IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc

2018-06-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10679 ) Change subject: IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc .. Patch Set 3: (7 comments)

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-7140 (part 2). Create skeleton for LocalFsTable

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10712 ) Change subject: IMPALA-7140 (part 2). Create skeleton for LocalFsTable .. Patch Set 2: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-3816, IMPALA-4065: Remove the indirection to TupleRowComparator::Compare()

2018-06-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10680 ) Change subject: IMPALA-3816, IMPALA-4065: Remove the indirection to TupleRowComparator::Compare() .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-06-14 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7174: fix test cancellation for RELEASE builds

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10722 Change subject: IMPALA-7174: fix test_cancellation for RELEASE builds .. IMPALA-7174: fix test_cancellation for RELEASE builds The

[Impala-ASF-CR] IMPALA-6305: Allow column definitions in ALTER VIEW

2018-06-14 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10720 ) Change subject: IMPALA-6305: Allow column definitions in ALTER VIEW .. Patch Set 2: (12 comments) Can also update the

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. Patch Set 4: I think this should be ok to merge whenever Vuk is

[Impala-ASF-CR] IMPALA-7111: avoid use of boost::split in CheckPluginEnabled

2018-06-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10709 ) Change subject: IMPALA-7111: avoid use of boost::split in CheckPluginEnabled .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7111: avoid use of boost::split in CheckPluginEnabled

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10709 ) Change subject: IMPALA-7111: avoid use of boost::split in CheckPluginEnabled .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10626 ) Change subject: IMPALA-7128 (part 2): add an interface for data sources .. IMPALA-7128 (part 2): add an interface for

[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 ) Change subject: IMPALA-7128 (part 2): add an interface for data sources .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7174: fix test cancellation for RELEASE builds

2018-06-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10722 ) Change subject: IMPALA-7174: fix test_cancellation for RELEASE builds .. Patch Set 2: Code-Review+2 Sounds fine. And I'll be sure not to

[Impala-ASF-CR] IMPALA-7174: fix test cancellation for RELEASE builds

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10722 ) Change subject: IMPALA-7174: fix test_cancellation for RELEASE builds .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-7174: fix test cancellation for RELEASE builds

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10722 ) Change subject: IMPALA-7174: fix test_cancellation for RELEASE builds .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7174: fix test cancellation for RELEASE builds

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10722 ) Change subject: IMPALA-7174: fix test_cancellation for RELEASE builds .. Patch Set 3: Hit HBase flake in data log -- To view, visit

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-06-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 3: Code-Review-1 (1 comment)

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-06-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. Patch Set 8: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7135. Skeleton implementation of LocalCatalog

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10627 ) Change subject: IMPALA-7135. Skeleton implementation of LocalCatalog .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7135. Skeleton implementation of LocalCatalog

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10627 ) Change subject: IMPALA-7135. Skeleton implementation of LocalCatalog .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. Patch Set 17: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. IMPALA-5552: Add support for authorized proxy groups

[Impala-ASF-CR] IMPALA-5604: document DISABLE CODEGEN ROWS THRESHOLD

2018-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10727 Change subject: IMPALA-5604: document DISABLE_CODEGEN_ROWS_THRESHOLD .. IMPALA-5604: document DISABLE_CODEGEN_ROWS_THRESHOLD Also fix

[Impala-ASF-CR] IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10717 ) Change subject: IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled" .. IMPALA-6942: Reword

[Impala-ASF-CR] IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10717 ) Change subject: IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled" .. Patch Set 3: Verified+1 -- To

  1   2   >