[Impala-ASF-CR] IMPALA-6591: Fix test ssl flaky test

2018-12-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12047 ) Change subject: IMPALA-6591: Fix test_ssl flaky test .. Patch Set 4: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-12-10 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11881 to look at the new patch set (#10). Change subject: IMPALA-7807: Analysis test fixture

[Impala-ASF-CR] IMPALA-7945: Fix test hdfs timeout.py on python 2.6

2018-12-10 Thread Joe McDonnell (Code Review)
Hello Bharath Vissapragada, Laszlo Gaal, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12059 to look at the new patch set (#2). Change subject: IMPALA-7945: Fix test_hdfs_timeout.py on python 2.6

[Impala-ASF-CR] IMPALA-7945: Fix test hdfs timeout.py on python 2.6

2018-12-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12059 ) Change subject: IMPALA-7945: Fix test_hdfs_timeout.py on python 2.6 .. Patch Set 2: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-7939: Fix issue where CTE is categorized as DML statement

2018-12-10 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/12052 ) Change subject: IMPALA-7939: Fix issue where CTE is categorized as DML statement .. IMPALA-7939: Fix issue where CTE is categorized as

[Impala-ASF-CR] IMPALA-6591: Fix test ssl flaky test

2018-12-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12047 ) Change subject: IMPALA-6591: Fix test_ssl flaky test .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-7914: Base class for statement-like AST nodes

2018-12-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12018 ) Change subject: IMPALA-7914: Base class for statement-like AST nodes .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7914: Base class for statement-like AST nodes

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12018 ) Change subject: IMPALA-7914: Base class for statement-like AST nodes .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-7939: Fix issue where CTE is categorized as DML statement

2018-12-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12052 ) Change subject: IMPALA-7939: Fix issue where CTE is categorized as DML statement .. Patch Set 6: I think ultimately we should either

[Impala-ASF-CR] IMPALA-7939: Fix issue where CTE is categorized as DML statement

2018-12-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12052 ) Change subject: IMPALA-7939: Fix issue where CTE is categorized as DML statement .. Patch Set 6: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-7945: Fix test hdfs timeout.py on python 2.6

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12059 ) Change subject: IMPALA-7945: Fix test_hdfs_timeout.py on python 2.6 .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7914: Base class for statement-like AST nodes

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12018 ) Change subject: IMPALA-7914: Base class for statement-like AST nodes .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7926: Fix flakiness in test reconnect

2018-12-10 Thread Thomas Marshall (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12045 to look at the new patch set (#2). Change subject: IMPALA-7926: Fix flakiness in test_reconnect .. IMPALA-7926: Fix

[Impala-ASF-CR] IMPALA-6591: Fix test ssl flaky test

2018-12-10 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12047 ) Change subject: IMPALA-6591: Fix test_ssl flaky test .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11881 ) Change subject: IMPALA-7807: Analysis test fixture .. Patch Set 10: (2 comments)

[Impala-ASF-CR] IMPALA-7939: Fix issue where CTE is categorized as DML statement

2018-12-10 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12052 ) Change subject: IMPALA-7939: Fix issue where CTE is categorized as DML statement .. Patch Set 7: Code-Review+1 (2 comments) Carry

[Impala-ASF-CR] IMPALA-7926: Fix flakiness in test reconnect

2018-12-10 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12045 ) Change subject: IMPALA-7926: Fix flakiness in test_reconnect .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-7913: Separate ccache TEMP directories by Docker container

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12030 ) Change subject: IMPALA-7913: Separate ccache TEMP directories by Docker container .. IMPALA-7913: Separate ccache

[Impala-ASF-CR] IMPALA-7913: Separate ccache TEMP directories by Docker container

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12030 ) Change subject: IMPALA-7913: Separate ccache TEMP directories by Docker container .. Patch Set 2: Verified+1 -- To view,

[Impala-ASF-CR] Build parquet-reader earlier in test-with-docker

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12025 ) Change subject: Build parquet-reader earlier in test-with-docker .. Build parquet-reader earlier in test-with-docker

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-12-10 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11881 ) Change subject: IMPALA-7807: Analysis test fixture .. Patch Set 9: Fixed the build issue; it resulted from an earlier fix in response

[Impala-ASF-CR] IMPALA-6591: Fix test ssl flaky test

2018-12-10 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12047 ) Change subject: IMPALA-6591: Fix test_ssl flaky test .. IMPALA-6591: Fix test_ssl flaky test test_ssl has a logic that waits for the

[Impala-ASF-CR] IMPALA-7945: Fix test hdfs timeout.py on python 2.6

2018-12-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12059 ) Change subject: IMPALA-7945: Fix test_hdfs_timeout.py on python 2.6 .. Patch Set 1: > On a related note, wondering why >

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11881 ) Change subject: IMPALA-7807: Analysis test fixture .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-7939: Fix issue where CTE is categorized as DML statement

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12052 ) Change subject: IMPALA-7939: Fix issue where CTE is categorized as DML statement .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-7945: Fix test hdfs timeout.py on python 2.6

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12059 ) Change subject: IMPALA-7945: Fix test_hdfs_timeout.py on python 2.6 .. Patch Set 2: Build Successful

[Impala-ASF-CR] Build parquet-reader earlier in test-with-docker

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12025 ) Change subject: Build parquet-reader earlier in test-with-docker .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6591: Fix test ssl flaky test

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12047 ) Change subject: IMPALA-6591: Fix test_ssl flaky test .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7945: Fix test hdfs timeout.py on python 2.6

2018-12-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12059 ) Change subject: IMPALA-7945: Fix test_hdfs_timeout.py on python 2.6 .. Patch Set 1: Phil, does it help to use a more powerful

[Impala-ASF-CR] IMPALA-7926: Fix flakiness in test reconnect

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12045 ) Change subject: IMPALA-7926: Fix flakiness in test_reconnect .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-7946: Use original timeout in THREAD POOL TASK TIMED OUT message

2018-12-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12062 Change subject: IMPALA-7946: Use original timeout in THREAD_POOL_TASK_TIMED_OUT message .. IMPALA-7946: Use original timeout in

[Impala-ASF-CR] IMPALA-7946: Use original timeout in THREAD POOL TASK TIMED OUT message

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12062 ) Change subject: IMPALA-7946: Use original timeout in THREAD_POOL_TASK_TIMED_OUT message .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2018-12-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-7945: Fix test hdfs timeout.py on python 2.6

2018-12-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12059 ) Change subject: IMPALA-7945: Fix test_hdfs_timeout.py on python 2.6 .. IMPALA-7945: Fix test_hdfs_timeout.py on python 2.6

[Impala-ASF-CR] IMPALA-7907: Fix ScalarFunction.toSql()

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12014 ) Change subject: IMPALA-7907: Fix ScalarFunction.toSql() .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7907: Fix ScalarFunction.toSql()

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12014 ) Change subject: IMPALA-7907: Fix ScalarFunction.toSql() .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-5200: Count child time for parent's total time

2018-12-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11791 ) Change subject: IMPALA-5200: Count child time for parent's total time .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7945: Fix test hdfs timeout.py on python 2.6

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12059 ) Change subject: IMPALA-7945: Fix test_hdfs_timeout.py on python 2.6 .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7914: Base class for statement-like AST nodes

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12018 ) Change subject: IMPALA-7914: Base class for statement-like AST nodes .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-7907: Fix ScalarFunction.toSql()

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12014 ) Change subject: IMPALA-7907: Fix ScalarFunction.toSql() .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7914: Base class for statement-like AST nodes

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12018 ) Change subject: IMPALA-7914: Base class for statement-like AST nodes .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7907: Fix ScalarFunction.toSql()

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12014 ) Change subject: IMPALA-7907: Fix ScalarFunction.toSql() .. IMPALA-7907: Fix ScalarFunction.toSql() Each AST statement

[Impala-ASF-CR] IMPALA-7914: Base class for statement-like AST nodes

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12018 ) Change subject: IMPALA-7914: Base class for statement-like AST nodes .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-7212: Remove dead code data-stream-mgr.cc

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12064 ) Change subject: IMPALA-7212: Remove dead code data-stream-mgr.cc .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7212: Remove dead code data-stream-mgr.cc

2018-12-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12064 ) Change subject: IMPALA-7212: Remove dead code data-stream-mgr.cc .. Patch Set 1: Code-Review+2 Thanks! -- To view, visit

[Impala-ASF-CR] IMPALA-7212: Remove dead code data-stream-mgr.cc

2018-12-10 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12064 Change subject: IMPALA-7212: Remove dead code data-stream-mgr.cc .. IMPALA-7212: Remove dead code data-stream-mgr.cc Dead code which was

[Impala-ASF-CR] IMPALA-7853: Add support to read int64 NANO timestamps from Parquet

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11984 ) Change subject: IMPALA-7853: Add support to read int64 NANO timestamps from Parquet .. IMPALA-7853: Add support to

[Impala-ASF-CR] IMPALA-7853: Add support to read int64 NANO timestamps from Parquet

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11984 ) Change subject: IMPALA-7853: Add support to read int64 NANO timestamps from Parquet .. Patch Set 7: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-7939: Fix issue where CTE is categorized as DML statement

2018-12-10 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12052 ) Change subject: IMPALA-7939: Fix issue where CTE is categorized as DML statement .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-7939: Fix issue where CTE is categorized as DML statement

2018-12-10 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/12052 ) Change subject: IMPALA-7939: Fix issue where CTE is categorized as DML statement .. IMPALA-7939: Fix issue where CTE is categorized as

[Impala-ASF-CR] IMPALA-7939: Fix issue where CTE is categorized as DML statement

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12052 ) Change subject: IMPALA-7939: Fix issue where CTE is categorized as DML statement .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-7903: Fix DCHECK failure in RawValue::PrintValue()

2018-12-10 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12021 ) Change subject: IMPALA-7903: Fix DCHECK failure in RawValue::PrintValue() .. Patch Set 5: Thanks Tim for kicking off the GVO! About

[Impala-ASF-CR] IMPALA-7853: Add support to read int64 NANO timestamps from Parquet

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11984 ) Change subject: IMPALA-7853: Add support to read int64 NANO timestamps from Parquet .. Patch Set 7: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-7853: Add support to read int64 NANO timestamps from Parquet

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11984 ) Change subject: IMPALA-7853: Add support to read int64 NANO timestamps from Parquet .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-7913: Separate ccache TEMP directories by Docker container

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12030 ) Change subject: IMPALA-7913: Separate ccache TEMP directories by Docker container .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7913: Separate ccache TEMP directories by Docker container

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12030 ) Change subject: IMPALA-7913: Separate ccache TEMP directories by Docker container .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] Build parquet-reader earlier in test-with-docker

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12025 ) Change subject: Build parquet-reader earlier in test-with-docker .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Build parquet-reader earlier in test-with-docker

2018-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12025 ) Change subject: Build parquet-reader earlier in test-with-docker .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-6591: Fix test ssl flaky test

2018-12-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12047 ) Change subject: IMPALA-6591: Fix test_ssl flaky test .. Patch Set 3: (1 comment)