[Impala-ASF-CR] IMPALA-9943, IMPALA-4974: INTERSECT and EXCEPT DISTINCT Support.

2020-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16123 ) Change subject: IMPALA-9943, IMPALA-4974: INTERSECT and EXCEPT DISTINCT Support. .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-9964: Fill file descriptors properly in setFileMetadataFromFS

2020-07-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16206 ) Change subject: IMPALA-9964: Fill file descriptors properly in setFileMetadataFromFS .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-9964: Fill file descriptors properly in setFileMetadataFromFS

2020-07-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16206 ) Change subject: IMPALA-9964: Fill file descriptors properly in setFileMetadataFromFS .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-9741: Support querying Iceberg table by impala

2020-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16143 ) Change subject: IMPALA-9741: Support querying Iceberg table by impala .. Patch Set 13: Build Successful

[Impala-ASF-CR] IMPALA-9882: Import KLL functionality from Apache DataSketches

2020-07-17 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16196 ) Change subject: IMPALA-9882: Import KLL functionality from Apache DataSketches .. Patch Set 3: In PS3 I've put this patch on top of

[Impala-ASF-CR] IMPALA-7001: Fix Privilege inconsistency between SHOW TABLES and SHOW FUNCTIONS

2020-07-17 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16199 ) Change subject: IMPALA-7001: Fix Privilege inconsistency between SHOW TABLES and SHOW FUNCTIONS .. Patch Set 6: (2 comments) The

[Impala-ASF-CR] IMPALA-9741: Support querying Iceberg table by impala

2020-07-17 Thread wangsheng (Code Review)
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16143 ) Change subject: IMPALA-9741: Support querying Iceberg table by impala .. Patch Set 13: (8 comments) Hi Zoltan, thanks for your review

[Impala-ASF-CR] IMPALA-9882: Import KLL functionality from Apache DataSketches

2020-07-17 Thread Gabor Kaszab (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16196 to look at the new patch set (#3). Change subject: IMPALA-9882: Import KLL functionality from Apache DataSketches

[Impala-ASF-CR] IMPALA-9882: Import KLL functionality from Apache DataSketches

2020-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16196 ) Change subject: IMPALA-9882: Import KLL functionality from Apache DataSketches .. Patch Set 3: Build Failed

[Impala-ASF-CR] IMPALA-9741: Support quering Icebreg table by impala

2020-07-17 Thread wangsheng (Code Review)
wangsheng has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/16143 ) Change subject: IMPALA-9741: Support quering Icebreg table by impala .. IMPALA-9741: Support quering Icebreg table by impala This patch

[Impala-ASF-CR] IMPALA-9741: Support quering Icebreg table by impala

2020-07-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16143 ) Change subject: IMPALA-9741: Support quering Icebreg table by impala .. Patch Set 11: (9 comments) Nice work! Only found some

[Impala-ASF-CR] IMPALA-7655: Implement codegen for conditional functions (if, isnull, coalesce)

2020-07-17 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16208 ) Change subject: IMPALA-7655: Implement codegen for conditional functions (if, isnull, coalesce) .. Patch Set 1: We have a number of

[Impala-ASF-CR] IMPALA-7655: Implement codegen for conditional functions (if, isnull, coalesce)

2020-07-17 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16208 ) Change subject: IMPALA-7655: Implement codegen for conditional functions (if, isnull, coalesce) .. Patch Set 1: (3 comments) I'll

[Impala-ASF-CR] IMPALA-9741: Support querying Iceberg table by impala

2020-07-17 Thread wangsheng (Code Review)
wangsheng has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/16143 ) Change subject: IMPALA-9741: Support querying Iceberg table by impala .. IMPALA-9741: Support querying Iceberg table by impala This patch

[Impala-ASF-CR] IMPALA-9741: Support quering Icebreg table by impala

2020-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16143 ) Change subject: IMPALA-9741: Support quering Icebreg table by impala .. Patch Set 12: Build Successful

[Impala-ASF-CR] IMPALA-7001: Fix Privilege inconsistency between SHOW TABLES and SHOW FUNCTIONS

2020-07-17 Thread Adam Tamas (Code Review)
Adam Tamas has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/16199 ) Change subject: IMPALA-7001: Fix Privilege inconsistency between SHOW TABLES and SHOW FUNCTIONS .. IMPALA-7001: Fix Privilege

[Impala-ASF-CR] IMPALA-7001: Fix Privilege inconsistency between SHOW TABLES and SHOW FUNCTIONS

2020-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16199 ) Change subject: IMPALA-7001: Fix Privilege inconsistency between SHOW TABLES and SHOW FUNCTIONS .. Patch Set 7: Build

[Impala-ASF-CR](asf-site) Add link to slack channel on community

2020-07-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16024 ) Change subject: Add link to slack channel on community .. Patch Set 1: Could we just use the-asf.slack.com and create an #impala channel?

[Impala-ASF-CR] IMPALA-7001: Fix Privilege inconsistency between SHOW TABLES and SHOW FUNCTIONS

2020-07-17 Thread Adam Tamas (Code Review)
Adam Tamas has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/16199 ) Change subject: IMPALA-7001: Fix Privilege inconsistency between SHOW TABLES and SHOW FUNCTIONS .. IMPALA-7001: Fix Privilege

[Impala-ASF-CR] IMPALA-7001: Fix Privilege inconsistency between SHOW TABLES and SHOW FUNCTIONS

2020-07-17 Thread Adam Tamas (Code Review)
Adam Tamas has posted comments on this change. ( http://gerrit.cloudera.org:8080/16199 ) Change subject: IMPALA-7001: Fix Privilege inconsistency between SHOW TABLES and SHOW FUNCTIONS .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-7001: Fix Privilege inconsistency between SHOW TABLES and SHOW FUNCTIONS

2020-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16199 ) Change subject: IMPALA-7001: Fix Privilege inconsistency between SHOW TABLES and SHOW FUNCTIONS .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-7001: Fix Privilege inconsistency between SHOW TABLES and SHOW FUNCTIONS

2020-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16199 ) Change subject: IMPALA-7001: Fix Privilege inconsistency between SHOW TABLES and SHOW FUNCTIONS .. Patch Set 8: Build

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-07-17 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 17: (11 comments)

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-07-17 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 17: Code-Review+1 (10 comments)

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 20: Build Successful

[Impala-ASF-CR] IMPALA-9741: Support querying Iceberg table by impala

2020-07-17 Thread wangsheng (Code Review)
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16143 ) Change subject: IMPALA-9741: Support querying Iceberg table by impala .. Patch Set 13: Test passed, and iceberg test worked in

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-07-17 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#20). ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. IMPALA-9744: Treat corrupt table stats as missing

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 20: (3 comments)

[Impala-ASF-CR] IMPALA-9964: Fill file descriptors properly in setFileMetadataFromFS

2020-07-17 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16206 ) Change subject: IMPALA-9964: Fill file descriptors properly in setFileMetadataFromFS .. Patch Set 4: (7 comments)

[Impala-ASF-CR] IMPALA-9903: Reduce Kudu openTable calls per query

2020-07-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16120 ) Change subject: IMPALA-9903: Reduce Kudu openTable calls per query .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16123 ) Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT] .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-17 Thread Shant Hovsepian (Code Review)
Hello David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16123 to look at the new patch set (#7). Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16123 ) Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT] .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-17 Thread Shant Hovsepian (Code Review)
Hello David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16123 to look at the new patch set (#8). Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16123 ) Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT] .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-07-17 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#22). ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. IMPALA-9744: Treat corrupt table stats as missing

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-17 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16123 ) Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT] .. Patch Set 8: (8 comments) > Patch Set 5: > > (6 comments)

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16123 ) Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT] .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 22: Build Successful