[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan (WIP)

2018-03-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9697 ) Change subject: IMPALA-6670: refresh lib-cache entries from plan (WIP) .. Patch Set 5: (8 comments) I'm not very familiar with the BE

[Impala-ASF-CR] IMPALA-6643: Add REFRESH fine-grained privilege

2018-03-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH fine-grained privilege .. Patch Set 19: Change looks good, but I'm intentionally holding off from

[Impala-ASF-CR] IMPALA-6643: Add REFRESH fine-grained privilege

2018-03-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH fine-grained privilege .. Patch Set 19: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6643: Add REFRESH fine-grained privilege

2018-03-19 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#19). ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH fine-grained privilege .. IMPALA-6643: Add REFRESH fine-grained privilege Before this patch,

[Impala-ASF-CR] IMPALA-6643: Add REFRESH fine-grained privilege

2018-03-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH fine-grained privilege .. Patch Set 18: (3 comments) Good to go after this

[Impala-ASF-CR] IMPALA-6643: Add REFRESH fine-grained privilege

2018-03-19 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#18). ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH fine-grained privilege .. IMPALA-6643: Add REFRESH fine-grained privilege Before this patch,

[Impala-ASF-CR] IMPALA-6643: Add REFRESH fine-grained privilege

2018-03-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH fine-grained privilege .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-6610: Improve LDAP auth fail warning message in impala-shell

2018-03-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 ) Change subject: IMPALA-6610: Improve LDAP auth fail warning message in impala-shell .. Patch Set 12: Code-Review+2 Rebase, carry +2.

[Impala-ASF-CR] IMPALA-6610: Improve LDAP auth fail warning message in impala-shell

2018-03-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 ) Change subject: IMPALA-6610: Improve LDAP auth fail warning message in impala-shell .. Patch Set 12: Build started:

[Impala-ASF-CR] IMPALA-6610: Improve LDAP auth fail warning message in impala-shell

2018-03-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 ) Change subject: IMPALA-6610: Improve LDAP auth fail warning message in impala-shell .. Patch Set 11: Code-Review+2 Thanks for your

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan (WIP)

2018-03-19 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9697 ) Change subject: IMPALA-6670: refresh lib-cache entries from plan (WIP) .. Patch Set 4: latest update: - fix several test cases found

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan (WIP)

2018-03-19 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/9697 ) Change subject: IMPALA-6670: refresh lib-cache entries from plan (WIP) .. IMPALA-6670: refresh lib-cache entries from plan (WIP) When an

[Impala-ASF-CR] IMPALA-6610: Improve LDAP auth fail warning message in impala-shell

2018-03-19 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 ) Change subject: IMPALA-6610: Improve LDAP auth fail warning message in impala-shell .. Patch Set 11: Thanks. I deleted the judgment of

[Impala-ASF-CR] IMPALA-6610: Improve LDAP auth fail warning message in impala-shell

2018-03-19 Thread Donghui Xu (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Sailesh Mukil, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9506 to look at the new patch set (#11). Change subject: IMPALA-6610: Improve LDAP auth fail warning message in impala-shell

[Impala-ASF-CR] IMPALA-6610: Improve LDAP auth fail warning message in impala-shell

2018-03-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 ) Change subject: IMPALA-6610: Improve LDAP auth fail warning message in impala-shell .. Patch Set 10: > Patch Set 10: > > Only the

[Impala-ASF-CR] IMPALA-6610: Improve LDAP auth fail warning message in impala-shell

2018-03-19 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 ) Change subject: IMPALA-6610: Improve LDAP auth fail warning message in impala-shell .. Patch Set 10: Only the echo command is detected

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6643: Add REFRESH fine-grained privilege

2018-03-19 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH fine-grained privilege .. Patch Set 17: (2 comments)

[Impala-ASF-CR] IMPALA-6643: Add REFRESH fine-grained privilege

2018-03-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH fine-grained privilege .. Patch Set 15: (3 comments)

[Impala-ASF-CR] IMPALA-6643: Add REFRESH fine-grained privilege

2018-03-19 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#17). ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH fine-grained privilege .. IMPALA-6643: Add REFRESH fine-grained privilege Before this patch,

[Impala-ASF-CR] IMPALA-6338: Fix flaky test profile fragment instances

2018-03-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9718 ) Change subject: IMPALA-6338: Fix flaky test_profile_fragment_instances .. Patch Set 1: (10 comments) Had some comments on the overall

[Impala-ASF-CR] IMPALA-6587: free buffers before ScanRange::Cancel() returns

2018-03-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9680 ) Change subject: IMPALA-6587: free buffers before ScanRange::Cancel() returns .. Patch Set 8: (8 comments)

[Impala-ASF-CR] IMPALA-4277: Support multiple versions of Hadoop ecosystem

2018-03-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9716 Change subject: IMPALA-4277: Support multiple versions of Hadoop ecosystem .. IMPALA-4277: Support multiple versions of Hadoop

[Impala-ASF-CR] IMPALA-6394: Restart HDFS only when no replication progress is made

2018-03-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9698 ) Change subject: IMPALA-6394: Restart HDFS only when no replication progress is made .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6643: Add REFRESH fine-grained privilege

2018-03-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH fine-grained privilege .. Patch Set 15: (10 comments)

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-6338: Fix flaky test profile fragment instances

2018-03-19 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9718 Change subject: IMPALA-6338: Fix flaky test_profile_fragment_instances .. IMPALA-6338: Fix flaky

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6587: free buffers before ScanRange::Cancel() returns

2018-03-19 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Impala Public Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9680 to look at the new patch set (#8). Change subject: IMPALA-6587: free buffers before ScanRange::Cancel() returns

[Impala-ASF-CR] IMPALA-6587: free buffers before ScanRange::Cancel() returns

2018-03-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9680 ) Change subject: IMPALA-6587: free buffers before ScanRange::Cancel() returns .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-6587: free buffers before ScanRange::Cancel() returns

2018-03-19 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Impala Public Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9680 to look at the new patch set (#7). Change subject: IMPALA-6587: free buffers before ScanRange::Cancel() returns

[Impala-ASF-CR] IMPALA-6394: Restart HDFS only when no replication progress is made

2018-03-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9698 ) Change subject: IMPALA-6394: Restart HDFS only when no replication progress is made .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6394: Restart HDFS only when no replication progress is made

2018-03-19 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9698 ) Change subject: IMPALA-6394: Restart HDFS only when no replication progress is made .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6230, IMPALA-6468: Fix the output type of round() and related fns

2018-03-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9346 ) Change subject: IMPALA-6230, IMPALA-6468: Fix the output type of round() and related fns .. Patch Set 2: (2 comments) I'm pretty happy

[native-toolchain-CR](cdh5.x) Bump Kudu version to cdh5.15-impala-toolchain

2018-03-19 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9700 ) Change subject: Bump Kudu version to cdh5.15-impala-toolchain .. Bump Kudu version to cdh5.15-impala-toolchain

[native-toolchain-CR](cdh5.x) Bump Kudu version to cdh5.15-impala-toolchain

2018-03-19 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9700 ) Change subject: Bump Kudu version to cdh5.15-impala-toolchain .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6621: Improve set lookup performance for in-predicate evaluation

2018-03-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9570 ) Change subject: IMPALA-6621: Improve set lookup performance for in-predicate evaluation .. Patch Set 3: Code-Review+2 -- To view, visit

[native-toolchain-CR](cdh5.x) Bump Kudu version to cdh5.15-impala-toolchain

2018-03-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9700 ) Change subject: Bump Kudu version to cdh5.15-impala-toolchain .. Patch Set 1: Code-Review+2 -- To view, visit

[native-toolchain-CR](cdh5.x) Bump Kudu version to cdh5.15-impala-toolchain

2018-03-19 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9700 ) Change subject: Bump Kudu version to cdh5.15-impala-toolchain .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-19 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9584 to look at the new patch set (#2). Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. IMPALA-5980:

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-19 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-6621: Improve set lookup performance for in-predicate evaluation

2018-03-19 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9570 ) Change subject: IMPALA-6621: Improve set lookup performance for in-predicate evaluation .. Patch Set 3: Code-Review+1 Carrying over

[Impala-ASF-CR] IMPALA-6643: Add REFRESH fine-grained privilege

2018-03-19 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH fine-grained privilege .. IMPALA-6643: Add REFRESH fine-grained privilege Before this patch,

[Impala-ASF-CR] IMPALA-6621: Improve set lookup performance for in-predicate evaluation

2018-03-19 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9570 to look at the new patch set (#3). Change subject: IMPALA-6621: Improve set lookup performance for in-predicate evaluation

[Impala-ASF-CR] IMPALA-6621: Improve set lookup performance for in-predicate evaluation

2018-03-19 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9570 ) Change subject: IMPALA-6621: Improve set lookup performance for in-predicate evaluation .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6610: Improve LDAP auth fail warning message in impala-shell

2018-03-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 ) Change subject: IMPALA-6610: Improve LDAP auth fail warning message in impala-shell .. Patch Set 10: > Patch Set 10: > >

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-03-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9403 ) Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-03-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9403 ) Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-03-19 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Gabor Kaszab, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9403 to look at the new patch set (#8). Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

[Impala-ASF-CR] IMPALA-6610: Improve LDAP auth fail warning message in impala-shell

2018-03-19 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 ) Change subject: IMPALA-6610: Improve LDAP auth fail warning message in impala-shell .. Patch Set 10: Hello,Bharath. Please CR+1. Need

[Impala-ASF-CR] IMPALA-6610: Improve LDAP auth fail warning message in impala-shell

2018-03-19 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 ) Change subject: IMPALA-6610: Improve LDAP auth fail warning message in impala-shell .. Patch Set 10: (4 comments) Thanks for your

[Impala-ASF-CR] IMPALA-6610: Improve LDAP auth fail warning message in impala-shell

2018-03-19 Thread Donghui Xu (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9506 to look at the new patch set (#10). Change subject: IMPALA-6610: Improve LDAP auth fail warning message in impala-shell

[Impala-ASF-CR] IMPALA-6610: Add inspection and warning for LDAP password in Impala shell when authentication fails

2018-03-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 ) Change subject: IMPALA-6610: Add inspection and warning for LDAP password in Impala shell when authentication fails .. Patch

[Impala-ASF-CR] IMPALA-6691: KRPC w/ kerberos fails on SLES11

2018-03-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9696 ) Change subject: IMPALA-6691: KRPC w/ kerberos fails on SLES11 .. Patch Set 1: > Patch Set 1: > > (1 comment) I spent about 2 days