[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-15 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR](2.x) IMPALA-7033/IMPALA-7030: Backout suspected change leading to crash

2018-05-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10423 ) Change subject: IMPALA-7033/IMPALA-7030: Backout suspected change leading to crash .. Patch Set 1: Code-Review+2 (1 comment) Fixed trivi

[Impala-ASF-CR](2.x) IMPALA-7033/IMPALA-7030: Backout suspected change leading to crash

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10423 ) Change subject: IMPALA-7033/IMPALA-7030: Backout suspected change leading to crash .. Patch Set 1: Build started: https://jen

[Impala-ASF-CR](2.x) IMPALA-7033/IMPALA-7030: Backout suspected change leading to crash

2018-05-15 Thread Dan Hecht (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10423 to review the following change. Change subject: IMPALA-7033/IMPALA-7030: Backout suspected change leading to crash .

[Impala-ASF-CR] IMPALA-7033/IMPALA-7030: Backout suspected change leading to crash

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10412 ) Change subject: IMPALA-7033/IMPALA-7030: Backout suspected change leading to crash .. Patch Set 2: This change did not cherry

[Impala-ASF-CR] IMPALA-6802 (part 3): Clean up authorization tests

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10358 ) Change subject: IMPALA-6802 (part 3): Clean up authorization tests .. IMPALA-6802 (part 3): Clean up authorization test

[Impala-ASF-CR] IMPALA-6802 (part 3): Clean up authorization tests

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10358 ) Change subject: IMPALA-6802 (part 3): Clean up authorization tests .. Patch Set 5: Verified+1 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-7025: ignore resources in some planner test

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10410 ) Change subject: IMPALA-7025: ignore resources in some planner test .. IMPALA-7025: ignore resources in some planner tes

[Impala-ASF-CR] IMPALA-7025: ignore resources in some planner test

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10410 ) Change subject: IMPALA-7025: ignore resources in some planner test .. Patch Set 5: Verified+1 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded()

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10364 ) Change subject: IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded() .. Patch Set 2: Verified+1 -- To view, visit ht

[Impala-ASF-CR] IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded()

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10364 ) Change subject: IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded() .. IMPALA-6997: Avoid redundant dumping i

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-05-15 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10421 Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStream

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

2018-05-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10409 ) Change subject: IMPALA-7032: Disable codegen for CHAR type null literals .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

2018-05-15 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10409 ) Change subject: IMPALA-7032: Disable codegen for CHAR type null literals .. IMPALA-7032: Disable codegen for CHAR type null liter

[Impala-ASF-CR] IMPALA-7003: Deflake erasure coding data loading

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10362 ) Change subject: IMPALA-7003: Deflake erasure coding data loading .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-7003: Deflake erasure coding data loading

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10362 ) Change subject: IMPALA-7003: Deflake erasure coding data loading .. IMPALA-7003: Deflake erasure coding data loading E

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

2018-05-15 Thread Lars Volker (Code Review)
Lars Volker has removed a vote on this change. Change subject: IMPALA-7032: Disable codegen for CHAR type null literals .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/10409 To u

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

2018-05-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10409 ) Change subject: IMPALA-7032: Disable codegen for CHAR type null literals .. Patch Set 2: This was a false positive from the recent Jenki

[Impala-ASF-CR] IMPALA-7022: TestQueries.test subquery: Subquery must not return more than one row

2018-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10407 ) Change subject: IMPALA-7022: TestQueries.test_subquery: Subquery must not return more than one row .. IMPALA-7022: TestQueries

[Impala-ASF-CR] IMPALA-7022: TestQueries.test subquery: Subquery must not return more than one row

2018-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has removed a vote on this change. Change subject: IMPALA-7022: TestQueries.test_subquery: Subquery must not return more than one row .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-7022: TestQueries.test subquery: Subquery must not return more than one row

2018-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10407 ) Change subject: IMPALA-7022: TestQueries.test_subquery: Subquery must not return more than one row .. Patch Set 1: Verified+1 This hi

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Spilling sort optimisations .. Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/9943/8/be/sr

[Impala-ASF-CR] IMPALA-6802 (part 3): Clean up authorization tests

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10358 ) Change subject: IMPALA-6802 (part 3): Clean up authorization tests .. Patch Set 5: Build started: https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-6802 (part 3): Clean up authorization tests

2018-05-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10358 ) Change subject: IMPALA-6802 (part 3): Clean up authorization tests .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-15 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-7025: ignore resources in some planner test

2018-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10410 ) Change subject: IMPALA-7025: ignore resources in some planner test .. Patch Set 5: Code-Review+2 carry -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-7025: ignore resources in some planner test

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10410 ) Change subject: IMPALA-7025: ignore resources in some planner test .. Patch Set 5: Build started: https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-7025: ignore resources in some planner test

2018-05-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10410 ) Change subject: IMPALA-7025: ignore resources in some planner test .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-15 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 8: (3 comments) Just wanted to get the replay regardi

[Impala-ASF-CR] IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded()

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10364 ) Change subject: IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded() .. Patch Set 2: Build started: https://jenkins.i

[Impala-ASF-CR] IMPALA-7025: ignore resources in some planner test

2018-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10410 ) Change subject: IMPALA-7025: ignore resources in some planner test .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-7025: ignore resources in some planner test

2018-05-15 Thread Tim Armstrong (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10410 to look at the new patch set (#4). Change subject: IMPALA-7025: ignore resources in some planner test .. IMPALA-7025:

[Impala-ASF-CR] IMPALA-7025: ignore resources in some planner test

2018-05-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10410 ) Change subject: IMPALA-7025: ignore resources in some planner test .. Patch Set 3: (3 comments) Looks good. Minor additional cleanup woul

[Impala-ASF-CR] IMPALA-7033/IMPALA-7030: Backout suspected change leading to crash

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10412 ) Change subject: IMPALA-7033/IMPALA-7030: Backout suspected change leading to crash .. IMPALA-7033/IMPALA-7030: Backout

[Impala-ASF-CR] IMPALA-7033/IMPALA-7030: Backout suspected change leading to crash

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10412 ) Change subject: IMPALA-7033/IMPALA-7030: Backout suspected change leading to crash .. Patch Set 1: Verified+1 -- To view, vi

[Impala-ASF-CR] IMPALA-6645: Enable disk spill encryption by default

2018-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10345 ) Change subject: IMPALA-6645: Enable disk spill encryption by default .. IMPALA-6645: Enable disk spill encryption by default P

[Impala-ASF-CR] IMPALA-6645: Enable disk spill encryption by default

2018-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has removed a vote on this change. Change subject: IMPALA-6645: Enable disk spill encryption by default .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/10345 To uns

[Impala-ASF-CR] IMPALA-6645: Enable disk spill encryption by default

2018-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10345 ) Change subject: IMPALA-6645: Enable disk spill encryption by default .. Patch Set 8: Verified+1 False positive from the JUnit test pub

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10409 ) Change subject: IMPALA-7032: Disable codegen for CHAR type null literals .. Patch Set 2: Verified-1 Build failed: https://jenk

[Impala-ASF-CR] IMPALA-7022: TestQueries.test subquery: Subquery must not return more than one row

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10407 ) Change subject: IMPALA-7022: TestQueries.test_subquery: Subquery must not return more than one row .. Patch Set 1: Verified-1

[Impala-ASF-CR] IMPALA-6802 (part 3): Clean up authorization tests

2018-05-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10358 ) Change subject: IMPALA-6802 (part 3): Clean up authorization tests .. Patch Set 5: -Code-Review My understanding is you and Adam are still

[Impala-ASF-CR] IMPALA-7025: ignore resources in some planner test

2018-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10410 ) Change subject: IMPALA-7025: ignore resources in some planner test .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10

[Impala-ASF-CR] IMPALA-7025: ignore resources in some planner test

2018-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10410 ) Change subject: IMPALA-7025: ignore resources in some planner test .. Patch Set 3: I changed the runPlannerTestFile() API to do a whit

[Impala-ASF-CR] IMPALA-6802 (part 3): Clean up authorization tests

2018-05-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/10358 ) Change subject: IMPALA-6802 (part 3): Clean up authorization tests .. IMPALA-6802 (part 3): Clean up authorization tests The third part o

[Impala-ASF-CR] IMPALA-7025: ignore resources in some planner test

2018-05-15 Thread Tim Armstrong (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10410 to look at the new patch set (#3). Change subject: IMPALA-7025: ignore resources in some planner test .. IMPALA-7025:

[Impala-ASF-CR] IMPALA-6802 (part 3): Clean up authorization tests

2018-05-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10358 ) Change subject: IMPALA-6802 (part 3): Clean up authorization tests .. Patch Set 5: Alex, can you please carry +2? -- To view, visit h

[Impala-ASF-CR] IMPALA-7035: Configure jceks.key.serialFilter for KMS.

2018-05-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10418 Change subject: IMPALA-7035: Configure jceks.key.serialFilter for KMS. .. IMPALA-7035: Configure jceks.key.serialFilter for KMS. Conf

[Impala-ASF-CR] IMPALA-6802 (part 3): Clean up authorization tests

2018-05-15 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10358 ) Change subject: IMPALA-6802 (part 3): Clean up authorization tests .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/1035

[Impala-ASF-CR] IMPALA-6802 (part 3): Clean up authorization tests

2018-05-15 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10358 ) Change subject: IMPALA-6802 (part 3): Clean up authorization tests .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/1035

[Impala-ASF-CR] IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded()

2018-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10364 ) Change subject: IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded() .. Patch Set 2: Code-Review+2 -- To view, visit http://

[Impala-ASF-CR](2.x) IMPALA-6957: calc thread resource requirement in planner

2018-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10398 ) Change subject: IMPALA-6957: calc thread resource requirement in planner .. IMPALA-6957: calc thread resource requirement in pl

[Impala-ASF-CR](2.x) IMPALA-6957: calc thread resource requirement in planner

2018-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10398 ) Change subject: IMPALA-6957: calc thread resource requirement in planner .. Patch Set 2: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-6802 (part 3): Clean up authorization tests

2018-05-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10358 ) Change subject: IMPALA-6802 (part 3): Clean up authorization tests .. Patch Set 2: (2 comments) Thanks for the cleanup, much more condens

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-05-15 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10415 Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. IMPALA-6034: Add Cpu and scanned bytes limits per query To

[Impala-ASF-CR] IMPALA-7019: Schedule EC as remote & disable failed tests

2018-05-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10413 ) Change subject: IMPALA-7019: Schedule EC as remote & disable failed tests .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-7003: Deflake erasure coding data loading

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10362 ) Change subject: IMPALA-7003: Deflake erasure coding data loading .. Patch Set 3: Build started: https://jenkins.impala.io/job/

[Impala-ASF-CR] IMPALA-7025: ignore resources in some planner test

2018-05-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10410 ) Change subject: IMPALA-7025: ignore resources in some planner test .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10410/

[Impala-ASF-CR] IMPALA-7003: Deflake erasure coding data loading

2018-05-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10362 ) Change subject: IMPALA-7003: Deflake erasure coding data loading .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-7003: Deflake erasure coding data loading

2018-05-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10362 ) Change subject: IMPALA-7003: Deflake erasure coding data loading .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10

[Impala-ASF-CR] IMPALA-7025: ignore resources in some planner test

2018-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10410 ) Change subject: IMPALA-7025: ignore resources in some planner test .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10

[Impala-ASF-CR] IMPALA-6983: stress: don't write a null runtime profile

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10381 ) Change subject: IMPALA-6983: stress: don't write a null runtime profile .. Patch Set 3: Verified-1 Build failed: https://jenki

[Impala-ASF-CR] IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded()

2018-05-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10364 ) Change subject: IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded() .. Patch Set 1: (2 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded()

2018-05-15 Thread Joe McDonnell (Code Review)
Hello Zoram Thanga, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10364 to look at the new patch set (#2). Change subject: IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded() .

[Impala-ASF-CR] IMPALA-6802 (part 3): Clean up authorization tests

2018-05-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10358 ) Change subject: IMPALA-6802 (part 3): Clean up authorization tests .. IMPALA-6802 (part 3): Clean up authorization tests The third part o

[Impala-ASF-CR] IMPALA-7019: Schedule EC as remote & disable failed tests

2018-05-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10413 Change subject: IMPALA-7019: Schedule EC as remote & disable failed tests .. IMPALA-7019: Schedule EC as remote & disable failed tests Th

[Impala-ASF-CR] IMPALA-7003: Deflake erasure coding data loading

2018-05-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10362 ) Change subject: IMPALA-7003: Deflake erasure coding data loading .. IMPALA-7003: Deflake erasure coding data loading Erasure coding data l

[Impala-ASF-CR](2.x) IMPALA-6957: calc thread resource requirement in planner

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10398 ) Change subject: IMPALA-6957: calc thread resource requirement in planner .. Patch Set 2: Verified+1 -- To view, visit http://

[Impala-ASF-CR] IMPALA-6645: Enable disk spill encryption by default

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10345 ) Change subject: IMPALA-6645: Enable disk spill encryption by default .. Patch Set 8: Verified-1 Build failed: https://jenkins.

[Impala-ASF-CR] IMPALA-7025: ignore resources in some planner test

2018-05-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10410 ) Change subject: IMPALA-7025: ignore resources in some planner test .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10410/

[Impala-ASF-CR] IMPALA-7033/IMPALA-7030: Backout suspected change leading to crash

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10412 ) Change subject: IMPALA-7033/IMPALA-7030: Backout suspected change leading to crash .. Patch Set 1: Build started: https://jen

[Impala-ASF-CR] IMPALA-7033/IMPALA-7030: Backout suspected change leading to crash

2018-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10412 ) Change subject: IMPALA-7033/IMPALA-7030: Backout suspected change leading to crash .. Patch Set 1: Code-Review+2 -- To view, visit h

[Impala-ASF-CR] IMPALA-7033/IMPALA-7030: Backout suspected change leading to crash

2018-05-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10412 ) Change subject: IMPALA-7033/IMPALA-7030: Backout suspected change leading to crash .. Patch Set 1: (2 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-7025: ignore resources in some planner test

2018-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10410 ) Change subject: IMPALA-7025: ignore resources in some planner test .. IMPALA-7025: ignore resources in some planner test The issue was t

[Impala-ASF-CR] IMPALA-7033/IMPALA-7030: Backout suspected change leading to crash

2018-05-15 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10412 Change subject: IMPALA-7033/IMPALA-7030: Backout suspected change leading to crash .. IMPALA-7033/IMPALA-7030: Backout suspected change lea

[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data

2018-05-15 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 2: > > > Safety is one thing, control

[Impala-ASF-CR] IMPALA-7029: Clone LHS when rewriting a between predicate

2018-05-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10402 ) Change subject: IMPALA-7029: Clone LHS when rewriting a between predicate .. Patch Set 2: Tianyi, before we pursue this further let's get

[Impala-ASF-CR] IMPALA-7022: TestQueries.test subquery: Subquery must not return more than one row

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10407 ) Change subject: IMPALA-7022: TestQueries.test_subquery: Subquery must not return more than one row .. Patch Set 1: Build star

[Impala-ASF-CR] IMPALA-6827: [DOCS] Updated the download link for the tutorial data

2018-05-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10393 ) Change subject: IMPALA-6827: [DOCS] Updated the download link for the tutorial data .. Patch Set 2: > > Safety is one thing, control is a

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10409 ) Change subject: IMPALA-7032: Disable codegen for CHAR type null literals .. Patch Set 2: Build started: https://jenkins.impala

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

2018-05-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10409 ) Change subject: IMPALA-7032: Disable codegen for CHAR type null literals .. Patch Set 2: Code-Review+2 (1 comment) Thanks for the quick

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

2018-05-15 Thread Lars Volker (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10409 to look at the new patch set (#2). Change subject: IMPALA-7032: Disable codegen for CHAR type null literals .. IMPALA

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

2018-05-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10409 ) Change subject: IMPALA-7032: Disable codegen for CHAR type null literals .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

2018-05-15 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10409 Change subject: IMPALA-7032: Disable codegen for CHAR type null literals .. IMPALA-7032: Disable codegen for CHAR type null literals Anal

[Impala-ASF-CR] IMPALA-6802 (part 3): Clean up authorization tests

2018-05-15 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10358 ) Change subject: IMPALA-6802 (part 3): Clean up authorization tests .. Patch Set 2: (9 comments) Taking over for Fredy while he's out.

[Impala-ASF-CR] Put ASAN options in CMakeLists.

2018-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10404 ) Change subject: Put ASAN options in CMakeLists. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10404/1//COMMIT_MSG C

[Impala-ASF-CR] Put ASAN options in CMakeLists.

2018-05-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10404 ) Change subject: Put ASAN options in CMakeLists. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10404/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-3134: Support different proc mem limits among impalads for admission control checks

2018-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10396 ) Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks .. Patch Set 2: (1 comment

[Impala-ASF-CR] IMPALA-3134: Support different proc mem limits among impalads for admission control checks

2018-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10396 ) Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks .. Patch Set 2: (10 commen

[Impala-ASF-CR] IMPALA-5384: Simplify coordinator locking protocol

2018-05-15 Thread Dan Hecht (Code Review)
Dan Hecht has abandoned this change. ( http://gerrit.cloudera.org:8080/7065 ) Change subject: IMPALA-5384: Simplify coordinator locking protocol .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7065 To unsubscribe,

[Impala-ASF-CR] IMPALA-5384: Simplify coordinator locking protocol

2018-05-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7065 ) Change subject: IMPALA-5384: Simplify coordinator locking protocol .. Patch Set 2: This has been subsumed by another set of patches that we

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-15 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-05-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-05-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 7: (2 comments) I focused mostly on the non-timestamp/timezone

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-15 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-05-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 18: (4 comments) http://gerrit.cloudera.org:8080/#/c/9

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-05-15 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Anonymous Coward #248, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#18). Change subject: IMPALA-5842: Write page index in Parquet files

[Impala-ASF-CR] IMPALA-6983: stress: don't write a null runtime profile

2018-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10381 ) Change subject: IMPALA-6983: stress: don't write a null runtime profile .. Patch Set 3: Build started: https://jenkins.impala.

[Impala-ASF-CR] IMPALA-6983: stress: don't write a null runtime profile

2018-05-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10381 ) Change subject: IMPALA-6983: stress: don't write a null runtime profile .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-6983: stress: don't write a null runtime profile

2018-05-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10381 ) Change subject: IMPALA-6983: stress: don't write a null runtime profile .. Patch Set 2: IMPALA-7030 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-6983: stress: don't write a null runtime profile

2018-05-15 Thread Michael Brown (Code Review)
Michael Brown has removed a vote on this change. Change subject: IMPALA-6983: stress: don't write a null runtime profile .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/10381 To

  1   2   >