[Impala-ASF-CR] IMPALA-7012: Fix NPE when parsing unexpected tokens

2018-05-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10512 ) Change subject: IMPALA-7012: Fix NPE when parsing unexpected tokens .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5522: Add support for authorized proxy groups

2018-05-29 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5522: Add support for authorized proxy groups .. Patch Set 3: Update the commit message - IMPALA-5552 vs 5522 --

[Impala-ASF-CR] IMPALA-7061: Rework HBase splitting and assignment

2018-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10447 ) Change subject: IMPALA-7061: Rework HBase splitting and assignment .. Patch Set 9: This change did not cherrypick

[Impala-ASF-CR] Revert IMPALA-2751: Matching quotes are not requirerd in comments

2018-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10537 ) Change subject: Revert IMPALA-2751: Matching quotes are not requirerd in comments .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6338: Disable more flaky bloom filter tests

2018-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10530 ) Change subject: IMPALA-6338: Disable more flaky bloom filter tests .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-7082: Show human readable size in query backend page

2018-05-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10523 ) Change subject: IMPALA-7082: Show human readable size in query backend page .. Patch Set 4: Code-Review+1 This looks fine to me. If

[Impala-ASF-CR] Revert IMPALA-2751: Matching quotes are not requirerd in comments

2018-05-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10537 ) Change subject: Revert IMPALA-2751: Matching quotes are not requirerd in comments .. Patch Set 1: Code-Review+2 If this is a clean

[Impala-ASF-CR] IMPALA-6338: Disable more flaky bloom filter tests

2018-05-29 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10530 ) Change subject: IMPALA-6338: Disable more flaky bloom filter tests .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Revert IMPALA-2751: Matching quotes are not requirerd in comments

2018-05-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10537 ) Change subject: Revert IMPALA-2751: Matching quotes are not requirerd in comments .. Patch Set 1: I'm making a fix for this right

[Impala-ASF-CR] IMPALA-7082: Show human readable size in query backend page

2018-05-29 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10523 ) Change subject: IMPALA-7082: Show human readable size in query backend page .. Patch Set 4: > This file (and a .gitignore) slipped

[Impala-ASF-CR] IMPALA-7082: Show human readable size in query backend page

2018-05-29 Thread Quanlong Huang (Code Review)
Hello Philip Zeyliger, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10523 to look at the new patch set (#4). Change subject: IMPALA-7082: Show human readable size in query backend page

[Impala-ASF-CR] IMPALA-7082: Show human readable size in query backend page

2018-05-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10523 ) Change subject: IMPALA-7082: Show human readable size in query backend page .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7091: Address NullPointerException in HBaseTable.getRegionSize().

2018-05-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10531 ) Change subject: IMPALA-7091: Address NullPointerException in HBaseTable.getRegionSize(). .. Patch Set 1:

[Impala-ASF-CR] IMPALA-7091: Address NullPointerException in HBaseTable.getRegionSize().

2018-05-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10531 Change subject: IMPALA-7091: Address NullPointerException in HBaseTable.getRegionSize(). .. IMPALA-7091: Address

[Impala-ASF-CR] IMPALA-7090: Limit the size of expr created by EqualityDisjunctsToInRule

2018-05-29 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10528 ) Change subject: IMPALA-7090: Limit the size of expr created by EqualityDisjunctsToInRule .. IMPALA-7090: Limit the size of expr created

[Impala-ASF-CR] IMPALA-5522: Add support for authorized proxy groups

2018-05-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5522: Add support for authorized proxy groups .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5522: Add support for authorized proxy groups

2018-05-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5522: Add support for authorized proxy groups .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-5522: Add support for authorized proxy groups

2018-05-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5522: Add support for authorized proxy groups .. IMPALA-5522: Add support for authorized proxy groups The patch

[Impala-ASF-CR] IMPALA-7082: Show human readable size in query backend page

2018-05-29 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10523 ) Change subject: IMPALA-7082: Show human readable size in query backend page .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-7082: Show human readable size in query backend page

2018-05-29 Thread Quanlong Huang (Code Review)
Hello Philip Zeyliger, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10523 to look at the new patch set (#3). Change subject: IMPALA-7082: Show human readable size in query backend page

[Impala-ASF-CR](2.x) Ignore IMPALA-6953 which has already been picked

2018-05-29 Thread Thomas Marshall (Code Review)
Thomas Marshall has abandoned this change. ( http://gerrit.cloudera.org:8080/10539 ) Change subject: Ignore IMPALA-6953 which has already been picked .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/10539 To

[Impala-ASF-CR](2.x) Ignore IMPALA-6953 which has already been picked

2018-05-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10539 ) Change subject: Ignore IMPALA-6953 which has already been picked .. Patch Set 1: I think I accidentally fixed this by submitting my

[Impala-ASF-CR](2.x) Ignore IMPALA-6953 which has already been picked

2018-05-29 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10539 Change subject: Ignore IMPALA-6953 which has already been picked .. Ignore IMPALA-6953 which has already been picked IMPALA-6953 was

[Impala-ASF-CR](2.x) IMPALA-6953: part 1: clean up DiskIoMgr

2018-05-29 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10532 to review the following change. Change subject: IMPALA-6953: part 1: clean up DiskIoMgr .. IMPALA-6953:

[Impala-ASF-CR](2.x) IMPALA-6953: part 1: clean up DiskIoMgr

2018-05-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10532 ) Change subject: IMPALA-6953: part 1: clean up DiskIoMgr .. IMPALA-6953: part 1: clean up DiskIoMgr There should be no

[Impala-ASF-CR](2.x) IMPALA-6953: part 1: clean up DiskIoMgr

2018-05-29 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10538 ) Change subject: IMPALA-6953: part 1: clean up DiskIoMgr .. Patch Set 1: Verified+1 Code-Review+2 Cherry-pick, no interesting

[Impala-ASF-CR](2.x) IMPALA-6953: part 1: clean up DiskIoMgr

2018-05-29 Thread Thomas Marshall (Code Review)
Thomas Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10538 ) Change subject: IMPALA-6953: part 1: clean up DiskIoMgr .. IMPALA-6953: part 1: clean up DiskIoMgr There should be no

[Impala-ASF-CR] IMPALA-7090: Limit the size of expr created by EqualityDisjunctsToInRule

2018-05-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10528 ) Change subject: IMPALA-7090: Limit the size of expr created by EqualityDisjunctsToInRule .. Patch Set 2: Code-Review+2 (2 comments)

[Impala-ASF-CR](2.x) IMPALA-6953: part 1: clean up DiskIoMgr

2018-05-29 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10538 Change subject: IMPALA-6953: part 1: clean up DiskIoMgr .. IMPALA-6953: part 1: clean up DiskIoMgr There should be no behavioural

[Impala-ASF-CR] IMPALA-7073: skip TestScannerReservation on non-miniclusters

2018-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10533 ) Change subject: IMPALA-7073: skip TestScannerReservation on non-miniclusters .. IMPALA-7073: skip

[Impala-ASF-CR] IMPALA-7073: skip TestScannerReservation on non-miniclusters

2018-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10533 ) Change subject: IMPALA-7073: skip TestScannerReservation on non-miniclusters .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] Revert IMPALA-2751: Matching quotes are not requirerd in comments

2018-05-29 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10537 Change subject: Revert IMPALA-2751: Matching quotes are not requirerd in comments .. Revert IMPALA-2751: Matching quotes are not

[Impala-ASF-CR] IMPALA-7090: Limit the size of expr created by EqualityDisjunctsToInRule

2018-05-29 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10528 ) Change subject: IMPALA-7090: Limit the size of expr created by EqualityDisjunctsToInRule .. IMPALA-7090: Limit the size of expr created

[Impala-ASF-CR] IMPALA-6990: TestClientSsl.test tls v12 failing due to Python SSL error

2018-05-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10529 ) Change subject: IMPALA-6990: TestClientSsl.test_tls_v12 failing due to Python SSL error .. Patch Set 2: (2 comments) > (2 comments)

[Impala-ASF-CR] IMPALA-6990: TestClientSsl.test tls v12 failing due to Python SSL error

2018-05-29 Thread Sailesh Mukil (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10529 to look at the new patch set (#3). Change subject: IMPALA-6990: TestClientSsl.test_tls_v12 failing due to Python SSL error

[native-toolchain-CR] Revert "Bump libunwind version to 1.3-rc1"

2018-05-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10534 ) Change subject: Revert "Bump libunwind version to 1.3-rc1" .. Patch Set 1: Verified+1 -- To view, visit

[native-toolchain-CR] Revert "Bump libunwind version to 1.3-rc1"

2018-05-29 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10534 ) Change subject: Revert "Bump libunwind version to 1.3-rc1" .. Revert "Bump libunwind version to 1.3-rc1" This reverts commit

[native-toolchain-CR] Revert "Bump libunwind version to 1.3-rc1"

2018-05-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10534 ) Change subject: Revert "Bump libunwind version to 1.3-rc1" .. Patch Set 1: Code-Review+2 -- To view, visit

[native-toolchain-CR] Revert "Bump libunwind version to 1.3-rc1"

2018-05-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10534 ) Change subject: Revert "Bump libunwind version to 1.3-rc1" .. Patch Set 1: Previous change broke building the toolchain on CentOS 5.

[native-toolchain-CR] Revert "Bump libunwind version to 1.3-rc1"

2018-05-29 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10534 Change subject: Revert "Bump libunwind version to 1.3-rc1" .. Revert "Bump libunwind version to 1.3-rc1" This reverts commit

[Impala-ASF-CR] IMPALA-7089: xfail test kudu dml reporting

2018-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10527 ) Change subject: IMPALA-7089: xfail test_kudu_dml_reporting .. IMPALA-7089: xfail test_kudu_dml_reporting

[Impala-ASF-CR] IMPALA-7089: xfail test kudu dml reporting

2018-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10527 ) Change subject: IMPALA-7089: xfail test_kudu_dml_reporting .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7088: Fix uninitialized variable in cluster dataload

2018-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10526 ) Change subject: IMPALA-7088: Fix uninitialized variable in cluster dataload .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7088: Fix uninitialized variable in cluster dataload

2018-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10526 ) Change subject: IMPALA-7088: Fix uninitialized variable in cluster dataload .. IMPALA-7088: Fix uninitialized variable

[Impala-ASF-CR] IMPALA-7073: skip TestScannerReservation on non-miniclusters

2018-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10533 ) Change subject: IMPALA-7073: skip TestScannerReservation on non-miniclusters .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-7073: skip TestScannerReservation on non-miniclusters

2018-05-29 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10533 ) Change subject: IMPALA-7073: skip TestScannerReservation on non-miniclusters .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7073: skip TestScannerReservation on non-miniclusters

2018-05-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10533 Change subject: IMPALA-7073: skip TestScannerReservation on non-miniclusters .. IMPALA-7073: skip TestScannerReservation on

[Impala-ASF-CR] IMPALA-7090: Limit the size of expr created by EqualityDisjunctsToInRule

2018-05-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10528 ) Change subject: IMPALA-7090: Limit the size of expr created by EqualityDisjunctsToInRule .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-5522: Add support for authorized proxy groups

2018-05-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5522: Add support for authorized proxy groups .. Patch Set 2: (5 comments) My main concern is whether this

[Impala-ASF-CR] IMPALA-6947: Kudu tests flaky due to rpc timeout

2018-05-29 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10466 ) Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6947: Kudu tests flaky due to rpc timeout

2018-05-29 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10466 ) Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout .. Patch Set 1: (2 comments) Please add another appropriate

[Impala-ASF-CR] IMPALA-6933: Avoids db name collisions for Kudu tests

2018-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10513 ) Change subject: IMPALA-6933: Avoids db name collisions for Kudu tests .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6933: Avoids db name collisions for Kudu tests

2018-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10513 ) Change subject: IMPALA-6933: Avoids db name collisions for Kudu tests .. IMPALA-6933: Avoids db name collisions for

[Impala-ASF-CR] IMPALA-6338: Disable more flaky bloom filter tests

2018-05-29 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10530 Change subject: IMPALA-6338: Disable more flaky bloom filter tests .. IMPALA-6338: Disable more flaky bloom filter tests Until

[Impala-ASF-CR] IMPALA-7082: Show human readable size in query backend page

2018-05-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10523 ) Change subject: IMPALA-7082: Show human readable size in query backend page .. Patch Set 2: -Code-Review (1 comment)

[Impala-ASF-CR] IMPALA-6990: TestClientSsl.test tls v12 failing due to Python SSL error

2018-05-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10529 ) Change subject: IMPALA-6990: TestClientSsl.test_tls_v12 failing due to Python SSL error .. Patch Set 2: (2 comments) I wrote a

[Impala-ASF-CR] IMPALA-6990: TestClientSsl.test tls v12 failing due to Python SSL error

2018-05-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10529 ) Change subject: IMPALA-6990: TestClientSsl.test_tls_v12 failing due to Python SSL error .. IMPALA-6990: TestClientSsl.test_tls_v12

[Impala-ASF-CR] IMPALA-6990: TestClientSsl.test tls v12 failing due to Python SSL error

2018-05-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10529 Change subject: IMPALA-6990: TestClientSsl.test_tls_v12 failing due to Python SSL error .. IMPALA-6990: TestClientSsl.test_tls_v12

[Impala-ASF-CR] IMPALA-7082: Show human readable size in query backend page

2018-05-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10523 ) Change subject: IMPALA-7082: Show human readable size in query backend page .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7090: Limit the size of expr created by EqualityDisjunctsToInRule

2018-05-29 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10528 Change subject: IMPALA-7090: Limit the size of expr created by EqualityDisjunctsToInRule .. IMPALA-7090: Limit the size of expr created

[Impala-ASF-CR] IMPALA-7082: Show human readable size in query backend page

2018-05-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10523 ) Change subject: IMPALA-7082: Show human readable size in query backend page .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7089: xfail test kudu dml reporting

2018-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10527 ) Change subject: IMPALA-7089: xfail test_kudu_dml_reporting .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-7089: xfail test kudu dml reporting

2018-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10527 ) Change subject: IMPALA-7089: xfail test_kudu_dml_reporting .. Patch Set 1: Code-Review+2 Makes sense to XFAIL for now since this is

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-05-29 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 3: (21 comments)

[Impala-ASF-CR] IMPALA-7089: xfail test kudu dml reporting

2018-05-29 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10527 Change subject: IMPALA-7089: xfail test_kudu_dml_reporting .. IMPALA-7089: xfail test_kudu_dml_reporting test_kudu_dml_reporting has

[Impala-ASF-CR] IMPALA-7088: Fix uninitialized variable in cluster dataload

2018-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10526 ) Change subject: IMPALA-7088: Fix uninitialized variable in cluster dataload .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7088: Fix uninitialized variable in cluster dataload

2018-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10526 ) Change subject: IMPALA-7088: Fix uninitialized variable in cluster dataload .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7088: Fix uninitialized variable in cluster dataload

2018-05-29 Thread Joe McDonnell (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10526 to look at the new patch set (#2). Change subject: IMPALA-7088: Fix uninitialized variable in cluster dataload

[Impala-ASF-CR] IMPALA-7088: Fix uninitialized variable in cluster dataload

2018-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10526 ) Change subject: IMPALA-7088: Fix uninitialized variable in cluster dataload .. Patch Set 2: Code-Review+2 Carry +2 -- To view,

[Impala-ASF-CR] IMPALA-7088: Fix uninitialized variable in cluster dataload

2018-05-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10526 ) Change subject: IMPALA-7088: Fix uninitialized variable in cluster dataload .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7088: Fix uninitialized variable in cluster dataload

2018-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10526 Change subject: IMPALA-7088: Fix uninitialized variable in cluster dataload .. IMPALA-7088: Fix uninitialized variable in cluster

[Impala-ASF-CR] IMPALA-6714: [DOCS] ORC file format support

2018-05-29 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10525 ) Change subject: IMPALA-6714: [DOCS] ORC file format support .. Patch Set 1: Alex Rodoni is currently most familiar with docs so

[Impala-ASF-CR] IMPALA-5642: [DOCS] An additional restriction for Hive/Java UDFs

2018-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10520 ) Change subject: IMPALA-5642: [DOCS] An additional restriction for Hive/Java UDFs .. IMPALA-5642: [DOCS] An additional

[Impala-ASF-CR] IMPALA-5642: [DOCS] An additional restriction for Hive/Java UDFs

2018-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10520 ) Change subject: IMPALA-5642: [DOCS] An additional restriction for Hive/Java UDFs .. Patch Set 1: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-5642: [DOCS] An additional restriction for Hive/Java UDFs

2018-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10520 ) Change subject: IMPALA-5642: [DOCS] An additional restriction for Hive/Java UDFs .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-5642: [DOCS] An additional restriction for Hive/Java UDFs

2018-05-29 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10520 ) Change subject: IMPALA-5642: [DOCS] An additional restriction for Hive/Java UDFs .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6933: Avoids db name collisions for Kudu tests

2018-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10513 ) Change subject: IMPALA-6933: Avoids db name collisions for Kudu tests .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6933: Avoids db name collisions for Kudu tests

2018-05-29 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10513 ) Change subject: IMPALA-6933: Avoids db name collisions for Kudu tests .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5642: [DOCS] An additional restriction for Hive/Java UDFs

2018-05-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10520 ) Change subject: IMPALA-5642: [DOCS] An additional restriction for Hive/Java UDFs .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6714: [DOCS] ORC file format support

2018-05-29 Thread Balazs Jeszenszky (Code Review)
Balazs Jeszenszky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10525 ) Change subject: IMPALA-6714: [DOCS] ORC file format support .. Patch Set 1: (6 comments) Thanks for doing this!

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-29 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Spilling sort optimisations .. Patch Set 17: Verified+1 I've spent some time (way more than wanted to:) )