[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 ) Change subject: IMPALA-7128 (part 2): add an interface for data sources .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe704197dc2ad7c09b8340865f17567096aa630e Gerrit-Change-Number: 10626 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Wed, 13 Jun 2018 04:17:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 5: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2649/ -- To view, visit http://gerrit.cloudera.org:8080/10611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id55f7d2e94d81e66ce720acb6315f15a89621b31 Gerrit-Change-Number: 10611 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Wed, 13 Jun 2018 03:25:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 21: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2650/ -- To view, visit http://gerrit.cloudera.org:8080/10060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I989cf5b259afb8f5bc5c35590c94961c81ce88bf Gerrit-Change-Number: 10060 Gerrit-PatchSet: 21 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 13 Jun 2018 03:25:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7141. Extract interfaces for partition pruning without loading
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10631 ) Change subject: IMPALA-7141. Extract interfaces for partition pruning without loading .. Patch Set 4: seems like this may have broken some existing behavior. Worth a look at a high level but will need a bit of tweaking before being committable. -- To view, visit http://gerrit.cloudera.org:8080/10631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifdcfd6cffcd298bbf44531e1ec2f47c3a5b7d1fa Gerrit-Change-Number: 10631 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Wed, 13 Jun 2018 03:20:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 4: Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2648/ -- To view, visit http://gerrit.cloudera.org:8080/10415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c6015e21da684bb9f33e236d71309dd4c178a20 Gerrit-Change-Number: 10415 Gerrit-PatchSet: 4 Gerrit-Owner: Mostafa Mokhtar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 13 Jun 2018 02:47:10 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-5931: Generates scan ranges in planner for s3/adls
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10692 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10692 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I326065adbb2f7e632814113aae85cb51ca4779a5 Gerrit-Change-Number: 10692 Gerrit-PatchSet: 2 Gerrit-Owner: Vuk Ercegovac Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Wed, 13 Jun 2018 02:30:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled
Fredy Wijaya has posted comments on this change. (
http://gerrit.cloudera.org:8080/10571 )
Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is
enabled
..
Patch Set 11:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10571/5/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java
File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java:
http://gerrit.cloudera.org:8080/#/c/10571/5/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@117
PS5, Line 117: static class SubqueryRewriter extends StmtRewriter {
> - I think the test you mentioned is broken because tableRefTosql() is not c
Yeah you're right. Thanks for your suggestion. Done.
http://gerrit.cloudera.org:8080/#/c/10571/10/fe/src/main/java/org/apache/impala/analysis/TableRef.java
File fe/src/main/java/org/apache/impala/analysis/TableRef.java:
http://gerrit.cloudera.org:8080/#/c/10571/10/fe/src/main/java/org/apache/impala/analysis/TableRef.java@593
PS10, Line 593: output.append(tableRefToSql(rewritten));
> tableRefToSql(rewritten)
Ah that's what's missing. Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/10571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53
Gerrit-Change-Number: 10571
Gerrit-PatchSet: 11
Gerrit-Owner: Fredy Wijaya
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Tianyi Wang
Gerrit-Reviewer: Vuk Ercegovac
Gerrit-Comment-Date: Wed, 13 Jun 2018 02:07:10 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled
Fredy Wijaya has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. IMPALA-7106: Print rewritten SQL correctly when log trace is enabled toSql() method is used to print SQL string that is close to the original SQL string, which is something that users want to see. When debugging issues related to SQL rewrites, it can be very useful to be able to print/get the SQL string that is being rewritten. This patch adds a new method toSql(boolean rewritten) to get the rewritten SQL string. The LOG.trace statement that prints the rewritten SQL is also updated to use toSql(true). Testing: - Added FE test for the rewritten SQL string - Ran all FE tests Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53 --- M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java M fe/src/main/java/org/apache/impala/analysis/FromClause.java M fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java M fe/src/main/java/org/apache/impala/analysis/StatementBase.java M fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java M fe/src/main/java/org/apache/impala/analysis/TableRef.java M fe/src/main/java/org/apache/impala/analysis/UnionStmt.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeSubqueriesTest.java M fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java 10 files changed, 112 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/10571/11 -- To view, visit http://gerrit.cloudera.org:8080/10571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53 Gerrit-Change-Number: 10571 Gerrit-PatchSet: 11 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10704 Change subject: IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans .. IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans This change ensures that the planner computes parquet conjuncts only for scans containing parquet files. Additionally, it also handles PARQUET_DICTIONARY_FILTERING and PARQUET_READ_STATISTICS query options in the planner. Testing was carried out independently on parquet and non-parquet scans: 1. Parquet scans were tested via the existing parquet-filtering planner test. Additionally, a new test [parquet-filtering-disabled] was added to ensure that the explain plan generated skips parquet predicates based on the query options. 2. Non-parquet scans were tested manually to ensure that the functions to compute parquet conjuncts were not invoked. This was done because the eventual explain plan returned to the client doesn't contain parquet predicates for non-parquet scans. Change-Id: I9d6c26d42db090c8a15c602f6419ad6399c329e7 --- M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java A testdata/workloads/functional-planner/queries/PlannerTest/parquet-filtering-disabled.test 3 files changed, 296 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/10704/2 -- To view, visit http://gerrit.cloudera.org:8080/10704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9d6c26d42db090c8a15c602f6419ad6399c329e7 Gerrit-Change-Number: 10704 Gerrit-PatchSet: 2 Gerrit-Owner: Pooja Nilangekar
[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 1: Actually after chatting with Hao Hao over this and actually reading the error in the JIRA (the telltale part is "Snapshot timestamp: P: 0 usec, L: 1"), it seems this is an instance of KUDU-2233, which happens when the clock doesn't get advanced on boot. Sorting that should also fix that problem. Note that this bug doesn't happen on clusters which have seen writes since the last reboot, so maybe you can use that to test your implementation while we fix the underlying issue, -- To view, visit http://gerrit.cloudera.org:8080/10503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70df84f2cbc663107f2ad029565d3c15bdfbd47c Gerrit-Change-Number: 10503 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 13 Jun 2018 00:58:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7141. Extract interfaces for partition pruning without loading
Hello Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10631 to look at the new patch set (#5). Change subject: IMPALA-7141. Extract interfaces for partition pruning without loading .. IMPALA-7141. Extract interfaces for partition pruning without loading This adds a new PrunablePartition interface which HdfsPartition implements. The interface includes only the partition ID and the partition key/values. For the case of the current catalog implementation, this provides no benefit. However, for LocalCatalog, we want to defer loading partition information until after pruning. With this interface, we can construct PrunablePartition objects using just the partition names, and then load the partitions once pruning is complete. Change-Id: Ifdcfd6cffcd298bbf44531e1ec2f47c3a5b7d1fa --- M fe/src/main/java/org/apache/impala/analysis/AlterTableSetCachedStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableSetLocationStmt.java M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java M fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java M fe/src/main/java/org/apache/impala/analysis/PartitionSet.java M fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java M fe/src/main/java/org/apache/impala/catalog/FeFsTable.java M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java A fe/src/main/java/org/apache/impala/catalog/PrunablePartition.java M fe/src/main/java/org/apache/impala/planner/HdfsPartitionFilter.java M fe/src/main/java/org/apache/impala/planner/HdfsPartitionPruner.java M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java M fe/src/test/java/org/apache/impala/testutil/BlockIdGenerator.java 18 files changed, 179 insertions(+), 46 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/10631/5 -- To view, visit http://gerrit.cloudera.org:8080/10631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifdcfd6cffcd298bbf44531e1ec2f47c3a5b7d1fa Gerrit-Change-Number: 10631 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7137. Support configuring Frontend to use LocalCatalog
Hello Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10629 to look at the new patch set (#5). Change subject: IMPALA-7137. Support configuring Frontend to use LocalCatalog .. IMPALA-7137. Support configuring Frontend to use LocalCatalog This adds a new flag -use_local_catalog which is passed through to the frontend and causes it to use LocalCatalog instead of ImpaladCatalog. Additionally, when this flag is configured, the impalad does not subscribe to catalog topic updates from the statestore. The patch is slightly more complex than simply picking which class to instantiate, because the lifecycle is designed a bit differently between the two implementations: - LocalCatalog is instantiated once per query/request. - ImpaladCatalog is instantiated once and stateful across queries, except when a full catalog update is received. This maintains the current behavior for this implementation. In order to abstract this difference in lifecycle from the frontend, I introduced a new FeCatalogManager class with different implementations for the two lifecycles. I also had to add a simple test implementation since some tests rely on directly injecting a Catalog implementation into the Frontend. This patch also includes a few small changes to the local catalog implementation objects to enable the impalad to start and accept connections. With this patch, I was able to manually test as follows: I started just the statestore and the impalad in the new mode: - ./bin/start-statestored.sh - ./bin/start-impalad.sh --use_local_catalog I connected with impala-shell as usual and was able to run the most simple queries: - SHOW DATABASES; - USE functional; - SHOW TABLES; All other functionality results in error messages due to the various TODOs in the current skeleton implementation. Change-Id: I8c9665bd031d23608740b23eef301970af9aa764 --- M be/src/runtime/exec-env.cc M be/src/service/impala-server.cc M be/src/util/backend-gflag-util.cc M common/thrift/BackendGflags.thrift M fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java M fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java M fe/src/main/java/org/apache/impala/service/DescribeResultFactory.java A fe/src/main/java/org/apache/impala/service/FeCatalogManager.java M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/main/java/org/apache/impala/service/JniFrontend.java M fe/src/main/java/org/apache/impala/service/MetadataOp.java 11 files changed, 241 insertions(+), 64 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/10629/5 -- To view, visit http://gerrit.cloudera.org:8080/10629 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8c9665bd031d23608740b23eef301970af9aa764 Gerrit-Change-Number: 10629 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog
Hello Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10630 to look at the new patch set (#5). Change subject: IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog .. IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog This adds support for loading the Table object from HMS and parsing out the Column and partitioning information from it. With this change, I'm able to connect to an impalad running in "local catalog" mode and run DESCRIBE, DESCRIBE EXTENDED, and SHOW CREATE TABLE commands. Other commands like SHOW PARTITIONS don't work properly yet, and type-specific table functionality (eg views, HBase tables, etc) are not yet supported. Again a simple unit test is included to check that column information is loaded. More thorough testing is deferred until we've reached enough coverage that we can start running e2e tests against a cluster running in "local" mode. Change-Id: I640f27e36198955e057da62a3ce25a858406e496 --- A fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java M fe/src/main/java/org/apache/impala/catalog/FeFsTable.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/catalog/Table.java M fe/src/main/java/org/apache/impala/catalog/local/LocalCatalogException.java M fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java 9 files changed, 301 insertions(+), 79 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/10630/5 -- To view, visit http://gerrit.cloudera.org:8080/10630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I640f27e36198955e057da62a3ce25a858406e496 Gerrit-Change-Number: 10630 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7135. Skeleton implementation of LocalCatalog
Hello Mostafa Mokhtar, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10627 to look at the new patch set (#5). Change subject: IMPALA-7135. Skeleton implementation of LocalCatalog .. IMPALA-7135. Skeleton implementation of LocalCatalog This adds some of the high level classes for implementing the local catalog: - LocalCatalog is the top level implementation. The plan is to instantiate this once per query, so that no thread safety is required. - It loads metadata from a MetaProvider interface. The current implementation fetches directly from HMS and provides no caching. A future subtask will add a CachingMetaProvider implementation. Separating out caching will make it easier to experiment with different policies or storage mechanisms. - It instantiates LocalDb and LocalTable objects to implement FeDb and FeTable. These are mostly stubbed out except for the most basic functionality. Functionality will be filled in incrementally in further patches. Since it's not yet possible to hook this up to most of the existing tests, a very simple new unit test is included to cover the bits of functionality that are not stubbed out. I didn't concentrate on too much test coverage here, since once we've implemented more functionality we can switch over all of the existing tests to get coverage of the new implementation. Change-Id: Iab653371188b21c72f50ee1ec4e94950aa6fb9ee --- M fe/src/main/java/org/apache/impala/catalog/Catalog.java M fe/src/main/java/org/apache/impala/catalog/CatalogObject.java M fe/src/main/java/org/apache/impala/catalog/FeDb.java A fe/src/main/java/org/apache/impala/catalog/HasName.java A fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java A fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java A fe/src/main/java/org/apache/impala/catalog/local/LocalCatalogException.java A fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java A fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java A fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java A fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java 11 files changed, 823 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/10627/5 -- To view, visit http://gerrit.cloudera.org:8080/10627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iab653371188b21c72f50ee1ec4e94950aa6fb9ee Gerrit-Change-Number: 10627 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10541 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2feae34026a7e63f3d31489f757f093a73ca5d2c Gerrit-Change-Number: 10541 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 13 Jun 2018 00:22:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7137. Support configuring Frontend to use LocalCatalog
Todd Lipcon has posted comments on this change. (
http://gerrit.cloudera.org:8080/10629 )
Change subject: IMPALA-7137. Support configuring Frontend to use LocalCatalog
..
Patch Set 4:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/10629/4/be/src/runtime/exec-env.cc
File be/src/runtime/exec-env.cc:
http://gerrit.cloudera.org:8080/#/c/10629/4/be/src/runtime/exec-env.cc@85
PS4, Line 85: DEFINE_bool(use_local_catalog, false,
> suffixing this with "_hidden" will suppress this from help. useful while th
Done
http://gerrit.cloudera.org:8080/#/c/10629/2/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:
http://gerrit.cloudera.org:8080/#/c/10629/2/fe/src/main/java/org/apache/impala/service/Frontend.java@197
PS2, Line 197: new AuthorizationPo
> I see, you were trying to re-use L224. Pls add a comment: "initializes auth
Done
http://gerrit.cloudera.org:8080/#/c/10629/4/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:
http://gerrit.cloudera.org:8080/#/c/10629/4/fe/src/main/java/org/apache/impala/service/Frontend.java@163
PS4, Line 163: //TODO: Make the reload interval configurable.
> nit: add a space.
Done
http://gerrit.cloudera.org:8080/#/c/10629/4/fe/src/main/java/org/apache/impala/service/Frontend.java@232
PS4, Line 232: public FeCatalog getCatalog() {
> nit: one line
Done
--
To view, visit http://gerrit.cloudera.org:8080/10629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c9665bd031d23608740b23eef301970af9aa764
Gerrit-Change-Number: 10629
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Todd Lipcon
Gerrit-Reviewer: Vuk Ercegovac
Gerrit-Comment-Date: Wed, 13 Jun 2018 00:14:21 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7135. Skeleton implementation of LocalCatalog
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10627 ) Change subject: IMPALA-7135. Skeleton implementation of LocalCatalog .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/10627/3/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/10627/3/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java@35 PS3, Line 35: * (filesystem, HMS, etc with no caching. > nit: ")" Done http://gerrit.cloudera.org:8080/#/c/10627/3/fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java: http://gerrit.cloudera.org:8080/#/c/10627/3/fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java@30 PS3, Line 30: into LocalCatalog > Is it required/intended to be so specific? Nothing here restricts which pro Done -- To view, visit http://gerrit.cloudera.org:8080/10627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab653371188b21c72f50ee1ec4e94950aa6fb9ee Gerrit-Change-Number: 10627 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Wed, 13 Jun 2018 00:11:58 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6929: Support multi-column range partitions for Kudu
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10441 ) Change subject: IMPALA-6929: Support multi-column range partitions for Kudu .. IMPALA-6929: Support multi-column range partitions for Kudu Kudu allows specifying range partitions over multiple columns. Impala already has support for doing this when the partitions are specified with '=', but if the partitions are specified with '<' or '<=', the parser would return an error. This patch modifies the parser to allow for creating Kudu tables like: create table kudu_test (a int, b int, primary key(a, b)) partition by range(a, b) (partition (0, 0) <= values < (1, 1)); and similary to alter partitions like: alter table kudu_test add range partition (1, 1) <= values < (2, 2); Testing: - Modified functional_kudu.jointbl's schema so that we have a table in functional with a multi-column range partition to test things against. - Added FE and E2E tests for CREATE and ALTER. Change-Id: I0141dd3344a4f22b186f513b7406f286668ef1e7 Reviewed-on: http://gerrit.cloudera.org:8080/10441 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/RangePartition.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M testdata/datasets/functional/functional_schema_template.sql M testdata/workloads/functional-planner/queries/PlannerTest/kudu.test M testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test 6 files changed, 115 insertions(+), 33 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10441 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0141dd3344a4f22b186f513b7406f286668ef1e7 Gerrit-Change-Number: 10441 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-6929: Support multi-column range partitions for Kudu
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10441 ) Change subject: IMPALA-6929: Support multi-column range partitions for Kudu .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10441 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0141dd3344a4f22b186f513b7406f286668ef1e7 Gerrit-Change-Number: 10441 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Wed, 13 Jun 2018 00:10:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10630 ) Change subject: IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java File fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java: http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java@37 PS4, Line 37: @param > why not? I agree with not slavish adherence to Javadoc when the parameters It was my understanding that flowing the param name in the description is preferable to using @param. I see that the project is inconsistent... some places use it, some don't, even in the same file. The several places where I've looked, it introduces duplication (e.g., Expr.castChild). Since we're far from being consistent, the @param doesn't seem to buy us much, so its terser to omit it. Open to alternatives though. http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java: http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java@78 PS4, Line 78: schemaInfo; > the problem is I needed to use tblName on line 75, so I need to checkNotNul I think this looks fine: this.db_ = Preconditions.checkNotNull(db); this.name_ = Preconditions.checkNotNull(tblName); this.schemaInfo = Preconditions.checkNotNull(schemaInfo); Preconditions.checkArgument(tblName.toLowerCase().equals(tblName)); http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java@190 PS4, Line 190: implementations > > Got confused about whether this is supposed to factor existing code thats fine, but pls leave a breadcrumb for where some of the lifting comes from. http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java@191 PS4, Line 191: stats > does num bytes get cached in the HMS? I think I missed that yes, have a look at setTableStats in Table.java -- To view, visit http://gerrit.cloudera.org:8080/10630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I640f27e36198955e057da62a3ce25a858406e496 Gerrit-Change-Number: 10630 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Wed, 13 Jun 2018 00:09:31 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10668 ) Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/10668/7/be/CMakeLists.txt File be/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/10668/7/be/CMakeLists.txt@521 PS7, Line 521: # TODO: IMPALA-2746: we should make this the default. > are we essentially addressing this? I think the desired end-state is that we remove the special function and it's just on for all backend tests. -- To view, visit http://gerrit.cloudera.org:8080/10668 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4 Gerrit-Change-Number: 10668 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 13 Jun 2018 00:06:38 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/10571/5/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java: http://gerrit.cloudera.org:8080/#/c/10571/5/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@117 PS5, Line 117: stmt.sqlString_ = null; > So removing stmt.sqlString_ = null breaks this test. - I think the test you mentioned is broken because tableRefTosql() is not called with rewritten in TableRef.java. See my comment there. - I don't understand what your statement about between is for. I'm not suggesting to turn it off. I think we need to change the test cases and replace those "<= x and >= y" with the original "BETWEEN" in the expected strings of those cases. http://gerrit.cloudera.org:8080/#/c/10571/10/fe/src/main/java/org/apache/impala/analysis/TableRef.java File fe/src/main/java/org/apache/impala/analysis/TableRef.java: http://gerrit.cloudera.org:8080/#/c/10571/10/fe/src/main/java/org/apache/impala/analysis/TableRef.java@593 PS10, Line 593: tableRefToSql(rewritten) -- To view, visit http://gerrit.cloudera.org:8080/10571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53 Gerrit-Change-Number: 10571 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Wed, 13 Jun 2018 00:06:25 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 21: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2650/ -- To view, visit http://gerrit.cloudera.org:8080/10060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I989cf5b259afb8f5bc5c35590c94961c81ce88bf Gerrit-Change-Number: 10060 Gerrit-PatchSet: 21 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 13 Jun 2018 00:05:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 21: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I989cf5b259afb8f5bc5c35590c94961c81ce88bf Gerrit-Change-Number: 10060 Gerrit-PatchSet: 21 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 13 Jun 2018 00:05:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2649/ -- To view, visit http://gerrit.cloudera.org:8080/10611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id55f7d2e94d81e66ce720acb6315f15a89621b31 Gerrit-Change-Number: 10611 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Wed, 13 Jun 2018 00:03:48 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10669 ) Change subject: IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance .. IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance In SendReport(), if VLOG_FILE_IS_ON is 'true' (which is not the most verbose logging level, but is higher than default), we pretty print the profile for every fragment instance, which is a very expensive operation, as serializing the profile is non-trivial (look at RuntimeProfile::PrettyPrint()), and printing large amounts of information to the logs isn't cheap as well. Lastly, it is very noisy. This seems unnecessary since this will not benefit us, as all the profiles are merged at the coordinator side. We could argue that this might be necessary when an executor fails to send the profile to the coordinator, but that signifies a network issue which will not be reflected in the profile of any fragment instance. This will help reduce noise in the logs when the log level is bumped up to find other real issues that VLOG_FILE can help with. Change-Id: Ic0445950385fa6160764feaed9a993fa0e59b242 Reviewed-on: http://gerrit.cloudera.org:8080/10669 Reviewed-by: Sailesh Mukil Tested-by: Impala Public Jenkins --- M be/src/runtime/fragment-instance-state.cc 1 file changed, 2 insertions(+), 7 deletions(-) Approvals: Sailesh Mukil: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic0445950385fa6160764feaed9a993fa0e59b242 Gerrit-Change-Number: 10669 Gerrit-PatchSet: 4 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil
[Impala-ASF-CR] IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10669 ) Change subject: IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0445950385fa6160764feaed9a993fa0e59b242 Gerrit-Change-Number: 10669 Gerrit-PatchSet: 3 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Tue, 12 Jun 2018 23:58:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 1: I filed https://issues.apache.org/jira/browse/KUDU-2473 -- To view, visit http://gerrit.cloudera.org:8080/10503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70df84f2cbc663107f2ad029565d3c15bdfbd47c Gerrit-Change-Number: 10503 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 12 Jun 2018 23:53:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10630 ) Change subject: IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java File fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java: http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java@37 PS4, Line 37: @param > lets not use javadocs. why not? I agree with not slavish adherence to Javadoc when the parameters are clear, but in this case it's useful to know "for use in exception messages" because it's not really obvious why this method would take a tableName. http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java: http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java@78 PS4, Line 78: schemaInfo; > I prefer the alternative style you used for these: the problem is I needed to use tblName on line 75, so I need to checkNotNull for tblName ahead of that. I could move just that one up, and use the checkNotNull on schemaInfo and db here, but then it's less consistent which I thought might look odd. Another option is to not bother doing checkNotNull on tblName and just let the tblName.toLowerCase() throw NPE if it's null, but that's a little ugly too. What do you think? http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java@190 PS4, Line 190: implementations > Got confused about whether this is supposed to factor existing code > in Table. Looks like it partially does-- pls clarify whether the > intent is to factor or leave the duplication. yea... I could probably do more surgery on Table/HdfsTable to reuse code from SchemaInfo, but was trying to stick to one of the high level goals of this project and minimize code churn on existing classes even if it means some copy-paste, except where such refactors are really trivial (extracting a straight-forward method). I initially attempted to refactor out the column-loading code from Table and reuse some of the same functions but it ended up being somewhat invasive there and didn't want to risk it. Happy to take another go at it, though, if you prefer http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java@191 PS4, Line 191: stats > is num bytes needed as well? does num bytes get cached in the HMS? I think I missed that -- To view, visit http://gerrit.cloudera.org:8080/10630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I640f27e36198955e057da62a3ce25a858406e496 Gerrit-Change-Number: 10630 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 12 Jun 2018 23:35:22 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2648/ -- To view, visit http://gerrit.cloudera.org:8080/10415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c6015e21da684bb9f33e236d71309dd4c178a20 Gerrit-Change-Number: 10415 Gerrit-PatchSet: 4 Gerrit-Owner: Mostafa Mokhtar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Jun 2018 23:29:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog
Vuk Ercegovac has posted comments on this change. (
http://gerrit.cloudera.org:8080/10630 )
Change subject: IMPALA-7140 (part 1). Support fetching schema info in
LocalCatalog
..
Patch Set 4:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
File fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java:
http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java@37
PS4, Line 37: @param
lets not use javadocs.
http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java@57
PS4, Line 57: full
fully qualified?
http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java@77
PS4, Line 77: name
fully qualified?
http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java@80
PS4, Line 80: validateClusteringColumns
based on HdfsTable::addColumnsFromFieldSchemas. pls add a todo for a potential
refactor there (would be nice not to duplicate these types of exception
strings).
http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java:
http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@119
PS4, Line 119: public
todo: pull it up to FeFsTable or comment at site of use.
http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
File fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java:
http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java@78
PS4, Line 78: schemaInfo;
I prefer the alternative style you used for these:
this.db_ = Preconditions.checkNotNull(db)
http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java@175
PS4, Line 175: HdfsTable
Table? (so that the child class is not used)
In either case, this is an odd dep. Seems like SchemaInfo can be the class that
knows specifically about HMS, so the detail about what param to pull out would
go there explicitly (then replace that method of Table)
http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java@175
PS4, Line 175: getRowCount
I saw that -1 is used as a default/unknown value in catalog.Table... needed
here as well?
http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java@190
PS4, Line 190: Table
FeTable?
http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java@190
PS4, Line 190: implementations
Got confused about whether this is supposed to factor existing code in Table.
Looks like it partially does-- pls clarify whether the intent is to factor or
leave the duplication.
http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java@191
PS4, Line 191: stats
is num bytes needed as well?
http://gerrit.cloudera.org:8080/#/c/10630/4/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java@263
PS4, Line 263: private boolean isClusteringColumn(Column c) {
duplicates the impl in Table, pls add a todo to refactor.
--
To view, visit http://gerrit.cloudera.org:8080/10630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I640f27e36198955e057da62a3ce25a858406e496
Gerrit-Change-Number: 10630
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon
Gerrit-Reviewer: Vuk Ercegovac
Gerrit-Comment-Date: Tue, 12 Jun 2018 23:26:36 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 1: Thomas and I chatted offline and it seems these errors happened with an implementation of RYW on a private branch. I agree that the snapshot errors are unexpected and we'll investigate. -- To view, visit http://gerrit.cloudera.org:8080/10503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70df84f2cbc663107f2ad029565d3c15bdfbd47c Gerrit-Change-Number: 10503 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 12 Jun 2018 23:21:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10703 Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition pruning .. IMPALA-7165: [DOCS] Correct example for dynamic partition pruning Change-Id: I44d1054f55d3dc7947ccf4c2ef440e506c41f963 --- M docs/shared/impala_common.xml 1 file changed, 10 insertions(+), 32 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/10703/1 -- To view, visit http://gerrit.cloudera.org:8080/10703 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I44d1054f55d3dc7947ccf4c2ef440e506c41f963 Gerrit-Change-Number: 10703 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10668 ) Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests .. Patch Set 7: Code-Review+1 (1 comment) Approach looks totally reasonable to me. Thanks! http://gerrit.cloudera.org:8080/#/c/10668/7/be/CMakeLists.txt File be/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/10668/7/be/CMakeLists.txt@521 PS7, Line 521: # TODO: IMPALA-2746: we should make this the default. are we essentially addressing this? -- To view, visit http://gerrit.cloudera.org:8080/10668 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4 Gerrit-Change-Number: 10668 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Tue, 12 Jun 2018 23:13:53 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 20: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I989cf5b259afb8f5bc5c35590c94961c81ce88bf Gerrit-Change-Number: 10060 Gerrit-PatchSet: 20 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Jun 2018 23:08:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests
Tim Armstrong has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/10668 ) Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests .. IMPALA-2746: part 1: enable LSAN for many backend tests This turns on leak sanitizer for backend tests that required relatively small modifications to pass. We suppress a few leaks, mainly related to the embedded JVM. Testing: Ran core tests under ASAN. Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4 --- M be/CMakeLists.txt M be/src/catalog/CMakeLists.txt M be/src/codegen/CMakeLists.txt M be/src/codegen/instruction-counter-test.cc M be/src/common/CMakeLists.txt M be/src/common/atomic-test.cc M be/src/common/atomic.h M be/src/exec/CMakeLists.txt M be/src/experiments/CMakeLists.txt M be/src/exprs/CMakeLists.txt M be/src/exprs/expr-test.cc M be/src/rpc/CMakeLists.txt M be/src/runtime/CMakeLists.txt M be/src/runtime/bufferpool/CMakeLists.txt M be/src/runtime/bufferpool/buffer-pool-test.cc M be/src/runtime/data-stream-test.cc M be/src/runtime/io/CMakeLists.txt M be/src/runtime/io/disk-io-mgr-stress.cc M be/src/runtime/io/disk-io-mgr-stress.h M be/src/runtime/io/disk-io-mgr-test.cc M be/src/runtime/mem-tracker.cc M be/src/scheduling/CMakeLists.txt M be/src/service/CMakeLists.txt M be/src/statestore/CMakeLists.txt M be/src/udf/udf.cc M be/src/util/CMakeLists.txt M be/src/util/decompress-test.cc A bin/lsan-suppressions.txt 28 files changed, 295 insertions(+), 239 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/10668/7 -- To view, visit http://gerrit.cloudera.org:8080/10668 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4 Gerrit-Change-Number: 10668 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong
[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 20: Dan, it's probably worth looking at PS19->20. It's a fairly minor test change but just want to be sure I didn't miss anything. -- To view, visit http://gerrit.cloudera.org:8080/10060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I989cf5b259afb8f5bc5c35590c94961c81ce88bf Gerrit-Change-Number: 10060 Gerrit-PatchSet: 20 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Jun 2018 22:54:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async
Tim Armstrong has uploaded a new patch set (#20) to the change originally created by Bikramjeet Vig. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. IMPALA-5216: Make admission control queuing async Implement asynchronous admission control queuing. This is achieved by running the admission control code-path in a separate thread. Major changes include: propagating cancellation to the admission control thread and dequeuing thread, and adding a new Query Operation State called "PENDING" that represents the state between completion of planning and starting of query execution. Testing: - Added a deterministic end to end test and a session expiry test. - Ran multiple stress tests successfully with a cancellation probability of 60% and with different values for the following parameters: max_requests, queue_wait_timeout_ms. Ensured that the impalad was in a valid state afterwards (no orphan fragments or wrong metrics). - Ran all exhaustive tests and ASAN core tests successfully. - Ran data load successfully. Change-Id: I989cf5b259afb8f5bc5c35590c94961c81ce88bf --- M be/src/common/atomic.h M be/src/common/logging.h M be/src/runtime/fragment-instance-state.cc M be/src/runtime/query-state.cc M be/src/scheduling/admission-controller.cc M be/src/scheduling/admission-controller.h M be/src/scheduling/query-schedule.cc M be/src/scheduling/query-schedule.h M be/src/service/client-request-state.cc M be/src/service/client-request-state.h M be/src/service/impala-beeswax-server.cc M be/src/service/impala-hs2-server.cc M be/src/service/impala-http-handler.cc M be/src/service/impala-server.cc M be/src/service/impala-server.h M be/src/util/debug-util.cc M be/src/util/debug-util.h M be/src/util/promise-test.cc M be/src/util/promise.h M common/thrift/ImpalaService.thrift M tests/authorization/test_authorization.py M tests/beeswax/impala_beeswax.py M tests/common/impala_connection.py M tests/custom_cluster/test_admission_controller.py M tests/custom_cluster/test_krpc_mem_usage.py M tests/custom_cluster/test_session_expiration.py M tests/hs2/hs2_test_suite.py M tests/hs2/test_hs2.py M tests/query_test/test_observability.py M tests/query_test/test_udfs.py M www/query_backends.tmpl 31 files changed, 682 insertions(+), 238 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/10060/20 -- To view, visit http://gerrit.cloudera.org:8080/10060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I989cf5b259afb8f5bc5c35590c94961c81ce88bf Gerrit-Change-Number: 10060 Gerrit-PatchSet: 20 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR](2.x) IMPALA-5931: Generates scan ranges in planner for s3/adls
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10692 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10692 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I326065adbb2f7e632814113aae85cb51ca4779a5 Gerrit-Change-Number: 10692 Gerrit-PatchSet: 2 Gerrit-Owner: Vuk Ercegovac Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Tue, 12 Jun 2018 22:53:22 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-5931: Generates scan ranges in planner for s3/adls
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10692 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2647/ -- To view, visit http://gerrit.cloudera.org:8080/10692 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I326065adbb2f7e632814113aae85cb51ca4779a5 Gerrit-Change-Number: 10692 Gerrit-PatchSet: 2 Gerrit-Owner: Vuk Ercegovac Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Tue, 12 Jun 2018 22:53:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 19: So it turns out the test was already broken - the query was rejected by admission control - but passing by coincidence because of a quirk of how exceptions were being wrapped and a bug in _check_exception(). https://github.com/apache/impala/blob/b56ac8f/tests/query_test/test_udfs.py#L50. Note the "'Cancelled' not in e.inner_exception.message" bit - the "not" shouldn't be there. The fix is to manually set buffer_pool_limit so that the query makes it through admission control. I'll loop the test a bit to make sure it's not flaky. -- To view, visit http://gerrit.cloudera.org:8080/10060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I989cf5b259afb8f5bc5c35590c94961c81ce88bf Gerrit-Change-Number: 10060 Gerrit-PatchSet: 19 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Jun 2018 22:46:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 1: When you say playing around, you on a private branch? Unless you actually added read-your-writes to impala in another patch/branch somewhere, I think what you are referring to as "read your writes" is the "old (2017) implementation, that gave the choice of either READ_LATEST or READ_AT_SNAPSHOT. Note that the latter is _not_ read your writes (nowhere in Kudu was this ever called "read your writes"), it's actually read at snapshot, despite what the impala commit messages at the time say, and even though no-one is actually setting a timestamp it still does choose one on its own. It seems that the READ_AT_SNAPSHOT implementation is buggy. In order of this to work properly the _frontent_ must choose a timestamp before it's passed to the scanners on the backend. Even when this is done the AHW in Kudu needs to be far enough behind to let all the scanners start, it was at some point shortened to something like 5 minutes, which is likely not enough. In order to get true "read-your-writes" impala needs to use the proper mode in the kudu side (READ_YOUR_WRITES) which was added just recently. This mode should not complain about AHW or care about snapshot timestamps. -- To view, visit http://gerrit.cloudera.org:8080/10503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70df84f2cbc663107f2ad029565d3c15bdfbd47c Gerrit-Change-Number: 10503 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 12 Jun 2018 22:43:38 + Gerrit-HasComments: No
[native-toolchain-CR] WIP ONLY: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: WIP ONLY: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 4: I need to re-run tests but I don't plan to make other code changes. -- To view, visit http://gerrit.cloudera.org:8080/6521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f8481a8dfe35273a763586e9d2da0d4008ac67 Gerrit-Change-Number: 6521 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Jun 2018 22:31:24 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6394: Disable dfs.namenode.replication.considerLoad
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10664 ) Change subject: IMPALA-6394: Disable dfs.namenode.replication.considerLoad .. IMPALA-6394: Disable dfs.namenode.replication.considerLoad By default namenode excludes heavily-loaded datanodes from being considered for block placement. Impala tests rely on every block to be fully-replicated so this option should be set to false. This is originally from IMPALA-7004 which was for 3.x branch only. The option has been renamed to "dfs.namenode.redundancy.considerLoad" in Hadooop 3.0. Change-Id: I00010107cbd61bffa38ed8af4395b3a0e3d13c13 Reviewed-on: http://gerrit.cloudera.org:8080/10664 Reviewed-by: Tianyi Wang Tested-by: Impala Public Jenkins --- M testdata/cluster/node_templates/common/etc/hadoop/conf/hdfs-site.xml.tmpl 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Tianyi Wang: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10664 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: merged Gerrit-Change-Id: I00010107cbd61bffa38ed8af4395b3a0e3d13c13 Gerrit-Change-Number: 10664 Gerrit-PatchSet: 5 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tianyi Wang
[Impala-ASF-CR](2.x) IMPALA-6394: Disable dfs.namenode.replication.considerLoad
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10664 ) Change subject: IMPALA-6394: Disable dfs.namenode.replication.considerLoad .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10664 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I00010107cbd61bffa38ed8af4395b3a0e3d13c13 Gerrit-Change-Number: 10664 Gerrit-PatchSet: 4 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Tue, 12 Jun 2018 22:15:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7145: fix leak of OpenSSL context when spilling
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10666 ) Change subject: IMPALA-7145: fix leak of OpenSSL context when spilling .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98760ed8f31b18b489a156f945c29c95c9bf3184 Gerrit-Change-Number: 10666 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Jun 2018 22:08:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7145: fix leak of OpenSSL context when spilling
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10666 ) Change subject: IMPALA-7145: fix leak of OpenSSL context when spilling .. IMPALA-7145: fix leak of OpenSSL context when spilling Add a RAII wrapper for the OpenSSL context that automatically frees on all exit paths from the function. Add a backend test wrapper that enables LeakSanitizer for an individual test. This is a step towards IMPALA-2746. Fix version check bug in asan.h. Testing: Enable LeakSanitizer for openssl-util-test. This reliably found the bug. Ran core tests under ASAN. Change-Id: I98760ed8f31b18b489a156f945c29c95c9bf3184 Reviewed-on: http://gerrit.cloudera.org:8080/10666 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/CMakeLists.txt M be/src/util/CMakeLists.txt M be/src/util/asan.h M be/src/util/openssl-util.cc 4 files changed, 38 insertions(+), 14 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I98760ed8f31b18b489a156f945c29c95c9bf3184 Gerrit-Change-Number: 10666 Gerrit-PatchSet: 10 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong
[native-toolchain-CR] WIP ONLY: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: WIP ONLY: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6521/4/functions.sh File functions.sh: http://gerrit.cloudera.org:8080/#/c/6521/4/functions.sh@502 PS4, Line 502: symlink_lib "$src_lib" "$file" > Sure. I'll do the review. Just asking - is this in a ready-for-review state? -- To view, visit http://gerrit.cloudera.org:8080/6521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f8481a8dfe35273a763586e9d2da0d4008ac67 Gerrit-Change-Number: 6521 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Jun 2018 22:00:31 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. Patch Set 4: Code-Review+1 Carry +1 -- To view, visit http://gerrit.cloudera.org:8080/10442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4cf3a4751b41908ef81ec35d89a2713d9fa0dc4 Gerrit-Change-Number: 10442 Gerrit-PatchSet: 4 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 12 Jun 2018 21:48:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests
Adam Holley has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. IMPALA-6802 (part 4): Clean up authorization tests The fourth part of this patch is to rewrite the following authorization tests: - describe Testing: - Added new authorization tests - Ran all front-end tests Cherry-picks: not for 2.x Change-Id: Ic4cf3a4751b41908ef81ec35d89a2713d9fa0dc4 --- M fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java 1 file changed, 277 insertions(+), 57 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/10442/4 -- To view, visit http://gerrit.cloudera.org:8080/10442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic4cf3a4751b41908ef81ec35d89a2713d9fa0dc4 Gerrit-Change-Number: 10442 Gerrit-PatchSet: 4 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests
Adam Holley has posted comments on this change. (
http://gerrit.cloudera.org:8080/10442 )
Change subject: IMPALA-6802 (part 4): Clean up authorization tests
..
Patch Set 3: Code-Review+1
(6 comments)
updated. carry +1
http://gerrit.cloudera.org:8080/#/c/10442/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java:
http://gerrit.cloudera.org:8080/#/c/10442/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@918
PS3, Line 918: @Test
> perhaps add a comment explaining what's being tested... from a first glance
Done
http://gerrit.cloudera.org:8080/#/c/10442/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@922
PS3, Line 922:
> consistent spacing (see comment below)
Done
http://gerrit.cloudera.org:8080/#/c/10442/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@938
PS3, Line 938:
> and several more places below
Done
http://gerrit.cloudera.org:8080/#/c/10442/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@946
PS3, Line 946: allExcept(
: TPrivilegeLevel.ALL, TPrivilegeLevel.SELECT)
> factor out (repeated 3 times in this block, so it adds too much noise).
This is the pattern we've been using in these tests to be explicit for each
test on the privileges required. It adds text, but reduces the need to
reference what the variable or constant means in a different part of the code.
http://gerrit.cloudera.org:8080/#/c/10442/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@952
PS3, Line 952: ng[]{"id"},
> explain what is being tested here (missing why "id" is special)
Done
http://gerrit.cloudera.org:8080/#/c/10442/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@1181
PS3, Line 1181:
> use consistent spacing for this... from a brief look, seems like no space i
Done
--
To view, visit http://gerrit.cloudera.org:8080/10442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4cf3a4751b41908ef81ec35d89a2713d9fa0dc4
Gerrit-Change-Number: 10442
Gerrit-PatchSet: 3
Gerrit-Owner: Adam Holley
Gerrit-Reviewer: Adam Holley
Gerrit-Reviewer: Alex Behm
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Vuk Ercegovac
Gerrit-Comment-Date: Tue, 12 Jun 2018 21:48:18 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7137. Support configuring Frontend to use LocalCatalog
Vuk Ercegovac has posted comments on this change. (
http://gerrit.cloudera.org:8080/10629 )
Change subject: IMPALA-7137. Support configuring Frontend to use LocalCatalog
..
Patch Set 4:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/10629/4/be/src/runtime/exec-env.cc
File be/src/runtime/exec-env.cc:
http://gerrit.cloudera.org:8080/#/c/10629/4/be/src/runtime/exec-env.cc@85
PS4, Line 85: DEFINE_bool(use_local_catalog, false,
suffixing this with "_hidden" will suppress this from help. useful while the
new functionality rolls out. for example, the flag controlling krpc was in this
state until it was made the default.
http://gerrit.cloudera.org:8080/#/c/10629/2/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:
http://gerrit.cloudera.org:8080/#/c/10629/2/fe/src/main/java/org/apache/impala/service/Frontend.java@197
PS2, Line 197: new AuthorizationPo
> I agree this is a little goofy, though I was trying to maintain the exact o
I see, you were trying to re-use L224. Pls add a comment: "initializes
authzChecker"
http://gerrit.cloudera.org:8080/#/c/10629/4/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:
http://gerrit.cloudera.org:8080/#/c/10629/4/fe/src/main/java/org/apache/impala/service/Frontend.java@163
PS4, Line 163: //TODO: Make the reload interval configurable.
nit: add a space.
http://gerrit.cloudera.org:8080/#/c/10629/4/fe/src/main/java/org/apache/impala/service/Frontend.java@232
PS4, Line 232: public FeCatalog getCatalog() {
nit: one line
--
To view, visit http://gerrit.cloudera.org:8080/10629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c9665bd031d23608740b23eef301970af9aa764
Gerrit-Change-Number: 10629
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Todd Lipcon
Gerrit-Reviewer: Vuk Ercegovac
Gerrit-Comment-Date: Tue, 12 Jun 2018 21:46:24 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc
Tianyi Wang has posted comments on this change. (
http://gerrit.cloudera.org:8080/10679 )
Change subject: IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc
..
Patch Set 3:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/10679/3/be/src/runtime/sorter-ir.cc
File be/src/runtime/sorter-ir.cc:
http://gerrit.cloudera.org:8080/#/c/10679/3/be/src/runtime/sorter-ir.cc@28
PS3, Line 28: void Sorter::TupleIterator::NextPage
> Does this need to be cross-compiled ?
See my comment at L51.
http://gerrit.cloudera.org:8080/#/c/10679/3/be/src/runtime/sorter-ir.cc@39
PS3, Line 39: void Sorter::TupleIterator::PrevPage
> Does this need to be cross-compiled ?
See my comment at L51.
http://gerrit.cloudera.org:8080/#/c/10679/3/be/src/runtime/sorter-ir.cc@51
PS3, Line 51: void Sorter::TupleIterator::Next(
> Does this need to be cross-compiled ?
It doesn't need to be. But it's in the inner-most while loop in Partition() so
we'd better inline it. Plus the IR code size increment is marginal so I don't
see why not.
http://gerrit.cloudera.org:8080/#/c/10679/3/be/src/runtime/sorter-ir.cc@185
PS3, Line 185: Tuple* Sorter::TupleSorter::SelectPivot(TupleIterator begin,
TupleIterator end) {
> Does this need to be cross-compiled ?
It calls Less(). See my comment at L209.
http://gerrit.cloudera.org:8080/#/c/10679/3/be/src/runtime/sorter-ir.cc@209
PS3, Line 209: Tuple* Sorter::TupleSorter::MedianOfThree(Tuple* t1, Tuple* t2,
Tuple* t3) {
> Does this need to be cross-compiled ?
This calls Less(). After my change Less() will always call CompareInterpreted()
if it's not replaced by the hand-crafted Compare(), which could be very slow.
So I chose to cross-compile this.
http://gerrit.cloudera.org:8080/#/c/10679/3/be/src/runtime/sorter-ir.cc@245
PS3, Line 245: void Sorter::TupleSorter::Swap(Tuple* left, Tuple* right, Tuple*
swap_tuple,
> Does this need to be cross-compiled ?
It's in the main loop in Partition() and it's about only 3 instructions so why
not?
--
To view, visit http://gerrit.cloudera.org:8080/10679
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaf2b75c2f789002c42939865c018f728d29a113
Gerrit-Change-Number: 10679
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Tianyi Wang
Gerrit-Reviewer: Tim Armstrong
Gerrit-Comment-Date: Tue, 12 Jun 2018 21:41:01 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 5: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2640/ -- To view, visit http://gerrit.cloudera.org:8080/10421 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c44cc9312c062cc7a5a4ac9156ceaa31fb887ff Gerrit-Change-Number: 10421 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Jun 2018 21:32:52 + Gerrit-HasComments: No
[Impala-ASF-CR] Change variables to make the code easier to read
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10699 ) Change subject: Change variables to make the code easier to read .. Patch Set 1: > I think we can run the script in a standalone fashion with the args > and confirm that we have all the shared libraries. Can't think of > any other alternatives. Did that, it worked. I am not aware of any tests exercising this script automatically so I marked this as Verified. -- To view, visit http://gerrit.cloudera.org:8080/10699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic98a79dba428d3307854a414d52742efa6bad0f7 Gerrit-Change-Number: 10699 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Tue, 12 Jun 2018 21:32:25 + Gerrit-HasComments: No
[Impala-ASF-CR] Change variables to make the code easier to read
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10699 ) Change subject: Change variables to make the code easier to read .. Change variables to make the code easier to read Change-Id: Ic98a79dba428d3307854a414d52742efa6bad0f7 Reviewed-on: http://gerrit.cloudera.org:8080/10699 Reviewed-by: Bharath Vissapragada Tested-by: Lars Volker --- M bin/diagnostics/collect_shared_libs.sh 1 file changed, 10 insertions(+), 6 deletions(-) Approvals: Bharath Vissapragada: Looks good to me, approved Lars Volker: Verified -- To view, visit http://gerrit.cloudera.org:8080/10699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic98a79dba428d3307854a414d52742efa6bad0f7 Gerrit-Change-Number: 10699 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Lars Volker
[Impala-ASF-CR] Change variables to make the code easier to read
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10699 ) Change subject: Change variables to make the code easier to read .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic98a79dba428d3307854a414d52742efa6bad0f7 Gerrit-Change-Number: 10699 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Tue, 12 Jun 2018 21:31:47 + Gerrit-HasComments: No
[Impala-ASF-CR] Change variables to make the code easier to read
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10699 ) Change subject: Change variables to make the code easier to read .. Patch Set 1: I think we can run the script in a standalone fashion with the args and confirm that we have all the shared libraries. Can't think of any other alternatives. -- To view, visit http://gerrit.cloudera.org:8080/10699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic98a79dba428d3307854a414d52742efa6bad0f7 Gerrit-Change-Number: 10699 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Tue, 12 Jun 2018 21:28:19 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-5931: Generates scan ranges in planner for s3/adls
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10692 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 1: Code-Review+2 I looked at the diff between this patch and the original patch in master and convinced myself that the merge conflicts have been addressed properly. -- To view, visit http://gerrit.cloudera.org:8080/10692 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I326065adbb2f7e632814113aae85cb51ca4779a5 Gerrit-Change-Number: 10692 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk Ercegovac Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Tue, 12 Jun 2018 21:28:22 + Gerrit-HasComments: No
[Impala-ASF-CR] Change variables to make the code easier to read
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10699 ) Change subject: Change variables to make the code easier to read .. Patch Set 1: Bharath, do we have an easy way to test this? -- To view, visit http://gerrit.cloudera.org:8080/10699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic98a79dba428d3307854a414d52742efa6bad0f7 Gerrit-Change-Number: 10699 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Tue, 12 Jun 2018 21:19:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. Patch Set 14: Code-Review+2 Seems like we're loosening things a bit, and this was also tested in Python 2.6 -- To view, visit http://gerrit.cloudera.org:8080/9933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ac7cb5a30e6dda73ebe761d9f0eb9ba038e14a7 Gerrit-Change-Number: 9933 Gerrit-PatchSet: 14 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Tue, 12 Jun 2018 21:10:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2645/ -- To view, visit http://gerrit.cloudera.org:8080/10541 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2feae34026a7e63f3d31489f757f093a73ca5d2c Gerrit-Change-Number: 10541 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Jun 2018 21:09:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10541 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2feae34026a7e63f3d31489f757f093a73ca5d2c Gerrit-Change-Number: 10541 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Jun 2018 21:09:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10541 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2feae34026a7e63f3d31489f757f093a73ca5d2c Gerrit-Change-Number: 10541 Gerrit-PatchSet: 6 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Jun 2018 21:08:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id55f7d2e94d81e66ce720acb6315f15a89621b31 Gerrit-Change-Number: 10611 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 12 Jun 2018 21:02:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 ) Change subject: IMPALA-7128 (part 2): add an interface for data sources .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe704197dc2ad7c09b8340865f17567096aa630e Gerrit-Change-Number: 10626 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 12 Jun 2018 21:01:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7158: Fix HdfsScanNodeBase::progress 's init
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10672 ) Change subject: IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init .. IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init (Testing) Verified that the correct node id is being logged with this patch and --v=2. Change-Id: Id2a738edea80ff3fb13ff368b4093c8b4ef34df7 Reviewed-on: http://gerrit.cloudera.org:8080/10672 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/exec/hdfs-scan-node-base.cc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id2a738edea80ff3fb13ff368b4093c8b4ef34df7 Gerrit-Change-Number: 10672 Gerrit-PatchSet: 4 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sailesh Mukil
[Impala-ASF-CR] IMPALA-7158: Fix HdfsScanNodeBase::progress 's init
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10672 ) Change subject: IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2a738edea80ff3fb13ff368b4093c8b4ef34df7 Gerrit-Change-Number: 10672 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Tue, 12 Jun 2018 20:59:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/10679 )
Change subject: IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc
..
Patch Set 3:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/10679/3/be/src/runtime/sorter-ir.cc
File be/src/runtime/sorter-ir.cc:
http://gerrit.cloudera.org:8080/#/c/10679/3/be/src/runtime/sorter-ir.cc@28
PS3, Line 28: void Sorter::TupleIterator::NextPage
Does this need to be cross-compiled ?
http://gerrit.cloudera.org:8080/#/c/10679/3/be/src/runtime/sorter-ir.cc@39
PS3, Line 39: void Sorter::TupleIterator::PrevPage
Does this need to be cross-compiled ?
http://gerrit.cloudera.org:8080/#/c/10679/3/be/src/runtime/sorter-ir.cc@51
PS3, Line 51: void Sorter::TupleIterator::Next(
Does this need to be cross-compiled ?
http://gerrit.cloudera.org:8080/#/c/10679/3/be/src/runtime/sorter-ir.cc@185
PS3, Line 185: Tuple* Sorter::TupleSorter::SelectPivot(TupleIterator begin,
TupleIterator end) {
Does this need to be cross-compiled ?
http://gerrit.cloudera.org:8080/#/c/10679/3/be/src/runtime/sorter-ir.cc@209
PS3, Line 209: Tuple* Sorter::TupleSorter::MedianOfThree(Tuple* t1, Tuple* t2,
Tuple* t3) {
Does this need to be cross-compiled ?
http://gerrit.cloudera.org:8080/#/c/10679/3/be/src/runtime/sorter-ir.cc@245
PS3, Line 245: void Sorter::TupleSorter::Swap(Tuple* left, Tuple* right, Tuple*
swap_tuple,
Does this need to be cross-compiled ?
--
To view, visit http://gerrit.cloudera.org:8080/10679
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaf2b75c2f789002c42939865c018f728d29a113
Gerrit-Change-Number: 10679
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Tianyi Wang
Gerrit-Reviewer: Tim Armstrong
Gerrit-Comment-Date: Tue, 12 Jun 2018 20:54:16 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7102: Disable support of erasure coding by default
Anonymous Coward #389 has posted comments on this change. ( http://gerrit.cloudera.org:8080/10646 ) Change subject: IMPALA-7102: Disable support of erasure coding by default .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10646/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: PS1: Can we massage the error message a bit? Queries involving scans of HDFS erasure-coded file is not supported? -- To view, visit http://gerrit.cloudera.org:8080/10646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd3b1754541262467a6e67068b0b447882a40fb3 Gerrit-Change-Number: 10646 Gerrit-PatchSet: 1 Gerrit-Owner: Taras Bobrovytsky Gerrit-Reviewer: Anonymous Coward #389 Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Jun 2018 20:48:37 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7135. Skeleton implementation of LocalCatalog
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10627 ) Change subject: IMPALA-7135. Skeleton implementation of LocalCatalog .. Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/10627/3/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/10627/3/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java@35 PS3, Line 35: * (filesystem, HMS, etc with no caching. nit: ")" http://gerrit.cloudera.org:8080/#/c/10627/3/fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java: http://gerrit.cloudera.org:8080/#/c/10627/3/fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java@30 PS3, Line 30: into LocalCatalog Is it required/intended to be so specific? Nothing here restricts which process reads metadata or what it does with it. This looks more like a federation api. I'd just replace the last two words with a "see LocalCatalog for an example". -- To view, visit http://gerrit.cloudera.org:8080/10627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab653371188b21c72f50ee1ec4e94950aa6fb9ee Gerrit-Change-Number: 10627 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 12 Jun 2018 20:43:54 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 19: Another clang-tidy error in promise-test and a flaky test: 06:24:42 query_test/test_udfs.py:438: in test_mem_limits 06:24:42 self._check_exception(e) 06:24:42 query_test/test_udfs.py:52: in _check_exception 06:24:42 raise e 06:24:42 E ImpalaBeeswaxException: ImpalaBeeswaxException: 06:24:42 EQuery aborted:Rejected query from pool default-pool: minimum memory reservation is greater than memory available to the query for buffer reservations. Memory reservation needed given the current plan: 32.00 KB. Set mem_limit to at least 32.03 MB. Note that changing the mem_limit may also change the plan. See the query profile for more information about the per-node memory requirements. -- To view, visit http://gerrit.cloudera.org:8080/10060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I989cf5b259afb8f5bc5c35590c94961c81ce88bf Gerrit-Change-Number: 10060 Gerrit-PatchSet: 19 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Jun 2018 20:35:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6929: Support multi-column range partitions for Kudu
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10441 ) Change subject: IMPALA-6929: Support multi-column range partitions for Kudu .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2644/ -- To view, visit http://gerrit.cloudera.org:8080/10441 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0141dd3344a4f22b186f513b7406f286668ef1e7 Gerrit-Change-Number: 10441 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 12 Jun 2018 20:35:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6929: Support multi-column range partitions for Kudu
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10441 ) Change subject: IMPALA-6929: Support multi-column range partitions for Kudu .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10441 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0141dd3344a4f22b186f513b7406f286668ef1e7 Gerrit-Change-Number: 10441 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 12 Jun 2018 20:35:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6929: Support multi-column range partitions for Kudu
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10441 ) Change subject: IMPALA-6929: Support multi-column range partitions for Kudu .. Patch Set 2: This change is small and low risk, so I think we can go ahead and merge it -- To view, visit http://gerrit.cloudera.org:8080/10441 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0141dd3344a4f22b186f513b7406f286668ef1e7 Gerrit-Change-Number: 10441 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 12 Jun 2018 20:35:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10669 ) Change subject: IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance .. Patch Set 3: Code-Review+2 Rebase, carry +2. -- To view, visit http://gerrit.cloudera.org:8080/10669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0445950385fa6160764feaed9a993fa0e59b242 Gerrit-Change-Number: 10669 Gerrit-PatchSet: 3 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Tue, 12 Jun 2018 20:33:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10669 ) Change subject: IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2643/ -- To view, visit http://gerrit.cloudera.org:8080/10669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0445950385fa6160764feaed9a993fa0e59b242 Gerrit-Change-Number: 10669 Gerrit-PatchSet: 3 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Tue, 12 Jun 2018 20:33:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7144: Re-enable TestDescribeTableResults
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10643 ) Change subject: IMPALA-7144: Re-enable TestDescribeTableResults .. IMPALA-7144: Re-enable TestDescribeTableResults This patch makes the TestDescribeTableResults more robust by only comparing the information that the authorization cares about instead of comparing all output in DESCRIBE. This change will avoid any unnecessary changes to AuthorizationTest if HMS updates the DESCRIBE output. The test is also updated to support standalone execution without relying on other tests be executed first since it can cause the test to be flaky especially if the tests in AuthorizationTest are executed in parallel. Testing: - Ran all FE tests Cherry-picks: not for 2.x Change-Id: I3aeaecf5b6d906a66d338e165a6d506e3964563f Reviewed-on: http://gerrit.cloudera.org:8080/10643 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java 1 file changed, 174 insertions(+), 186 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3aeaecf5b6d906a66d338e165a6d506e3964563f Gerrit-Change-Number: 10643 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7144: Re-enable TestDescribeTableResults
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10643 ) Change subject: IMPALA-7144: Re-enable TestDescribeTableResults .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aeaecf5b6d906a66d338e165a6d506e3964563f Gerrit-Change-Number: 10643 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 12 Jun 2018 20:29:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 6: We could go ahead with this one I think, if the reviewers are ok with it. -- To view, visit http://gerrit.cloudera.org:8080/10541 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2feae34026a7e63f3d31489f757f093a73ca5d2c Gerrit-Change-Number: 10541 Gerrit-PatchSet: 6 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Jun 2018 20:25:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments
Tim Armstrong has removed a vote on this change. Change subject: IMPALA-2751: Matching quotes are not required in comments .. Removed Code-Review-2 by Tim Armstrong -- To view, visit http://gerrit.cloudera.org:8080/10541 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I2feae34026a7e63f3d31489f757f093a73ca5d2c Gerrit-Change-Number: 10541 Gerrit-PatchSet: 6 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Change variables to make the code easier to read
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10699 ) Change subject: Change variables to make the code easier to read .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic98a79dba428d3307854a414d52742efa6bad0f7 Gerrit-Change-Number: 10699 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Bharath Vissapragada Gerrit-Comment-Date: Tue, 12 Jun 2018 20:17:58 + Gerrit-HasComments: No
[Impala-ASF-CR] Optimize dependencies for Codegen
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10688 ) Change subject: Optimize dependencies for Codegen .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3294cd27c2d35388a04934440a1d2b0ba3a0dd9 Gerrit-Change-Number: 10688 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 12 Jun 2018 19:15:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3816, IMPALA-4065: Remove the indirection to TupleRowComparator::Compare()
Tianyi Wang has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10680 ) Change subject: IMPALA-3816, IMPALA-4065: Remove the indirection to TupleRowComparator::Compare() .. IMPALA-3816, IMPALA-4065: Remove the indirection to TupleRowComparator::Compare() This patch removes the indirection of codegened TupleRowComparator:: Compare() at its call sites in sorter and topn node. It's implemented by cloning and modifying all the functions between the codegened entry function and Compare(). TPCH queries with a sort node are 2%-5% faster. The call site in SortedRunMerger is still indirect, but the indirection could be removed in the same way as this patch. Change-Id: If4657ac09daf20408797856d94521d417d8cf171 --- M be/src/codegen/gen_ir_descriptions.py M be/src/codegen/llvm-codegen.cc M be/src/codegen/llvm-codegen.h M be/src/exec/exchange-node.cc M be/src/exec/topn-node.cc M be/src/runtime/data-stream-test.cc M be/src/runtime/sorted-run-merger.cc M be/src/runtime/sorter-internal.h M be/src/runtime/sorter.cc M be/src/util/tuple-row-compare.cc M be/src/util/tuple-row-compare.h A tests/custom_cluster/test_replace_tuple_row_compare.py 12 files changed, 404 insertions(+), 214 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/10680/3 -- To view, visit http://gerrit.cloudera.org:8080/10680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If4657ac09daf20408797856d94521d417d8cf171 Gerrit-Change-Number: 10680 Gerrit-PatchSet: 3 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tianyi Wang
[Impala-ASF-CR] IMPALA-7145: fix leak of OpenSSL context when spilling
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10666 ) Change subject: IMPALA-7145: fix leak of OpenSSL context when spilling .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98760ed8f31b18b489a156f945c29c95c9bf3184 Gerrit-Change-Number: 10666 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Jun 2018 18:45:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7145: fix leak of OpenSSL context when spilling
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10666 ) Change subject: IMPALA-7145: fix leak of OpenSSL context when spilling .. Patch Set 9: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2642/ -- To view, visit http://gerrit.cloudera.org:8080/10666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98760ed8f31b18b489a156f945c29c95c9bf3184 Gerrit-Change-Number: 10666 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Jun 2018 18:45:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7145: fix leak of OpenSSL context when spilling
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10666 ) Change subject: IMPALA-7145: fix leak of OpenSSL context when spilling .. Patch Set 8: Code-Review+2 carry -- To view, visit http://gerrit.cloudera.org:8080/10666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98760ed8f31b18b489a156f945c29c95c9bf3184 Gerrit-Change-Number: 10666 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Jun 2018 18:44:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7145: fix leak of OpenSSL context when spilling
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10666 to look at the new patch set (#8). Change subject: IMPALA-7145: fix leak of OpenSSL context when spilling .. IMPALA-7145: fix leak of OpenSSL context when spilling Add a RAII wrapper for the OpenSSL context that automatically frees on all exit paths from the function. Add a backend test wrapper that enables LeakSanitizer for an individual test. This is a step towards IMPALA-2746. Fix version check bug in asan.h. Testing: Enable LeakSanitizer for openssl-util-test. This reliably found the bug. Ran core tests under ASAN. Change-Id: I98760ed8f31b18b489a156f945c29c95c9bf3184 --- M be/CMakeLists.txt M be/src/util/CMakeLists.txt M be/src/util/asan.h M be/src/util/openssl-util.cc 4 files changed, 38 insertions(+), 14 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/10666/8 -- To view, visit http://gerrit.cloudera.org:8080/10666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I98760ed8f31b18b489a156f945c29c95c9bf3184 Gerrit-Change-Number: 10666 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-7145: fix leak of OpenSSL context when spilling
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10666 ) Change subject: IMPALA-7145: fix leak of OpenSSL context when spilling .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/10666/7/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/10666/7/be/src/util/openssl-util.cc@103 PS7, Line 103: > DISALLOW_COPY_AND_ASSIGN(ScopedEVPCipherCtx); Done -- To view, visit http://gerrit.cloudera.org:8080/10666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98760ed8f31b18b489a156f945c29c95c9bf3184 Gerrit-Change-Number: 10666 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Jun 2018 18:44:15 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc
Tianyi Wang has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10679 ) Change subject: IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc .. IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc To inline calls to Compare() in TupleSorter, we need to cross compile TupleSorter to LLVM-IR first. This patch also adopted some clang-tidy suggestions including using nullptr. Change-Id: Iaaf2b75c2f789002c42939865c018f728d29a113 --- M be/src/codegen/impala-ir.cc M be/src/runtime/CMakeLists.txt A be/src/runtime/sorter-internal.h A be/src/runtime/sorter-ir.cc M be/src/runtime/sorter.cc 5 files changed, 907 insertions(+), 823 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/10679/3 -- To view, visit http://gerrit.cloudera.org:8080/10679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iaaf2b75c2f789002c42939865c018f728d29a113 Gerrit-Change-Number: 10679 Gerrit-PatchSet: 3 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR](2.x) IMPALA-6394: Disable dfs.namenode.replication.considerLoad
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10664 ) Change subject: IMPALA-6394: Disable dfs.namenode.replication.considerLoad .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10664 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I00010107cbd61bffa38ed8af4395b3a0e3d13c13 Gerrit-Change-Number: 10664 Gerrit-PatchSet: 4 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Tue, 12 Jun 2018 18:37:29 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6394: Disable dfs.namenode.replication.considerLoad
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10664 ) Change subject: IMPALA-6394: Disable dfs.namenode.replication.considerLoad .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2641/ -- To view, visit http://gerrit.cloudera.org:8080/10664 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I00010107cbd61bffa38ed8af4395b3a0e3d13c13 Gerrit-Change-Number: 10664 Gerrit-PatchSet: 4 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Tue, 12 Jun 2018 18:35:36 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6394: Disable dfs.namenode.replication.considerLoad
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10664 ) Change subject: IMPALA-6394: Disable dfs.namenode.replication.considerLoad .. Patch Set 4: The failure is IMPALA-7156 -- To view, visit http://gerrit.cloudera.org:8080/10664 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I00010107cbd61bffa38ed8af4395b3a0e3d13c13 Gerrit-Change-Number: 10664 Gerrit-PatchSet: 4 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Tue, 12 Jun 2018 18:35:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10421 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c44cc9312c062cc7a5a4ac9156ceaa31fb887ff Gerrit-Change-Number: 10421 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Jun 2018 18:15:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2640/ -- To view, visit http://gerrit.cloudera.org:8080/10421 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c44cc9312c062cc7a5a4ac9156ceaa31fb887ff Gerrit-Change-Number: 10421 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Jun 2018 18:15:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 4: Code-Review+2 Rebase. Carry +2. -- To view, visit http://gerrit.cloudera.org:8080/10421 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c44cc9312c062cc7a5a4ac9156ceaa31fb887ff Gerrit-Change-Number: 10421 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Jun 2018 18:14:18 + Gerrit-HasComments: No
[Impala-ASF-CR] Change variables to make the code easier to read
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10699 Change subject: Change variables to make the code easier to read .. Change variables to make the code easier to read Change-Id: Ic98a79dba428d3307854a414d52742efa6bad0f7 --- M bin/diagnostics/collect_shared_libs.sh 1 file changed, 10 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/10699/1 -- To view, visit http://gerrit.cloudera.org:8080/10699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic98a79dba428d3307854a414d52742efa6bad0f7 Gerrit-Change-Number: 10699 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker
[Impala-ASF-CR] IMPALA-6835: Add table name and node id to Kudu scanner errors
Pooja Nilangekar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10671 ) Change subject: IMPALA-6835: Add table name and node id to Kudu scanner errors .. IMPALA-6835: Add table name and node id to Kudu scanner errors Previously, the error messages in KuduScanner only contained the reason for failure. They did not contain the KuduTable name or the TPlanNode id which made it inconveient to debug. This change adds the TPlanNode id to all error messages and the KuduTable name whenever applicable. This change was manually tested by explicitly returning failure while scanning kudu tables. Change-Id: I0377fc8591738dc45092d228fcf292ddbb367825 --- M be/src/exec/kudu-scanner.cc M be/src/exec/kudu-scanner.h M be/src/exec/kudu-util.h 3 files changed, 27 insertions(+), 14 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/10671/3 -- To view, visit http://gerrit.cloudera.org:8080/10671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0377fc8591738dc45092d228fcf292ddbb367825 Gerrit-Change-Number: 10671 Gerrit-PatchSet: 3 Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-7115: set a default THREAD RESERVATION LIMIT value
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10628 ) Change subject: IMPALA-7115: set a default THREAD_RESERVATION_LIMIT value .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10628/1/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: http://gerrit.cloudera.org:8080/#/c/10628/1/common/thrift/ImpalaInternalService.thrift@287 PS1, Line 287: 3000 it'd be good to include some explanation as to how this was chosen. -- To view, visit http://gerrit.cloudera.org:8080/10628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I31d3fa3f6305c360922649dba53a9026c9563384 Gerrit-Change-Number: 10628 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Comment-Date: Tue, 12 Jun 2018 17:35:58 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7158: Fix HdfsScanNodeBase::progress 's init
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10672 ) Change subject: IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2639/ -- To view, visit http://gerrit.cloudera.org:8080/10672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2a738edea80ff3fb13ff368b4093c8b4ef34df7 Gerrit-Change-Number: 10672 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Jun 2018 17:35:36 + Gerrit-HasComments: No
