[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 6: Verify tests fail in test_time_travel. It

[Impala-ASF-CR] IMPALA-11375 Impala shell outputs details of each RPC

2023-01-04 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19388 ) Change subject: IMPALA-11375 Impala shell outputs details of each RPC .. Patch Set 9: (22 comments) Generally looks good...

[Impala-ASF-CR] IMPALA-11826: Avoid calling planFiles() on Iceberg V2 tables when there are no predicates

2023-01-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19419 ) Change subject: IMPALA-11826: Avoid calling planFiles() on Iceberg V2 tables when there are no predicates .. Patch Set 2:

[Impala-ASF-CR] IMPALA-11375 Impala shell outputs details of each RPC

2023-01-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19388 ) Change subject: IMPALA-11375 Impala shell outputs details of each RPC .. Patch Set 15: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-09 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 4: (3 comments) Thanks for the comments

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-09 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. IMPALA-10893: Use old schema during iceberg time travel.

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-11 Thread Andrew Sherman (Code Review)
Hello Tamas Mate, Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19380 to look at the new patch set (#7). Change subject: IMPALA-10893: Use old schema during iceberg time travel.

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-11 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 7: The gerrit-verify-dryrun tests run the

[Impala-ASF-CR] [tools] Add inline pom.py script for development

2022-12-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19314 ) Change subject: [tools] Add inline_pom.py script for development .. Patch Set 4: Code-Review+2 (3 comments) Looks good, please

[Impala-ASF-CR] IMPALA-11767: Ignore exceptions for invalid paths in Hudi search

2022-12-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19312 ) Change subject: IMPALA-11767: Ignore exceptions for invalid paths in Hudi search .. Patch Set 3: Code-Review+2 Thanks for the quick

[Impala-ASF-CR] IMPALA-11767: Catch exceptions for invalid paths in Hudi search

2022-12-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19312 ) Change subject: IMPALA-11767: Catch exceptions for invalid paths in Hudi search .. Patch Set 1: Code-Review+2 (2 comments) LGTM

[Impala-ASF-CR] IMPALA-11715: test resource limits kudu fails

2022-12-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19288 ) Change subject: IMPALA-11715: test_resource_limits_kudu fails .. Patch Set 2: Code-Review+2 LGTM, thanks -- To view, visit

[Impala-ASF-CR] IMPALA-11787, IMPALA-11516: Cardinality estimate for UNION in Iceberg position-delete plans can double the actual table cardinality

2022-12-14 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19354 ) Change subject: IMPALA-11787, IMPALA-11516: Cardinality estimate for UNION in Iceberg position-delete plans can double the actual table cardinality

[Impala-ASF-CR] IMPALA-11787: Cardinality estimate for UNION in Iceberg position-delete plans can double the actual table cardinality

2022-12-13 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19354 ) Change subject: IMPALA-11787: Cardinality estimate for UNION in Iceberg position-delete plans can double the actual table cardinality

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2022-12-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19380 Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. IMPALA-10893: Use old schema during iceberg time travel.

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2022-12-20 Thread Andrew Sherman (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19380 to look at the new patch set (#2). Change subject: IMPALA-10893: Use old schema during iceberg time travel.

[Impala-ASF-CR] IMPALA-11726 Make impala-shell work with kerberos authentication

2022-11-15 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19248 ) Change subject: IMPALA-11726 Make impala-shell work with kerberos authentication .. Patch Set 3: (3 comments) Quick comments

[Impala-ASF-CR] IMPALA-11850 Adds HTTP tracing headers when using the hs2-http protocol.

2023-01-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19428 ) Change subject: IMPALA-11850 Adds HTTP tracing headers when using the hs2-http protocol. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-11013 (part 1): Support 'MIGRATE TABLE' for external Hdfs tables

2023-01-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19397 ) Change subject: IMPALA-11013 (part 1): Support 'MIGRATE TABLE' for external Hdfs tables .. Patch Set 6: (3 comments) This seems a

[Impala-ASF-CR] IMPALA-11850 Adds HTTP tracing headers when using the hs2-http protocol.

2023-01-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19428 ) Change subject: IMPALA-11850 Adds HTTP tracing headers when using the hs2-http protocol. .. Patch Set 6: (3 comments) A few more

[Impala-ASF-CR] IMPALA-11850 Adds HTTP tracing headers when using the hs2-http protocol.

2023-01-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19428 ) Change subject: IMPALA-11850 Adds HTTP tracing headers when using the hs2-http protocol. .. Patch Set 6: (2 comments) More

[Impala-ASF-CR] IMPALA-11617: Pool service should be made aware of cpu core limit

2023-01-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19366 ) Change subject: IMPALA-11617: Pool service should be made aware of cpu core limit .. Patch Set 4: (1 comment) Just questions, I'm

[Impala-ASF-CR] IMPALA-11662: Improve 'refresh iceberg tbl on oss' performance

2023-01-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19379 ) Change subject: IMPALA-11662: Improve 'refresh iceberg_tbl_on_oss' performance .. Patch Set 9: Code-Review+2 LGTM -- To view,

[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19447 ) Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. IMPALA-11862: [DOCS] Document the default

[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19447 ) Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. Patch Set 2: (2 comments) Thanks for

[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19447 ) Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19447 Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. IMPALA-11862: [DOCS] Document the default

[Impala-ASF-CR] IMPALA-11617: Pool service should be made aware of cpu core limit

2023-01-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19366 ) Change subject: IMPALA-11617: Pool service should be made aware of cpu core limit .. Patch Set 5: Code-Review+2 Thanks for the

[Impala-ASF-CR] IMPALA-11856: Use POST requests to set log level

2023-01-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19199 ) Change subject: IMPALA-11856: Use POST requests to set log level .. Patch Set 20: Code-Review+2 (3 comments) LGTM, thanks for this

[Impala-ASF-CR] IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema.

2023-01-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19420 ) Change subject: IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema. .. IMPALA-11835: [DOCS] Document

[Impala-ASF-CR] IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema.

2023-01-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/19420 ) Change subject: IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema. .. IMPALA-11835: [DOCS] Document

[Impala-ASF-CR] IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema.

2023-01-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19420 ) Change subject: IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema.

2023-01-15 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19420 Change subject: IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema. .. IMPALA-11835: [DOCS] Document

[Impala-ASF-CR] IMPALA-11850 Adds HTTP tracing headers when using the hs2-http protocol.

2023-01-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19428 ) Change subject: IMPALA-11850 Adds HTTP tracing headers when using the hs2-http protocol. .. Patch Set 3: (11 comments) A few quick

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-06 Thread Andrew Sherman (Code Review)
Hello Tamas Mate, Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19380 to look at the new patch set (#3). Change subject: IMPALA-10893: Use old schema during iceberg time travel.

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-11-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19043 ) Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables .. Patch Set 8: Code-Review+2 LGTM (I think all other

[Impala-ASF-CR] IMPALA-11596: [DOCS] Document EXECUTE ROLLBACK functionality

2023-03-09 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19606 Change subject: IMPALA-11596: [DOCS] Document EXECUTE ROLLBACK functionality .. IMPALA-11596: [DOCS] Document EXECUTE ROLLBACK

[Impala-ASF-CR] IMPALA-11964: Make sure Impala returns error for Iceberg tables with equality deletes

2023-03-09 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19601 ) Change subject: IMPALA-11964: Make sure Impala returns error for Iceberg tables with equality deletes .. Patch Set 2: Code-Review+1

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

2023-03-16 Thread Andrew Sherman (Code Review)
Hello Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19509 to look at the new patch set (#9). Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is

[Impala-ASF-CR] IMPALA-11999: Ensure iceberg catalog location has correct filesystem prefix for Ozone

2023-03-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19629 ) Change subject: IMPALA-11999: Ensure iceberg catalog location has correct filesystem prefix for Ozone .. Patch Set 2: Thanks, I'm

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

2023-03-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 ) Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing. .. Patch Set 9: PS 9 is a rebase to fix

[Impala-ASF-CR] IMPALA-12017: Skip memory and cpu limit check if REQUEST POOL is set

2023-03-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19645 ) Change subject: IMPALA-12017: Skip memory and cpu limit check if REQUEST_POOL is set .. Patch Set 2: (4 comments) A few quick

[Impala-ASF-CR] IMPALA-12017: Skip memory and cpu limit check if REQUEST POOL is set

2023-03-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19645 ) Change subject: IMPALA-12017: Skip memory and cpu limit check if REQUEST_POOL is set .. Patch Set 4: Code-Review+2 LGTM -- To

[Impala-ASF-CR] IMPALA-11596: [DOCS] Document EXECUTE ROLLBACK functionality

2023-03-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19606 ) Change subject: IMPALA-11596: [DOCS] Document EXECUTE ROLLBACK functionality .. IMPALA-11596: [DOCS] Document EXECUTE ROLLBACK

[Impala-ASF-CR] IMPALA-11596: [DOCS] Document EXECUTE ROLLBACK functionality

2023-03-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19606 ) Change subject: IMPALA-11596: [DOCS] Document EXECUTE ROLLBACK functionality .. Patch Set 1: (1 comment) Thanks for the quick

[Impala-ASF-CR] IMPALA-12023: Skip resource checking on last executor group set

2023-03-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19649 ) Change subject: IMPALA-12023: Skip resource checking on last executor group set .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12015: enable healthz endpoint in admissiond webui

2023-03-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19647 ) Change subject: IMPALA-12015: enable healthz endpoint in admissiond webui .. Patch Set 1: (1 comment) quick question

[Impala-ASF-CR] IMPALA-12015: enable healthz endpoint in admissiond webui

2023-03-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19647 ) Change subject: IMPALA-12015: enable healthz endpoint in admissiond webui .. Patch Set 4: Code-Review+2 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-11999: Ensure iceberg catalog location has correct filesystem prefix for Ozone

2023-03-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19629 Change subject: IMPALA-11999: Ensure iceberg catalog location has correct filesystem prefix for Ozone .. IMPALA-11999: Ensure iceberg

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

2023-03-16 Thread Andrew Sherman (Code Review)
Hello Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19509 to look at the new patch set (#8). Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

2023-03-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 ) Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing. .. Patch Set 4: (1 comment) Thanks for the

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

2023-03-07 Thread Andrew Sherman (Code Review)
Hello Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19509 to look at the new patch set (#6). Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

2023-03-07 Thread Andrew Sherman (Code Review)
Hello Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19509 to look at the new patch set (#7). Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is

[Impala-ASF-CR] chnage zoltan's test 3/3 IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2023-03-07 Thread Andrew Sherman (Code Review)
Hello Tamas Mate, Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19002 to look at the new patch set (#10). Change subject: chnage zoltan's test 3/3 IMPALA-11482: Alter Table

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2023-03-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19002 ) Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. Patch Set 9: (1 comment) The big change here is

[Impala-ASF-CR] IMPALA-11858: Cap per backend memory estimate to its memory limit for admission

2023-03-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19533 ) Change subject: IMPALA-11858: Cap per backend memory estimate to its memory limit for admission .. Patch Set 7: Code-Review+1 (3

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2023-03-07 Thread Andrew Sherman (Code Review)
Hello Tamas Mate, Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19002 to look at the new patch set (#11). Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg

[Impala-ASF-CR] IMPALA-11858: Cap per backend memory estimate to its memory limit for admission

2023-03-11 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19533 ) Change subject: IMPALA-11858: Cap per backend memory estimate to its memory limit for admission .. Patch Set 12: Code-Review+2 LGTM

[Impala-ASF-CR] rm line

2023-02-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has abandoned this change. ( http://gerrit.cloudera.org:8080/19542 ) Change subject: rm line .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/19542 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-11479: Add Java unit tests for IcebergUtil.

2023-02-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has abandoned this change. ( http://gerrit.cloudera.org:8080/19541 ) Change subject: IMPALA-11479: Add Java unit tests for IcebergUtil. .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/19541 To

[Impala-ASF-CR] IMPALA-11479: Add Java unit tests for IcebergUtil.

2023-02-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19543 Change subject: IMPALA-11479: Add Java unit tests for IcebergUtil. .. IMPALA-11479: Add Java unit tests for IcebergUtil. This does

[Impala-ASF-CR] IMPALA-11330: Add test for missing iceberg metadata directory.

2023-02-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has abandoned this change. ( http://gerrit.cloudera.org:8080/18818 ) Change subject: IMPALA-11330: Add test for missing iceberg metadata directory. .. Abandoned superseded by

[Impala-ASF-CR] IMPALA-11479: Add Java unit tests for IcebergUtil.

2023-02-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19541 Change subject: IMPALA-11479: Add Java unit tests for IcebergUtil. .. IMPALA-11479: Add Java unit tests for IcebergUtil. This does

[Impala-ASF-CR] rm line

2023-02-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19542 Change subject: rm line .. rm line Change-Id: I9e265a2174d2a8550de81dfde1d2f767ff96642f --- M

[Impala-ASF-CR] IMPALA-11947: Bump GBN to get Iceberg change #6074

2023-02-26 Thread Andrew Sherman (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19538 to look at the new patch set (#2). Change subject: IMPALA-11947: Bump GBN to get Iceberg change #6074 ..

[Impala-ASF-CR] IMPALA-11922 Verify JWKS URL server TLS certificate by default.

2023-02-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19503 ) Change subject: IMPALA-11922 Verify JWKS URL server TLS certificate by default. .. Patch Set 6: (11 comments) Mostly comments about

[Impala-ASF-CR] IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.

2023-02-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 ) Change subject: IMPALA-11509: Prevent query hanging when Iceberg metadata is missing. .. Patch Set 2: (2 comments) Thanks for the

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2023-03-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/19002 ) Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. IMPALA-11482: Alter Table Execute Rollback for

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2023-03-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19002 ) Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. Patch Set 9: I had to rebase to get the upstream

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2023-03-03 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19002 ) Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. Patch Set 9: (9 comments) Comments ahead of next

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

2023-03-03 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 ) Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing. .. Patch Set 4: (2 comments) Thanks for

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

2023-03-03 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/19509 ) Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing. .. IMPALA-11509: Prevent queries hanging when

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

2023-03-04 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 ) Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing. .. Patch Set 5: recheck -- To view, visit

[Impala-ASF-CR] IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.

2023-02-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19509 Change subject: IMPALA-11509: Prevent query hanging when Iceberg metadata is missing. .. IMPALA-11509: Prevent query hanging when

[Impala-ASF-CR] IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.

2023-02-16 Thread Andrew Sherman (Code Review)
Hello Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19509 to look at the new patch set (#2). Change subject: IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.

[Impala-ASF-CR] IMPALA-11940: [DOCS] Document manifest caching settings for Iceberg

2023-02-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19530 ) Change subject: IMPALA-11940: [DOCS] Document manifest caching settings for Iceberg .. Patch Set 2: (7 comments) I did a quick

[Impala-ASF-CR] IMPALA-11922 Verify JWKS URL server TLS certificate by default.

2023-02-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19503 ) Change subject: IMPALA-11922 Verify JWKS URL server TLS certificate by default. .. Patch Set 8: Code-Review+2 Oh I see Alexey gave

[Impala-ASF-CR] IMPALA-11922 Verify JWKS URL server TLS certificate by default.

2023-02-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19503 ) Change subject: IMPALA-11922 Verify JWKS URL server TLS certificate by default. .. Patch Set 8: Code-Review+1 LGTM -- To view,

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

2023-02-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/19509 ) Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing. .. IMPALA-11509: Prevent queries hanging when

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

2023-02-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 ) Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing. .. Patch Set 2: (2 comments) Narrowed the

[Impala-ASF-CR] IMPALA-11633: Use longer ctas timeout for S3/Ozone

2023-03-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19497 ) Change subject: IMPALA-11633: Use longer ctas timeout for S3/Ozone .. Patch Set 2: Code-Review+2 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

2023-02-23 Thread Andrew Sherman (Code Review)
Hello Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19509 to look at the new patch set (#4). Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is

[Impala-ASF-CR] WIP IMPALA-11947: Bump GBN to get Iceberg change #6074

2023-02-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19538 Change subject: WIP IMPALA-11947: Bump GBN to get Iceberg change #6074 .. WIP IMPALA-11947: Bump GBN to get Iceberg change #6074 We

[Impala-ASF-CR] IMPALA-11945: Fix Flaky Test in JwtHttpTest

2023-02-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19536 ) Change subject: IMPALA-11945: Fix Flaky Test in JwtHttpTest .. Patch Set 5: Code-Review+1 LGTM, I'll let Riza take this to +2 --

[Impala-ASF-CR] IMPALA-11945: Fix Flaky Test in JwtHttpTest

2023-02-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19536 ) Change subject: IMPALA-11945: Fix Flaky Test in JwtHttpTest .. Patch Set 4: (1 comment) I have a suggestion which you can push back

[Impala-ASF-CR] IMPALA-12028: test execute rollback might fail due to used timezone

2023-03-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19655 ) Change subject: IMPALA-12028: test_execute_rollback might fail due to used timezone .. Patch Set 2: Code-Review+2 LGTM -- To

[Impala-ASF-CR] IMPALA-12031: Add security-related HTTP headers

2023-03-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19661 ) Change subject: IMPALA-12031: Add security-related HTTP headers .. Patch Set 1: (2 comments) Looks good, I have one suggestion then

[Impala-ASF-CR] IMPALA-12031: Add security-related HTTP headers

2023-03-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19661 ) Change subject: IMPALA-12031: Add security-related HTTP headers .. Patch Set 2: Code-Review+2 Thanks for the fix -- To view, visit

[Impala-ASF-CR] IMPALA-12034: Use more portable filesystem client instead of hdfs client.

2023-03-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19672 Change subject: IMPALA-12034: Use more portable filesystem_client instead of hdfs_client. .. IMPALA-12034: Use more portable

[Impala-ASF-CR] IMPALA-12039: graceful shutdown doesn't work in redhat docker image

2023-04-08 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19711 ) Change subject: IMPALA-12039: graceful shutdown doesn't work in redhat docker image .. Patch Set 1: Code-Review+2 LGTM -- To

[Impala-ASF-CR] IMPALA-12039 (addendum): Verify presence of pgrep during docker build

2023-04-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19713 ) Change subject: IMPALA-12039 (addendum): Verify presence of pgrep during docker build .. Patch Set 1: Code-Review+2 LGTM -- To

[Impala-ASF-CR] IMPALA-12050: Exclude kryo-shaded from the Java build

2023-04-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19707 Change subject: IMPALA-12050: Exclude kryo-shaded from the Java build .. IMPALA-12050: Exclude kryo-shaded from the Java build Kryo

[Impala-ASF-CR] IMPALA-12037: Update Chart.js to 2.9.4

2023-04-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19683 ) Change subject: IMPALA-12037: Update Chart.js to 2.9.4 .. Patch Set 2: Code-Review+2 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-11850 Adds HTTP tracing headers when using the hs2-http protocol.

2023-02-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19428 ) Change subject: IMPALA-11850 Adds HTTP tracing headers when using the hs2-http protocol. .. Patch Set 7: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-11859: Add bytes-read-encrypted metric

2023-01-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19461 ) Change subject: IMPALA-11859: Add bytes-read-encrypted metric .. Patch Set 3: Code-Review+2 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-11913: Upgrade datatables to 1.13.2

2023-02-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19489 ) Change subject: IMPALA-11913: Upgrade datatables to 1.13.2 .. Patch Set 1: Code-Review+2 I built the change and looked at the webui

[Impala-ASF-CR] IMPALA-12150: Use protocol version to isolate cluster components

2023-06-14 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19959 ) Change subject: IMPALA-12150: Use protocol version to isolate cluster components .. Patch Set 13: (12 comments) More nits based on

[Impala-ASF-CR] IMPALA-12294 Fix Cookie handling for Impala Shell with python 3

2023-07-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20216 Change subject: IMPALA-12294 Fix Cookie handling for Impala Shell with python 3 .. IMPALA-12294 Fix Cookie handling for Impala Shell

[Impala-ASF-CR] IMPALA-12295: Statestore crashed when restarting catalogd

2023-07-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20217 ) Change subject: IMPALA-12295: Statestore crashed when restarting catalogd .. Patch Set 1: Code-Review+2 (1 comment) LGTM

[Impala-ASF-CR] IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile

2023-07-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20204 ) Change subject: IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile .. Patch Set 1: Looks good, can we add

<    1   2   3   4   5   6   7   >