[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-05 Thread Bharath Vissapragada (Code Review)
Hello radford nguyen, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14143 to look at the new patch set (#8). Change subject: IMPALA-8572: Log query events before unregister.

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 8: There was a test failure with mismatched linea

[Impala-ASF-CR] IMPALA-8923: remove synchronized in HBaseTable.getEstimatedRowStats

2019-09-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14188 ) Change subject: IMPALA-8923: remove synchronized in HBaseTable.getEstimatedRowStats .. Patch Set 2: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-8923: remove synchronized in HBaseTable.getEstimatedRowStats

2019-09-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14188 ) Change subject: IMPALA-8923: remove synchronized in HBaseTable.getEstimatedRowStats .. Patch Set 3: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-8921: Use short name for Ranger grant/revoke requests

2019-09-07 Thread Bharath Vissapragada (Code Review)
Hello Quanlong Huang, Austin Nobis, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14185 to look at the new patch set (#2). Change subject: IMPALA-8921: Use short name for Ranger grant/revoke requests .

[Impala-ASF-CR] IMPALA-8921: Use short name for Ranger grant/revoke requests

2019-09-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14185 ) Change subject: IMPALA-8921: Use short name for Ranger grant/revoke requests .. Patch Set 2: Code-Review+2 Carrying +2. -- To

[Impala-ASF-CR] IMPALA-8921: Use short name for Ranger grant/revoke requests

2019-09-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14185 ) Change subject: IMPALA-8921: Use short name for Ranger grant/revoke requests .. Patch Set 1: (3 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-07 Thread Bharath Vissapragada (Code Review)
Hello radford nguyen, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14143 to look at the new patch set (#9). Change subject: IMPALA-8572: Log query events before unregister.

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 9: (7 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-8931: Fix fe trigger for lineage events

2019-09-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14194 Change subject: IMPALA-8931: Fix fe trigger for lineage events .. IMPALA-8931: Fix fe trigger for lineage events Currently, fe g

[Impala-ASF-CR] IMPALA-8931: Fix fe trigger for lineage events

2019-09-07 Thread Bharath Vissapragada (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14194 to look at the new patch set (#2). Change subject: IMPALA-8931: Fix fe trigger for lineage events .. IMPAL

[Impala-ASF-CR] IMPALA-8228: Ownership support for Ranger authz

2019-09-09 Thread Bharath Vissapragada (Code Review)
Hello Austin Nobis, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14106 to look at the new patch set (#6). Change subject: IMPALA-8228: Ownership support for Ranger authz .

[Impala-ASF-CR] IMPALA-8228: Ownership support for Ranger authz

2019-09-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14106 ) Change subject: IMPALA-8228: Ownership support for Ranger authz .. Patch Set 6: Todd, this is ready for review. Added tests. I

[Impala-ASF-CR] IMPALA-7975(continued): Improve supportability of the automatic invalidate feature.

2019-09-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has abandoned this change. ( http://gerrit.cloudera.org:8080/13947 ) Change subject: IMPALA-7975(continued): Improve supportability of the automatic invalidate feature. .. Abandoned This was submitted as

[Impala-ASF-CR] IMPALA-8932: shell shouldn't retry kerberos over http

2019-09-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14201 ) Change subject: IMPALA-8932: shell shouldn't retry kerberos over http .. Patch Set 1: Code-Review+2 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 9: I didn't get a chance to debug it but my theor

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 9: Yes, those mismatched results are definitely w

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 9: The issue is that the lineage test does querie

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-10 Thread Bharath Vissapragada (Code Review)
Hello radford nguyen, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14143 to look at the new patch set (#10). Change subject: IMPALA-8572: Log query events before unregister. ...

[Impala-ASF-CR] IMPALA-8933: Enforce ranger deny policy

2019-09-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14203 ) Change subject: IMPALA-8933: Enforce ranger deny policy .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/14203

[Impala-ASF-CR] IMPALA-8933: Enforce ranger deny policy

2019-09-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14203 ) Change subject: IMPALA-8933: Enforce ranger deny policy .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/14203/

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-10 Thread Bharath Vissapragada (Code Review)
Hello radford nguyen, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14143 to look at the new patch set (#11). Change subject: IMPALA-8572: Log query events before unregister. ...

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 11: (5 comments) Still not clear on the test fai

[Impala-ASF-CR] IMPALA-8228: Ownership support for Ranger authz

2019-09-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14106 ) Change subject: IMPALA-8228: Ownership support for Ranger authz .. Patch Set 6: (14 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-8228: Ownership support for Ranger authz

2019-09-11 Thread Bharath Vissapragada (Code Review)
Hello Austin Nobis, Fredy Wijaya, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14106 to look at the new patch set (#7). Change subject: IMPALA-8228: Ownership support for Ranger authz ...

[Impala-ASF-CR] IMPALA-8228: Ownership support for Ranger authz

2019-09-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14106 ) Change subject: IMPALA-8228: Ownership support for Ranger authz .. Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-8228: Ownership support for Ranger authz

2019-09-11 Thread Bharath Vissapragada (Code Review)
Hello Austin Nobis, Fredy Wijaya, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14106 to look at the new patch set (#8). Change subject: IMPALA-8228: Ownership support for Ranger authz ...

[Impala-ASF-CR] IMPALA-8228: Ownership support for Ranger authz

2019-09-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14106 ) Change subject: IMPALA-8228: Ownership support for Ranger authz .. Patch Set 8: The test fails because of the remnants from ear

[Impala-ASF-CR] IMPALA-8228: Ownership support for Ranger authz

2019-09-11 Thread Bharath Vissapragada (Code Review)
Hello Austin Nobis, Fredy Wijaya, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14106 to look at the new patch set (#9). Change subject: IMPALA-8228: Ownership support for Ranger authz ...

[Impala-ASF-CR] IMPALA-8228: Ownership support for Ranger authz

2019-09-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14106 ) Change subject: IMPALA-8228: Ownership support for Ranger authz .. Patch Set 9: Added a delete-retry logic in creation of test

[Impala-ASF-CR] IMPALA-8940: Fix MetastoreEventsProcessorTest.testPartitionEvents in CDP builds

2019-09-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14213 ) Change subject: IMPALA-8940: Fix MetastoreEventsProcessorTest.testPartitionEvents in CDP builds .. Patch Set 1: Code-Review+2

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-11 Thread Bharath Vissapragada (Code Review)
Hello radford nguyen, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14143 to look at the new patch set (#12). Change subject: IMPALA-8572: Log query events before unregister. ...

[Impala-ASF-CR] IMPALA-8572: Log query events before unregister.

2019-09-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before unregister. .. Patch Set 12: Code-Review+2 (1 comment) Carrying +2. I've

[Impala-ASF-CR] IMPALA-8228: Ownership support for Ranger authz

2019-09-11 Thread Bharath Vissapragada (Code Review)
Hello Austin Nobis, Fredy Wijaya, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14106 to look at the new patch set (#10). Change subject: IMPALA-8228: Ownership support for Ranger authz ..

[Impala-ASF-CR] IMPALA-8228: Ownership support for Ranger authz

2019-09-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14106 ) Change subject: IMPALA-8228: Ownership support for Ranger authz .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-8228: Ownership support for Ranger authz

2019-09-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14106 ) Change subject: IMPALA-8228: Ownership support for Ranger authz .. Patch Set 10: Any more reviews for this patch? -- To view,

[Impala-ASF-CR] IMPALA-8228: Ownership support for Ranger authz

2019-09-11 Thread Bharath Vissapragada (Code Review)
Hello Austin Nobis, Fredy Wijaya, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14106 to look at the new patch set (#11). Change subject: IMPALA-8228: Ownership support for Ranger authz ..

[Impala-ASF-CR] IMPALA-8228: Ownership support for Ranger authz

2019-09-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14106 ) Change subject: IMPALA-8228: Ownership support for Ranger authz .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-8228: Ownership support for Ranger authz

2019-09-11 Thread Bharath Vissapragada (Code Review)
Hello Austin Nobis, Fredy Wijaya, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14106 to look at the new patch set (#12). Change subject: IMPALA-8228: Ownership support for Ranger authz ..

[Impala-ASF-CR] IMPALA-8228: Ownership support for Ranger authz

2019-09-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14106 ) Change subject: IMPALA-8228: Ownership support for Ranger authz .. Patch Set 12: Code-Review+2 (2 comments) Thanks for the rev

[Impala-ASF-CR] IMPALA-8228: Ownership support for Ranger authz

2019-09-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14106 ) Change subject: IMPALA-8228: Ownership support for Ranger authz .. IMPALA-8228: Ownership support for Ranger authz With

[Impala-ASF-CR] IMPALA-8228: Ownership support for Ranger authz

2019-09-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14106 ) Change subject: IMPALA-8228: Ownership support for Ranger authz .. Patch Set 12: Verified+1 Already verified with a previous GV

[Impala-ASF-CR] IMPALA-8932: addendum - protocol var not defined

2019-09-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14225 ) Change subject: IMPALA-8932: addendum - protocol var not defined .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-7975(continued): Improve supportability of the automatic invalidate feature.

2019-09-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14200 ) Change subject: IMPALA-7975(continued): Improve supportability of the automatic invalidate feature. .. Patch Set 1: Code-Review

[Impala-ASF-CR] IMPALA-8572: Skip test lineage output on S3

2019-09-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14230 Change subject: IMPALA-8572: Skip test_lineage_output on S3 .. IMPALA-8572: Skip test_lineage_output on S3 The test has a hbase

[Impala-ASF-CR] IMPALA-8228: Fix test ownership for CentOS6

2019-09-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14231 Change subject: IMPALA-8228: Fix _test_ownership for CentOS6 .. IMPALA-8228: Fix _test_ownership for CentOS6 String format() wit

[Impala-ASF-CR] IMPALA-8228: Fix test ownership on CentOS6

2019-09-15 Thread Bharath Vissapragada (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14231 to look at the new patch set (#2). Change subject: IMPALA-8228: Fix _test_ownership on CentOS6 .. IMPALA-8

[Impala-ASF-CR] IMPALA-8572: Skip test lineage output on S3

2019-09-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14230 ) Change subject: IMPALA-8572: Skip test_lineage_output on S3 .. Patch Set 1: Thanks for the review. This test does not add any c

[Impala-ASF-CR] IMPALA-8572: Skip test lineage output on S3

2019-09-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14230 ) Change subject: IMPALA-8572: Skip test_lineage_output on S3 .. IMPALA-8572: Skip test_lineage_output on S3 The test has

[Impala-ASF-CR] IMPALA-8228: Fix test ownership on CentOS6

2019-09-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14231 ) Change subject: IMPALA-8228: Fix _test_ownership on CentOS6 .. IMPALA-8228: Fix _test_ownership on CentOS6 String forma

[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

2019-09-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14229 ) Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger .. Patch Set 1: (5 comments) http://

[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile

2019-09-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13786 ) Change subject: IMPALA-7322: Add storage wait time to profile .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

2019-09-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14229 ) Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger .. Patch Set 2: (2 comments) Couple

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-09-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 25: I'll take a deeper look at this today. Thanks for

[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

2019-09-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14229 ) Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger .. Patch Set 3: Code-Review+2 (1 comm

[Impala-ASF-CR] IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger

2019-09-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14229 ) Change subject: IMPALA-8930: [DOCS] Object ownership support when integrated with Ranger .. Patch Set 4: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-8944: Update and re-enable S3PlannerTest

2019-09-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14248 ) Change subject: IMPALA-8944: Update and re-enable S3PlannerTest .. Patch Set 1: Code-Review+1 (1 comment) I'll let Joe take an

[Impala-ASF-CR] IMPALA-8761: Improve events processor configuration validation.

2019-09-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14240 ) Change subject: IMPALA-8761: Improve events processor configuration validation. .. Patch Set 2: Code-Review+2 (4 comments) htt

[Impala-ASF-CR] IMPALA-8944: Update and re-enable S3PlannerTest

2019-09-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14248 ) Change subject: IMPALA-8944: Update and re-enable S3PlannerTest .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-8761: Improve events processor configuration validation.

2019-09-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14240 ) Change subject: IMPALA-8761: Improve events processor configuration validation. .. Patch Set 3: Code-Review+2 -- To view, visi

[Impala-ASF-CR] IMPALA-2138: part 1: initial cleanup

2019-09-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14265 ) Change subject: IMPALA-2138: part 1: initial cleanup .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-2138: part 2: clean up result expr handling

2019-09-24 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14270 ) Change subject: IMPALA-2138: part 2: clean up result expr handling .. Patch Set 8: Code-Review+2 Nice refactor. Makes sense to

[Impala-ASF-CR] IMPALA-8968: Alter database events on dropped database should not put events processor in error state.

2019-09-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14296 ) Change subject: IMPALA-8968: Alter database events on dropped database should not put events processor in error state. .. Patch

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-09-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 25: (9 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-7506: support global INVALIDATE METADATA in local catalog mode

2019-09-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14307 ) Change subject: IMPALA-7506: support global INVALIDATE METADATA in local catalog mode .. Patch Set 2: Just to capture the summ

[Impala-ASF-CR] IMPALA-8968: Alter database events on dropped database should not put events processor in error state.

2019-09-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14296 ) Change subject: IMPALA-8968: Alter database events on dropped database should not put events processor in error state. .. Patch

[Impala-ASF-CR] IMPALA-7506: support global INVALIDATE METADATA in local catalog mode

2019-10-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14307 ) Change subject: IMPALA-7506: support global INVALIDATE METADATA in local catalog mode .. Patch Set 5: (1 comment) http://gerr

[Impala-ASF-CR] IMPALA-7506: support global INVALIDATE METADATA in local catalog mode

2019-10-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14307 ) Change subject: IMPALA-7506: support global INVALIDATE METADATA in local catalog mode .. Patch Set 5: (2 comments) http://ger

[Impala-ASF-CR] Fix diagnostics path to not include the parent dir structure

2018-05-09 Thread Bharath Vissapragada (Code Review)
Hello Lars Volker, Philip Zeyliger, Kim Jin Chul, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10347 to look at the new patch set (#3). Change subject: Fix diagnostics path to not include the parent dir structure ..

[Impala-ASF-CR] Fix diagnostics path to not include the parent dir structure

2018-05-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10347 ) Change subject: Fix diagnostics path to not include the parent dir structure .. Patch Set 3: (2 comments) http://gerrit.cloude

[Impala-ASF-CR] Fix diagnostics path to not include the parent dir structure

2018-05-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10347 ) Change subject: Fix diagnostics path to not include the parent dir structure .. Patch Set 3: Code-Review+2 -- To view, visit h

[Impala-ASF-CR] IMPALA-5642: [DOCS] An additional restriction for Hive/Java UDFs

2018-05-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10520 ) Change subject: IMPALA-5642: [DOCS] An additional restriction for Hive/Java UDFs .. Patch Set 1: Code-Review+2 (1 comment) htt

[Impala-ASF-CR] IMPALA-7012: Fix NPE when parsing unexpected tokens

2018-05-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10512 ) Change subject: IMPALA-7012: Fix NPE when parsing unexpected tokens .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-05-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 1: (13 comments) http://ge

[Impala-ASF-CR] IMPALA-7012: Fix NPE when parsing unexpected tokens

2018-05-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10512 ) Change subject: IMPALA-7012: Fix NPE when parsing unexpected tokens .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cl

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-05-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 2: (2 comments) http://ger

[Impala-ASF-CR] [DOCS] SHOW TBLPROPERTIES not supported in impala

2018-06-01 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10564 ) Change subject: [DOCS] SHOW TBLPROPERTIES not supported in impala .. Patch Set 1: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-06-01 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. Patch Set 12: No takers for +2? This has been lingering

[Impala-ASF-CR] IMPALA-6020: [DOCS] REFRESH statement cannot detect HDFS block movement

2018-06-01 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10470 ) Change subject: IMPALA-6020: [DOCS] REFRESH statement cannot detect HDFS block movement .. Patch Set 1: Code-Review+2 Yes, thi

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 3: (1 comment) http://gerr

[Impala-ASF-CR] IMPALA-7110. Fix some warnings from error-prone

2018-06-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10583 ) Change subject: IMPALA-7110. Fix some warnings from error-prone .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-7077. Add a configuration for the max number of partitions to load

2018-06-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10584 ) Change subject: IMPALA-7077. Add a configuration for the max number of partitions to load .. Patch Set 1: (7 comments) http:/

[Impala-ASF-CR] IMPALA-7077. Add a configuration for the max number of partitions to load

2018-06-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10584 ) Change subject: IMPALA-7077. Add a configuration for the max number of partitions to load .. Patch Set 1: (2 comments) Todd,

[Impala-ASF-CR] IMPALA-7110. Fix errors from error-prone

2018-06-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10583 ) Change subject: IMPALA-7110. Fix errors from error-prone .. Patch Set 2: Code-Review+1 (1 comment) Phil, can you +2 this, I'm

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-06-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. Patch Set 8: (13 comments) Just came across this CR. I

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-06-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-06-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. Patch Set 11: (10 comments) Few more comments, looks p

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-06-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-06-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. Patch Set 13: (3 comments) LGTM once my comments are a

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-06-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. Patch Set 14: Code-Review+1 Phil, do you want to +2?

[Impala-ASF-CR] IMPALA-7158: Fix HdfsScanNodeBase::progress 's init

2018-06-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10672 Change subject: IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init .. IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init Chang

[Impala-ASF-CR] IMPALA-7158: Fix HdfsScanNodeBase::progress 's init

2018-06-11 Thread Bharath Vissapragada (Code Review)
Hello Sailesh Mukil, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10672 to look at the new patch set (#2). Change subject: IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init ..

[Impala-ASF-CR] IMPALA-7158: Fix HdfsScanNodeBase::progress 's init

2018-06-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10672 ) Change subject: IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init .. Patch Set 2: Updated the commit message. -- To view, v

[Impala-ASF-CR] Change variables to make the code easier to read

2018-06-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10699 ) Change subject: Change variables to make the code easier to read .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] Change variables to make the code easier to read

2018-06-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10699 ) Change subject: Change variables to make the code easier to read .. Patch Set 1: I think we can run the script in a standalone

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 10: Sorry, was busy. Will t

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-06-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. Patch Set 14: (1 comment) Just skimmi

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-06-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. Patch Set 15: Code-Review+2 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-06-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. IMPALA-2195: Improper handling of comments in qu

<    3   4   5   6   7   8   9   10   >