[Impala-ASF-CR] IMPALA-8698: Disable row count estimate to avoid a flaky test

2019-06-25 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13727 ) Change subject: IMPALA-8698: Disable row count estimate to avoid a flaky test .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-12 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 11: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-8697: fix assert in test query options for EC test runs

2019-06-21 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13709 Change subject: IMPALA-8697: fix assert in test_query_options for EC test runs .. IMPALA-8697: fix assert in test_query_options for EC

[Impala-ASF-CR] IMPALA-8697: fix assert in test query options for EC test runs

2019-06-21 Thread Bikramjeet Vig (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13709 to look at the new patch set (#2). Change subject: IMPALA-8697: fix assert in test_query_options for EC test runs

[Impala-ASF-CR] IMPALA-8697: fix assert in test query options for EC test runs

2019-06-24 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13709 to look at the new patch set (#3). Change subject: IMPALA-8697: fix assert in test_query_options for EC test runs

[Impala-ASF-CR] IMPALA-8697: fix assert in test query options for EC test runs

2019-06-24 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13709 ) Change subject: IMPALA-8697: fix assert in test_query_options for EC test runs .. Patch Set 3: Code-Review+2 Fixed a typo in the

[Impala-ASF-CR] IMPALA-7665: Fix unwarranted query cancellation on statestore restart

2019-05-09 Thread Bikramjeet Vig (Code Review)
Hello Michael Ho, Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13061 to look at the new patch set (#7). Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart

[Impala-ASF-CR] IMPALA-7031: Add additional info to query canceled from http endpoint

2019-05-09 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12926 ) Change subject: IMPALA-7031: Add additional info to query canceled from http endpoint .. Patch Set 10: (3 comments)

[Impala-ASF-CR] IMPALA-7665: Fix unwarranted query cancellation on statestore restart

2019-05-09 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13061 ) Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart .. Patch Set 7: Fixed a python issue -- To

[Impala-ASF-CR] IMPALA-7665: Fix unwarranted query cancellation on statestore restart

2019-05-09 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13061 ) Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart .. Patch Set 7: Code-Review+2 Carrying over

[Impala-ASF-CR] IMPALA-966: Attribute type error to the right expression in an insert statement

2019-05-09 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13050 ) Change subject: IMPALA-966: Attribute type error to the right expression in an insert statement .. Patch Set 8: Code-Review+2 (2

[Impala-ASF-CR] IMPALA-7665: Fix unwarranted query cancellation on statestore restart

2019-05-10 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13061 ) Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart .. Patch Set 8: Code-Review+2 GVO failed due

[Impala-ASF-CR] IMPALA-966: Attribute type error to the right expression in an insert statement

2019-05-13 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13050 ) Change subject: IMPALA-966: Attribute type error to the right expression in an insert statement .. Patch Set 9: Code-Review+2 --

[Impala-ASF-CR] IMPALA-966: Attribute type error to the right expression in an insert statement

2019-05-14 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13050 ) Change subject: IMPALA-966: Attribute type error to the right expression in an insert statement .. Patch Set 11: Code-Review+2 --

[Impala-ASF-CR] IMPALA-8570: Fix flakiness in test restart statestore query resilience

2019-05-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13406 Change subject: IMPALA-8570: Fix flakiness in test_restart_statestore_query_resilience .. IMPALA-8570: Fix flakiness in

[Impala-ASF-CR] IMPALA-6042: Allow Impala shell to use a global impalarc config

2019-05-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 ) Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config .. Patch Set 9: (2 comments)

[Impala-ASF-CR] IMPALA-8570: Fix flakiness in test restart statestore query resilience

2019-05-24 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13406 ) Change subject: IMPALA-8570: Fix flakiness in test_restart_statestore_query_resilience .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8570: Fix flakiness in test restart statestore query resilience

2019-05-24 Thread Bikramjeet Vig (Code Review)
Hello Thomas Marshall, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13406 to look at the new patch set (#2). Change subject: IMPALA-8570: Fix flakiness in test_restart_statestore_query_resilience

[Impala-ASF-CR] IMPALA-7031: Add additional info to query canceled from http endpoint

2019-05-09 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12926 ) Change subject: IMPALA-7031: Add additional info to query canceled from http endpoint .. Patch Set 11: (5 comments)

[Impala-ASF-CR] IMPALA-8460: Simplify cluster membership management

2019-05-21 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13207 ) Change subject: IMPALA-8460: Simplify cluster membership management .. Patch Set 11: (7 comments)

[Impala-ASF-CR] IMPALA-966: Attribute type error to the right expression in an insert statement

2019-05-08 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13050 ) Change subject: IMPALA-966: Attribute type error to the right expression in an insert statement .. Patch Set 7: (4 comments) Looks

[Impala-ASF-CR] IMPALA-6042: Allow Impala shell to use a global impalarc config

2019-05-20 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 ) Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config .. Patch Set 8: (5 comments) Looks good, just a few

[Impala-ASF-CR] IMPALA-7665: Fix unwarranted query cancellation on statestore restart

2019-04-30 Thread Bikramjeet Vig (Code Review)
Hello Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13061 to look at the new patch set (#3). Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart

[Impala-ASF-CR] IMPALA-7665: Fix unwarranted query cancellation on statestore restart

2019-04-30 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13061 ) Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-966: Type errors are attributed to wrong expression with insert

2019-05-01 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13050 ) Change subject: IMPALA-966: Type errors are attributed to wrong expression with insert .. Patch Set 3: (12 comments)

[Impala-ASF-CR] IMPALA-7665: Fix unwarranted query cancellation on statestore restart

2019-04-29 Thread Bikramjeet Vig (Code Review)
Hello Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13061 to look at the new patch set (#2). Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart

[Impala-ASF-CR] IMPALA-7665: Fix unwarranted query cancellation on statestore restart

2019-04-29 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13061 ) Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart .. Patch Set 2: (15 comments)

[Impala-ASF-CR] IMPALA-966: Type errors are attributed to wrong expression with insert

2019-05-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13050 ) Change subject: IMPALA-966: Type errors are attributed to wrong expression with insert .. Patch Set 5: (11 comments)

[Impala-ASF-CR] IMPALA-7665: Fix unwarranted query cancellation on statestore restart

2019-05-07 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13061 ) Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-7665: Fix unwarranted query cancellation on statestore restart

2019-05-07 Thread Bikramjeet Vig (Code Review)
Hello Michael Ho, Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13061 to look at the new patch set (#5). Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart

[Impala-ASF-CR] IMPALA-966: Attribute type error to the right expression in an insert statement

2019-05-07 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13050 ) Change subject: IMPALA-966: Attribute type error to the right expression in an insert statement .. Patch Set 6: (6 comments)

[Impala-ASF-CR] IMPALA-7031: Add additional info to query canceled from http endpoint

2019-05-07 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12926 ) Change subject: IMPALA-7031: Add additional info to query canceled from http endpoint .. Patch Set 9: (9 comments)

[Impala-ASF-CR] IMPALA-8401: SIGRTMIN initiates the graceful shutdown process

2019-04-18 Thread Bikramjeet Vig (Code Review)
Hello Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12973 to look at the new patch set (#9). Change subject: IMPALA-8401: SIGRTMIN initiates the graceful shutdown process

[Impala-ASF-CR] IMPALA-8401: SIGRTMIN initiates the graceful shutdown process

2019-04-18 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12973 ) Change subject: IMPALA-8401: SIGRTMIN initiates the graceful shutdown process .. Patch Set 9: Code-Review+2 Updated Commit message

[Impala-ASF-CR] IMPALA-8270: fix MemTracker teardown in FeSupport

2019-04-18 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13057 ) Change subject: IMPALA-8270: fix MemTracker teardown in FeSupport .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-8270: fix MemTracker teardown in FeSupport

2019-04-19 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13057 ) Change subject: IMPALA-8270: fix MemTracker teardown in FeSupport .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8460: Simplify cluster membership management

2019-05-03 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13207 ) Change subject: IMPALA-8460: Simplify cluster membership management .. Patch Set 5: (20 comments)

[Impala-ASF-CR] IMPALA-7665: Fix unwarranted query cancellation on statestore restart

2019-05-03 Thread Bikramjeet Vig (Code Review)
Hello Michael Ho, Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13061 to look at the new patch set (#4). Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart

[Impala-ASF-CR] IMPALA-7665: Fix unwarranted query cancellation on statestore restart

2019-05-03 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13061 ) Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-7031: Add additional info to query canceled from http endpoint

2019-05-02 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12926 ) Change subject: IMPALA-7031: Add additional info to query canceled from http endpoint .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-8460: Simplify cluster membership management

2019-05-08 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13207 ) Change subject: IMPALA-8460: Simplify cluster membership management .. Patch Set 6: Code-Review+1 (5 comments)

[Impala-ASF-CR] [WIP] IMPALA-7486: Prototype for admitting less mem on coord

2019-06-28 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13740 ) Change subject: [WIP] IMPALA-7486: Prototype for admitting less mem on coord .. Patch Set 2: Thanks everyone for reviewing. PS2 just

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-23 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 2: (4 comments) looks good, just a few nits

[Impala-ASF-CR] IMPALA-8295: Fix flakiness in TestAdmissionControllerStress

2019-04-24 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13103 Change subject: IMPALA-8295: Fix flakiness in TestAdmissionControllerStress .. IMPALA-8295: Fix flakiness in

[Impala-ASF-CR] IMPALA-8295: Fix flakiness in TestAdmissionControllerStress

2019-04-24 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13103 ) Change subject: IMPALA-8295: Fix flakiness in TestAdmissionControllerStress .. Patch Set 2: (1 comment) Carrying over Tim's +1

[Impala-ASF-CR] IMPALA-8295: Fix flakiness in TestAdmissionControllerStress

2019-04-24 Thread Bikramjeet Vig (Code Review)
Hello Michael Ho, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13103 to look at the new patch set (#2). Change subject: IMPALA-8295: Fix flakiness in TestAdmissionControllerStress

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-24 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8224: [DOCS] Add the missing contents about Impala web UI pages

2019-04-10 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12934 ) Change subject: IMPALA-8224: [DOCS] Add the missing contents about Impala web UI pages .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-8224: [DOCS] Add the missing contents about Impala web UI pages

2019-04-10 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12934 ) Change subject: IMPALA-8224: [DOCS] Add the missing contents about Impala web UI pages .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-8224: [DOCS] Add the missing contents about Impala web UI pages

2019-04-10 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12934 ) Change subject: IMPALA-8224: [DOCS] Add the missing contents about Impala web UI pages .. Patch Set 4: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7031: Cancel action of debug page should not unregister query

2019-04-09 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12926 ) Change subject: IMPALA-7031: Cancel action of debug page should not unregister query .. Patch Set 4: (10 comments)

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-25 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] [WIP] IMPALA-7486: Prototype for admitting less mem on coord

2019-06-28 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13740 to look at the new patch set (#2). Change subject: [WIP] IMPALA-7486: Prototype for admitting less mem on coord

[Impala-ASF-CR] IMPALA-8791: Handle the case where there is no fragment scheduled on the coordinator

2019-08-13 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14058 ) Change subject: IMPALA-8791: Handle the case where there is no fragment scheduled on the coordinator .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8791: Handle the case where there is no fragment scheduled on the coordinator

2019-08-13 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14058 Change subject: IMPALA-8791: Handle the case where there is no fragment scheduled on the coordinator .. IMPALA-8791: Handle the case

[Impala-ASF-CR] IMPALA-8549: Add support for scanning DEFLATE text files

2019-08-02 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13857 ) Change subject: IMPALA-8549: Add support for scanning DEFLATE text files .. Patch Set 9: Code-Review+2 Carrying forward Zoltan's +2

[Impala-ASF-CR] IMPALA-8376: directory limits for scratch usage

2019-08-02 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13986 ) Change subject: IMPALA-8376: directory limits for scratch usage .. Patch Set 3: Code-Review+1 (4 comments)

[Impala-ASF-CR] IMPALA-8858: Add observability of idle executor groups

2019-08-19 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14103 Change subject: IMPALA-8858: Add observability of idle executor groups .. IMPALA-8858: Add observability of idle executor groups This

[Impala-ASF-CR] IMPALA-8803: Coordinator should release admitted memory per-backend

2019-08-21 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14104 ) Change subject: IMPALA-8803: Coordinator should release admitted memory per-backend .. Patch Set 1: (19 comments) Took a pass over

[Impala-ASF-CR] IMPALA-8858: Add observability of idle executor groups

2019-08-21 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14103 to look at the new patch set (#3). Change subject: IMPALA-8858: Add observability of idle executor groups

[Impala-ASF-CR] IMPALA-8858: Add observability of idle executor groups

2019-08-21 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add observability of idle executor groups .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8858: Add observability of idle executor groups

2019-08-20 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14103 to look at the new patch set (#2). Change subject: IMPALA-8858: Add observability of idle executor groups

[Impala-ASF-CR] IMPALA-8858: Add observability of idle executor groups

2019-08-20 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add observability of idle executor groups .. Patch Set 2: (1 comment) > This looks like the right

[Impala-ASF-CR] IMPALA-8760: Disable TestAdmissionControllerStress tests for CentOS 6

2019-08-26 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14124 ) Change subject: IMPALA-8760: Disable TestAdmissionControllerStress tests for CentOS 6 .. Patch Set 3: Previous GVO seems to have

[Impala-ASF-CR] IMPALA-7604: part 1: tests for agg cardinality

2019-08-27 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14131 ) Change subject: IMPALA-7604: part 1: tests for agg cardinality .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7604: part 2: fixes for AggregationNode cardinality

2019-08-27 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14132 ) Change subject: IMPALA-7604: part 2: fixes for AggregationNode cardinality .. Patch Set 6: Code-Review+2 (1 comment) Lgtm

[Impala-ASF-CR] IMPALA-7604: part 2: fixes for AggregationNode cardinality

2019-08-27 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14132 ) Change subject: IMPALA-7604: part 2: fixes for AggregationNode cardinality .. Patch Set 9: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8858: Add observability of the query load on executor groups

2019-08-23 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14103 to look at the new patch set (#5). Change subject: IMPALA-8858: Add observability of the query load on executor groups

[Impala-ASF-CR] IMPALA-8858: Add observability of the query load on executor groups

2019-08-23 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add observability of the query load on executor groups .. Patch Set 4: @all Please let me know if the

[Impala-ASF-CR] IMPALA-8858: Add observability of the query load on executor groups

2019-08-23 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add observability of the query load on executor groups .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8858: Add observability of the query load on executor groups

2019-08-23 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14103 to look at the new patch set (#4). Change subject: IMPALA-8858: Add observability of the query load on executor groups

[Impala-ASF-CR] IMPALA-8760: Disable TestAdmissionControllerStress tests for CentOS 6

2019-08-23 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14124 Change subject: IMPALA-8760: Disable TestAdmissionControllerStress tests for CentOS 6 .. IMPALA-8760: Disable

[Impala-ASF-CR] IMPALA-7604: part 1: tests for agg cardinality

2019-08-28 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14131 ) Change subject: IMPALA-7604: part 1: tests for agg cardinality .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8760: Disable TestAdmissionControllerStress tests for CentOS 6

2019-08-26 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14124 to look at the new patch set (#2). Change subject: IMPALA-8760: Disable TestAdmissionControllerStress tests for CentOS 6

[Impala-ASF-CR] IMPALA-8760: Disable TestAdmissionControllerStress tests for CentOS 6

2019-08-26 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14124 ) Change subject: IMPALA-8760: Disable TestAdmissionControllerStress tests for CentOS 6 .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8760: Disable TestAdmissionControllerStress tests for CentOS 6

2019-08-26 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14124 ) Change subject: IMPALA-8760: Disable TestAdmissionControllerStress tests for CentOS 6 .. Patch Set 3: Code-Review+2 Carrying over

[Impala-ASF-CR] IMPALA-8858: Add observability of the query load on executor groups

2019-08-28 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14103 to look at the new patch set (#6). Change subject: IMPALA-8858: Add observability of the query load on executor groups

[Impala-ASF-CR] IMPALA-8858: Add observability of the query load on executor groups

2019-08-28 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add observability of the query load on executor groups .. Patch Set 6: (4 comments)

[Impala-ASF-CR] IMPALA-8830: Fix executor group assignment of coordinator only queries

2019-09-05 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14183 ) Change subject: IMPALA-8830: Fix executor group assignment of coordinator only queries .. Patch Set 1: (5 comments) > (5 comments)

[Impala-ASF-CR] IMPALA-8830: Fix executor group assignment of coordinator only queries

2019-09-05 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14183 Change subject: IMPALA-8830: Fix executor group assignment of coordinator only queries .. IMPALA-8830: Fix executor group assignment

[Impala-ASF-CR] IMPALA-8858: Add observability of the query load on executor groups

2019-09-04 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14103 to look at the new patch set (#7). Change subject: IMPALA-8858: Add observability of the query load on executor groups

[Impala-ASF-CR] IMPALA-8858: Add observability of the query load on executor groups

2019-09-04 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add observability of the query load on executor groups .. Patch Set 7: (11 comments)

[Impala-ASF-CR] IMPALA-8858: Add observability of the query load on executor groups

2019-09-04 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14103 to look at the new patch set (#8). Change subject: IMPALA-8858: Add observability of the query load on executor groups

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups .. Patch Set 12: (20 comments)

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-11 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14103 to look at the new patch set (#13). Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-8830: Fix executor group assignment of coordinator only queries

2019-09-12 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14183 ) Change subject: IMPALA-8830: Fix executor group assignment of coordinator only queries .. Patch Set 2: (1 comment) As discussed

[Impala-ASF-CR] IMPALA-8830: Fix executor group assignment of coordinator only queries

2019-09-12 Thread Bikramjeet Vig (Code Review)
Hello Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14183 to look at the new patch set (#2). Change subject: IMPALA-8830: Fix executor group assignment of coordinator only queries

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-10 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14103 to look at the new patch set (#10). Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-10 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups .. Patch Set 10: (6 comments)

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-10 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14103 to look at the new patch set (#11). Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-10 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups .. Patch Set 12: fixed clang-tidy error

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-10 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14103 to look at the new patch set (#12). Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-10 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-09 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups .. Patch Set 8: (8 comments)

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-09 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14103 to look at the new patch set (#9). Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups .. Patch Set 15: Code-Review+1 Rebased and

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-17 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14103 to look at the new patch set (#16). Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-17 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14103 to look at the new patch set (#15). Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-17 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14103 to look at the new patch set (#14). Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups

<    1   2   3   4   5   6   7   8   9   10   >