[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2018-07-11 Thread Lars Volker (Code Review)
Hello Michael Ho, Henry Robinson, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10758 to look at the new patch set (#12). Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2018-07-11 Thread Lars Volker (Code Review)
Hello Michael Ho, Henry Robinson, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10758 to look at the new patch set (#10). Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

2018-07-11 Thread Lars Volker (Code Review)
Hello Michael Ho, Sailesh Mukil, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10769 to look at the new patch set (#15). Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes

[Impala-ASF-CR] IMPALA-7006: Remove KRPC folders

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10756 ) Change subject: IMPALA-7006: Remove KRPC folders .. Patch Set 5: Code-Review+2 Rebased, carrying Michael's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-7006: [KSECURITY] Update security library integration

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10759 ) Change subject: IMPALA-7006: [KSECURITY] Update security library integration .. Patch Set 10: Code-Review+2 Rebased, carrying Michael's

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10758 ) Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 10: Code-Review+2 Rebased and addressed the final

[Impala-ASF-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10765 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 11: Code-Review+2 Rebased, carrying Michael's

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10760 ) Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. Patch Set 11: Code-Review+2 Rebased, carrying Michael's +2. --

[Impala-ASF-CR] IMPALA-7006: Add KRPC folders from kudu@334ecafd

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10757 ) Change subject: IMPALA-7006: Add KRPC folders from kudu@334ecafd .. Patch Set 7: Code-Review+2 Rebased, carrying Michael's +2. -- To

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10763 ) Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork .. Patch Set 11: Code-Review+2 Rebased, carrying Michael's

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 ) Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes .. Patch Set 15: Code-Review+2 Rebased and addressed the final

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10763 ) Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork .. Patch Set 11: That carried +2 was from Sailesh,

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 ) Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes .. Patch Set 14: (2 comments)

[Impala-ASF-CR] IMPALA-7006: Add KRPC folders from kudu@334ecafd

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10757 ) Change subject: IMPALA-7006: Add KRPC folders from kudu@334ecafd .. Patch Set 9: Code-Review+2 Removed .rej file, rebased, carrying

[Impala-ASF-CR] IMPALA-7006: [KSECURITY] Update security library integration

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10759 ) Change subject: IMPALA-7006: [KSECURITY] Update security library integration .. Patch Set 12: Code-Review+2 Rebased, carrying Michael's

[Impala-ASF-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10765 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 13: Code-Review+2 Rebased, carrying Michael's

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10763 ) Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork .. Patch Set 13: Code-Review+2 Rebased, carrying Sailesh's

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 ) Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes .. Patch Set 17: Code-Review+2 Rebased, carrying Michael's +2.

[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps

2018-01-23 Thread Lars Volker (Code Review)
Hello Sailesh Mukil, Zoram Thanga, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9079 to look at the new patch set (#9). Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2018-01-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 17: Code-Review+2 Fixed a rogue DCHECK, ran

[native-toolchain-CR] IMPALA-6377: Bump breakpad version to include fix for #752

2018-01-16 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9036 Change subject: IMPALA-6377: Bump breakpad version to include fix for #752 .. IMPALA-6377: Bump breakpad version to include fix for #752

[native-toolchain-CR] IMPALA-6377: Bump breakpad version to include fix for #752

2018-01-16 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9036 ) Change subject: IMPALA-6377: Bump breakpad version to include fix for #752 .. Patch Set 1: I tested this in a private build. -- To

[Impala-ASF-CR] KUDU-2256: Add GetTransferSize() to RpcContext

2018-01-12 Thread Lars Volker (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9019 to review the following change. Change subject: KUDU-2256: Add GetTransferSize() to RpcContext ..

[Impala-ASF-CR] KUDU-2256: Add GetTransferSize() to RpcContext

2018-01-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9019 ) Change subject: KUDU-2256: Add GetTransferSize() to RpcContext .. Patch Set 1: I cherry-picked KUDU-2256 into Impala. It had one merge

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9059 ) Change subject: IMPALA-6383: free memory after skipping parquet row groups .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2018-01-22 Thread Lars Volker (Code Review)
Hello Michael Ho, Joe McDonnell, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8758 to look at the new patch set (#13). Change subject: IMPALA-6190/6246: Add instances tab and event sequence

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2018-01-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 13: (5 comments) Thanks for the review. Please see

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2018-01-22 Thread Lars Volker (Code Review)
Hello Michael Ho, Joe McDonnell, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8758 to look at the new patch set (#14). Change subject: IMPALA-6190/6246: Add instances tab and event sequence

[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps

2018-01-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 ) Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps .. Patch Set 8: Rebased to get the workaround

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2018-01-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 14: Code-Review+2 Rebased, carrying Tim's +2. --

[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps

2018-01-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 ) Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps .. Patch Set 8: Code-Review-2 Still testing

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2018-01-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 2: Code-Review+1 > Patch Set 2: > > Checked the binary sizes for

[native-toolchain-CR] IMPALA-6401 : Re-apply the PPC Breakpad patches

2018-01-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9077 ) Change subject: IMPALA-6401 : Re-apply the PPC Breakpad patches .. Patch Set 1: I ran md5sum on x86 on all binaries with and without the

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9059 ) Change subject: IMPALA-6383: free memory after skipping parquet row groups .. Patch Set 4: I'm happy to +2 this one. Alex, do you have

[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps

2018-01-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 ) Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps .. Patch Set 8: Verified+1 Code-Review+2

[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps

2018-01-23 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9079 ) Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps .. IMPALA-6399: Fix timeout logic in

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2018-01-23 Thread Lars Volker (Code Review)
Hello Michael Ho, Joe McDonnell, Tim Armstrong, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8758 to look at the new patch set (#15). Change subject: IMPALA-6190/6246: Add instances tab and event sequence

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2018-01-23 Thread Lars Volker (Code Review)
Hello Michael Ho, Joe McDonnell, Tim Armstrong, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8758 to look at the new patch set (#16). Change subject: IMPALA-6190/6246: Add instances tab and event sequence

[Impala-ASF-CR](refs/meta/config) Expose refs/heads/2.x and refs/scratch/2.x-staging to impala-public-jenkins.

2018-01-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9101 ) Change subject: Expose refs/heads/2.x and refs/scratch/2.x-staging to impala-public-jenkins. .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR](refs/meta/config) Expose refs/heads/2.x and refs/sandbox//*.

2018-01-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9101 ) Change subject: Expose refs/heads/2.x and refs/sandbox//*. .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR](refs/meta/config) Expose refs/heads/2.x and refs/sandbox//*.

2018-01-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9101 ) Change subject: Expose refs/heads/2.x and refs/sandbox//*. .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR](refs/meta/config) Expose refs/heads/2.x and refs/sandbox//*.

2018-01-23 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9101 ) Change subject: Expose refs/heads/2.x and refs/sandbox//*. .. Expose refs/heads/2.x and refs/sandbox//*. refs/heads/2.x is

[Impala-ASF-CR](refs/meta/config) Fixing typo: removing "heads" from "refs/sandbox"

2018-01-23 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9106 ) Change subject: Fixing typo: removing "heads" from "refs/sandbox" .. Fixing typo: removing "heads" from "refs/sandbox"

[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps

2018-01-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 ) Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps .. Patch Set 8: -Code-Review Sailesh, Zoram,

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2018-01-23 Thread Lars Volker (Code Review)
Hello Michael Ho, Joe McDonnell, Tim Armstrong, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8758 to look at the new patch set (#18). Change subject: IMPALA-6190/6246: Add instances tab and event sequence

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2018-01-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 18: Code-Review+2 Re-added status.h include.

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-23 Thread Lars Volker (Code Review)
Hello Michael Ho, Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8914 to look at the new patch set (#8). Change subject: IMPALA-6193: Track memory of incoming data streams

[Impala-ASF-CR](2.x) IMPALA-6405: Error when string to decimal cast overflows

2018-03-07 Thread Lars Volker (Code Review)
Hello Dan Hecht, Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9530 to review the following change. Change subject: IMPALA-6405: Error when string to decimal cast overflows

[Impala-ASF-CR] Add missing brace to example JSON

2018-03-07 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9532 Change subject: Add missing brace to example JSON .. Add missing brace to example JSON Change-Id:

[Impala-ASF-CR] Add missing brace to example JSON

2018-03-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9532 ) Change subject: Add missing brace to example JSON .. Patch Set 2: Marking this as +1 Verified, it only updates a comment and does not

[Impala-ASF-CR] Add missing brace to example JSON

2018-03-07 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9532 ) Change subject: Add missing brace to example JSON .. Add missing brace to example JSON Change-Id:

[Impala-ASF-CR] Add missing brace to example JSON

2018-03-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9532 ) Change subject: Add missing brace to example JSON .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/9532 To

[Impala-ASF-CR](2.x) IMPALA-6405: Ignore commit for automatic cherry picking

2018-03-07 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9531 ) Change subject: IMPALA-6405: Ignore commit for automatic cherry picking .. IMPALA-6405: Ignore commit for automatic cherry

[Impala-ASF-CR](2.x) IMPALA-6405: Ignore commit for automatic cherry picking

2018-03-07 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9531 Change subject: IMPALA-6405: Ignore commit for automatic cherry picking .. IMPALA-6405: Ignore commit for automatic cherry picking The

[Impala-ASF-CR] Add missing brace to example JSON

2018-03-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9532 ) Change subject: Add missing brace to example JSON .. Patch Set 1: (2 comments) Thanks Alex for the review. Please see PS2.

[Impala-ASF-CR] Add missing brace to example JSON

2018-03-07 Thread Lars Volker (Code Review)
Hello Philip Zeyliger, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9532 to look at the new patch set (#2). Change subject: Add missing brace to example JSON .. Add missing

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-6613: Change TEST KRPC to DISABLE KRPC

2018-03-06 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9516 Change subject: IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC .. IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC This change renames the

[Impala-ASF-CR] IMPALA-6613: Change TEST KRPC to DISABLE KRPC

2018-03-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9516 ) Change subject: IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC .. Patch Set 1: (1 comment) Thanks for the review, Sailesh. Please see

[Impala-ASF-CR] IMPALA-6613: Change TEST KRPC to DISABLE KRPC

2018-03-06 Thread Lars Volker (Code Review)
Hello Michael Ho, Philip Zeyliger, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9516 to look at the new patch set (#2). Change subject: IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 13: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6613: Change TEST KRPC to DISABLE KRPC

2018-03-06 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9516 ) Change subject: IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC .. IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC This change

[Impala-ASF-CR] IMPALA-6613: Change TEST KRPC to DISABLE KRPC

2018-03-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9516 ) Change subject: IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC .. Patch Set 2: Verified+1 This change does not affect the builds in out

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

2018-03-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9546 ) Change subject: Fix test dimensions in test_errorlog.py .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

2018-03-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9546 ) Change subject: Fix test dimensions in test_errorlog.py .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6617: Improve diagnostics for debugging.

2018-03-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9545 ) Change subject: IMPALA-6617: Improve diagnostics for debugging. .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-03-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 ) Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-03-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 ) Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 2: (6 comments) Thanks for the review.

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-09 Thread Lars Volker (Code Review)
Hello Michael Ho, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9562 to look at the new patch set (#3). Change subject: IMPALA-6576: Add metrics for data stream service memory usage

[Impala-ASF-CR](2.x) IMPALA-6405: Error when string to decimal cast overflows

2018-03-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9530 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 1: Verified-1 Both builds have failed. Can you

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 4: Code-Review+1 Thanks for the reviews. PS4

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-12 Thread Lars Volker (Code Review)
Hello Michael Ho, Sailesh Mukil, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9562 to look at the new patch set (#5). Change subject: IMPALA-6576: Add metrics for data stream service memory usage

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 5: I wasn't happy with the metric naming, I

[Impala-ASF-CR](2.x) IMPALA-6405: Error when string to decimal cast overflows

2018-03-12 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9530 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. IMPALA-6405: Error when string to decimal cast

[Impala-ASF-CR](2.x) IMPALA-6405: Error when string to decimal cast overflows

2018-03-12 Thread Lars Volker (Code Review)
Hello Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9530 to look at the new patch set (#2). Change subject: IMPALA-6405: Error when string to decimal cast overflows

[Impala-ASF-CR] DRAFT IMPALA-5185: Skip pages based on Parquet::Statistics

2018-03-13 Thread Lars Volker (Code Review)
Lars Volker has restored this change. ( http://gerrit.cloudera.org:8080/7354 ) Change subject: DRAFT IMPALA-5185: Skip pages based on Parquet::Statistics .. Restored We'll want to discuss this as part of implementing page

[Impala-ASF-CR] IMPALA-6682: Remove MD5 assumption from pypi download script

2018-03-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9683 ) Change subject: IMPALA-6682: Remove MD5 assumption from pypi download script .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9635 ) Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes .. Patch Set 4: (6 comments) I had a first look

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9635 ) Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes .. Patch Set 5: Code-Review+1 (2 comments) I

[Impala-ASF-CR] IMPALA-6682: Remove MD5 assumption from pypi download script

2018-03-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9683 ) Change subject: IMPALA-6682: Remove MD5 assumption from pypi download script .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6227: more logging in test admission controller

2018-03-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9555 ) Change subject: IMPALA-6227: more logging in test_admission_controller .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6589: remove invalid DCHECK in parquet reader

2018-03-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9556 ) Change subject: IMPALA-6589: remove invalid DCHECK in parquet reader .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6394: Restart HDFS when blocks are under replicated

2018-03-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9469 ) Change subject: IMPALA-6394: Restart HDFS when blocks are under replicated .. Patch Set 4: (1 comment)

[Impala-ASF-CR](2.x) IMPALA-6405: Error when string to decimal cast overflows

2018-03-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9530 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 1: I had done the same, but it's still running:

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-6652: Rename label of MemTracker for early RPCs

2018-03-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9633 ) Change subject: IMPALA-6652: Rename label of MemTracker for early RPCs .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6652: Rename label of MemTracker for early RPCs

2018-03-14 Thread Lars Volker (Code Review)
Hello Michael Ho, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9633 to look at the new patch set (#4). Change subject: IMPALA-6652: Rename label of MemTracker for early RPCs

[Impala-ASF-CR] IMPALA-6652: Rename label of MemTracker for early RPCs

2018-03-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9633 ) Change subject: IMPALA-6652: Rename label of MemTracker for early RPCs .. Patch Set 3: (2 comments) Please see PS4.

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-08 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9562 Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. IMPALA-6576: Add metrics for data stream service memory

[Impala-ASF-CR] IMPALA-6652: Rename Data Stream Manager MemTracker

2018-03-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9633 ) Change subject: IMPALA-6652: Rename Data Stream Manager MemTracker .. Patch Set 1: (2 comments) Thanks for the review. I saw your

[Impala-ASF-CR] IMPALA-6652: Rename Data Stream Manager MemTracker

2018-03-14 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9633 Change subject: IMPALA-6652: Rename Data Stream Manager MemTracker .. IMPALA-6652: Rename Data Stream Manager MemTracker This change

[Impala-ASF-CR] IMPALA-6652: Rename label of MemTracker for early RPCs

2018-03-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9632 ) Change subject: IMPALA-6652: Rename label of MemTracker for early RPCs .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6652: Rename label of MemTracker for early RPCs

2018-03-14 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/9633 ) Change subject: IMPALA-6652: Rename label of MemTracker for early RPCs .. IMPALA-6652: Rename label of MemTracker for early RPCs This

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9928 ) Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY .. Patch Set 1: (3 comments)

[Impala-ASF-CR] KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails

2018-04-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9940 ) Change subject: KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails .. Patch Set 1: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-6811: Increase timeout on S3 for test exchange delays

2018-04-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9995 ) Change subject: IMPALA-6811: Increase timeout on S3 for test_exchange_delays .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9928 ) Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9928 ) Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY .. Patch Set 3: Code-Review+1 (1 comment) Thank you for fixing

[Impala-ASF-CR] IMPALA-6811: Increase timeout on S3 for test exchange delays

2018-04-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9995 ) Change subject: IMPALA-6811: Increase timeout on S3 for test_exchange_delays .. Patch Set 1: (1 comment)

<    1   2   3   4   5   6   7   8   9   10   >