[Impala-ASF-CR] IMPALA-3710: All-null columns give wrong estimates in planner Modified the planner to handle low-value NDVs by adjusting them upward by one to account for null values. Thus, even an al

2018-09-27 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11528 ) Change subject: IMPALA-3710: All-null columns give wrong estimates in planner Modified the planner to handle low-value NDVs by adjusting them upward by one to account for null values. Thus, even an

[Impala-ASF-CR] IMPALA-3710: All-null columns give wrong estimates in planner Modified the planner to handle low-value NDVs by adjusting them upward by one to account for null values. Thus, even an al

2018-09-27 Thread Paul Rogers (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11528 to look at the new patch set (#3). Change subject: IMPALA-3710: All-null columns give wrong estimates in planner Modified the planner to handle low-value NDVs by adjusting

[Impala-ASF-CR] IMPALA-7310: All-null columns give wrong estimates in planner

2018-09-27 Thread Paul Rogers (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11528 to look at the new patch set (#4). Change subject: IMPALA-7310: All-null columns give wrong estimates in planner

[Impala-ASF-CR] IMPALA-7310: All-null columns give wrong estimates in planner

2018-09-27 Thread Paul Rogers (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11528 to look at the new patch set (#5). Change subject: IMPALA-7310: All-null columns give wrong estimates in planner

[Impala-ASF-CR] IMPALA-7310: All-null columns give wrong estimates in planner

2018-09-27 Thread Paul Rogers (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11528 to look at the new patch set (#6). Change subject: IMPALA-7310: All-null columns give wrong estimates in planner

[Impala-ASF-CR] IMPALA-7310: Use NDV=1 for a Column with all nulls

2018-10-12 Thread Paul Rogers (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11528 to look at the new patch set (#11). Change subject: IMPALA-7310: Use NDV=1 for a Column with all nulls

[Impala-ASF-CR] IMPALA-7310: Use NDV=1 for a Column with all nulls

2018-10-12 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11528 ) Change subject: IMPALA-7310: Use NDV=1 for a Column with all nulls .. Patch Set 12: (3 comments) > Uploaded patch set 12. Addressed a

[Impala-ASF-CR] IMPALA-7310: Use NDV=1 for a Column with all nulls

2018-10-12 Thread Paul Rogers (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11528 to look at the new patch set (#12). Change subject: IMPALA-7310: Use NDV=1 for a Column with all nulls

[Impala-ASF-CR] IMPALA-7501: Slim down metastore Partition objects in LocalCatalog cache

2018-10-15 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11688 Change subject: IMPALA-7501: Slim down metastore Partition objects in LocalCatalog cache .. IMPALA-7501: Slim down metastore Partition

[Impala-ASF-CR] IMPALA-7715: [DOCS] Better descriptions for conditional functions

2018-10-17 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11704 ) Change subject: IMPALA-7715: [DOCS] Better descriptions for conditional functions .. Patch Set 3: Code-Review+1 Looks good. The

[Impala-ASF-CR] IMPALA-7715: [DOCS] Better descriptions for conditional functions

2018-10-16 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11704 ) Change subject: IMPALA-7715: [DOCS] Better descriptions for conditional functions .. Patch Set 2: (4 comments) Thanks for making

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-18 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 3: (1 comment) This will be a great change.

[Impala-ASF-CR] IMPALA-7659: Simplify expression to collect NULLs count

2018-10-18 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: IMPALA-7659: Simplify expression to collect NULLs count .. Patch Set 5: (2 comments) A few comments.

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-18 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 16: (5 comments) Good stuff. A few random

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-22 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 16: (3 comments) A few more comments as I learn

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-24 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-7740: [DOCS] Correct description of NVL2 function

2018-10-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11758 ) Change subject: IMPALA-7740: [DOCS] Correct description of NVL2 function .. Patch Set 1: Code-Review+1 Thanks for the quick fix! --

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-23 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. IMPALA-7655: Rewrite if, isnull, coalesce to use CASE See

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11760 to look at the new patch set (#7). Change subject: IMPALA-7655: Rewrite if, isnull,

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11760 to look at the new patch set (#5). Change subject: IMPALA-7655: Rewrite if, isnull,

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 5: Thanks everyone for your patient reviews of this

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11760 to look at the new patch set (#6). Change subject: IMPALA-7655: Rewrite if, isnull,

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11760 to look at the new patch set (#8). Change subject: IMPALA-7655: Rewrite if, isnull,

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/11822 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Abandoned Duplicate -- To view, visit

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 7: (14 comments) Thanks, Phil, for the code review.

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11822 Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. IMPALA-7655: Rewrite if, isnull, coalesce to use CASE See

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-31 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 10: (10 comments)

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull to use CASE

2018-10-31 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11760 to look at the new patch set (#11). Change subject: IMPALA-7655: Rewrite if, isnull to

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-30 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11760 to look at the new patch set (#9). Change subject: IMPALA-7655: Rewrite if, isnull,

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-30 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 7: Turns out that there is a BE bug that means CASE

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-30 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11760 to look at the new patch set (#10). Change subject: IMPALA-7655: Rewrite if, isnull,

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-25 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 4: (12 comments) Thanks everyone for the comments.

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-25 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 4: (1 comment)

[Impala-ASF-CR] Update .gitignore

2018-10-25 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 3: Code-Review+1 Thanks! I've found a few more additions, many around the use of

[Impala-ASF-CR] IMPALA-7501: Slim down metastore Partition objects in LocalCatalog

2018-10-26 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11688 ) Change subject: IMPALA-7501: Slim down metastore Partition objects in LocalCatalog .. Patch Set 2: (2 comments) Updated with changes

[Impala-ASF-CR] IMPALA-7501: Slim down metastore Partition objects in LocalCatalog

2018-10-26 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11688 to look at the new patch set (#2). Change subject: IMPALA-7501: Slim down metastore Partition objects in LocalCatalog

[Impala-ASF-CR] IMPALA-7501: Slim down metastore Partition objects in LocalCatalog

2018-11-01 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/11688 ) Change subject: IMPALA-7501: Slim down metastore Partition objects in LocalCatalog .. Abandoned Change has become too involved for a simple

[Impala-ASF-CR] IMPALA-7501: Slim down metastore Partition objects in LocalCatalog cache

2018-10-25 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11688 ) Change subject: IMPALA-7501: Slim down metastore Partition objects in LocalCatalog cache .. Patch Set 1: Hey Todd, you asked for this

[Impala-ASF-CR] IMPALA-7739 IMPALA-7740: [DOCS] Correct descriptions of NVL2 and DECODE

2018-10-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11758 ) Change subject: IMPALA-7739 IMPALA-7740: [DOCS] Correct descriptions of NVL2 and DECODE .. Patch Set 4: Code-Review+1 Very nice. Great

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-23 Thread Paul Rogers (Code Review)
Hello Philip Zeyliger, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11760 to look at the new patch set (#4). Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-23 Thread Paul Rogers (Code Review)
Hello Philip Zeyliger, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11760 to look at the new patch set (#3). Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 2: (6 comments)

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11887 ) Change subject: IMPALA-7818: Standardize use of Expr predicates .. Patch Set 3: Dry-run passed:

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11887 ) Change subject: IMPALA-7818: Standardize use of Expr predicates .. Patch Set 4: (2 comments) Fixed check style warnings.

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Paul Rogers (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11887 to look at the new patch set (#4). Change subject: IMPALA-7818: Standardize use of Expr predicates

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11887 Change subject: IMPALA-7818: Standardize use of Expr predicates .. IMPALA-7818: Standardize use of Expr predicates The Expr node provids

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-07 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 1: Dry-run tests passed:

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-07 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11893 Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. IMPALA-7823: Clean up Java warnings, fix minor issues Roll-up

[Impala-ASF-CR] IMPALA-7808: Refactor Analyzer for easier debugging

2018-11-06 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11883 ) Change subject: IMPALA-7808: Refactor Analyzer for easier debugging .. Patch Set 2: (12 comments) Thanks for the reviews. Addressed

[Impala-ASF-CR] IMPALA-7808: Refactor Analyzer for easier debugging

2018-11-06 Thread Paul Rogers (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11883 to look at the new patch set (#3). Change subject: IMPALA-7808: Refactor Analyzer for easier debugging

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Paul Rogers (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11887 to look at the new patch set (#5). Change subject: IMPALA-7818: Standardize use of Expr predicates

[Impala-ASF-CR] IMPALA-7818: Standardize use of Expr predicates

2018-11-07 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11887 ) Change subject: IMPALA-7818: Standardize use of Expr predicates .. Patch Set 5: (5 comments) Thanks Vuk for the review. Addressed your

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-07 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-07 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 1: (3 comments) Thanks Bharath for the review.

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-07 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11893 to look at the new patch set (#2). Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues

[Impala-ASF-CR] IMPALA-7310: Use NDV=1 for a Column with all nulls

2018-11-08 Thread Paul Rogers (Code Review)
Hello Philip Zeyliger, Bikramjeet Vig, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11528 to look at the new patch set (#13). Change subject: IMPALA-7310: Use NDV=1 for a Column with all nulls

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-11-08 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11881 ) Change subject: IMPALA-7807: Analysis test fixture .. IMPALA-7807: Analysis test fixture Refactors the existing ExprRewriteRulesTest to

[Impala-ASF-CR] IMPALA-7805: Emit zero as "0" in toSql()

2018-11-08 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11878 ) Change subject: IMPALA-7805: Emit zero as "0" in toSql() .. IMPALA-7805: Emit zero as "0" in toSql() It turns out that Impala has a

[Impala-ASF-CR] IMPALA-7310: Use NDV=1 for a Column with all nulls

2018-11-08 Thread Paul Rogers (Code Review)
Hello Philip Zeyliger, Bikramjeet Vig, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11528 to look at the new patch set (#14). Change subject: IMPALA-7310: Use NDV=1 for a Column with all nulls

[Impala-ASF-CR] IMPALA-7310: Use NDV=1 for a Column with all nulls

2018-11-08 Thread Paul Rogers (Code Review)
Hello Philip Zeyliger, Bikramjeet Vig, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11528 to look at the new patch set (#15). Change subject: IMPALA-7310: Use NDV=1 for a Column with all nulls

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-11-13 Thread Paul Rogers (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11920 to look at the new patch set (#2). Change subject: IMPALA-7842: Make query fragments available for unit testing

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-11-13 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Make query fragments available for unit testing .. Patch Set 2: (2 comments) Thanks, Phil, for the

[Impala-ASF-CR] IMPALA-7841: Refactor QueryStmt, etc. for easier debugging

2018-11-13 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11915 ) Change subject: IMPALA-7841: Refactor QueryStmt, etc. for easier debugging .. Patch Set 1: Dry-run tests passed:

[Impala-ASF-CR] IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging

2018-11-15 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11890 ) Change subject: IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging .. Patch Set 2: (4 comments) Thanks for the reviews.

[Impala-ASF-CR] IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging

2018-11-15 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11890 to look at the new patch set (#2). Change subject: IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-15 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-11-15 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11881 to look at the new patch set (#5). Change subject: IMPALA-7807: Analysis test fixture

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-11-15 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11881 to look at the new patch set (#4). Change subject: IMPALA-7807: Analysis test fixture

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-11-05 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11881 Change subject: IMPALA-7807: Analysis test fixture .. IMPALA-7807: Analysis test fixture Refactors the existing ExprRewriteRulesTest to

[Impala-ASF-CR] IMPALA-7805: Emit zero as "0" in toSql()

2018-11-05 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11878 Change subject: IMPALA-7805: Emit zero as "0" in toSql() .. IMPALA-7805: Emit zero as "0" in toSql() It turns out that Impala has a

[Impala-ASF-CR] IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging

2018-11-06 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11890 Change subject: IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging .. IMPALA-7821: Refactor ExprRewriteRulesTest for easier

[Impala-ASF-CR] IMPALA-7808: Refactor Analyzer for easier debugging

2018-11-06 Thread Paul Rogers (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11883 to look at the new patch set (#4). Change subject: IMPALA-7808: Refactor Analyzer for easier debugging

[Impala-ASF-CR] IMPALA-7808: Refactor Analyzer for easier debugging

2018-11-05 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11883 Change subject: IMPALA-7808: Refactor Analyzer for easier debugging .. IMPALA-7808: Refactor Analyzer for easier debugging Changes two

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-08 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11893 to look at the new patch set (#3). Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues

[Impala-ASF-CR] IMPALA-7310: Use NDV=1 for a Column with all nulls

2018-11-08 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11528 ) Change subject: IMPALA-7310: Use NDV=1 for a Column with all nulls .. Patch Set 12: Bikramjeet, please take a look at this fix to see

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-11-11 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11920 Change subject: IMPALA-7842: Make query fragments available for unit testing .. IMPALA-7842: Make query fragments available for unit

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-11-11 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Make query fragments available for unit testing .. Patch Set 1: Dry-run tests passed:

[Impala-ASF-CR] IMPALA-7841: Refactor QueryStmt, etc. for easier debugging

2018-11-09 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11915 Change subject: IMPALA-7841: Refactor QueryStmt, etc. for easier debugging .. IMPALA-7841: Refactor QueryStmt, etc. for easier debugging

[Impala-ASF-CR] Use NDV=1 for a Column with all nulls

2018-10-02 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11528 ) Change subject: Use NDV=1 for a Column with all nulls .. Patch Set 10: (3 comments) Thanks for the continued reviews. Cleaned up a few

[Impala-ASF-CR] Use NDV=1 for a Column with all nulls

2018-10-02 Thread Paul Rogers (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11528 to look at the new patch set (#10). Change subject: Use NDV=1 for a Column with all nulls

[Impala-ASF-CR] IMPALA-7310: All-null columns give wrong estimates in planner

2018-10-02 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/11544 ) Change subject: IMPALA-7310: All-null columns give wrong estimates in planner .. Abandoned Duplicate of 11528 -- To view, visit

[Impala-ASF-CR] IMPALA-7310: All-null columns give wrong estimates in planner

2018-09-28 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11544 Change subject: IMPALA-7310: All-null columns give wrong estimates in planner .. IMPALA-7310: All-null columns give wrong estimates in

[Impala-ASF-CR] IMPALA-7310: All-null columns give wrong estimates in planner

2018-09-28 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11528 ) Change subject: IMPALA-7310: All-null columns give wrong estimates in planner .. Patch Set 8: (32 comments) Thanks for the reviews.

[Impala-ASF-CR] IMPALA-7310: All-null columns give wrong estimates in planner

2018-09-28 Thread Paul Rogers (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11528 to look at the new patch set (#8). Change subject: IMPALA-7310: All-null columns give wrong estimates in planner

[Impala-ASF-CR] IMPALA-7310: All-null columns give wrong estimates in planner

2018-09-28 Thread Paul Rogers (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11528 to look at the new patch set (#7). Change subject: IMPALA-7310: All-null columns give wrong estimates in planner

[Impala-ASF-CR] IMPALA-7310: All-null columns give wrong estimates in planner

2018-10-01 Thread Paul Rogers (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11528 to look at the new patch set (#9). Change subject: IMPALA-7310: All-null columns give wrong estimates in planner

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-16 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11942 ) Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. Patch Set 2: (6 comments) Thanks much for the improvement.

[Impala-ASF-CR] IMPALA-7867 (Part 4): Collection cleanup in catalog

2018-12-27 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12131 Change subject: IMPALA-7867 (Part 4): Collection cleanup in catalog .. IMPALA-7867 (Part 4): Collection cleanup in catalog Continues the

[Impala-ASF-CR] IMPALA-7970 : Add support for metastore event based automatic invalidate

2018-12-27 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for metastore event based automatic invalidate .. Patch Set 9: (39 comments) This will be a

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-27 Thread Paul Rogers (Code Review)
Hello Fredy Wijaya, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12079 to look at the new patch set (#6). Change subject: IMPALA-7968, Part 1: JSON serialization framework

[Impala-ASF-CR] IMPALA-7867 (Part 4): Collection cleanup in catalog

2018-12-27 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12131 ) Change subject: IMPALA-7867 (Part 4): Collection cleanup in catalog .. Patch Set 2: Pre-review tests passed:

[Impala-ASF-CR] IMPALA-7970 : Add support for metastore event based automatic invalidate

2018-12-27 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for metastore event based automatic invalidate .. Patch Set 9: (20 comments) Remaining

[Impala-ASF-CR] IMPALA-5973: Provide query plan in JSON format

2018-12-27 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11974 ) Change subject: IMPALA-5973: Provide query plan in JSON format .. Patch Set 3: Update on this one. Been working on a tricky planner

[Impala-ASF-CR] IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging

2018-12-27 Thread Paul Rogers (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11915 to look at the new patch set (#2). Change subject: IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging

[Impala-ASF-CR] IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging

2018-12-27 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11915 ) Change subject: IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging .. Patch Set 2: Reduced the scope of the change for

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-27 Thread Paul Rogers (Code Review)
Hello Fredy Wijaya, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12079 to look at the new patch set (#7). Change subject: IMPALA-7968, Part 1: JSON serialization framework

[Impala-ASF-CR] IMPALA-8041, Part 1: Move rewrite rules into expr nodes

2019-01-06 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12143 Change subject: IMPALA-8041, Part 1: Move rewrite rules into expr nodes .. IMPALA-8041, Part 1: Move rewrite rules into expr nodes This

[Impala-ASF-CR] IMPALA-8041, Part 1: Move rewrite rules into expr nodes

2019-01-06 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12143 ) Change subject: IMPALA-8041, Part 1: Move rewrite rules into expr nodes .. Patch Set 1: Passed pre-commit tests:

[Impala-ASF-CR] IMPALA-8058: Fallback for HBase key scan range estimation

2019-01-18 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Zoram Thanga, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12192 to look at the new patch set (#2). Change subject: IMPALA-8058: Fallback for HBase key scan range estimation

[Impala-ASF-CR] IMPALA-8058: Fallback for HBase key scan range estimation

2019-01-18 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12192 ) Change subject: IMPALA-8058: Fallback for HBase key scan range estimation .. Patch Set 2: (3 comments) Addressed code review comments.

  1   2   3   4   5   >