[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5017: Error on decimal overflow

2017-11-30 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8404 ) Change subject: IMPALA-5017: Error on decimal overflow .. IMPALA-5017: Error on decimal overflow Before this patch, decimal

[Impala-ASF-CR] IMPALA-5017: Error on decimal overflow

2017-11-30 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/8404 ) Change subject: IMPALA-5017: Error on decimal overflow .. IMPALA-5017: Error on decimal overflow Before this patch, decimal

[Impala-ASF-CR] IMPALA-5017: Error on decimal overflow

2017-11-30 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8404 ) Change subject: IMPALA-5017: Error on decimal overflow .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5017: Error on decimal overflow

2017-11-30 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8404 ) Change subject: IMPALA-5017: Error on decimal overflow .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5017: Error on decimal overflow

2017-12-01 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/8404 ) Change subject: IMPALA-5017: Error on decimal overflow .. IMPALA-5017: Error on decimal overflow Before this patch, decimal

[Impala-ASF-CR] IMPALA-6284: Mark the intermediate decimal avg struct as packed

2017-12-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8836 ) Change subject: IMPALA-6284: Mark the intermediate decimal avg struct as packed .. IMPALA-6284: Mark the intermediate decimal avg

[Impala-ASF-CR] IMPALA-6284: Mark the intermediate decimal avg struct as packed

2017-12-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8836 ) Change subject: IMPALA-6284: Mark the intermediate decimal avg struct as packed .. Patch Set 3: Code-Review+2 Fixed the expected

[Impala-ASF-CR] IMPALA-6284: Mark the intermediate decimal avg struct as packed

2017-12-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8836 ) Change subject: IMPALA-6284: Mark the intermediate decimal avg struct as packed .. Patch Set 1: I'm not really sure what a new

[Impala-ASF-CR] IMPALA-6284: Mark the intermediate decimal avg struct as packed

2017-12-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8836 ) Change subject: IMPALA-6284: Mark the intermediate decimal avg struct as packed .. IMPALA-6284: Mark the intermediate decimal avg

[Impala-ASF-CR] IMPALA-6284: Mark the intermediate decimal avg struct as packed

2017-12-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8836 ) Change subject: IMPALA-6284: Mark the intermediate decimal avg struct as packed .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. IMPALA-6300: Fix decimal modulo overflow In order to compute the modulo

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

2017-12-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 2: (9 comments)

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8833 Change subject: IMPALA-6300: Fix decimal modulo overflow .. IMPALA-6300: Fix decimal modulo overflow In order to compute the modulo

[Impala-ASF-CR] IMPALA-5191: Standardize column alias behavior

2017-12-12 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8801 ) Change subject: IMPALA-5191: Standardize column alias behavior .. Patch Set 4: (7 comments)

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-12-12 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has abandoned this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Abandoned We decided that rounding a double should return a double

[Impala-ASF-CR] IMPALA-5191: Standardize column alias behavior

2017-12-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8801 ) Change subject: IMPALA-5191: Standardize column alias behavior .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-11-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2017-11-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 9: (20 comments)

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2017-11-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8574 ) Change subject: IMPALA-5936: operator '%' overflows on large decimals .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-4964: Fix Decimal modulo overflow

2017-11-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/8329 ) Change subject: IMPALA-4964: Fix Decimal modulo overflow .. IMPALA-4964: Fix Decimal modulo overflow The modulo operation between

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-11-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. IMPALA-5019: Decimal V2 addition In this patch, we implement the new decimal

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-11-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-11-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. Patch Set 5: Code-Review+1 Carrying the +1 from Tim -- To view, visit

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 4: Code-Review-1 The current plan is to go in a

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-11-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-12-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 17: (1 comment)

[Impala-ASF-CR] IMPALA-6292: Fix incorrect DCHECK in decimal subtraction

2017-12-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8796 Change subject: IMPALA-6292: Fix incorrect DCHECK in decimal subtraction .. IMPALA-6292: Fix incorrect DCHECK in decimal subtraction

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

2017-12-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8774 Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. IMPALA-5014: Part 1: Round when casting string to

[Impala-ASF-CR] IMPALA-5191: Behavior of column aliases should be more standard conforming

2017-12-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8801 ) Change subject: IMPALA-5191: Behavior of column aliases should be more standard conforming .. Patch Set 3: (7 comments)

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

2017-12-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 1: (11 comments)

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

2017-12-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. IMPALA-5014: Part 1: Round when casting string to

[Impala-ASF-CR] IMPALA-6949: Add the option to start the minicluster with EC enabled

2018-05-04 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10275 ) Change subject: IMPALA-6949: Add the option to start the minicluster with EC enabled .. Patch Set 5: Code-Review+2 Added

[Impala-ASF-CR] IMPALA-6949: Add the option to start the minicluster with EC enabled

2018-05-04 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/10275 ) Change subject: IMPALA-6949: Add the option to start the minicluster with EC enabled .. IMPALA-6949: Add the option to start the

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

2018-04-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 9: (3 comments)

[Impala-ASF-CR] Speed up Python dependencies.

2018-04-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10234 ) Change subject: Speed up Python dependencies. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

2018-04-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 10: (3 comments)

[Impala-ASF-CR] Speed up Python dependencies.

2018-04-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10234 ) Change subject: Speed up Python dependencies. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Speed up Python dependencies.

2018-04-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10234 ) Change subject: Speed up Python dependencies. .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

2018-04-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 10: (5 comments)

[Impala-ASF-CR] IMPALA-7019: Schedule EC as remote & disable failed tests

2018-05-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10413 ) Change subject: IMPALA-7019: Schedule EC as remote & disable failed tests .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-05-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-7079: Disable the multiple blocks test in erasure coding build

2018-05-25 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10521 Change subject: IMPALA-7079: Disable the multiple blocks test in erasure coding build .. IMPALA-7079: Disable the multiple blocks

[Impala-ASF-CR] IMPALA-7019: Schedule EC as remote & disable failed tests

2018-05-18 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10413 ) Change subject: IMPALA-7019: Schedule EC as remote & disable failed tests .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-7039: Ignore the port in HBase planner tests

2018-05-18 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10459 Change subject: IMPALA-7039: Ignore the port in HBase planner tests .. IMPALA-7039: Ignore the port in HBase planner tests Before

[Impala-ASF-CR] IMPALA-7019: Schedule EC as remote & disable failed tests

2018-05-18 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10413 ) Change subject: IMPALA-7019: Schedule EC as remote & disable failed tests .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-7102: Disable support of erasure coding by default

2018-06-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10646 Change subject: IMPALA-7102: Disable support of erasure coding by default .. IMPALA-7102: Disable support of erasure coding by

[Impala-ASF-CR] IMPALA-7149: Skip q7 in test mem usage scaling in erasure coding build

2018-06-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10647 Change subject: IMPALA-7149: Skip q7 in test_mem_usage_scaling in erasure coding build .. IMPALA-7149: Skip q7 in

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 20: (1 comment)

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 21: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6642 (Part 2): Add timestamps to start-impala-cluster.py

2018-06-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10780 ) Change subject: IMPALA-6642 (Part 2): Add timestamps to start-impala-cluster.py .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6642 (Part 2): clean up start-impala-cluster.py

2018-06-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10780 ) Change subject: IMPALA-6642 (Part 2): clean up start-impala-cluster.py .. IMPALA-6642 (Part 2): clean up start-impala-cluster.py We

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 16: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7149: Disable some tests in the EC build

2018-06-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10804 Change subject: IMPALA-7149: Disable some tests in the EC build .. IMPALA-7149: Disable some tests in the EC build We temporarily

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 15: Also, I agree with Tim that it's a good idea to add this

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 15: I already let Anuj know offline that it's ok to remove

[Impala-ASF-CR] IMPALA-6642 (Part 2): Add timestamps to start-impala-cluster.py

2018-06-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10780 Change subject: IMPALA-6642 (Part 2): Add timestamps to start-impala-cluster.py .. IMPALA-6642 (Part 2): Add timestamps to

[Impala-ASF-CR] IMPALA-7102: Disable support of erasure coding by default

2018-06-26 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10646 ) Change subject: IMPALA-7102: Disable support of erasure coding by default .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7102(Part 1): Disable reading of erasure coding by default

2018-06-26 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10646 ) Change subject: IMPALA-7102(Part 1): Disable reading of erasure coding by default .. IMPALA-7102(Part 1): Disable reading of

[Impala-ASF-CR] IMPALA-7102 (Part 1): Disable reading of erasure coding by default

2018-06-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10646 ) Change subject: IMPALA-7102 (Part 1): Disable reading of erasure coding by default .. Patch Set 4: Code-Review+2 Fixed a typo in

[Impala-ASF-CR] IMPALA-6949: Add the option to start the minicluster with EC enabled

2018-05-01 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10275 Change subject: IMPALA-6949: Add the option to start the minicluster with EC enabled .. IMPALA-6949: Add the option to start the

[Impala-ASF-CR] IMPALA-6949: Add the option to start the minicluster with EC enabled

2018-05-01 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10275 ) Change subject: IMPALA-6949: Add the option to start the minicluster with EC enabled .. IMPALA-6949: Add the option to start the

[Impala-ASF-CR] IMPALA-6949: Add the option to start the minicluster with EC enabled

2018-05-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10275 ) Change subject: IMPALA-6949: Add the option to start the minicluster with EC enabled .. IMPALA-6949: Add the option to start the

[Impala-ASF-CR] IMPALA-6949: Add the option to start the minicluster with EC enabled

2018-05-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10275 ) Change subject: IMPALA-6949: Add the option to start the minicluster with EC enabled .. Patch Set 2: (5 comments) Yes, nested

[Impala-ASF-CR] WIP: IMPALA-6518,IMPALA-6340: Check that decimal types are compatible in FE

2018-04-26 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9930 ) Change subject: WIP: IMPALA-6518,IMPALA-6340: Check that decimal types are compatible in FE .. Patch Set 8: (6 comments)

[Impala-ASF-CR] IMPALA-6340,IMPALA-6518: Check that decimal types are compatible in FE

2018-04-26 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/9930 ) Change subject: IMPALA-6340,IMPALA-6518: Check that decimal types are compatible in FE .. IMPALA-6340,IMPALA-6518: Check that

[Impala-ASF-CR] IMPALA-6340,IMPALA-6518: Check that decimal types are compatible in FE

2018-04-26 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/9930 ) Change subject: IMPALA-6340,IMPALA-6518: Check that decimal types are compatible in FE .. IMPALA-6340,IMPALA-6518: Check that

[Impala-ASF-CR] IMPALA-6949: Add the option to start the minicluster with EC enabled

2018-05-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/10275 ) Change subject: IMPALA-6949: Add the option to start the minicluster with EC enabled .. IMPALA-6949: Add the option to start the

[Impala-ASF-CR] IMPALA-6949: Add the option to start the minicluster with EC enabled

2018-05-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10275 ) Change subject: IMPALA-6949: Add the option to start the minicluster with EC enabled .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-7202: Add width bucket() to the decimal fuzz test

2018-07-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10859 Change subject: IMPALA-7202: Add width_bucket() to the decimal fuzz test .. IMPALA-7202: Add width_bucket() to the decimal fuzz

[Impala-ASF-CR] IMPALA-6231: Implement decimal v2 fuzz test

2018-01-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8898 ) Change subject: IMPALA-6231: Implement decimal_v2 fuzz test .. IMPALA-6231: Implement decimal_v2 fuzz test Implement a test that

[Impala-ASF-CR] IMPALA-6231: Implement decimal v2 fuzz test

2018-01-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8898 ) Change subject: IMPALA-6231: Implement decimal_v2 fuzz test .. Patch Set 1: (8 comments)

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. IMPALA-6300: Fix decimal modulo overflow In order to compute the modulo

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. Patch Set 5: Code-Review+2 Made a minor change to overflow benchmark.

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

2017-12-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 4: Code-Review+2 Fixed the issue with the

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

2017-12-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 3: (2 comments) Thanks for the review,

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2017-12-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 2: I agree that it's probably best to unblock first.

[Impala-ASF-CR] IMPALA-5478: Run TPCDS queries with decimal v2 enabled

2018-01-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8985 Change subject: IMPALA-5478: Run TPCDS queries with decimal_v2 enabled .. IMPALA-5478: Run TPCDS queries with decimal_v2 enabled We

[Impala-ASF-CR] IMPALA-5014: Part 2: Round when casting decimal to timestamp

2018-01-08 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8969 Change subject: IMPALA-5014: Part 2: Round when casting decimal to timestamp .. IMPALA-5014: Part 2: Round when casting decimal to

[Impala-ASF-CR] IMPALA-5014: Part 2: Round when casting decimal to timestamp

2018-01-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8969 ) Change subject: IMPALA-5014: Part 2: Round when casting decimal to timestamp .. IMPALA-5014: Part 2: Round when casting decimal to

[Impala-ASF-CR] IMPALA-5478: Run TPCDS queries with decimal v2 enabled

2018-01-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8985 ) Change subject: IMPALA-5478: Run TPCDS queries with decimal_v2 enabled .. IMPALA-5478: Run TPCDS queries with decimal_v2 enabled We

[Impala-ASF-CR] IMPALA-6231: Implement decimal v2 fuzz test

2018-01-08 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8898 ) Change subject: IMPALA-6231: Implement decimal_v2 fuzz test .. IMPALA-6231: Implement decimal_v2 fuzz test Implement a test that

[Impala-ASF-CR] IMPALA-6388: Fix the Union node number of hosts estimation

2018-01-16 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9017 ) Change subject: IMPALA-6388: Fix the Union node number of hosts estimation .. Patch Set 5: bump up* -- To view, visit

[Impala-ASF-CR] IMPALA-6388: Fix the Union node number of hosts estimation

2018-01-16 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9017 ) Change subject: IMPALA-6388: Fix the Union node number of hosts estimation .. Patch Set 5: I pump up the max row size in the

[Impala-ASF-CR] IMPALA-6388: Fix the Union node number of hosts estimation

2018-01-16 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/9017 ) Change subject: IMPALA-6388: Fix the Union node number of hosts estimation .. IMPALA-6388: Fix the Union node number of hosts

[Impala-ASF-CR] IMPALA-4924: Enable Decimal V2 by default

2018-01-18 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9062 Change subject: IMPALA-4924: Enable Decimal V2 by default .. IMPALA-4924: Enable Decimal V2 by default In this commit we enable

[Impala-ASF-CR] IMPALA-4924: Enable Decimal V2 by default

2018-01-19 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9062 ) Change subject: IMPALA-4924: Enable Decimal V2 by default .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-4924: Enable Decimal V2 by default

2018-01-19 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/9062 ) Change subject: IMPALA-4924: Enable Decimal V2 by default .. IMPALA-4924: Enable Decimal V2 by default In this commit we enable

[Impala-ASF-CR] IMPALA-4924: Enable Decimal V2 by default

2018-01-18 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/9062 ) Change subject: IMPALA-4924: Enable Decimal V2 by default .. IMPALA-4924: Enable Decimal V2 by default In this commit we enable

[Impala-ASF-CR] IMPALA-4924: Enable Decimal V2 by default

2018-01-19 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/9062 ) Change subject: IMPALA-4924: Enable Decimal V2 by default .. IMPALA-4924: Enable Decimal V2 by default In this commit we enable

[Impala-ASF-CR] IMPALA-4924: Enable Decimal V2 by default

2018-01-19 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9062 ) Change subject: IMPALA-4924: Enable Decimal V2 by default .. Patch Set 4: (6 comments)

[Impala-ASF-CR] IMPALA-4924: Enable Decimal V2 by default

2018-01-18 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9062 ) Change subject: IMPALA-4924: Enable Decimal V2 by default .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-6410: Tool to cherrypick changes across branches.

2018-01-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9045 ) Change subject: IMPALA-6410: Tool to cherrypick changes across branches. .. Patch Set 2: (3 comments)

[Impala-ASF-CR] Bumping version to 3.0.

2018-01-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9044 ) Change subject: Bumping version to 3.0. .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/9044 To

[Impala-ASF-CR] IMPALA-5478: Run TPCDS queries with decimal v2 enabled

2018-01-16 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8985 ) Change subject: IMPALA-5478: Run TPCDS queries with decimal_v2 enabled .. IMPALA-5478: Run TPCDS queries with decimal_v2 enabled We

  1   2   3   >