[Impala-ASF-CR] IMPALA-4369: Avoid DCHECK in Parquet scanner with MT DOP > 0.

2016-10-25 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/4851 Change subject: IMPALA-4369: Avoid DCHECK in Parquet scanner with MT_DOP > 0. .. IMPALA-4369: Avoid DCHECK in Parquet scanner with MT_DOP >

[Impala-ASF-CR] IMPALA-4336: Cast exprs after unnesting union operands.

2016-10-25 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4336: Cast exprs after unnesting union operands. .. Patch Set 1: (8 comments) Flushing some initial comments. Still need to wrap my head around

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-25 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-2521: Add clustered hint to insert statements .. Patch Set 13: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4745 To unsubscribe,

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-25 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-2521: Add clustered hint to insert statements .. IMPALA-2521: Add clustered hint to insert statements This change introduces a

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-10-25 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4023: don't attach buffered tuple streams to batches .. IMPALA-4023: don't attach buffered tuple streams to batches This simplifies the

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-10-25 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4023: don't attach buffered tuple streams to batches .. Patch Set 13: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4448 To

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-10-25 Thread Amos Bird (Code Review)
Hello Marcel Kornacker, Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3942 to look at the new patch set (#19). Change subject: IMPALA-1654: General partition exprs in DDL operations.

[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-10-25 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load .. Patch Set 7: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4362: Misc. fixes for PFE counters

2016-10-25 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4362: Misc. fixes for PFE counters .. IMPALA-4362: Misc. fixes for PFE counters * ExecTime was always 0, because it wasn't updated before the

[Impala-ASF-CR] IMPALA-4362: Misc. fixes for PFE counters

2016-10-25 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4362: Misc. fixes for PFE counters .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4829 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4277: remove unneeded LegacyTCLIService

2016-10-25 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4277: remove unneeded LegacyTCLIService .. IMPALA-4277: remove unneeded LegacyTCLIService Change-Id:

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-25 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 13: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4047 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4277: remove unneeded LegacyTCLIService

2016-10-25 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4277: remove unneeded LegacyTCLIService .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4844 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3838: Codegen EvalRuntimeFilters().

2016-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3838: Codegen EvalRuntimeFilters(). .. Patch Set 1: (7 comments) Mostly looks good - would be good to know whether any queries regressed with the

[Impala-ASF-CR] IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions

2016-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions .. Patch Set 9: (8 comments) Rebased to pick up IMPALA-3884

[Impala-ASF-CR] IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions

2016-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#9). Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions .. IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions This change enables codegen

[Impala-ASF-CR] Move vim-specific config file to top level directory

2016-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Move vim-specific config file to top level directory .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4850 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3788: Support for Kudu 'read-your-writes' consistency

2016-10-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3788: Support for Kudu 'read-your-writes' consistency .. Patch Set 4: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions

2016-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#8). Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions .. IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions This change enables codegen

[Impala-ASF-CR] Move vim-specific config file to top level directory

2016-10-25 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/4850 Change subject: Move vim-specific config file to top level directory .. Move vim-specific config file to top level directory Files in be/

[Impala-ASF-CR] Enabling end-to-end tests on a remote cluster

2016-10-25 Thread Harrison Sheinblatt (Code Review)
Harrison Sheinblatt has posted comments on this change. Change subject: Enabling end-to-end tests on a remote cluster .. Patch Set 1: (3 comments) Responded to comments.

[Impala-ASF-CR] Enabling end-to-end tests on a remote cluster

2016-10-25 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Enabling end-to-end tests on a remote cluster .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/4769/1/bin/remote_data_load.py File

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-10-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/4849 Change subject: IMPALA-3771: Expose kudu client timeout and set default .. IMPALA-3771: Expose kudu client timeout and set default The

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2521: Add clustered hint to insert statements .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4745 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-10-25 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3676: Use clang as a static analysis tool .. Patch Set 7: > > I rearranged them all. Tim convinced me to roll some back. > > That doesn't really answer my

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-25 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2521: Add clustered hint to insert statements .. Patch Set 13: Alex, can you +2 this again? The tests got renamed and I didn't catch the syntax error when

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-25 Thread Lars Volker (Code Review)
Hello Marcel Kornacker, Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4745 to look at the new patch set (#13). Change subject: IMPALA-2521: Add clustered hint to insert statements

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-10-25 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3676: Use clang as a static analysis tool .. Patch Set 6: > I rearranged them all. Tim convinced me to roll some back. That doesn't really answer my

[Impala-ASF-CR] IMPALA-4153: Fix count(*) on all blank('') columns - test

2016-10-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4153: Fix count(*) on all blank('') columns - test .. Patch Set 1: Laszlo, can you try merging this again or is there something wrong with the patch? --

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4023: don't attach buffered tuple streams to batches .. Patch Set 13: Code-Review+2 (1 comment) Carry +2

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-10-25 Thread Tim Armstrong (Code Review)
Hello Internal Jenkins, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4448 to look at the new patch set (#12). Change subject: IMPALA-4023: don't attach buffered tuple streams to batches

[Impala-ASF-CR] IMPALA-3872: allow providing PyPi mirror for python packages

2016-10-25 Thread Tim Armstrong (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4770 to look at the new patch set (#4). Change subject: IMPALA-3872: allow providing PyPi mirror for python packages ..

[Impala-ASF-CR] IMPALA-3872: allow providing PyPi mirror for python packages

2016-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3872: allow providing PyPi mirror for python packages .. Patch Set 4: Code-Review+1 Carry +1 -- To view, visit http://gerrit.cloudera.org:8080/4770 To

[Impala-ASF-CR] IMPALA-3872: allow providing PyPi mirror for python packages

2016-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3872: allow providing PyPi mirror for python packages .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-3202: DiskIoMgr improvements for new buffer pool

2016-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: DiskIoMgr improvements for new buffer pool .. Patch Set 1: (8 comments)

[Impala-ASF-CR] IMPALA-3202: DiskIoMgr improvements for new buffer pool

2016-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-3202: DiskIoMgr improvements for new buffer pool .. IMPALA-3202: DiskIoMgr improvements for new buffer pool The main goal of this patch is to add support

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-25 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-2521: Add clustered hint to insert statements .. Patch Set 12: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4362: Misc. fixes for PFE counters

2016-10-25 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4362: Misc. fixes for PFE counters .. Patch Set 2: Code-Review+2 Rebase. -- To view, visit http://gerrit.cloudera.org:8080/4829 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4362: Misc. fixes for PFE counters

2016-10-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4362: Misc. fixes for PFE counters .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4829 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3788: Support for Kudu 'read-your-writes' consistency

2016-10-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3788: Support for Kudu 'read-your-writes' consistency .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-4350: Crash with vlog level 2 in hash join node

2016-10-25 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4350: Crash with vlog level 2 in hash join node .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4830 To unsubscribe,

[Impala-ASF-CR] IMPALA-4350: Crash with vlog level 2 in hash join node

2016-10-25 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4350: Crash with vlog level 2 in hash join node .. IMPALA-4350: Crash with vlog level 2 in hash join node Testing: Reproduced by running

[Impala-ASF-CR] IMPALA-3872: allow providing PyPi mirror for python packages

2016-10-25 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3872: allow providing PyPi mirror for python packages .. Patch Set 3: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-10-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4023: don't attach buffered tuple streams to batches .. Patch Set 11: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-3872: allow providing PyPi mirror for python packages

2016-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3872: allow providing PyPi mirror for python packages .. Patch Set 2: (2 comments)

[Impala-ASF-CR](hadoop-next) Merge remote-tracking branch 'gerrit/master' into HEAD

2016-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: Merge remote-tracking branch 'gerrit/master' into HEAD .. Merge remote-tracking branch 'gerrit/master' into HEAD Change-Id:

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-10-25 Thread Tim Armstrong (Code Review)
Hello Internal Jenkins, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4448 to look at the new patch set (#10). Change subject: IMPALA-4023: don't attach buffered tuple streams to batches

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4756 To

[Impala-ASF-CR] IMPALA-4260: Alter table add column drops all the column stats

2016-10-25 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4260: Alter table add column drops all the column stats .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4340: explain how to install postgresql-9.5 or higher

2016-10-25 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/4846 Change subject: IMPALA-4340: explain how to install postgresql-9.5 or higher .. IMPALA-4340: explain how to install postgresql-9.5 or

[Impala-ASF-CR] IMPALA-4277: remove unneeded LegacyTCLIService

2016-10-25 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4277: remove unneeded LegacyTCLIService .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4844 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-25 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 6: (4 comments)

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-25 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#6). Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. IMPALA-1169: Admission control info on the queries debug webpage This patch adds a

[Impala-ASF-CR] IMPALA-4277: remove unneeded LegacyTCLIService

2016-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4844 Change subject: IMPALA-4277: remove unneeded LegacyTCLIService .. IMPALA-4277: remove unneeded LegacyTCLIService Change-Id:

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. Patch Set 17: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4349 To

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-25 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4047 to look at the new patch set (#13). Change subject: IMPALA-3725 Support Kudu UPSERT in Impala ..

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2016-10-25 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#3). Change subject: IMPALA-4086: Add benchmark for simple scheduler .. IMPALA-4086: Add benchmark for simple scheduler Change-Id: I89ec1c6c1828bb0b86d1e13ce4dfc5a8df865c2e --- M

[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-10-25 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4617 To

[Impala-ASF-CR] IMPALA-3202: DiskIoMgr improvements for new buffer pool

2016-10-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3202: DiskIoMgr improvements for new buffer pool .. Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/4631/1/be/src/exec/hdfs-scan-node-base.h

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-25 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#19). Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-25 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#19). Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2016-10-25 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-4086: Add benchmark for simple scheduler .. IMPALA-4086: Add benchmark for simple scheduler Change-Id: I89ec1c6c1828bb0b86d1e13ce4dfc5a8df865c2e --- M

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2016-10-25 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 1: (3 comments) Thanks Tim for the review. I addressed your comments in PS2. I will rebase this

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2521: Add clustered hint to insert statements .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4745 To unsubscribe, visit

[Impala-ASF-CR](hadoop-next) Merge remote-tracking branch 'gerrit/master' into HEAD

2016-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Merge remote-tracking branch 'gerrit/master' into HEAD .. Patch Set 1: Code-Review+2 Verified+1 Clean merge -- To view, visit

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-25 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2521: Add clustered hint to insert statements .. Patch Set 12: Rebase done in PS12 -- To view, visit http://gerrit.cloudera.org:8080/4745 To unsubscribe,

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-25 Thread Lars Volker (Code Review)
Hello Marcel Kornacker, Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4745 to look at the new patch set (#12). Change subject: IMPALA-2521: Add clustered hint to insert statements

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 5: Thanks! Do the exhaustive AC tests pass? -- To view, visit

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-25 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-4223: Handle truncated file read from HDFS cache

2016-10-25 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4223: Handle truncated file read from HDFS cache .. Patch Set 1: (1 comment) > (1 comment) > > Can we test this by having the test load metadata and

[Impala-ASF-CR] IMPALA-4350: Crash with vlog level 2 in hash join node

2016-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4350: Crash with vlog level 2 in hash join node .. Patch Set 2: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/4830 To

[Impala-ASF-CR] Remove seemingly incorrect DCHECK-s.

2016-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Remove seemingly incorrect DCHECK-s. .. Patch Set 1: (1 comment) I agree that this looks like a bug. http://gerrit.cloudera.org:8080/#/c/4835/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-25 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#7). Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. IMPALA-4309: Introduce Expr rewrite phase and supporting classes. Introduces a new phase for

[Impala-ASF-CR] IMPALA-4223: Handle truncated file read from HDFS cache

2016-10-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4223: Handle truncated file read from HDFS cache .. Patch Set 1: (1 comment) Can we test this by having the test load metadata and then truncate a cached

[Impala-ASF-CR] Remove seemingly incorrect DCHECK-s.

2016-10-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Remove seemingly incorrect DCHECK-s. .. Patch Set 1: Is it reasonably possible to create a file that demonstrates this and can be added to the regression test

[Impala-ASF-CR] IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions

2016-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-3872: allow providing PyPi mirror for python packages

2016-10-25 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3872: allow providing PyPi mirror for python packages .. Patch Set 2: (2 comments)

[Impala-ASF-CR] Remove seemingly incorrect DCHECK-s.

2016-10-25 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has uploaded a new change for review. http://gerrit.cloudera.org:8080/4835 Change subject: Remove seemingly incorrect DCHECK-s. .. Remove seemingly incorrect DCHECK-s. The first conditional DCHECK means that if

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-25 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#18). Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-25 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#18). Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD

[Impala-ASF-CR] IMPALA-3838: Codegen EvalRuntimeFilters().

2016-10-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3838: Codegen EvalRuntimeFilters(). .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4833/1/be/src/exec/hdfs-parquet-scanner.cc File

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-25 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#18). Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-25 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions

2016-10-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions .. Patch Set 7: (8 comments)

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-25 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2521: Add clustered hint to insert statements .. Patch Set 11: Fixed AnalyzeStmtsTest, also needs another rebase due to more Kudu related changes making

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-25 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-2521: Add clustered hint to insert statements .. Patch Set 10: Verified-1 Build failed: