[Impala-ASF-CR] IMPALA-4282: Remove max length check for type strings.

2017-02-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4282: Remove max length check for type strings. .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6034 To

[Impala-ASF-CR] IMPALA-4282: Remove max length check for type strings.

2017-02-15 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-4282: Remove max length check for type strings. .. IMPALA-4282: Remove max length check for type strings. During analysis, Impala used to enforce the default

[Impala-ASF-CR] IMPALA-4282: Remove max length check for type strings.

2017-02-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4282: Remove max length check for type strings. .. Patch Set 2: Ahh right. Thanks. Done. -- To view, visit http://gerrit.cloudera.org:8080/6034 To

[Impala-ASF-CR] IMPALA-4282: Remove max length check for type strings.

2017-02-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4282: Remove max length check for type strings. .. Patch Set 1: Looks like you forgot to git-add changes from ColumnDef.java. -- To view, visit

[Impala-ASF-CR] IMPALA-4282: Remove max length check for type strings.

2017-02-15 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/6034 Change subject: IMPALA-4282: Remove max length check for type strings. .. IMPALA-4282: Remove max length check for type strings. During

[Impala-ASF-CR] IMPALA-4854: Fix incremental stats with complex types.

2017-02-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4854: Fix incremental stats with complex types. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6033 To

[Impala-ASF-CR] IMPALA-4854: Fix incremental stats with complex types.

2017-02-15 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/6033 Change subject: IMPALA-4854: Fix incremental stats with complex types. .. IMPALA-4854: Fix incremental stats with complex types. The bug:

[Impala-ASF-CR] IMPALA-2328: Read support for min/max Parquet statistics

2017-02-15 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/6032 Change subject: IMPALA-2328: Read support for min/max Parquet statistics .. IMPALA-2328: Read support for min/max Parquet statistics This

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-15 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 11: I have not updated the Python test yet, as that would require a rebase. Python test and benchmark

[Impala-ASF-CR] IMPALA-4926: Upgrade LZ4 to 1.7.5

2017-02-15 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6030 Change subject: IMPALA-4926: Upgrade LZ4 to 1.7.5 .. IMPALA-4926: Upgrade LZ4 to 1.7.5 LZ4 has deprecated the method names

[Impala-ASF-CR] IMPALA-4840: Fix REFRESH performance regression.

2017-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4840: Fix REFRESH performance regression. .. IMPALA-4840: Fix REFRESH performance regression. The fix for IMPALA-4172 introduced a

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-15 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#11). Change subject: IMPALA-2020: Add rounding for decimal casts .. IMPALA-2020: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding behavior for both

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 1: (14 comments)

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-15 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/5951/10/be/src/runtime/decimal-value.inline.h File

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-15 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5951/5/be/src/exprs/literal.cc File

[Impala-ASF-CR] IMPALA-4546: Fix Moscow timezone conversion after 2014

2017-02-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 .. IMPALA-4546: Fix Moscow timezone conversion after 2014 In 2014 Moscow timezone rules changed from

[Impala-ASF-CR] IMPALA-4546: Fix Moscow timezone conversion after 2014

2017-02-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 .. IMPALA-4546: Fix Moscow timezone conversion after 2014 In 2014 Moscow timezone rules changed from

[Impala-ASF-CR] IMPALA-4546: Fix Moscow timezone conversion after 2014

2017-02-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/5969/1/be/src/exprs/expr-test.cc

[Impala-ASF-CR] IMPALA-4937: Remove unused kudu scanner keep alive variable

2017-02-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4937: Remove unused kudu scanner keep alive variable .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6021 To unsubscribe,

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 1: (14 comments) Did you verify the memory savings with a simple experiment?

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 1: I'll do a CR later tonight or tmr morning. -- To view, visit

[Impala-ASF-CR] IMPALA-4933: Force thrift to initialize SSL on process startup

2017-02-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4933: Force thrift to initialize SSL on process startup .. Patch Set 1: Running jenkins job now, will also deploy to a secure cluster for additional

[Impala-ASF-CR] IMPALA-4933: Force thrift to initialize SSL on process startup

2017-02-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6027 Change subject: IMPALA-4933: Force thrift to initialize SSL on process startup .. IMPALA-4933: Force thrift to initialize SSL on

[Impala-ASF-CR] IMPALA-4840: Fix REFRESH performance regression.

2017-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4840: Fix REFRESH performance regression. .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/278/ -- To

[Impala-ASF-CR] IMPALA-4840: Fix REFRESH performance regression.

2017-02-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4840: Fix REFRESH performance regression. .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6009 To unsubscribe,

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#13). Change subject: IMPALA-4822: Implement dynamic log level changes .. IMPALA-4822: Implement dynamic log level changes Very often we have to change the logging levels of

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 12: (16 comments) Fxed a minor bug in the web UI where the setting for java log level

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/6025 Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this

[Impala-ASF-CR] IMPALA-4848: Add WIDHT BUCKET() function

2017-02-15 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-4848: Add WIDHT_BUCKET() function .. Patch Set 1: Will add a commit message. Results of the tests match the postgres output. aphadke-MBP-2:~ aphadke$

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-02-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough .. Patch Set 7: (40 comments) http://gerrit.cloudera.org:8080/#/c/5816/7/be/src/exec/analytic-eval-node.cc File

[Impala-ASF-CR] IMPALA-4848: Add WIDHT BUCKET() function

2017-02-15 Thread anujphadke (Code Review)
anujphadke has uploaded a new change for review. http://gerrit.cloudera.org:8080/6023 Change subject: IMPALA-4848: Add WIDHT_BUCKET() function .. IMPALA-4848: Add WIDHT_BUCKET() function Change-Id:

[Impala-ASF-CR] IMPALA-4931: Update squeasel to include patch to disable SSL init

2017-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4931: Update squeasel to include patch to disable SSL init .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4916: Fix maintenance of set of item sets in DisjointSet.

2017-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4916: Fix maintenance of set of item sets in DisjointSet. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5980 To

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-15 Thread Matthew Jacobs (Code Review)
Hello Thomas Tauber-Marshall, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5840 to look at the new patch set (#7). Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read

[Impala-ASF-CR] IMPALA-4840: Fix REFRESH performance regression.

2017-02-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4840: Fix REFRESH performance regression. .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6009 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/6013/1/be/src/util/thread.cc File

[Impala-ASF-CR] IMPALA-4840: Fix REFRESH performance regression.

2017-02-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#3). Change subject: IMPALA-4840: Fix REFRESH performance regression. .. IMPALA-4840: Fix REFRESH performance regression. The fix for IMPALA-4172 introduced a regression in

[Impala-ASF-CR] IMPALA-4840: Fix REFRESH performance regression.

2017-02-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4840: Fix REFRESH performance regression. .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-4840: Fix REFRESH performance regression.

2017-02-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4840: Fix REFRESH performance regression. .. Patch Set 2: (4 comments) Getting close.

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-4840: Fix REFRESH performance regression.

2017-02-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#2). Change subject: IMPALA-4840: Fix REFRESH performance regression. .. IMPALA-4840: Fix REFRESH performance regression. The fix for IMPALA-4172 introduced a regression in

[Impala-ASF-CR] IMPALA-4931: Update squeasel to include patch to disable SSL init

2017-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4931: Update squeasel to include patch to disable SSL init .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-4931: Update squeasel to include patch to disable SSL init

2017-02-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4931: Update squeasel to include patch to disable SSL init .. Patch Set 2: Code-Review+2 removed the old cmake line and rebased -- To view, visit

[Impala-ASF-CR] IMPALA-4931: Update squeasel to include patch to disable SSL init

2017-02-15 Thread Matthew Jacobs (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6006 to look at the new patch set (#2). Change subject: IMPALA-4931: Update squeasel to include patch to disable SSL init

[Impala-ASF-CR] Revert "IMPALA-4829: Change default Kudu read behavior for "RYW""

2017-02-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Revert "IMPALA-4829: Change default Kudu read behavior for "RYW"" .. Patch Set 3: Code-Review+2 rebase -- To view, visit

[Impala-ASF-CR] Revert "IMPALA-4829: Change default Kudu read behavior for "RYW""

2017-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Revert "IMPALA-4829: Change default Kudu read behavior for "RYW"" .. Patch Set 3: Build started:

[Impala-ASF-CR] Revert "IMPALA-4829: Change default Kudu read behavior for "RYW""

2017-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Revert "IMPALA-4829: Change default Kudu read behavior for "RYW"" .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4916: Fix maintenance of set of item sets in DisjointSet.

2017-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4916: Fix maintenance of set of item sets in DisjointSet. .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-4916: Fix maintenance of set of item sets in DisjointSet.

2017-02-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4916: Fix maintenance of set of item sets in DisjointSet. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5980 To

[Impala-ASF-CR] IMPALA-4916: Fix maintenance of set of item sets in DisjointSet.

2017-02-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4916: Fix maintenance of set of item sets in DisjointSet. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] Revert "IMPALA-4829: Change default Kudu read behavior for "RYW""

2017-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Revert "IMPALA-4829: Change default Kudu read behavior for "RYW"" .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 1: A publicly available screenshot:

[Impala-ASF-CR] IMPALA-2020: Make it easy to work with big numbers

2017-02-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2020: Make it easy to work with big numbers .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5902/4/be/src/util/decimal-util.cc File

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 1: This is super useful. Could you post the screenshot somewhere that's publicly accessible? --

[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916

2017-02-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: A blog post about IMPALA-4916 .. Patch Set 3: > (1 comment) > > So, I believe that all of the pages still point to the old blog > site. This patch doesn't seem

[Impala-ASF-CR] IMPALA-4916: Fix maintenance of set of item sets in DisjointSet.

2017-02-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4916: Fix maintenance of set of item sets in DisjointSet. .. Patch Set 2: Code-Review+1 (2 comments)