[native-toolchain-CR] Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply patches function to appropriately apply patches w.r.t host arch's

2017-04-26 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply_patches function to appropriately apply patches w.r.t host arch's

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-26 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has uploaded a new patch set (#3). Change subject: Ported native-toolchain to work on ppc64le .. Ported native-toolchain to work on ppc64le Change-Id: I7931752ca497bc7a5e3cc574bbb54637f382c72a --- M

[native-toolchain-CR] Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply patches function to appropriately apply patches w.r.t host arch's

2017-04-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply_patches function to appropriately apply patches w.r.t host arch's ..

[native-toolchain-CR] Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply patches function to appropriately apply patches w.r.t host arch's

2017-04-26 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply_patches function to appropriately apply patches w.r.t host arch's

[native-toolchain-CR] Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply patches function to appropriately apply patches w.r.t host arch's

2017-04-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply_patches function to appropriately apply patches w.r.t host arch's ..

[native-toolchain-CR] Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply patches function to appropriately apply patches w.r.t host arch's

2017-04-26 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has uploaded a new change for review. http://gerrit.cloudera.org:8080/6739 Change subject: Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply_patches function to appropriately apply patches w.r.t host arch's

[Impala-ASF-CR] IMPALA-5245: Disable buffer-allocator-test under ASAN

2017-04-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5245: Disable buffer-allocator-test under ASAN .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/511/ -- To

[Impala-ASF-CR] IMPALA-3742: Partitions and sort INSERTs for Kudu tables

2017-04-26 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3742: Partitions and sort INSERTs for Kudu tables .. Patch Set 5: (22 comments) http://gerrit.cloudera.org:8080/#/c/6559/5/be/src/exec/kudu-util.h

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan conjuncts

2017-04-26 Thread Zach Amsden (Code Review)
Hello Impala Public Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6389 to look at the new patch set (#25). Change subject: IMPALA-5003: Constant propagation in scan conjuncts

[Impala-ASF-CR] IMPALA-4731/IMPALA-397/IMPALA-4728: Materialize sort exprs

2017-04-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4731/IMPALA-397/IMPALA-4728: Materialize sort exprs .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6322 To

[Impala-ASF-CR] IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet

2017-04-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet .. Patch Set 8: (5 comments)

[Impala-ASF-CR] IMPALA-5245: Disable buffer-allocator-test under ASAN

2017-04-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5245: Disable buffer-allocator-test under ASAN .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6737 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5245: Disable buffer-allocator-test under ASAN

2017-04-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5245: Disable buffer-allocator-test under ASAN .. Patch Set 1: Kicked off a private ASAN build of BE tests. Will wait for that to complete before pushing

[Impala-ASF-CR] IMPALA-5245: Disable buffer-allocator-test under ASAN

2017-04-26 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new change for review. http://gerrit.cloudera.org:8080/6737 Change subject: IMPALA-5245: Disable buffer-allocator-test under ASAN .. IMPALA-5245: Disable buffer-allocator-test under ASAN Until we

[Impala-ASF-CR] IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg

2017-04-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6724 To

[Impala-ASF-CR] IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg

2017-04-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg .. IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg Since

[Impala-ASF-CR] IMPALA-5192: Don't bake MemPool* into IR

2017-04-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5192: Don't bake MemPool* into IR .. IMPALA-5192: Don't bake MemPool* into IR Tuple::CodegenMaterializeExprs() currently bakes the

[Impala-ASF-CR] IMPALA-5192: Don't bake MemPool* into IR

2017-04-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5192: Don't bake MemPool* into IR .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6657 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet

2017-04-26 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet .. Patch Set 8: > (1 comment) Yes, I think we should do that. -- To view, visit

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan conjuncts

2017-04-26 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan conjuncts .. Patch Set 23: (1 comment) http://gerrit.cloudera.org:8080/#/c/6389/23//COMMIT_MSG Commit Message: PS23,

[Impala-ASF-CR] IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet

2017-04-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-4731/IMPALA-397/IMPALA-4728: Materialize sort exprs

2017-04-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4731/IMPALA-397/IMPALA-4728: Materialize sort exprs .. Patch Set 9: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/510/

[Impala-ASF-CR] IMPALA-4731/IMPALA-397/IMPALA-4728: Materialize sort exprs

2017-04-26 Thread Thomas Tauber-Marshall (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6322 to look at the new patch set (#9). Change subject: IMPALA-4731/IMPALA-397/IMPALA-4728: Materialize sort exprs ..

[Impala-ASF-CR] IMPALA-4731/IMPALA-397/IMPALA-4728: Materialize sort exprs

2017-04-26 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4731/IMPALA-397/IMPALA-4728: Materialize sort exprs .. Patch Set 9: Code-Review+2 Rebased. -- To view, visit

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan conjuncts

2017-04-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan conjuncts .. Patch Set 23: Code-Review+2 Let me know if you need help investigation that last issue. -- To view, visit

[Impala-ASF-CR] IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg

2017-04-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan conjuncts

2017-04-26 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan conjuncts .. Patch Set 23: So this tripped up on an functional.alltypes_datasource test, and the first failure was

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan conjuncts

2017-04-26 Thread Zach Amsden (Code Review)
Hello Impala Public Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6389 to look at the new patch set (#23). Change subject: IMPALA-5003: Constant propagation in scan conjuncts

[Impala-ASF-CR] IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg

2017-04-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6724 To

[Impala-ASF-CR] IMPALA-4731/IMPALA-397/IMPALA-4728: Materialize sort exprs

2017-04-26 Thread Thomas Tauber-Marshall (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6322 to look at the new patch set (#8). Change subject: IMPALA-4731/IMPALA-397/IMPALA-4728: Materialize sort exprs ..

[Impala-ASF-CR] IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg

2017-04-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg

2017-04-26 Thread Michael Ho (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6724 to look at the new patch set (#5). Change subject: IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg

[Impala-ASF-CR] IMPALA-5192: Don't bake MemPool* into IR

2017-04-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5192: Don't bake MemPool* into IR .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/508/ -- To view, visit

[Impala-ASF-CR] IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet

2017-04-26 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-4815, IMPALA-4817, IMPALA-4819: Populate Parquet Statistics for remaining types

2017-04-26 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Populate Parquet Statistics for remaining types .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg

2017-04-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg .. Patch Set 4: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan conjuncts

2017-04-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan conjuncts .. Patch Set 22: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5188: Add slot sorting in TupleDescriptor::LayoutEquals()

2017-04-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5188: Add slot sorting in TupleDescriptor::LayoutEquals() .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg

2017-04-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6724/2//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg

2017-04-26 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#4). Change subject: IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg .. IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg Since commit d2d3f4c (on

[Impala-ASF-CR] IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg

2017-04-26 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#3). Change subject: IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg .. IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg Since commit d2d3f4c (on

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan conjuncts

2017-04-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan conjuncts .. Patch Set 22: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/507/ -- To

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan conjuncts

2017-04-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan conjuncts .. Patch Set 22: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6389 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4864 [DRAFT] Speed up single slot predicates with dictionaries

2017-04-26 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#3). Change subject: IMPALA-4864 [DRAFT] Speed up single slot predicates with dictionaries .. IMPALA-4864 [DRAFT] Speed up single slot predicates with dictionaries When dictionaries