[Impala-ASF-CR] IMPALA-5791: Make bootstrap development.sh survive apt-get failure

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5791: Make bootstrap_development.sh survive apt-get failure .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7657 To

[Impala-ASF-CR] IMPALA-5749: coordinator race hits DCHECK 'num remaining backends > 0'

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5749: coordinator race hits DCHECK 'num_remaining_backends_ > 0' .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7577/2/be/src/runtime/

[Impala-ASF-CR] IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot()

2017-08-11 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot() .. Patch Set 3: (13 comments) http://gerrit.cloudera.org:8080/#/c/7574/2//COMMIT_MSG

[Impala-ASF-CR] MPALA-5776: Write partial tuple to the correct mempool

2017-08-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: MPALA-5776: Write partial tuple to the correct mempool .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7639/2/be/src/exec/hdfs-text-scanner.cc File

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 15: I've tested (at least by building) this on all the platforms we distribute at Cloudera.

[Impala-ASF-CR] IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot()

2017-08-11 Thread anujphadke (Code Review)
anujphadke has uploaded a new patch set (#3). Change subject: IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot() .. IMPALA-2689: Log why codegen is disabled in TextConverter::CodegenWriteSlot() Plumbi

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/764

[Impala-ASF-CR] IMPALA-4833: Compute precise per-host reservation size

2017-08-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#4). Change subject: IMPALA-4833: Compute precise per-host reservation size .. IMPALA-4833: Compute precise per-host reservation size Before this change, the per-host reservation size

[Impala-ASF-CR] PREVIEW: IMPALA-2615: support [[nodiscard]] on Status

2017-08-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: PREVIEW: IMPALA-2615: support [[nodiscard]] on Status .. Patch Set 6: (8 comments) http://gerrit.cloudera.org:8080/#/c/7253/5/be/CMakeLists.txt File be/CMakeLists.t

[Impala-ASF-CR] IMPALA-4833: Compute precise per-host reservation size

2017-08-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4833: Compute precise per-host reservation size .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/7630/2/be/src/runtime/coordinator-backe

[Impala-ASF-CR] IMPALA-4833: Compute precise per-host reservation size

2017-08-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#3). Change subject: IMPALA-4833: Compute precise per-host reservation size .. IMPALA-4833: Compute precise per-host reservation size Before this change, the per-host reservation size

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue .. Patch Set 3: (1 comment) Is there any regression in performance ? http://gerrit.c

[Impala-ASF-CR] IMPALA-5681: release reservation from blocking operators

2017-08-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5681: release reservation from blocking operators .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7619/3//COMMIT_M

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

2017-08-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad .. Patch Set 2: > Yes, please do create a separate patch. We have done the same thing > in Thrift where we've re

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

2017-08-11 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad .. IMPALA-5477: Fix minidump-2-core tool in breakpad The recent PPC port broke the minidump-2-core tool in the tool

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad .. Patch Set 1: Yes, please do create a separate patch. We have done the same thing in Thrift where we've rev

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue .. Patch Set 3: Code-Review+1 Looks good to me, I'll just give others a chance to t

[Impala-ASF-CR] PREVIEW: IMPALA-2615: support [[nodiscard]] on Status

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: PREVIEW: IMPALA-2615: support [[nodiscard]] on Status .. Patch Set 6: Oops, thanks for pointing that out -- To view, visit http://gerrit.cloudera.org:8080/7253

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

2017-08-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad .. Patch Set 1: > Do you think should add this as a separate patch, rather than > updating an existing one? That

[Impala-ASF-CR] PREVIEW: IMPALA-2615: support [[nodiscard]] on Status

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#6). Change subject: PREVIEW: IMPALA-2615: support [[nodiscard]] on Status .. PREVIEW: IMPALA-2615: support [[nodiscard]] on Status This is the set of changes required to get Impala to

[Impala-ASF-CR] IMPALA-4737: Prevent SIGUSR1 from killing daemons when minidumps are disabled

2017-08-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4737: Prevent SIGUSR1 from killing daemons when minidumps are disabled .. Patch Set 2: > Should any startup scripts be modified to trap '' SIGUSR1 before

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad .. Patch Set 1: Do you think should add this as a separate patch, rather than updating an existing one? That

[Impala-ASF-CR] IMPALA-5666: ASAN poisoning for MemPool and BufferPool

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool .. Patch Set 2: Thanks! Unfortunately there's an issue with the ASAN build - the huge group_concat query

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

2017-08-11 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/7658 Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad .. IMPALA-5477: Fix minidump-2-core tool in breakpad The recent PPC port

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 16: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5717 To unsubscribe, visit h

[Impala-ASF-CR] PREVIEW: IMPALA-2615: support [[nodiscard]] on Status

2017-08-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: PREVIEW: IMPALA-2615: support [[nodiscard]] on Status .. Patch Set 5: > (14 comments) It looks like you may have forgotten to push your new patch set? -- To view,

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/5717/15/CMakeLists.txt File CMakeLists.

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#16). Change subject: IMPALA-4669: [SECURITY] Add security library to build .. IMPALA-4669: [SECURITY] Add security library to build * Minor compilation fix * Add krb5 as a non-toolch

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7646/2/be/src/ru

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue .. IMPALA-5773: Correctly account for memory used in data stream receiver queue Data

[Impala-ASF-CR] IMPALA-5708: Test failure with invalid exec summary

2017-08-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5708: Test failure with invalid exec summary .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7627/1/tests/beeswax/impala_beeswax

[Impala-ASF-CR] IMPALA-5708: Test failure with invalid exec summary

2017-08-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: IMPALA-5708: Test failure with invalid exec summary .. IMPALA-5708: Test failure with invalid exec summary For some queries, the exec summary will not be

[Impala-ASF-CR] IMPALA-5412: Fix scan result with partitions on same file

2017-08-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5412: Fix scan result with partitions on same file .. Patch Set 5: Code-Review+1 Looks good -- To view, visit http://gerrit.cloudera.org:8080/7625 To u

[Impala-ASF-CR] IMPALA-5412 Fix scan result with partitions on same file

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5412 Fix scan result with partitions on same file .. Patch Set 3: (3 comments) I ended up combining the tests in test_partition_metadata and adding parqu

[Impala-ASF-CR] IMPALA-5412: Fix scan result with partitions on same file

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-5412: Fix scan result with partitions on same file .. IMPALA-5412: Fix scan result with partitions on same file The maps storing file descriptors and file m

[Impala-ASF-CR] IMPALA-5412 Fix scan result with partitions on same file

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-5412 Fix scan result with partitions on same file .. IMPALA-5412 Fix scan result with partitions on same file The maps storing file descriptors and file met

[Impala-ASF-CR] IMPALA-4674: Part 3: fix null-aware anti join

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 3: fix null-aware anti join .. Patch Set 8: Rebase onto the BTSV2 -> BTS rename -- To view, visit http://gerrit.cloudera.org:8080/7367 To uns

[Impala-ASF-CR] IMPALA-4674: Part 3: fix null-aware anti join

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#8). Change subject: IMPALA-4674: Part 3: fix null-aware anti join .. IMPALA-4674: Part 3: fix null-aware anti join Part 2 regressed NAAJ by tightening up the spilling invariants (e.g.

[Impala-ASF-CR] IMPALA-4674: Part 3: fix null-aware anti join

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#8). Change subject: IMPALA-4674: Part 3: fix null-aware anti join .. IMPALA-4674: Part 3: fix null-aware anti join Part 2 regressed NAAJ by tightening up the spilling invariants (e.g.

[Impala-ASF-CR] IMPALA-5116: Remove deprecated hash * types in gutil

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5116: Remove deprecated hash_* types in gutil .. Patch Set 4: Did you have a chance to look at Jim's comments? We are very close to getting this merged.

[Impala-ASF-CR] IMPALA-5666: ASAN poisoning for MemPool and BufferPool

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool .. Patch Set 2: Code-Review+2 I got my wires crossed and thought I was waiting for a new patchset here. I'

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/7642/3/be/src/util/jni-util.cc File be/src/u

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7646/2/be/src/run

[Impala-ASF-CR] IMPALA-5791: Make bootstrap development.sh survive apt-get failure

2017-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5791: Make bootstrap_development.sh survive apt-get failure .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/103

[Impala-ASF-CR] IMPALA-5791: Make bootstrap development.sh survive apt-get failure

2017-08-11 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5791: Make bootstrap_development.sh survive apt-get failure .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7657 To unsu

[Impala-ASF-CR] IMPALA-4833: Compute precise per-host reservation size

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4833: Compute precise per-host reservation size .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/7630/2/be/src/runtime/coordinator-backen

[Impala-ASF-CR] IMPALA-5681: release reservation from blocking operators

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-5681: release reservation from blocking operators .. IMPALA-5681: release reservation from blocking operators When an in-memory blocking aggregation or join

[Impala-ASF-CR] IMPALA-5791: Make bootstrap development.sh survive apt-get failure

2017-08-11 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/7657 Change subject: IMPALA-5791: Make bootstrap_development.sh survive apt-get failure .. IMPALA-5791: Make bootstrap_development.sh survive apt

<    1   2