Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
Patch Set 12:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1218/
--
To
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8050
Change subject: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()
..
IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-5856: Fix outer join predicate assignment.
..
Patch Set 1:
(5 comments)
Alex Behm has posted comments on this change.
Change subject: IMPALA-5211: Simplifying ifnull conditional.
..
Patch Set 6:
(16 comments)
http://gerrit.cloudera.org:8080/#/c/7829/6//COMMIT_MSG
Commit Message:
Line 9:
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
Patch Set 12: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8011
To unsubscribe, visit
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8049
Change subject: IMPALA-5927: Fix enable_distcc for zsh
..
IMPALA-5927: Fix enable_distcc for zsh
enable_distcc didn't work on zsh anymore
Alex Behm has posted comments on this change.
Change subject: IMPALA-3437: DECIMAL_V2: avoid implicit decimal->double
conversion
..
Patch Set 5:
(1 comment)
Alex Behm has posted comments on this change.
Change subject: IMPALA-3437: DECIMAL_V2: avoid implicit decimal->double
conversion
..
Patch Set 5:
(11 comments)
Jim Apple has posted comments on this change.
Change subject: IMPALA-5905: add script for all-build-options job
..
Patch Set 2: Code-Review+2
(3 comments)
Can you add a note about ccache and ninja?
Alex Behm has posted comments on this change.
Change subject: IMPALA-5597: Try casting targetExpr when building runtime
filter plan
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7949
To
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5597: Try casting targetExpr when building runtime
filter plan
..
Patch Set 4:
Build started:
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3516: Avoid writing to /tmp in testing
..
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1216/
--
To view,
Alex Behm has posted comments on this change.
Change subject: IMPALA-3516: Avoid writing to /tmp in testing
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8047
To unsubscribe, visit
Lars Volker has posted comments on this change.
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
Patch Set 10:
(2 comments)
Changed to INTERNAL_ERROR for the possible error in GetNextBuffer().
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8011
to look at the new patch set (#12).
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-5597: Try casting targetExpr when building runtime
filter plan
..
Patch Set 3:
(3 comments)
Tianyi Wang has uploaded a new patch set (#4).
Change subject: IMPALA-5597: Try casting targetExpr when building runtime
filter plan
..
IMPALA-5597: Try casting targetExpr when building runtime filter plan
This patch fixes a
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-3516: Avoid writing to /tmp in testing
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8047/1/be/src/service/fe-support.cc
File
Tianyi Wang has uploaded a new patch set (#2).
Change subject: IMPALA-3516: Avoid writing to /tmp in testing
..
IMPALA-3516: Avoid writing to /tmp in testing
Currently some parts of the tests write to /tmp:
1. PlannerTest
Vuk Ercegovac has posted comments on this change.
Change subject: IMPALA-1767 Adds predicate to test boolean values true, false,
unknown.
..
Patch Set 7:
(21 comments)
Vuk Ercegovac has uploaded a new patch set (#7).
Change subject: IMPALA-1767 Adds predicate to test boolean values true, false,
unknown.
..
IMPALA-1767 Adds predicate to test boolean values true, false, unknown.
Adds a new
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4987: Fix flaky test test_row_availability.py
..
IMPALA-4987: Fix flaky test test_row_availability.py
This patch keeps
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4987: Fix flaky test test_row_availability.py
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8036
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
Patch Set 11: Code-Review+1
The stricter invariant makes sense to me.
--
To view, visit
Alex Behm has posted comments on this change.
Change subject: IMPALA-5597: Try casting targetExpr when building runtime
filter plan
..
Patch Set 3:
(4 comments)
lgtm after this round
Alex Behm has posted comments on this change.
Change subject: IMPALA-3516: Avoid writing to /tmp in testing
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8047/1/be/src/service/fe-support.cc
File
Bharath Vissapragada has abandoned this change.
Change subject: IMPALA-5881: Use native allocation while building catalog
updates
..
Abandoned
While this change works as expected, I think we can be more uniform in our
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
..
Patch Set 2:
(3 comments)
It's a bit unfortunate that we have to pull in this much code to
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
Patch Set 10:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8011/10/be/src/exec/scanner-context.cc
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
Patch Set 10:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8011/10/be/src/exec/scanner-context.cc
File
Tianyi Wang has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8047
Change subject: IMPALA-3516: Avoid writing to /tmp in testing
..
IMPALA-3516: Avoid writing to /tmp in testing
Currently some parts of
Alex Behm has posted comments on this change.
Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7731
To unsubscribe,
Tim Armstrong has uploaded a new patch set (#2).
Change subject: IMPALA-5905: add script for all-build-options job
..
IMPALA-5905: add script for all-build-options job
This checks in a modified version of the job script for
Lars Volker has posted comments on this change.
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
Patch Set 10:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/8011/10/be/src/exec/scanner-context.cc
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8011
to look at the new patch set (#11).
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5905: add script for all-build-options job
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8043/1/bin/all-build-options.sh
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3437: DECIMAL_V2: avoid implicit decimal->double
conversion
..
Patch Set 5:
Updated with some additional tests to get more exhaustive coverage of the
Hello Greg Rahn,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7916
to look at the new patch set (#5).
Change subject: IMPALA-3437: DECIMAL_V2: avoid implicit decimal->double
conversion
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-5597: Try casting targetExpr when building runtime
filter plan
..
Patch Set 2:
(7 comments)
Tianyi Wang has uploaded a new patch set (#3).
Change subject: IMPALA-5597: Try casting targetExpr when building runtime
filter plan
..
IMPALA-5597: Try casting targetExpr when building runtime filter plan
This patch fixes a
Dimitris Tsirogiannis has uploaded a new patch set (#3).
Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects
..
IMPALA-5538: Use explicit catalog versions for deleted objects
This commit changes the
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects
..
Patch Set 2:
(16 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
Patch Set 10:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/8011/10/be/src/exec/scanner-context.cc
File
Philip Zeyliger has posted comments on this change.
Change subject: IMPALA-5905: add script for all-build-options job
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8043/1/bin/all-build-options.sh
File
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-5881: Use native allocation while building catalog
updates
..
Patch Set 19: Code-Review+2
Thanks for the reviews. Carrying +2.
--
To view,
Hello Dimitris Tsirogiannis, Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7955
to look at the new patch set (#19).
Change subject: IMPALA-5881: Use native allocation while building catalog
updates
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-5881: Use native allocation while building catalog
updates
..
Patch Set 18:
(8 comments)
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8043
Change subject: IMPALA-5905: add script for all-build-options job
..
IMPALA-5905: add script for all-build-options job
This checks in a
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-5881: Use native allocation while building catalog
updates
..
Patch Set 18: Code-Review+2
(2 comments)
Impala Public Jenkins has posted comments on this change.
Change subject: Bump Kudu version to 3f49724
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8040
To unsubscribe, visit
Impala Public Jenkins has submitted this change and it was merged.
Change subject: Bump Kudu version to 3f49724
..
Bump Kudu version to 3f49724
Change-Id: I21aff562e2bca90436a8d0206ffca44b712bc1f1
Reviewed-on:
Lars Volker has posted comments on this change.
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
Patch Set 10:
I fixed more test errors and will run an exhaustive build in parallel now.
--
To view,
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8011
to look at the new patch set (#10).
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
Alex Behm has posted comments on this change.
Change subject: IMPALA-5250: Unify decompressor output_length semantics
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8030/1//COMMIT_MSG
Commit Message:
Line
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-5881: Use native allocation while building catalog
updates
..
Patch Set 18:
Taking a look now.
--
To view, visit
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4987: Fix flaky test test_row_availability.py
..
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1215/
--
To
Alex Behm has posted comments on this change.
Change subject: IMPALA-5597: Try casting targetExpr when building runtime
filter plan
..
Patch Set 2:
(8 comments)
Alex Behm has posted comments on this change.
Change subject: IMPALA-4987: Fix flaky test test_row_availability.py
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8036
To unsubscribe, visit
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-4987: Fix flaky test test_row_availability.py
..
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/8036/2//COMMIT_MSG
Commit Message:
Line 7:
Tianyi Wang has uploaded a new patch set (#3).
Change subject: IMPALA-4987: Fix flaky test test_row_availability.py
..
IMPALA-4987: Fix flaky test test_row_availability.py
This patch keeps test_row_availbility from randomly
Tim Armstrong has uploaded a new patch set (#2).
Change subject: IMPALA-5860: upgrade to LLVM 3.9.1
..
IMPALA-5860: upgrade to LLVM 3.9.1
LLVM made a few API changes:
* Misc minor changes to function and type signatures
* The
Tim Armstrong has uploaded a new patch set (#2).
Change subject: IMPALA-3877: support unpatched LLVM
..
IMPALA-3877: support unpatched LLVM
The p1 patch we use for LLVM avoided merging of structurally
identical Struct types in
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-5250: Unify decompressor output_length semantics
..
Patch Set 1:
(18 comments)
http://gerrit.cloudera.org:8080/#/c/8030/1//COMMIT_MSG
Commit Message:
Tianyi Wang has uploaded a new patch set (#2).
Change subject: IMPALA-5250: Unify decompressor output_length semantics
..
IMPALA-5250: Unify decompressor output_length semantics
This patch makes the semantics of the
Alex Behm has posted comments on this change.
Change subject: IMPALA-4987: Fix flaky test test_row_availability.py
..
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/8036/2//COMMIT_MSG
Commit Message:
Line 7:
Alex Behm has posted comments on this change.
Change subject: IMPALA-5881: Use native allocation while building catalog
updates
..
Patch Set 18: Code-Review+1
(6 comments)
Dimitris, any more comments?
Greg Rahn has posted comments on this change.
Change subject: PREVIEW: IMPALA-3437: DECIMAL_V2: avoid implicit
decimal->double conversion
..
Patch Set 4: Code-Review+1
LGTM
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: [DOCS] Explain Boost setting needed for 96-bit timestamps
..
Patch Set 2: Code-Review-1
I think that the documented solution is not the correct solution to the
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
Patch Set 9: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/8011
To unsubscribe, visit
Bharath Vissapragada has uploaded a new patch set (#18).
Change subject: IMPALA-5881: Use native allocation while building catalog
updates
..
IMPALA-5881: Use native allocation while building catalog updates
This patch moves
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-5881: Use native allocation while building catalog
updates
..
Patch Set 17:
(7 comments)
Fixed a subtle bug in the test allocator.
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-4987: Fix flaky test test_row_availability.py
..
Patch Set 1:
(13 comments)
http://gerrit.cloudera.org:8080/#/c/8036/1//COMMIT_MSG
Commit Message:
Line
Philip Zeyliger has posted comments on this change.
Change subject: IMPALA-5736: Add impala-shell argument to set default query
options
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8038/1//COMMIT_MSG
Tianyi Wang has uploaded a new patch set (#2).
Change subject: IMPALA-4987: Fix flaky test test_row_availability.py
..
IMPALA-4987: Fix flaky test test_row_availability.py
This patch keeps test_row_availbility from random
Tianyi Wang has uploaded a new patch set (#2).
Change subject: IMPALA-5597: Try casting targetExpr when building runtime
filter plan
..
IMPALA-5597: Try casting targetExpr when building runtime filter plan
This patch fixes a
Tianyi Wang has restored this change.
Change subject: IMPALA-5597: Check predicate children types when building
runtime filter plan
..
Restored
A new fix is implemented.
--
To view, visit
I've been talking to John out of band about this. I had some more meta
concerns about documenting this and whether it will encourage customers to
do dangerous things. Need to organise my thoughts and enumerate concerns.
On 12 Sep. 2017 9:42 am, "Matthew Jacobs (Code Review)"
Lars Volker has uploaded a new patch set (#9).
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
IMPALA-5890: Abort queries if scanner hits IO errors
Prior to this fix, an error in
Lars Volker has posted comments on this change.
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8011/8/be/src/exec/base-sequence-scanner.cc
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8011/8/be/src/exec/base-sequence-scanner.cc
Impala Public Jenkins has posted comments on this change.
Change subject: Bump Kudu version to 3f49724
..
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1214/
--
To view, visit
Lars Volker has posted comments on this change.
Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala
..
Patch Set 2:
(1 comment)
Lars Volker has posted comments on this change.
Change subject: IMPALA-5736: Add impala-shell argument to set default query
options
..
Patch Set 1:
(1 comment)
Looks good to me, only a minor comment.
Pranay Singh has uploaded a new patch set (#2).
Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder
..
IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder
Currently DictDecoder class and
Pranay Singh has posted comments on this change.
Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8034/1/be/src/exec/exec-node.h
Matthew Jacobs has posted comments on this change.
Change subject: [DOCS] Explain Boost setting needed for 96-bit timestamps
..
Patch Set 2:
(3 comments)
Matthew Jacobs has posted comments on this change.
Change subject: Bump Kudu version to 3f49724
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8040
To unsubscribe, visit
Pranay Singh has uploaded a new patch set (#2).
Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder
..
IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder
Currently DictDecoder class and
Thomas Tauber-Marshall has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8040
Change subject: Bump Kudu version to 3f49724
..
Bump Kudu version to 3f49724
Change-Id:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
Patch Set 8:
(2 comments)
Alex Behm has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8039
Change subject: IMPALA-5856: Fix outer join predicate assignment.
..
IMPALA-5856: Fix outer join predicate assignment.
Fixes incorrect
Csaba Ringhofer has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8038
Change subject: IMPALA-5736: Add impala-shell argument to set default query
options
..
IMPALA-5736: Add impala-shell argument to set
Lars Volker has uploaded a new patch set (#8).
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
IMPALA-5890: Abort queries if scanner hits IO errors
Prior to this fix, an error in
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4082: Remove todo item in getRegionsInRange
..
IMPALA-4082: Remove todo item in getRegionsInRange
HbaseTable.GetRegionsInRange is a
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4082: Remove todo item in getRegionsInRange
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8018
To unsubscribe,
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5894: [DOCS] Clarify placement of STRAIGHT_JOIN hint
..
IMPALA-5894: [DOCS] Clarify placement of STRAIGHT_JOIN hint
"immediately after
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5894: [DOCS] Clarify placement of STRAIGHT_JOIN hint
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8031
To
John Russell has posted comments on this change.
Change subject: [DOCS] Explain Boost setting needed for 96-bit timestamps
..
Patch Set 2:
Tim and Michael, I added you as reviewers based on your frequent activity in
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5894: [DOCS] Clarify placement of STRAIGHT_JOIN hint
..
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/153/
--
To
99 matches
Mail list logo