[Impala-ASF-CR] IMPALA-3360: Codegen inserting into runtime filters

2017-09-18 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3360: Codegen inserting into runtime filters .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-3360: Codegen inserting into runtime filters

2017-09-18 Thread Thomas Tauber-Marshall (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8029 to look at the new patch set (#3). Change subject: IMPALA-3360: Codegen inserting into runtime filters ..

[Impala-ASF-CR] IMPALA-5932: Improve the transitive closure computation performance in value transfer graph

2017-09-18 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5932: Improve the transitive closure computation performance in value transfer graph .. Patch Set 1: (4 comments) nice

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-18 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar .. Patch Set 5: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-5932: Improve the transitive closure computation performance in value transfer graph

2017-09-18 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/8098 Change subject: IMPALA-5932: Improve the transitive closure computation performance in value transfer graph .. IMPALA-5932: Improve the

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-18 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar .. Patch Set 4: (8 comments)

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-18 Thread Matthew Jacobs (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8035 to look at the new patch set (#5). Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar .. Patch Set 4: (13 comments) Thanks, Zach - some good observations. I made a bunch of the

[Impala-ASF-CR] IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh

2017-09-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4786: Clean up how ImpalaServers are created

2017-09-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4786: Clean up how ImpalaServers are created .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/8076/1/be/src/service/impala-server.cc

[Impala-ASF-CR] IMPALA-4786: Clean up how ImpalaServers are created

2017-09-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). Change subject: IMPALA-4786: Clean up how ImpalaServers are created .. IMPALA-4786: Clean up how ImpalaServers are created ImpalaServer had to be created via an awkward

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-18 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar .. Patch Set 4: (17 comments) Looks good but I have a few comments - there is a lot more that

[Impala-ASF-CR] IMPALA-5895: clean up runtime profile lifecycle

2017-09-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-5895: clean up runtime profile lifecycle .. IMPALA-5895: clean up runtime profile lifecycle Require callers to explicitly stop counter updating instead of

[Impala-ASF-CR] IMPALA-5895: clean up runtime profile lifecycle

2017-09-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5895: clean up runtime profile lifecycle .. Patch Set 6: (12 comments) http://gerrit.cloudera.org:8080/#/c/8069/6/be/src/exec/hdfs-scan-node-base.h File

[Impala-ASF-CR] IMPALA-4786: Clean up how ImpalaServers are created

2017-09-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4786: Clean up how ImpalaServers are created .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/8076/1/be/src/service/impala-server.cc File

[Impala-ASF-CR] IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh

2017-09-18 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh .. Patch Set 3: Started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1234/ --

[Impala-ASF-CR] IMPALA-3360: Codegen inserting into runtime filters

2017-09-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3360: Codegen inserting into runtime filters .. Patch Set 2: > (4 comments) > > Looks good to me minus a couple of things. Not sure if Dan wants to >

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-18 Thread Matthew Jacobs (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8035 to look at the new patch set (#4). Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5895: clean up runtime profile lifecycle

2017-09-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5895: clean up runtime profile lifecycle .. Patch Set 6: (12 comments) http://gerrit.cloudera.org:8080/#/c/8069/6/be/src/exec/hdfs-scan-node-base.h File

[Impala-ASF-CR] IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh

2017-09-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh .. Patch Set 3: Ran full dataload + tests and everything worked. I think this is

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 7: (2 comments)

[Impala-ASF-CR] Re-apply: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: Re-apply: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Patch Set 1: This is a re-run of

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-18 Thread Philip Zeyliger (Code Review)
Hello Impala Public Jenkins, Bharath Vissapragada, Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8070 to look at the new patch set (#7). Change subject: IMPALA-5908: Allow SET to unset modified query options.

[Impala-ASF-CR] Re-apply: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new change for review. http://gerrit.cloudera.org:8080/8096 Change subject: Re-apply: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Re-apply:

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-09-18 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-4671: Replace kudu::ServicePool with one that uses Impala threads

2017-09-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4671: Replace kudu::ServicePool with one that uses Impala threads .. Patch Set 1: > Why not make a separate implementation of a service pool, rather >

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-2636: HS2 GetTables() returns TABLE TYPE as TABLE for VIEW

2017-09-18 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has posted comments on this change. Change subject: IMPALA-2636: HS2 GetTables() returns TABLE_TYPE as TABLE for VIEW .. Patch Set 2: (13 comments) Addressed review comments.

[Impala-ASF-CR] IMPALA-2636: HS2 GetTables() returns TABLE TYPE as TABLE for VIEW

2017-09-18 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has uploaded a new patch set (#2). Change subject: IMPALA-2636: HS2 GetTables() returns TABLE_TYPE as TABLE for VIEW .. IMPALA-2636: HS2 GetTables() returns TABLE_TYPE as TABLE for VIEW Added code to read

[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1

2017-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7974 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1

2017-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. IMPALA-5860: upgrade to LLVM 3.9.1 LLVM made a few API changes: * Misc minor changes to function and type

[Impala-ASF-CR] IMPALA-4671: Replace kudu::ServicePool with one that uses Impala threads

2017-09-18 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4671: Replace kudu::ServicePool with one that uses Impala threads .. Patch Set 1: Why not make a separate implementation of a service pool, rather than

[Impala-ASF-CR] IMPALA-4671: Replace kudu::ServicePool with one that uses Impala threads

2017-09-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/8094 Change subject: IMPALA-4671: Replace kudu::ServicePool with one that uses Impala threads .. IMPALA-4671: Replace kudu::ServicePool with

[Impala-ASF-CR] IMPALA-5599: Fix for mis-use of TimestampValue

2017-09-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5599: Fix for mis-use of TimestampValue .. Patch Set 2: (15 comments) Do you plan to take care of the other cases noted in the jira? Okay to do it in a

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 5: Following through on the layering (process options, pool defaults, session options,

[Impala-ASF-CR] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-09-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5895: clean up runtime profile lifecycle

2017-09-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#6). Change subject: IMPALA-5895: clean up runtime profile lifecycle .. IMPALA-5895: clean up runtime profile lifecycle Require callers to explicitly stop counter updating instead of

[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1

2017-09-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. Patch Set 9: Code-Review+2 Missed a couple of clang warnings. -- To view, visit http://gerrit.cloudera.org:8080/7974 To

[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1

2017-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. Patch Set 9: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1233/ -- To view, visit

[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1

2017-09-18 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7974 to look at the new patch set (#9). Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 ..

[Impala-ASF-CR] IMPALA-3360: Codegen inserting into runtime filters

2017-09-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3360: Codegen inserting into runtime filters .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8029/2/be/src/exec/filter-context.cc File

[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1

2017-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. Patch Set 8: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1232/ -- To view, visit