[Impala-ASF-CR] IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads

2017-01-06 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads .. Patch Set 2: > > The HDFS-5776 JIRA mentions that it's implemented for the pread() > > code path

[Impala-ASF-CR] IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads

2017-01-06 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads .. Patch Set 2: > The HDFS-5776 JIRA mentions that it's implemented for the pread() > code path, bu

[Impala-ASF-CR] IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads

2017-01-06 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5635/2/be/src/runtime/disk-io-mgr-s

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-27 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4867/1/be/src/catalog/catalog

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-24 Thread Huaisi Xu (Code Review)
Huaisi Xu has uploaded a new patch set (#17). Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. IMPALA-1702: Enforce single-table consistency in query analysis. Catalogd managed table id generat

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-24 Thread Huaisi Xu (Code Review)
Hello Marcel Kornacker, Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4349 to look at the new patch set (#17). Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. ..

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-24 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. Patch Set 16: (10 comments) Thanks Marcel. http://gerrit.cloudera.org:8080/#/c/4349/15/fe/src/m

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-24 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. Patch Set 16: solved conflict first. addressing comment next -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-24 Thread Huaisi Xu (Code Review)
Huaisi Xu has uploaded a new patch set (#16). Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. IMPALA-1702: Enforce single-table consistency in query analysis. Catalogd managed table id generat

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-24 Thread Huaisi Xu (Code Review)
Hello Marcel Kornacker, Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4349 to look at the new patch set (#16). Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. ..

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4772/1/fe/src/main/java/org/ap

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: actually this can this be checked when we load the table, and this should be e

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4772/1/be/src/catalog/catalog

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4772/1/fe/src/main/java/org/ap

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/4772/1/be/src/catalog/catalog

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-11 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. Patch Set 15: > The concern that Marcel raised is also related to > https://issues.cloudera.org/

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-10 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. Patch Set 15: > (3 comments) Should I do the same for other catalog object as well? e.g. data so

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-10 Thread Huaisi Xu (Code Review)
Hello Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4349 to look at the new patch set (#15). Change subject: IMPALA-1702: Enforce single-table consistency in query analysis.

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-10 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. Patch Set 14: (4 comments) thanks http://gerrit.cloudera.org:8080/#/c/4349/14/common/thrift/Cat

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-07 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/4349/14/fe/src/main/java/org/apach

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-07 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. Patch Set 14: Code-Review+1 (2 comments) carry Alex +1 http://gerrit.cloudera.org:8080/#/c/4349

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-07 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. Patch Set 14: (3 comments) thanks http://gerrit.cloudera.org:8080/#/c/4349/13/fe/src/test/java/

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-07 Thread Huaisi Xu (Code Review)
Hello Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4349 to look at the new patch set (#14). Change subject: IMPALA-1702: Enforce single-table consistency in query analysis.

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-07 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/4349/13/fe/src/test/java/org/apac

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-07 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. Patch Set 12: (10 comments) http://gerrit.cloudera.org:8080/#/c/4349/12//COMMIT_MSG Commit Messa

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-07 Thread Huaisi Xu (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4349 to look at the new patch set (#13). Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. ...

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency

2016-10-07 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency .. Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/4349/12/fe/src/test/java/org/apache/impala/planner/Pl

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency

2016-10-07 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency .. Patch Set 11: (8 comments) thanks! http://gerrit.cloudera.org:8080/#/c/4349/11//COMMIT_MSG Commit Message: Line 11

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency

2016-10-07 Thread Huaisi Xu (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4349 to look at the new patch set (#12). Change subject: IMPALA-1702: Enforce table level consistency .. IMPALA-

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency

2016-10-06 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency .. Patch Set 11: (5 comments) http://gerrit.cloudera.org:8080/#/c/4349/11//COMMIT_MSG Commit Message: Line 11: analyzi

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency

2016-10-06 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency .. Patch Set 10: (6 comments) http://gerrit.cloudera.org:8080/#/c/4349/10/fe/src/main/java/org/apache/impala/analysis/D

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency

2016-10-06 Thread Huaisi Xu (Code Review)
Huaisi Xu has uploaded a new patch set (#11). Change subject: IMPALA-1702: Enforce table level consistency .. IMPALA-1702: Enforce table level consistency Catalogd managed table id generation causes problems when new update arri

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency

2016-10-06 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency .. Patch Set 10: (6 comments) http://gerrit.cloudera.org:8080/#/c/4349/9//COMMIT_MSG Commit Message: PS9, Line 7: Enfo

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency

2016-10-06 Thread Huaisi Xu (Code Review)
Huaisi Xu has uploaded a new patch set (#10). Change subject: IMPALA-1702: Enforce table level consistency .. IMPALA-1702: Enforce table level consistency Catalogd managed table id generation causes problems when new update arri

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-06 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency accross service .. Patch Set 9: (6 comments) http://gerrit.cloudera.org:8080/#/c/4349/8/fe/src/main/java/org/apache/imp

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-06 Thread Huaisi Xu (Code Review)
Huaisi Xu has uploaded a new patch set (#9). Change subject: IMPALA-1702: Enforce table level consistency accross service .. IMPALA-1702: Enforce table level consistency accross service Problems: 1. CatalogServiceCatalog::reset(

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-05 Thread Huaisi Xu (Code Review)
Huaisi Xu has uploaded a new patch set (#8). Change subject: IMPALA-1702: Enforce table level consistency accross service .. IMPALA-1702: Enforce table level consistency accross service Problems: 1. CatalogServiceCatalog::reset(

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-05 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency accross service .. Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/4349/7/fe/src/main/java/org/apache/imp

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-05 Thread Huaisi Xu (Code Review)
Huaisi Xu has uploaded a new patch set (#7). Change subject: IMPALA-1702: Enforce table level consistency accross service .. IMPALA-1702: Enforce table level consistency accross service Problems: 1. CatalogServiceCatalog::reset(

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-05 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency accross service .. Patch Set 7: (16 comments) http://gerrit.cloudera.org:8080/#/c/4349/6/common/thrift/Types.thrift Fil

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-05 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency accross service .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4349/6/fe/src/main/java/org/apache/impa

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-05 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency accross service .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/4349/6/common/thrift/Types.thrift File

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-05 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency accross service .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/4349/4/fe/src/main/java/org/apache/imp

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-05 Thread Huaisi Xu (Code Review)
Huaisi Xu has uploaded a new patch set (#6). Change subject: IMPALA-1702: Enforce table level consistency accross service .. IMPALA-1702: Enforce table level consistency accross service Problems: 1. CatalogServiceCatalog::reset(

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-04 Thread Huaisi Xu (Code Review)
Huaisi Xu has uploaded a new patch set (#5). Change subject: IMPALA-1702: Enforce table level consistency accross service .. IMPALA-1702: Enforce table level consistency accross service Problems: 1. CatalogServiceCatalog::reset(

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-04 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency accross service .. Patch Set 4: (11 comments) http://gerrit.cloudera.org:8080/#/c/4349/4/fe/src/main/java/org/apache/im

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-03 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency accross service .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4349/4/fe/src/main/java/org/apache/impa

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-03 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency accross service .. Patch Set 4: (17 comments) http://gerrit.cloudera.org:8080/#/c/4349/3//COMMIT_MSG Commit Message: P

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-03 Thread Huaisi Xu (Code Review)
Huaisi Xu has uploaded a new patch set (#4). Change subject: IMPALA-1702: Enforce table level consistency accross service .. IMPALA-1702: Enforce table level consistency accross service Problems: 1. CatalogServiceCatalog::reset(

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-09-30 Thread Huaisi Xu (Code Review)
Huaisi Xu has uploaded a new patch set (#3). Change subject: IMPALA-1702: Enforce table level consistency accross service .. IMPALA-1702: Enforce table level consistency accross service Problems: 1. CatalogServiceCatalog::reset(

[Impala-ASF-CR] IMPALA-1702: Enforce unique table ID

2016-09-13 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce unique table ID .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4349/2/fe/src/main/java/com/cloudera/impala/catalog/CatalogSer

[Impala-ASF-CR] IMPALA-1702: Enforce unique table ID

2016-09-13 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce unique table ID .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4349/2/fe/src/main/java/com/cloudera/impala/catalog/CatalogServ

[Impala-ASF-CR] IMPALA-1702: Enforce unique table ID

2016-09-13 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce unique table ID .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4349/2/fe/src/main/java/com/cloudera/impala/catalog/CatalogServ