Lars Volker has uploaded a new patch set (#4).
Change subject: IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables
..
IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables
This is a rough draft and should serve
Lars Volker has posted comments on this change.
Change subject: IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables
..
Patch Set 2:
(5 comments)
Thanks for the reviews, please see PS3.
Lars Volker has uploaded a new patch set (#3).
Change subject: IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables
..
IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables
This is a rough draft and should serve
Lars Volker has posted comments on this change.
Change subject: IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables
..
Patch Set 1:
(4 comments)
Thank you for the reviews. Please see PS2.
Lars Volker has uploaded a new patch set (#2).
Change subject: IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables
..
IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables
This is a rough draft and should serve
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5390
Change subject: IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables
..
IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu
Lars Volker has posted comments on this change.
Change subject: IMPALA-4163: Add sortby() query hint
..
Patch Set 3:
I moved the parsing code into the lexer and parser. This changed some of the
error behavior, where errors
Lars Volker has posted comments on this change.
Change subject: IMPALA-4431: Add audit event log control mechanism to prevent
disk overflow
..
Patch Set 11: Code-Review+1
Let's someone else have a look.
--
To view, visit
Lars Volker has posted comments on this change.
Change subject: IMPALA-4550: Fix CastExpr analysis for substituted slots
..
Patch Set 2:
(1 comment)
Hello Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5267
to look at the new patch set (#3).
Change subject: IMPALA-4550: Fix CastExpr analysis for substituted slots
..
Lars Volker has posted comments on this change.
Change subject: IMPALA-4550: Fix CastExpr analysis for substituted slots
..
Patch Set 1:
(5 comments)
Thanks for the review. Please see PS2.
Hello Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5267
to look at the new patch set (#2).
Change subject: IMPALA-4550: Fix CastExpr analysis for substituted slots
..
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5267
Change subject: IMPALA-4550: Fix CastExpr analysis for substituted slots
..
IMPALA-4550: Fix CastExpr analysis for substituted slots
Lars Volker has abandoned this change.
Change subject: IMPALA-4550: Fix CastExpr analysis for substituted slots
..
Abandoned
Needs rebase.
--
To view, visit http://gerrit.cloudera.org:8080/5265
To unsubscribe, visit
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5265
Change subject: IMPALA-4550: Fix CastExpr analysis for substituted slots
..
IMPALA-4550: Fix CastExpr analysis for substituted slots
Lars Volker has posted comments on this change.
Change subject: IMPALA-4540: Function call in DCHECK crashes scheduler
..
Patch Set 1:
I ran the core tests in release mode and they passed.
--
To view, visit
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5218
Change subject: IMPALA-4540: Function call in DCHECK crashes scheduler
..
IMPALA-4540: Function call in DCHECK crashes scheduler
The fix
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5217
Change subject: IMPALA-4540: Function call in DCHECK crashes scheduler
..
IMPALA-4540: Function call in DCHECK crashes scheduler
The fix
Lars Volker has abandoned this change.
Change subject: IMPALA-4540: Function call in DCHECK crashes scheduler
..
Abandoned
Will rebase.
--
To view, visit http://gerrit.cloudera.org:8080/5217
To unsubscribe, visit
Hello Marcel Kornacker, Internal Jenkins, Sailesh Mukil, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5127
to look at the new patch set (#10).
Change subject: IMPALA-4494: Fix crash in SimpleScheduler
Lars Volker has posted comments on this change.
Change subject: IMPALA-4494: Fix crash in SimpleScheduler
..
Patch Set 7:
(4 comments)
Thanks for the review. Addressed the comments and ran git-clang-format. Will
rebase next.
Hello Marcel Kornacker, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5127
to look at the new patch set (#8).
Change subject: IMPALA-4494: Fix crash in SimpleScheduler
..
Lars Volker has posted comments on this change.
Change subject: IMPALA-4431: Add audit event log control mechanism to prevent
disk overflow
..
Patch Set 11:
Here's the commit that added CheckAndRotateLogFiles(). Please have
Lars Volker has posted comments on this change.
Change subject: IMPALA-4431: Add audit event log control mechanism to prevent
disk overflow
..
Patch Set 11:
Here's the commit that added CheckAndRotateLogFiles(). Please have
Lars Volker has posted comments on this change.
Change subject: IMPALA-4431: Add audit event log control mechanism to prevent
disk overflow
..
Patch Set 11:
> (3 comments)
>
> I have modified the code according to your
Lars Volker has posted comments on this change.
Change subject: IMPALA-4494: Fix crash in SimpleScheduler
..
Patch Set 6:
(1 comment)
Thanks for the reviews!
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5127
to look at the new patch set (#7).
Change subject: IMPALA-4494: Fix crash in SimpleScheduler
..
IMPALA-4494: Fix
Lars Volker has uploaded a new patch set (#6).
Change subject: IMPALA-4494: Fix crash in SimpleScheduler
..
IMPALA-4494: Fix crash in SimpleScheduler
The scheduler maintains a local list of active backends, which is
updated
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 19: Code-Review+1
Replaced NULL with nullptr as discussed in previous comments. Carry +1.
Hello Marcel Kornacker, Alex Behm, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#19).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 18: Code-Review+1
Rebased and ran the relevant tests locally, carry +1.
--
To view, visit
Hello Marcel Kornacker, Alex Behm, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#18).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 16:
(3 comments)
Thanks for the review. I addressed the comments in PS17 and will rebase
Hello Marcel Kornacker, Alex Behm, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#17).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
Lars Volker has posted comments on this change.
Change subject: IMPALA-4494: Fix crash in SimpleScheduler
..
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5127/3/be/src/scheduling/simple-scheduler.cc
File
Lars Volker has uploaded a new patch set (#5).
Change subject: IMPALA-4494: Fix crash in SimpleScheduler
..
IMPALA-4494: Fix crash in SimpleScheduler
The scheduler maintains a local list of active backends, which is
updated
Lars Volker has uploaded a new patch set (#4).
Change subject: IMPALA-4494: Fix crash in SimpleScheduler
..
IMPALA-4494: Fix crash in SimpleScheduler
The scheduler maintains a local list of active backends, which is
updated
Lars Volker has abandoned this change.
Change subject: WIP add local backend to backend list if it is not empty
..
Abandoned
Erroneous push, will squash into the parrent change. Apologies for the noise.
--
To view, visit
Lars Volker has posted comments on this change.
Change subject: IMPALA-4494: Fix crash in SimpleScheduler
..
Patch Set 3:
> I think it would make sense to add the local backend to the list of
> backends at the same time as we
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5140
Change subject: WIP add local backend to backend list if it is not empty
..
WIP add local backend to backend list if it is not empty
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 15:
(5 comments)
Thanks for the comments, please see PS16.
Hello Alex Behm, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#16).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
Lars Volker has posted comments on this change.
Change subject: IMPALA-4494: Fix crash in SimpleScheduler
..
Patch Set 1:
Thank you for your comments. I modified the change to always schedule at the
coordinator if
Lars Volker has uploaded a new patch set (#3).
Change subject: IMPALA-4494: Fix crash in SimpleScheduler
..
IMPALA-4494: Fix crash in SimpleScheduler
The scheduler maintains a local list of active backends, which is
updated
Lars Volker has uploaded a new patch set (#2).
Change subject: IMPALA-4494: Fix crash in SimpleScheduler
..
IMPALA-4494: Fix crash in SimpleScheduler
The scheduler maintains a local list of active backends, which is
updated
Lars Volker has posted comments on this change.
Change subject: IMPALA-4431: Add audit event log control mechanism to prevent
disk overflow
..
Patch Set 9:
(1 comment)
Lars Volker has posted comments on this change.
Change subject: IMPALA-4494: Fix crash in SimpleScheduler
..
Patch Set 1:
Thanks for your feedback. I agree that this is not optimal, and if there was a
way to send the
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5127
Change subject: IMPALA-4494: Fix crash in SimpleScheduler
..
IMPALA-4494: Fix crash in SimpleScheduler
The scheduler maintains a local
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 13:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4863/13/be/src/exec/hdfs-table-sink.cc
Hello Alex Behm, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#15).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 13:
(10 comments)
Thanks for the review. Please see PS14.
Hello Alex Behm, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#14).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
Lars Volker has posted comments on this change.
Change subject: IMPALA-4163: Add sortby() query hint
..
Patch Set 1:
(14 comments)
Thank you for the review. Please see my comments and PS2.
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 12:
Rebased and added tests in AnalyzeStmtsTest as suggested by Alex in
Lars Volker has posted comments on this change.
Change subject: IMPALA-4431: Add audit event log control mechanism to prevent
disk overflow.
..
Patch Set 7:
(3 comments)
Only minor formatting issues left. Please see here
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5051
Change subject: IMPALA-4163: Add sortby() query hint
..
IMPALA-4163: Add sortby() query hint
This change introduces the sortby() query
Lars Volker has posted comments on this change.
Change subject: IMPALA-4431: Add audit event log control mechanism to prevent
disk overflow.
..
Patch Set 6:
(4 comments)
There are still some minor formatting issues left.
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 12: Code-Review+1
Rebased, carry +1 from Alex.
--
To view, visit
Hello Alex Behm, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#12).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
Lars Volker has posted comments on this change.
Change subject: IMPALA-4431: Add audit event log control mechanism to prevent
disk overflow.
..
Patch Set 4:
(2 comments)
Please address the questions in my previous comments
Lars Volker has posted comments on this change.
Change subject: Preview: IMPALA-4363: Add timestamp validation
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4968/2/common/thrift/generate_error_codes.py
File
Lars Volker has posted comments on this change.
Change subject: IMPALA-4431: Add audit event log control mechanism to prevent
disk overflow.
..
Patch Set 3:
(5 comments)
Please mark comments as done and post replies here
Lars Volker has posted comments on this change.
Change subject: Preview: IMPALA-4363: Add timestamp validation
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4968/2/be/src/exec/parquet-column-readers.cc
File
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 11:
Passed private S3 run with only query_tests enabled here.
Relevant lines for S3:
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 9:
(3 comments)
Thanks for the reviews. I'm running another private job to test the change
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#11).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Lars Volker has posted comments on this change.
Change subject: IMPALA-3202: refactor scratch file management into TmpFileMgr
..
Patch Set 3: Code-Review+1
(4 comments)
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#10).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Lars Volker has posted comments on this change.
Change subject: Add -build_shared_libs for default build for speed.
..
Patch Set 1: Code-Review+1
I use this, too, and it works well.
--
To view, visit
Lars Volker has posted comments on this change.
Change subject: IMPALA-4431: Add audit event log control mechanism to prevent
disk overflow.
..
Patch Set 1:
(6 comments)
Thank you for working on this. Please make sure your
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#9).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Lars Volker has posted comments on this change.
Change subject: Preview: IMPALA-4363: Add timestamp validation
..
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4968/1/be/src/exec/parquet-column-readers.cc
File
Lars Volker has posted comments on this change.
Change subject: IMPALA-4391: fix dropped statuses in scanners
..
Patch Set 1: Code-Review+1
Thanks for fixing this!
--
To view, visit http://gerrit.cloudera.org:8080/4938
To
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 8:
(14 comments)
Thanks for the reviews, please see PS8. I will update again once the
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#8).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Lars Volker has posted comments on this change.
Change subject: IMPALA-3771: Expose kudu client timeout and set default
..
Patch Set 4: Code-Review+1
Thanks.
--
To view, visit http://gerrit.cloudera.org:8080/4849
To
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 7:
(1 comment)
Thanks Tim, for the review. I pushed PS7, removing a DCHECK I had added -
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#7).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 5:
(4 comments)
Thanks for the review, please see PS6.
Lars Volker has uploaded a new patch set (#6).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
IMPALA-2523: Make HdfsTableSink aware of clustered input
IMPALA-2521 introduced clustering for insert
Lars Volker has posted comments on this change.
Change subject: IMPALA-3771: Expose kudu client timeout and set default
..
Patch Set 4:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4849/4/be/src/exec/kudu-util.cc
File
Lars Volker has posted comments on this change.
Change subject: IMPALA-3853: More RAT cleaning.
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4904
To unsubscribe, visit
Lars Volker has posted comments on this change.
Change subject: Add functional tests for compute stats with mt_dop > 0.
..
Patch Set 4:
This ran on a jenkins worker who hit JENKINS-300 several times. I suspect this
was the
Lars Volker has abandoned this change.
Change subject: Revert "IMPALA-4314: Standardize on MT-related data structures"
..
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/4903
To unsubscribe, visit
Lars Volker has posted comments on this change.
Change subject: IMPALA-4374: Use new syntax for creating TPC-DS/H tables in
Kudu stress test
..
Patch Set 2:
Private build passed here:
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4903
Change subject: Revert "IMPALA-4314: Standardize on MT-related data structures"
..
Revert "IMPALA-4314: Standardize on MT-related data
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4887
Change subject: IMPALA-4330: Fix JSON syntax in generate_metrics.py
..
IMPALA-4330: Fix JSON syntax in generate_metrics.py
The hardcoded
Lars Volker has posted comments on this change.
Change subject: IMPALA-3771: Expose kudu client timeout and set default
..
Patch Set 2:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/4849/2/be/src/exec/kudu-table-sink.cc
Lars Volker has uploaded a new patch set (#5).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
IMPALA-2523: Make HdfsTableSink aware of clustered input
IMPALA-2521 introduced clustering for insert
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 4:
(17 comments)
http://gerrit.cloudera.org:8080/#/c/4863/4/be/src/exec/hdfs-table-sink.cc
Lars Volker has posted comments on this change.
Change subject: Add functional tests for compute stats with mt_dop > 0.
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4879
To unsubscribe,
Lars Volker has posted comments on this change.
Change subject: IMPALA-4223: Handle truncated file read from HDFS cache
..
Patch Set 1:
(1 comment)
> (1 comment)
>
> > (1 comment)
> >
> > > (1 comment)
> > >
> > > Can
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 4:
(2 comments)
Thanks Tim for having a look. Please see PS4.
Lars Volker has uploaded a new patch set (#4).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
IMPALA-2523: Make HdfsTableSink aware of clustered input
IMPALA-2521 introduced clustering for insert
Lars Volker has uploaded a new patch set (#2).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
IMPALA-2523: Make HdfsTableSink aware of clustered input
IMPALA-2521 introduced clustering for insert
Lars Volker has uploaded a new patch set (#3).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
IMPALA-2523: Make HdfsTableSink aware of clustered input
IMPALA-2521 introduced clustering for insert
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4870
Change subject: IMPALA-4388: Fix query option reset in tests
..
IMPALA-4388: Fix query option reset in tests
Before this change, using
Lars Volker has posted comments on this change.
Change subject: IMPALA_2523: Make HdfsTableSink aware of clustered input
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4863/1/be/src/exec/hdfs-table-sink.cc
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4863
Change subject: IMPALA_2523: Make HdfsTableSink aware of clustered input
..
IMPALA_2523: Make HdfsTableSink aware of clustered input
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4858
Change subject: IMPALA-4380: Remove 'cloudera' from hostnames in
bin/generate_minidump_collection_testdata.py
..
IMPALA-4380: Remove
701 - 800 of 875 matches
Mail list logo
