[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Donghui Xu has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 14: I have resolved the JIRA and changed it's status to resolved. -- To

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 14: Thanks for your contribution! Please go ahead and resolve the JIRA

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. IMPALA-4431: Add audit event log control mechanism to prevent di

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 13: Verified+1 -- To view, visit http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 13: Build started: http://jenkins.impala.io:8080/job/gerrit-ve

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 13: Code-Review+2 Needed a rebase -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 12: Verified-1 Build failed: http://jenkins.impala.io:8080/job

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 12: Build started: http://jenkins.impala.io:8080/job/gerrit-ve

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 12: Code-Review+2 This seems like it should be uncontroversial, partic

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Donghui Xu has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 12: (2 comments) Thank you. I have modified the code according to your o

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4971 to look at the new patch set (#12). Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow ...

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 11: (2 comments) Looks good - couple of minor comments http://gerrit

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Donghui Xu has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 11: Is there any expert review my code? Thanks. -- To view, visit http:

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Lars Volker has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 11: Code-Review+1 Let's someone else have a look. -- To view, visit ht

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Donghui Xu has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 11: Audit event log has no link file, so there is no link file switch pro

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Lars Volker has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 11: > I have tested that set max_audit_event_log_files to 1. That worked

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Donghui Xu has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 11: I have tested that set max_audit_event_log_files to 1. That worked as

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Lars Volker has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 11: Here's the commit that added CheckAndRotateLogFiles(). Please have a

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Lars Volker has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 11: Here's the commit that added CheckAndRotateLogFiles(). Please have a

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Lars Volker has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 11: > (3 comments) > > I have modified the code according to your opi

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Donghui Xu has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 11: (3 comments) I have modified the code according to your opinion. The

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Donghui Xu has uploaded a new patch set (#11). Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. IMPALA-4431: Add audit event log control mechanism to prevent disk overflow There i

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Lars Volker has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 10: (3 comments) Thanks for applying the fixes. I noticed that there a

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Donghui Xu has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 10: (1 comment) Thanks. I have modified my code. http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Donghui Xu has uploaded a new patch set (#10). Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. IMPALA-4431: Add audit event log control mechanism to prevent disk overflow There i

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Lars Volker has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/4971/9/be/src/common

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Donghui Xu has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 9: Use clang-format-diff.py to correct code format. -- To view, visit h

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Donghui Xu has uploaded a new patch set (#9). Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. IMPALA-4431: Add audit event log control mechanism to prevent disk overflow There is

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Donghui Xu has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 8: (3 comments) Thank you for reviewing my low level format errors so ma

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

Donghui Xu has uploaded a new patch set (#8). Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. IMPALA-4431: Add audit event log control mechanism to prevent disk overflow There is

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

Lars Volker has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. Patch Set 7: (3 comments) Only minor formatting issues left. Please see here for

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

Donghui Xu has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. Patch Set 7: Sorry. I'm not familiar with the use of git-clang-format tools.:) I

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

Donghui Xu has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. Patch Set 7: (6 comments) Sorry. I'm not familiar with the use of git-clang-forma

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

Donghui Xu has uploaded a new patch set (#7). Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. There

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

Lars Volker has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. Patch Set 6: (4 comments) There are still some minor formatting issues left. Hav

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

Donghui Xu has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. Patch Set 6: I have added static method GetAuditEventLogFilePrefix in class Impala

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

Donghui Xu has uploaded a new patch set (#6). Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. There

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

Donghui Xu has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. Patch Set 5: (9 comments) logging.cc Line 58: I can't use it by include impala-se

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

Donghui Xu has uploaded a new patch set (#5). Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. There

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

Lars Volker has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. Patch Set 4: (2 comments) Please address the questions in my previous comments a

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

Donghui Xu has uploaded a new patch set (#4). Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. There

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

Lars Volker has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. Patch Set 3: (5 comments) Please mark comments as done and post replies here whe

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

Donghui Xu has uploaded a new patch set (#3). Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. There

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

davy...@163.com has uploaded a new patch set (#2). Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. T

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

Lars Volker has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. Patch Set 1: (6 comments) Thank you for working on this. Please make sure your ch

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

davy...@163.com has uploaded a new change for review. http://gerrit.cloudera.org:8080/4971 Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. IMPALA-4431: Add audit event log contr