[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-06-01 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 6: > Was able to run Impala exhaustive tests with this toolchain > version. > > Thanks

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: Ported native-toolchain to work on ppc64le .. Ported native-toolchain to work on ppc64le Change-Id: I7931752ca497bc7a5e3cc574bbb54637f382c72a --- M

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 6: Code-Review+2 Verified+1 Was able to run Impala exhaustive tests with this toolchain version. Thanks

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 6: I'm just building and running tests on x86. So far so good. Will +2 and submit once the tests are

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-29 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 5: > nice! that's a good result. Thanks, Valencia. > > I have no other comments. Let's let Tim

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 5: Code-Review+1 nice! that's a good result. Thanks, Valencia. I have no other comments. Let's let Tim

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-26 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 5: (1 comment) Thanks, Matthew/Jim.

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 5: > (1 comment) Thanks Jim, I do realize that so like I said, I wouldn't hold this up if it doesn't

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-25 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 5: (1 comment)

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-25 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 5: (3 comments) Thanks, Matthew! http://gerrit.cloudera.org:8080/#/c/6468/5/buildall.sh File

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-24 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6468/5/buildall.sh File buildall.sh: PS5, Line

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-24 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 5: (3 comments) looking much better, thank you Valencia!

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-24 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 4: (1 comment) Thanks, Tim! I'd like to inform you that I've initialized the new

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-24 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has uploaded a new patch set (#5). Change subject: Ported native-toolchain to work on ppc64le .. Ported native-toolchain to work on ppc64le Change-Id: I7931752ca497bc7a5e3cc574bbb54637f382c72a --- M

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 4: (1 comment) Thanks for the changes. The code changes look good aside from one minor comment. After

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-19 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 2: (14 comments) Thanks for the comments on the patchset, Tim! I've worked on the points you

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-19 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has uploaded a new patch set (#4). Change subject: Ported native-toolchain to work on ppc64le .. Ported native-toolchain to work on ppc64le Change-Id: I7931752ca497bc7a5e3cc574bbb54637f382c72a --- M

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 3: (13 comments) Sorry for the slow turnaround - was on holiday for a couple of weeks. I think we're

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-07 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 3: > Uploaded patch set 3. It would be great if I could get your comments on the new patchset

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-26 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has uploaded a new patch set (#3). Change subject: Ported native-toolchain to work on ppc64le .. Ported native-toolchain to work on ppc64le Change-Id: I7931752ca497bc7a5e3cc574bbb54637f382c72a --- M

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-24 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: (1 comment) Thanks, Tim. http://gerrit.cloudera.org:8080/#/c/6468/1/source/crcutil/build.sh

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: (1 comment) Thanks for the responses - looking forward to the next patchset. I missed that you were

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-20 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: > We talked about this on dev@ and it seems there are no objections > to starting code

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: > > > > @Matthew: Would you be needing the ppc64le infra for > temporary > > > > usage to test the

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-10 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: > > > @Matthew: Would you be needing the ppc64le infra for temporary > > > usage to test the

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: > > @Matthew: Would you be needing the ppc64le infra for temporary > > usage to test the changes until

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: > @Matthew: Would you be needing the ppc64le infra for temporary > usage to test the changes until

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-06 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: @Matthew: Would you be needing the ppc64le infra for temporary usage to test the changes

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-06 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: Matthew, could you let me know the system configuration required on the ppc64le infra ? --

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-04 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: > Valencia, before we continue the discussion of the work on this > toolchain patch much

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: Valencia, before we continue the discussion of the work on this toolchain patch much further, I

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-03-30 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: (1 comment) I'm ready with almost all required changes, except, for crcutil. Before I push

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-03-28 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: (16 comments) > (5 comments) @Matt: Thanks for your comments. I've incorporated the

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-03-27 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: @Matthew, @Tim: Thanks for reviewing the patch. I'm working on the pointers you have

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-03-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: (11 comments) I did a pass over most of it. It would be easier to review with some cleanup to avoid

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-03-24 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/6468/1/buildall.sh File buildall.sh: PS1, Line

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-03-24 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has uploaded a new change for review. http://gerrit.cloudera.org:8080/6468 Change subject: Ported native-toolchain to work on ppc64le .. Ported native-toolchain to work on ppc64le Change-Id: