[Impala-ASF-CR] IMPALA-4747: macros should only evaluate their arguments once

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4747: macros should only evaluate their arguments once .. IMPALA-4747: macros should only evaluate their arguments once The way the

[Impala-ASF-CR] IMPALA-4650: Allow protobuf to find non-system libraries and binaries

2017-01-11 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4650: Allow protobuf to find non-system libraries and binaries .. IMPALA-4650: Allow protobuf to find non-system libraries and binaries This

[Impala-ASF-CR] IMPALA-4650: Add Protobuf to build

2017-01-11 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4650: Add Protobuf to build .. IMPALA-4650: Add Protobuf to build This patch adds Protobuf 2.6.1 to Impala's build, and bumps the toolchain

[Impala-ASF-CR] IMPALA-4650: Add Protobuf to build

2017-01-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4650: Add Protobuf to build .. Patch Set 2: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/5657 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4652: Add crcutil to build

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4652: Add crcutil to build .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/177/ -- To view, visit

[Impala-ASF-CR] IMPALA-4650: Add Protobuf to build

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4650: Add Protobuf to build .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5657 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4652: Add crcutil to build

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4652: Add crcutil to build .. Patch Set 2: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/175/ -- To view,

[Impala-ASF-CR] IMPALA-4651: Add LibEv to build

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4651: Add LibEv to build .. Patch Set 2: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/174/ -- To view, visit

[Impala-ASF-CR] IMPALA-4650: Allow protobuf to find non-system libraries and binaries

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4650: Allow protobuf to find non-system libraries and binaries .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-11 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-4341: Add metadata load to planner timeline

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4341: Add metadata load to planner timeline .. IMPALA-4341: Add metadata load to planner timeline This moves the timeline from the

[Impala-ASF-CR] IMPALA-4341: Add metadata load to planner timeline

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4341: Add metadata load to planner timeline .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5685 To unsubscribe,

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 7: (6 comments)

[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints

2017-01-11 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#4). Change subject: IMPALA-2522: Add doc for sortby() and clustered hints .. IMPALA-2522: Add doc for sortby() and clustered hints Also IMPALA-4163: Add SORTBY() to list of hints in

[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints

2017-01-11 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#3). Change subject: IMPALA-2522: Add doc for sortby() and clustered hints .. IMPALA-2522: Add doc for sortby() and clustered hints Also IMPALA-4163: Add SORTBY() to list of hints in

[Impala-ASF-CR] IMPALA-4036: invalid SQL generated for partitioned table with comment

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4036: invalid SQL generated for partitioned table with comment .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] Add Kudu cmake utilities

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Add Kudu cmake utilities .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5656 To unsubscribe, visit

[Impala-ASF-CR] Add Kudu cmake utilities

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Add Kudu cmake utilities .. Add Kudu cmake utilities This commit imports some CMake utility methods from Kudu, in preparation for adding KRPC

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5662 To unsubscribe,

[Impala-ASF-CR] IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

2017-01-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5683 Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit .. IMPALA-4748: crash in TmpFileMgr when hitting process

[Impala-ASF-CR] IMPALA-4747: macros should only evaluate their arguments once

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4747: macros should only evaluate their arguments once .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/176/

[Impala-ASF-CR] IMPALA-4549: consistently treat 9999 as upper bound for timestamp year

2017-01-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4549: consistently treat as upper bound for timestamp year .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4651: Add LibEv to build

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4651: Add LibEv to build .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/174/ -- To view, visit

[Impala-ASF-CR] IMPALA-4652: Add crcutil to build

2017-01-11 Thread Henry Robinson (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5660 to look at the new patch set (#2). Change subject: IMPALA-4652: Add crcutil to build .. IMPALA-4652: Add crcutil

[Impala-ASF-CR] IMPALA-4651: Add LibEv to build

2017-01-11 Thread Henry Robinson (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5659 to look at the new patch set (#2). Change subject: IMPALA-4651: Add LibEv to build .. IMPALA-4651: Add LibEv to

[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@c6fcede (10/1/2017)

2017-01-11 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5687 Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@c6fcede (10/1/2017) .. IMPALA-4758: (1/2) Update gutil/ from Kudu@c6fcede

[Impala-ASF-CR] IMPALA-4652: Add crcutil to build

2017-01-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4652: Add crcutil to build .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5660/1//COMMIT_MSG Commit Message: Line 7: IMPALA-4652: Add

[Impala-ASF-CR] IMPALA-4651: Add LibEv to build

2017-01-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4651: Add LibEv to build .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5659/1//COMMIT_MSG Commit Message: Line 9: Add libev 4.20 to

[Impala-ASF-CR] IMPALA-4747: macros should only evaluate their arguments once

2017-01-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4747: macros should only evaluate their arguments once .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5686 To

[Impala-ASF-CR] IMPALA-4650: Allow protobuf to find non-system libraries and binaries

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4650: Allow protobuf to find non-system libraries and binaries .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-4747: macros should only evaluate their arguments once

2017-01-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4747: macros should only evaluate their arguments once .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5686 To

[Impala-ASF-CR] IMPALA-4549: consistently treat 9999 as upper bound for timestamp year

2017-01-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-4549: consistently treat as upper bound for timestamp year .. IMPALA-4549: consistently treat as upper bound for timestamp year Previously

Re: [Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-11 Thread Marcel Kornacker
+Greg On Wed, Jan 11, 2017 at 3:22 PM, Tim Armstrong (Code Review) wrote: > Tim Armstrong has posted comments on this change. > > Change subject: IMPALA-1861: Simplify conditionals with constant conditions >

[Impala-ASF-CR] IMPALA-4716: Expr rewrite causes IllegalStateException

2017-01-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4716: Expr rewrite causes IllegalStateException .. Patch Set 3: Code-Review+1 LGTM, will let someone else approve -- To view, visit

[Impala-ASF-CR] IMPALA-4341: Add metadata load to planner timeline

2017-01-11 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4341: Add metadata load to planner timeline .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5685 To unsubscribe,

[Impala-ASF-CR] IMPALA-3671: Add SCRATCH LIMIT query option.

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3671: Add SCRATCH_LIMIT query option. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5651 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4341: Add metadata load to planner timeline

2017-01-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#2). Change subject: IMPALA-4341: Add metadata load to planner timeline .. IMPALA-4341: Add metadata load to planner timeline This moves the timeline from the Analyzer GlobalState to

[Impala-ASF-CR] IMPALA-4716: Expr rewrite causes IllegalStateException

2017-01-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4716: Expr rewrite causes IllegalStateException .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4716: Expr rewrite causes IllegalStateException

2017-01-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#3). Change subject: IMPALA-4716: Expr rewrite causes IllegalStateException .. IMPALA-4716: Expr rewrite causes IllegalStateException The DECODE constructor in CaseExpr uses

[Impala-ASF-CR] IMPALA-3671: Add SCRATCH LIMIT query option.

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3671: Add SCRATCH_LIMIT query option. .. IMPALA-3671: Add SCRATCH_LIMIT query option. Clarify comment about # of DataNodes. Change-Id:

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 5: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/166/ -- To

[Impala-ASF-CR] IMPALA-4747: macros should only evaluate their arguments once

2017-01-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5686 Change subject: IMPALA-4747: macros should only evaluate their arguments once .. IMPALA-4747: macros should only evaluate their

[Impala-ASF-CR] Add Kudu cmake utilities

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Add Kudu cmake utilities .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/170/ -- To view, visit

[Impala-ASF-CR] IMPALA-3671: Add SCRATCH LIMIT query option.

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3671: Add SCRATCH_LIMIT query option. .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/16/ -- To view, visit

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-4643: Centralize tags in separate .ditamap

2017-01-11 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#2). Change subject: IMPALA-4643: Centralize tags in separate .ditamap .. IMPALA-4643: Centralize tags in separate .ditamap Patch set #2 to bring this gerrit review up to date with

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-11 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-4341: Add metadata load to planner timeline

2017-01-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4341: Add metadata load to planner timeline .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5685/1//COMMIT_MSG Commit Message: PS1, Line

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-4341: Add metadata load to planner timeline

2017-01-11 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4341: Add metadata load to planner timeline .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-4036: invalid SQL generated for partitioned table with comment

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4036: invalid SQL generated for partitioned table with comment .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-4341: Add metadata load to planner timeline

2017-01-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5685 Change subject: IMPALA-4341: Add metadata load to planner timeline .. IMPALA-4341: Add metadata load to planner timeline This moves the

[Impala-ASF-CR] IMPALA-3671: Add SCRATCH LIMIT query option.

2017-01-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3671: Add SCRATCH_LIMIT query option. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5651 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-11 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 5: Code-Review+2 > I don't fully understand the consequences of not analyzing these > exprs.

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/168/ -- To

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-11 Thread Marcel Kornacker (Code Review)
Hello Impala Public Jenkins, Dimitris Tsirogiannis, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5662 to look at the new patch set (#5). Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses

[Impala-ASF-CR] IMPALA-4752: make ObjectPool more efficient

2017-01-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4752: make ObjectPool more efficient .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5666/2/be/src/common/object-pool.h File

[Impala-ASF-CR] IMPALA-4752: make ObjectPool more efficient

2017-01-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4752: make ObjectPool more efficient .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/5666/2/be/src/common/object-pool.h File

[Impala-ASF-CR] Add Kudu cmake utilities

2017-01-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Add Kudu cmake utilities .. Patch Set 3: Code-Review+2 I think this makes more sense now, thanks. -- To view, visit http://gerrit.cloudera.org:8080/5656 To

[Impala-ASF-CR] IMPALA-4752: make ObjectPool more efficient

2017-01-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4752: make ObjectPool more efficient .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5666/2/be/src/common/object-pool.h File

[Impala-ASF-CR] IMPALA-4752: make ObjectPool more efficient

2017-01-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-4752: make ObjectPool more efficient .. IMPALA-4752: make ObjectPool more efficient Previously it was implemented as a vector of pointers to dynamically

[Impala-ASF-CR] IMPALA-4752: make ObjectPool more efficient

2017-01-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4752: make ObjectPool more efficient .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5666/2/be/src/common/object-pool.h File

[Impala-ASF-CR] IMPALA-4752: make ObjectPool more efficient

2017-01-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4752: make ObjectPool more efficient .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5666/2/be/src/common/object-pool.h File

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/166/ -- To view, visit

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-11 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4878 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4752: make ObjectPool more efficient

2017-01-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4752: make ObjectPool more efficient .. IMPALA-4752: make ObjectPool more efficient Previously it was implemented as a vector of pointers to dynamically

[Impala-ASF-CR] IMPALA-4752: make ObjectPool more efficient

2017-01-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5666 Change subject: IMPALA-4752: make ObjectPool more efficient .. IMPALA-4752: make ObjectPool more efficient Previously it was

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 5: Also fixed the clang-tidy warnings (I had posted a draft earlier so I could use the dryrun jenkins job).

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-2615: warn if Status is ignored .. IMPALA-2615: warn if Status is ignored This introduces a WARN_UNUSED_RESULT macro. It can be used at the end of function

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-11 Thread Tim Armstrong (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4878 to look at the new patch set (#5). Change subject: IMPALA-2615: warn if Status is ignored .. IMPALA-2615: warn if

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4878/3//COMMIT_MSG Commit Message: PS3, Line 10: in

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-11 Thread Tim Armstrong (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4878 to look at the new patch set (#4). Change subject: IMPALA-2615: warn if Status is ignored .. IMPALA-2615: warn if

[Impala-ASF-CR] IMPALA-3671: Add SCRATCH LIMIT query option.

2017-01-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3671: Add SCRATCH_LIMIT query option. .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5651 To unsubscribe, visit

[Impala-ASF-CR] Clean up tags for 2 query options

2017-01-11 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5682 Change subject: Clean up tags for 2 query options .. Clean up tags for 2 query options One query option was missing a tag. The other

[Impala-ASF-CR] IMPALA-3671: Add SCRATCH LIMIT query option.

2017-01-11 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3671: Add SCRATCH_LIMIT query option. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5651/1/docs/topics/impala_scratch_limit.xml File

[Impala-ASF-CR] IMPALA-3671: Add SCRATCH LIMIT query option.

2017-01-11 Thread John Russell (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5651 to look at the new patch set (#2). Change subject: IMPALA-3671: Add SCRATCH_LIMIT query option. .. IMPALA-3671:

[Impala-ASF-CR] Add Kudu cmake utilities

2017-01-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Add Kudu cmake utilities .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5656/2/cmake_modules/kudu_cmake_fns.txt File

[Impala-ASF-CR] Add Kudu cmake utilities

2017-01-11 Thread Henry Robinson (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5656 to look at the new patch set (#3). Change subject: Add Kudu cmake utilities .. Add Kudu cmake utilities This

[Impala-ASF-CR] IMPALA-4036: invalid SQL generated for partitioned table with comment

2017-01-11 Thread Joe McDonnell (Code Review)
Hello Marcel Kornacker, Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5648 to look at the new patch set (#4). Change subject: IMPALA-4036: invalid SQL generated for partitioned table with comment

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 4: I don't fully understand the consequences of not analyzing these exprs. Based on Jim's

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 3: Code-Review+1 (1 comment) I'm ok with +2ing this as soon as clang-tidy warnings induced by these new