[Impala-ASF-CR] Prepare for official 2.8 release by incrementing version number

2017-01-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Prepare for official 2.8 release by incrementing version number .. Patch Set 2: Build started:

[Impala-ASF-CR] Prepare for official 2.8 release by incrementing version number

2017-01-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Prepare for official 2.8 release by incrementing version number .. Patch Set 2: Code-Review+2 (1 comment) carry +2

[Impala-ASF-CR] Prepare for official 2.8 release by incrementing version number

2017-01-20 Thread Jim Apple (Code Review)
Hello Marcel Kornacker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5763 to look at the new patch set (#2). Change subject: Prepare for official 2.8 release by incrementing version number

[Impala-ASF-CR] Prepare for official 2.8 release by icnrementing version number

2017-01-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Prepare for official 2.8 release by icnrementing version number .. Patch Set 1: Verified-1 Build failed:

[Impala-ASF-CR] Prepare for official 2.8 release by icnrementing version number

2017-01-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Prepare for official 2.8 release by icnrementing version number .. Patch Set 1: (1 comment) one typo. http://gerrit.cloudera.org:8080/#/c/5763/1//COMMIT_MSG

[Impala-ASF-CR] Prepare for official 2.8 release by icnrementing version number

2017-01-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Prepare for official 2.8 release by icnrementing version number .. Patch Set 1: Build started:

[Impala-ASF-CR] Prepare for official 2.8 release by icnrementing version number

2017-01-20 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: Prepare for official 2.8 release by icnrementing version number .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5763 To

[Impala-ASF-CR] Prepare for official 2.8 release by icnrementing version number

2017-01-20 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5763 Change subject: Prepare for official 2.8 release by icnrementing version number .. Prepare for official 2.8 release by icnrementing version

[Impala-ASF-CR] Update copyright year to 2017

2017-01-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Update copyright year to 2017 .. Patch Set 1: This was found by one of our IPMC release voters. -- To view, visit http://gerrit.cloudera.org:8080/5754 To

[Impala-ASF-CR] Update copyright year to 2017

2017-01-20 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5754 Change subject: Update copyright year to 2017 .. Update copyright year to 2017 Change-Id: I6a815c67176fc2a08ed693b581fac4c6919f297c --- M

[Impala-ASF-CR](asf-site) Download and signature links for 2.8.0 release

2017-01-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Download and signature links for 2.8.0 release .. Patch Set 1: This can be submitted in 24 hours, since the IPMC vote passed and the release artifacts are in SVN

[Impala-ASF-CR] IMPALA-3785: Record query handle for invalid handle

2017-01-20 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#3). Change subject: IMPALA-3785: Record query handle for invalid handle .. IMPALA-3785: Record query handle for invalid handle Add the query handle to error messages for Invalid Query

[Impala-ASF-CR] IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen

2017-01-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen .. Patch Set 1: (8 comments)

[Impala-ASF-CR] IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen

2017-01-20 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen .. IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen This change fixes

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 11: (1 comment) Can you please address the question in agg-fn-evaluator.cc ? I can +1 afterwards.

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-20 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 5: To make progress here, should this patch be restricted to the currently clearly

[Impala-ASF-CR] IMPALA-5748 Record query handle for invalid handle

2017-01-20 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5748 Record query handle for invalid handle .. Patch Set 2: Henry, I don't think it matters at all in this case, but I did want to figure out how to use

[Impala-ASF-CR] IMPALA-5748 Record query handle for invalid handle

2017-01-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5748 Record query handle for invalid handle .. Patch Set 2: (2 comments) Do you think the perf difference is worth considering replacing Substitute()?

[Impala-ASF-CR] IMPALA-5748 Record query handle for invalid handle

2017-01-20 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5748 Record query handle for invalid handle .. Patch Set 1: So I wrote a little benchmark. As expected, karma blew away all the other forms of string

[Impala-ASF-CR] IMPALA-5748 Record query handle for invalid handle

2017-01-20 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-5748 Record query handle for invalid handle .. IMPALA-5748 Record query handle for invalid handle Add the query handle to error messages for Invalid Query

[Impala-ASF-CR] Remove 'without Cloudera Manager' from two titles

2017-01-20 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: Remove 'without Cloudera Manager' from two titles .. Patch Set 2: (2 comments) Fixed the commit message as recommended. Thank you.

[Impala-ASF-CR] IMPALA-4735: Upgrade pytest in python env to version 2.9.2.

2017-01-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4735: Upgrade pytest in python env to version 2.9.2. .. Patch Set 3: (10 comments) Thank you for making this patch

[Impala-ASF-CR] Updates to DML statements for Impala + Kudu

2017-01-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Updates to DML statements for Impala + Kudu .. Patch Set 3: the pdf doesn't seem to include the recent changes, can you update it? -- To view, visit

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5649/6/docs/shared/impala_common.xml File

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 6: (18 comments) http://gerrit.cloudera.org:8080/#/c/5649/6/docs/shared/impala_common.xml File

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-01-20 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5483 to look at the new patch set (#6). Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. IMPALA-4192:

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 2: (1 comment) It seems like we really need to talk through the big picture of what to

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 6: (15 comments) Another round of comments. I've seen that not all previous comments have been

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. IMPALA-4449: Revisit table locking pattern in the catalog This commit fixes an

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5710 To

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-01-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 4: (12 comments) http://gerrit.cloudera.org:8080/#/c/5483/4//COMMIT_MSG Commit Message: PS4, Line 31:

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-01-20 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5483 to look at the new patch set (#5). Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. IMPALA-4192:

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-20 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#5). Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. IMPALA-3909: Populate min/max statistics in Parquet writer Change-Id:

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-20 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#4). Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. IMPALA-3909: Populate min/max statistics in Parquet writer Change-Id:

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4735: Upgrade pytest in python env to version 2.9.2.

2017-01-20 Thread David Knupp (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5640 to look at the new patch set (#2). Change subject: IMPALA-4735: Upgrade pytest in python env to version 2.9.2. ..

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 3: (1 comment)

[Impala-ASF-CR] Add doc for MT DOP query option.

2017-01-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Add doc for MT_DOP query option. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5652/1/docs/topics/impala_mt_dop.xml File

[Impala-ASF-CR] IMPALA-278: Mention DIV arithmetic operator.

2017-01-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-278: Mention DIV arithmetic operator. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5634/1/docs/topics/impala_math_functions.xml File

[Impala-ASF-CR] IMPALA-1654: DDL for multiple partitions

2017-01-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1654: DDL for multiple partitions .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/5726/4/docs/topics/impala_alter_table.xml File

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 2: (9 comments)

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-20 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#3). Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. IMPALA-3909: Populate min/max statistics in Parquet writer Change-Id:

[Impala-ASF-CR] Add the query handle to error messages for Invalid Query Handle for beeswax interface.

2017-01-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Add the query handle to error messages for Invalid Query Handle for beeswax interface. .. Patch Set 1: > I was going to do that but I wasn't sure how to test the

[Impala-ASF-CR] Add the query handle to error messages for Invalid Query Handle for beeswax interface.

2017-01-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Add the query handle to error messages for Invalid Query Handle for beeswax interface. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 6: John, do we have a pdf from these sources? It helps immensely the review process of docs --

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2017-01-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows .. Patch Set 8: Sorry for the slow response - lost track of where we were for this. -- To

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2017-01-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 2: *sigh* it seems like there are also some bugs and ambiguities for binary values:

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 2: We should also think about saving the timestamp stats for a later commit, since it

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5743/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/200/ --

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 5: Code-Review+2 Rebase and carry Marcel's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-20 Thread Dimitris Tsirogiannis (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5710 to look at the new patch set (#5). Change subject: IMPALA-4449: Revisit table locking pattern in the catalog ..

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 1: > > That is really unfortunate that our timestamps are treated as > byte > > arrays

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 1: > That is really unfortunate that our timestamps are treated as byte > arrays by

[Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files

2017-01-20 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#9). Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files .. IMPALA-3989: Display skew warning for poorly formatted Parquet files Parquet files are

[Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files

2017-01-20 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files .. Patch Set 8: (4 comments)

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 2: That is really unfortunate that our timestamps are treated as byte arrays by

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-20 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 2: > > (1 comment) > > Apologies for the delayed reply. Hive writes timestamps using

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 2: > (1 comment) Apologies for the delayed reply. Hive writes timestamps using 12 bytes

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-20 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 2: (1 comment)