Michael Ho has posted comments on this change.
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
..
Patch Set 15: Code-Review+2
Looks reasonable to me.
--
To view, visit http://gerrit.cloudera.org:8080/5719
Michael Ho has posted comments on this change.
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
..
Patch Set 15:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5719/15/be/src/kudu/rpc/CMakeLists.txt
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
..
Patch Set 15:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5719/15/be/src/kudu/rpc/CMakeLists.txt
File
Philip Zeyliger has posted comments on this change.
Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is
a literal.
..
Patch Set 5:
(1 comment)
I also ran the "jococo" coverage tool on the java
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7781
to look at the new patch set (#6).
Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is
a literal.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5836: Improvements to Eclipse frontend configuration.
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7803
To
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5836: Improvements to Eclipse frontend configuration.
..
IMPALA-5836: Improvements to Eclipse frontend configuration.
Having recently
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is
a literal.
..
Patch Set 5:
(1 comment)
Philip Zeyliger has posted comments on this change.
Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is
a literal.
..
Patch Set 4:
(7 comments)
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7781
to look at the new patch set (#5).
Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is
a literal.
Bharath Vissapragada has posted comments on this change.
Change subject: [PREVIEW] IMPALA-5538: Use explicit catalog versions for
deleted objects
..
Patch Set 1:
some help* from you.
--
To view, visit
Bharath Vissapragada has posted comments on this change.
Change subject: [PREVIEW] IMPALA-5538: Use explicit catalog versions for
deleted objects
..
Patch Set 1:
(6 comments)
Got some high level comments. I'm still trying to
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5827: add test for failure to repartition in hash join
..
IMPALA-5827: add test for failure to repartition in hash join
Testing:
Ran the
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5827: add test for failure to repartition in hash join
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7811
To
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5713: always reserve memory for preaggs
..
IMPALA-5713: always reserve memory for preaggs
Before this change the preaggregation was
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5713: always reserve memory for preaggs
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7739
To unsubscribe, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4856: Include KRPC services in plan fragment's
destinations
..
Patch Set 2:
(4 comments)
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-5210: Count rows and collection items in parquet scanner
separately
..
Patch Set 3:
(1 comment)
> (3 comments)
>
> Only a comment left.
Done
Tianyi Wang has uploaded a new patch set (#5).
Change subject: IMPALA-5210: Count rows and collection items in parquet scanner
separately
..
IMPALA-5210: Count rows and collection items in parquet scanner separately
This patch
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-4856: Include KRPC services in plan fragment's
destinations
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7760
To
Lars Volker has posted comments on this change.
Change subject: IMPALA-5210: Count rows and collection items in parquet scanner
separately
..
Patch Set 4:
(3 comments)
Only a comment left.
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-5210: Count rows and collection items in parquet scanner
separately
..
Patch Set 3:
(5 comments)
Tianyi Wang has uploaded a new patch set (#4).
Change subject: IMPALA-5210: Count rows and collection items in parquet scanner
separately
..
IMPALA-5210: Count rows and collection items in parquet scanner separately
This patch
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5836: Improvements to Eclipse frontend configuration.
..
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1151/
--
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5799: Kudu DML can crash if schema has changed
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7688
To unsubscribe,
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5799: Kudu DML can crash if schema has changed
..
IMPALA-5799: Kudu DML can crash if schema has changed
We check that the number/types
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7818
Change subject: IMPALA-5846: Fix output path for kudu libraries
..
IMPALA-5846: Fix output path for kudu libraries
Prior to this
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5840: Don't write page-level statistics in Parquet files.
..
Patch Set 1: Code-Review+1
That makes sense, thanks for clarifying.
--
To view, visit
Lars Volker has posted comments on this change.
Change subject: IMPALA-5840: Don't write page-level statistics in Parquet files.
..
Patch Set 1:
> Do any tests need to be modified to reflect this?
No, there are no tests to
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5840: Don't write page-level statistics in Parquet files.
..
Patch Set 1:
Do any tests need to be modified to reflect this?
--
To view, visit
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7817
Change subject: IMPALA-5840: Don't write page-level statistics in Parquet files.
..
IMPALA-5840: Don't write page-level statistics in
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3642: Adding backend addresses to error statuses for
scratch failures.
..
Patch Set 1:
We have test coverage for scratch errors in a few places:
Tianyi Wang has abandoned this change.
Change subject: IMPALA-5425: Add test for validating input when setting query
options
..
Abandoned
I will move them to backend tests
--
To view, visit
Philip Zeyliger has posted comments on this change.
Change subject: IMPALA-3642: Adding backend addresses to error statuses for
scratch failures.
..
Patch Set 1:
I'm looking for feedback on whether we have more explicit ways
Lars Volker has posted comments on this change.
Change subject: IMPALA-5210: Count rows and collection items in parquet scanner
separately
..
Patch Set 2:
(8 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5830: SET_DENY_RESERVATION_PROBABILITY test
..
Patch Set 2: Code-Review+1
Please have someone review the python code more carefully. I mostly focused on
the
Philip Zeyliger has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7816
Change subject: IMPALA-3642: Adding backend addresses to error statuses for
scratch failures.
..
IMPALA-3642: Adding backend
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5830: SET_DENY_RESERVATION_PROBABILITY test
..
Patch Set 2:
(1 comment)
Tim Armstrong has uploaded a new patch set (#2).
Change subject: IMPALA-5830: SET_DENY_RESERVATION_PROBABILITY test
..
IMPALA-5830: SET_DENY_RESERVATION_PROBABILITY test
Add a targeted test that confirms that setting the query
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
..
Patch Set 14:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5719/14/be/src/kudu/rpc/CMakeLists.txt
File
Hello Impala Public Jenkins, Michael Ho,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5719
to look at the new patch set (#15).
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5827: add test for failure to repartition in hash join
..
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1150/
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5827: add test for failure to repartition in hash join
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7811
To unsubscribe,
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5830: SET_DENY_RESERVATION_PROBABILITY test
..
Patch Set 1:
(1 comment)
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7811
Change subject: IMPALA-5827: add test for failure to repartition in hash join
..
IMPALA-5827: add test for failure to repartition in
Alex Behm has posted comments on this change.
Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is
a literal.
..
Patch Set 4:
(6 comments)
I vote for keeping the rewrite logic simple like it is in
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7809
Change subject: IMPALA-5830: SET_DENY_RESERVATION_PROBABILITY test
..
IMPALA-5830: SET_DENY_RESERVATION_PROBABILITY test
Add a targeted
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5713: always reserve memory for preaggs
..
Patch Set 6: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/7739
To unsubscribe,
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5713: always reserve memory for preaggs
..
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1149/
--
To view,
Alex Behm has posted comments on this change.
Change subject: IMPALA-5713: always reserve memory for preaggs
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7739
To unsubscribe, visit
Pranay Singh has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7807
Change subject: IMPALA-5108: Followup change to do the cleanup.
..
IMPALA-5108: Followup change to do the cleanup.
This change involves
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5713: always reserve memory for preaggs
..
Patch Set 5:
I spoke to Mostafa about the change and he agreed it was a good idea.
--
To view, visit
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-5210: Count rows and collection items in parquet scanner
separately
..
Patch Set 2:
(3 comments)
Tianyi Wang has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7805
Change subject: IMPALA-5425: Add test for validating input when setting query
options
..
IMPALA-5425: Add test for validating input when
Michael Brown has posted comments on this change.
Change subject: IMPALA-5625: stress test: write profile when queries fail
..
Patch Set 5:
Nice work! Please mark IMPALA-5625 fixed and include a reference either to the
commit
Michael Brown has submitted this change and it was merged.
Change subject: IMPALA-5625: stress test: write profile when queries fail
..
IMPALA-5625: stress test: write profile when queries fail
This change writes query
Michael Brown has posted comments on this change.
Change subject: IMPALA-5625: stress test: write profile when queries fail
..
Patch Set 4: Verified+1
This doesn't go through GVD, so I'm going to verify and submit it myself. I
Michael Brown has posted comments on this change.
Change subject: IMPALA-5625: stress test: write profile when queries fail
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7376
To unsubscribe,
Matthew Mulder has posted comments on this change.
Change subject: IMPALA-5625: stress test: write profile when queries fail
..
Patch Set 2:
(1 comment)
Michael Brown has posted comments on this change.
Change subject: IMPALA-5625: stress test: write profile when queries fail
..
Patch Set 2:
(1 comment)
Matthew Mulder has uploaded a new patch set (#4).
Change subject: IMPALA-5625: stress test: write profile when queries fail
..
IMPALA-5625: stress test: write profile when queries fail
This change writes query profiles as text
Matthew Mulder has abandoned this change.
Change subject: get_profile() -> fetch_and_set_profile()
..
Abandoned
Oops, wrong change id.
--
To view, visit http://gerrit.cloudera.org:8080/7804
To unsubscribe, visit
Michael Brown has posted comments on this change.
Change subject: get_profile() -> fetch_and_set_profile()
..
Patch Set 1:
You probably want to abandon this and squash this into
https://gerrit.cloudera.org/#/c/7376/
--
To
Matthew Mulder has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7804
Change subject: get_profile() -> fetch_and_set_profile()
..
get_profile() -> fetch_and_set_profile()
Change-Id:
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5799: Kudu DML can crash if schema has changed
..
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1148/
--
To
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5799: Kudu DML can crash if schema has changed
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7688
To unsubscribe,
Sailesh Mukil has posted comments on this change.
Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7741
To
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-5210: Count rows and collection items in parquet scanner
separately
..
Patch Set 2:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/7776/2//COMMIT_MSG
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-5836: Improvements to Eclipse frontend configuration.
..
Patch Set 1: Code-Review+2
Thank you!
--
To view, visit
Philip Zeyliger has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7803
Change subject: IMPALA-5836: Improvements to Eclipse frontend configuration.
..
IMPALA-5836: Improvements to Eclipse frontend
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5108: Followup change to do the cleanup.
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7801/1/be/src/service/session-expiry-test.cc
File
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5531: Fix correctness issue in correlated aggregate
subqueries
..
Patch Set 5: Verified+1
--
To view, visit
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5531: Fix correctness issue in correlated aggregate
subqueries
..
IMPALA-5531: Fix correctness issue in correlated aggregate subqueries
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5648: fix count(*) mem estimate regression
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7783
To unsubscribe,
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5648: fix count(*) mem estimate regression
..
IMPALA-5648: fix count(*) mem estimate regression
The metadata-only scan doesn't allocate
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests
..
IMPALA-5780,IMPALA-5779: extra spilling tests
* Test for disable_unsafe_spills
* Test for
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7787
To unsubscribe, visit
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5531: Fix correctness issue in correlated aggregate
subqueries
..
Patch Set 5:
Build started:
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-5531: Fix correctness issue in correlated aggregate
subqueries
..
Patch Set 5: Code-Review+2
Rebase, keep Alex's +2
--
To view, visit
79 matches
Mail list logo
