[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-01 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#4). Change subject: IMPALA-4822: Implement dynamic log level changes .. IMPALA-4822: Implement dynamic log level changes Very often we have to change the logging levels of

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-01 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 1: (2 comments) PS4 implements dynamic logging changes to the backend (equivalent to

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-01 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#5). Change subject: IMPALA-4822: Implement dynamic log level changes .. IMPALA-4822: Implement dynamic log level changes Very often we have to change the logging levels of

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-02 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#6). Change subject: IMPALA-4822: Implement dynamic log level changes .. IMPALA-4822: Implement dynamic log level changes Very often we have to change the logging levels of

[Impala-ASF-CR] Removed dead join inversion code from Analyzer.

2017-02-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has abandoned this change. Change subject: Removed dead join inversion code from Analyzer. .. Abandoned As discussed with Alex, I'm abandoning this change and will submit a new change with a larger

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 5: (9 comments) webserver-test.cc seems to be more unit-testing the WebServer class and I

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-02 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 4: A sample output looks like this. [localhost:21000] > explain select * from

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-02 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-01 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-01 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#3). Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. IMPALA-1427: Improvements to "Unknown disk-ID" warning This commit, - Removes the runtime unknown

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-01 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#2). Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. IMPALA-1427: Improvements to "Unknown disk-ID" warning This commit, - Removes the runtime unknown

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-01 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5828/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#5). Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. IMPALA-1427: Improvements to "Unknown disk-ID" warning This commit, - Removes the runtime

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 4: (6 comments)

[Impala-ASF-CR] IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs

2017-01-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs .. Patch Set 3: @reviewers: Please don't review PS2/3. My next PS includes a bunch

[Impala-ASF-CR] IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs

2017-01-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs .. Patch Set 1: (6 comments) Thanks Alex for the reviews. Very helpful. I agree

[Impala-ASF-CR] IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs

2017-01-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#2). Change subject: IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs .. IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs Very often we

[Impala-ASF-CR] IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs

2017-01-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#3). Change subject: IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs .. IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs Very often we

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 8: Code-Review+2 Rebased, carrying +2. Thanks for the reviews. -- To view, visit

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 8: Looks like it is not related to the PATCH. Can someone please re-trigger this

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 8: Full trace, if someone is interested. 16:35:06

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5792/7/common/thrift/Logging.thrift

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#10). Change subject: IMPALA-4822: Implement dynamic log level changes .. IMPALA-4822: Implement dynamic log level changes Very often we have to change the logging levels of

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 6: (3 comments) - I'm not totally sure why IMPALA-1427 wasn't closed. Looks like it

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 7: Thanks for the review Dan. I'll wait for Alex's +2. I ran a quick test against an

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-06 Thread Bharath Vissapragada (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5828 to look at the new patch set (#7). Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning ..

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 7: (29 comments)

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/5792/6/be/src/util/logging-support.cc

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#7). Change subject: IMPALA-4822: Implement dynamic log level changes .. IMPALA-4822: Implement dynamic log level changes Very often we have to change the logging levels of

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 6: Code-Review+2 Carrying Alex's +2. Will wait for Dan to sign off. -- To view,

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/5828/5//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-05 Thread Bharath Vissapragada (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5828 to look at the new patch set (#6). Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning ..

[Impala-ASF-CR] IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs

2017-01-24 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new change for review. http://gerrit.cloudera.org:8080/5792 Change subject: IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs .. IMPALA-4822: Dynamic log level changes to

[Impala-ASF-CR] IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs

2017-01-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs .. Patch Set 1: I created a small screencast here [1] to demo this enhancement. In

[Impala-ASF-CR] Improvements to "Unknown disk-ID" warning

2017-01-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new change for review. http://gerrit.cloudera.org:8080/5828 Change subject: Improvements to "Unknown disk-ID" warning .. Improvements to "Unknown disk-ID" warning This commit, - Appends

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 5: No comments. LGTM. -- To view, visit

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-4282: Remove max length check for type strings.

2017-02-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4282: Remove max length check for type strings. .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6034 To

[Impala-ASF-CR] IMPALA-4854: Fix incremental stats with complex types.

2017-02-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4854: Fix incremental stats with complex types. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6033 To

[Impala-ASF-CR] IMPALA-4282: Remove max length check for type strings.

2017-02-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4282: Remove max length check for type strings. .. Patch Set 1: Looks like you forgot to git-add changes from ColumnDef.java. -- To view, visit

[Impala-ASF-CR] IMPALA-4902: Copy parameters map in HdfsPartition.toThrift().

2017-02-23 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4902: Copy parameters map in HdfsPartition.toThrift(). .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/6127/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4902: Copy parameters map in HdfsPartition.toThrift().

2017-02-23 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4902: Copy parameters map in HdfsPartition.toThrift(). .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-4902: Copy parameters map in HdfsPartition.toThrift().

2017-02-23 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4902: Copy parameters map in HdfsPartition.toThrift(). .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4955: Fix integer overflow in hdfs table size accounting

2017-02-23 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new change for review. http://gerrit.cloudera.org:8080/6133 Change subject: IMPALA-4955: Fix integer overflow in hdfs table size accounting .. IMPALA-4955: Fix integer overflow in hdfs

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#11). Change subject: IMPALA-4822: Implement dynamic log level changes .. IMPALA-4822: Implement dynamic log level changes Very often we have to change the logging levels of

[Impala-ASF-CR] Fix merge conflict

2017-02-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: Fix merge conflict .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5967 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 7: (16 comments) http://gerrit.cloudera.org:8080/#/c/5792/7/be/src/util/logging-support.cc

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#12). Change subject: IMPALA-4822: Implement dynamic log level changes .. IMPALA-4822: Implement dynamic log level changes Very often we have to change the logging levels of

[Impala-ASF-CR] IMPALA-4840: Fix REFRESH performance regression.

2017-02-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new change for review. http://gerrit.cloudera.org:8080/6009 Change subject: IMPALA-4840: Fix REFRESH performance regression. .. IMPALA-4840: Fix REFRESH performance regression. The fix for

[Impala-ASF-CR] IMPALA-4840: Fix REFRESH performance regression.

2017-02-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#3). Change subject: IMPALA-4840: Fix REFRESH performance regression. .. IMPALA-4840: Fix REFRESH performance regression. The fix for IMPALA-4172 introduced a regression in

[Impala-ASF-CR] IMPALA-4840: Fix REFRESH performance regression.

2017-02-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4840: Fix REFRESH performance regression. .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/6013/1/be/src/util/thread.cc File

[Impala-ASF-CR] IMPALA-4840: Fix REFRESH performance regression.

2017-02-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#2). Change subject: IMPALA-4840: Fix REFRESH performance regression. .. IMPALA-4840: Fix REFRESH performance regression. The fix for IMPALA-4172 introduced a regression in

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 12: (16 comments) Fxed a minor bug in the web UI where the setting for java log level

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#13). Change subject: IMPALA-4822: Implement dynamic log level changes .. IMPALA-4822: Implement dynamic log level changes Very often we have to change the logging levels of

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/5710/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4778 IMPALA-1972: Add known issue

2017-01-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4778 IMPALA-1972: Add known issue .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5747/1/docs/topics/impala_known_issues.xml File

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 1: Code-Review+1 (1 comment) The fix makes sense to me. We are doing a

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 13: (4 comments)

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-27 Thread Bharath Vissapragada (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5792 to look at the new patch set (#14). Change subject: IMPALA-4822: Implement dynamic log level changes ..

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/5792/13/be/src/util/logging-support.cc

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/5792/13/be/src/util/logging-support.cc

[Impala-ASF-CR] Remove deadcode from frontend - Part 1

2017-02-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#2). Change subject: Remove deadcode from frontend - Part 1 .. Remove deadcode from frontend - Part 1 Change-Id: I3fa810cf4eaf9f9ff545fe80a11bc62619039224 --- M

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-28 Thread Bharath Vissapragada (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5792 to look at the new patch set (#15). Change subject: IMPALA-4822: Implement dynamic log level changes ..

[Impala-ASF-CR] IMPALA-4998: Fix missing table lock acquisition.

2017-02-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4998: Fix missing table lock acquisition. .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 15: Code-Review+2 Thanks Henry. Rebased and increased the page width to 50% for it look

[Impala-ASF-CR] Remove deadcode from frontend - Part 1

2017-02-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: Remove deadcode from frontend - Part 1 .. Patch Set 1: (2 comments)

[Impala-ASF-CR] Remove deadcode from frontend - Part 1

2017-02-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: Remove deadcode from frontend - Part 1 .. Patch Set 1: (1 comment) Also I'm afraid if the stuff I removed from this might affect xplain tool as I

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 13: Henry, do you have any further comments on this? Thanks. -- To view, visit

[Impala-ASF-CR] IMPALA-4998: Fix missing table lock acquisition.

2017-02-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4998: Fix missing table lock acquisition. .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-1702: Enforce unique table ID

2016-09-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1702: Enforce unique table ID .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4099: Fix the error message while loading UDFs with no JARs

2016-09-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4099: Fix the error message while loading UDFs with no JARs .. Patch Set 1: (5 comments) Thanks Alex for the review.

[Impala-ASF-CR] IMPALA-4099: Fix the error message while loading UDFs with no JARs

2016-09-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#2). Change subject: IMPALA-4099: Fix the error message while loading UDFs with no JARs .. IMPALA-4099: Fix the error message while loading UDFs with no JARs Currently we

[Impala-ASF-CR] IMPALA-4196: Cross compile bit-byte-functions

2016-09-29 Thread Bharath Vissapragada (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4557 to look at the new patch set (#2). Change subject: IMPALA-4196: Cross compile bit-byte-functions .. IMPALA-4196:

[Impala-ASF-CR] IMPALA-4196: Cross compile bit-byte-functions

2016-09-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4196: Cross compile bit-byte-functions .. Patch Set 2: Sry missed the test. Added it in PS2. -- To view, visit

[Impala-ASF-CR] IMPALA-4196: Cross compile bit-byte-functions

2016-09-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4196: Cross compile bit-byte-functions .. Patch Set 3: Code-Review+1 (1 comment) Carry +1

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency

2016-10-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency .. Patch Set 11: Code-Review+1 (1 comment) The change looks fine to me. Thanks for working on this Huaisi.

[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-10-07 Thread Bharath Vissapragada (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4617 to look at the new patch set (#4). Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load

[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-10-07 Thread Bharath Vissapragada (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4617 to look at the new patch set (#5). Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load

[Impala-ASF-CR] IMPALA-3983: Delete function jar resources after load

2016-10-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#2). Change subject: IMPALA-3983: Delete function jar resources after load .. IMPALA-3983: Delete function jar resources after load The Catalog copies the UDF jar files to the

[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-10-04 Thread Bharath Vissapragada (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4617 to look at the new patch set (#3). Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load

[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-10-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load .. Patch Set 2: (1 comment) Thanks Alex. Carrying +1.

[Impala-ASF-CR] IMPALA-3983: Delete function jar resources after load

2016-10-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3983: Delete function jar resources after load .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4617/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-10-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load .. Patch Set 3: (1 comment) Added a test.

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-09-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1654: General partition exprs in DDL operations. .. Patch Set 16: (9 comments) Great work. I just have a bunch of nits and some clarifications.

[Impala-ASF-CR] IMPALA-4206: Add column lineage regression test.

2016-09-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4206: Add column lineage regression test. .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-4196: Cross compile bit-byte-functions

2016-09-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new change for review. http://gerrit.cloudera.org:8080/4557 Change subject: IMPALA-4196: Cross compile bit-byte-functions .. IMPALA-4196: Cross compile bit-byte-functions Change-Id:

[Impala-ASF-CR] IMPALA-4196: Cross compile bit-byte-functions

2016-09-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4196: Cross compile bit-byte-functions .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency accross service .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/4349/3//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4196: Cross compile bit-byte-functions

2016-09-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4196: Cross compile bit-byte-functions .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4196: Cross compile bit-byte-functions

2016-09-30 Thread Bharath Vissapragada (Code Review)
Hello Michael Ho, Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4557 to look at the new patch set (#4). Change subject: IMPALA-4196: Cross compile bit-byte-functions

[Impala-ASF-CR] IMPALA-4196: Cross compile bit-byte-functions

2016-09-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4196: Cross compile bit-byte-functions .. Patch Set 4: Code-Review+2 Rebased. -- To view, visit http://gerrit.cloudera.org:8080/4557 To

[Impala-ASF-CR] IMPALA-4196: Cross compile bit-byte-functions

2016-09-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4196: Cross compile bit-byte-functions .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (4 comments) Haven't gone through the whole patch, but I put some

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-10-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (3 comments)

  1   2   3   4   5   >