[Impala-ASF-CR] IMPALA-4868: Fix flaky TestRequestPoolService.testUpdatingConfigs

2017-02-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5876 Change subject: IMPALA-4868: Fix flaky TestRequestPoolService.testUpdatingConfigs .. IMPALA-4868: Fix flaky

[Impala-ASF-CR] CDH-48291: Fix flaky test TestRequestPoolService

2017-02-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: CDH-48291: Fix flaky test TestRequestPoolService .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4839: Remote Kudu tests failing because loopback is hard-coded

2017-02-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4839: Remote Kudu tests failing because loopback is hard-coded .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/5877/4//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. IMPALA-4828: Alter Kudu schema outside Impala may crash on read Creating a table in Impala,

[Impala-ASF-CR] Clarify synchronization policy for 'done ' in KuduScanNode

2017-02-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Clarify synchronization policy for 'done_' in KuduScanNode .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/5494/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4880: Clarify synchronization policy for 'done ' in KuduScanNode

2017-02-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4880: Clarify synchronization policy for 'done_' in KuduScanNode .. Patch Set 3: Code-Review+1 Thanks, I think there are some helpful improvements

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-02-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 14: (11 comments) http://gerrit.cloudera.org:8080/#/c/5649/14/docs/topics/impala_explain.xml File

[Impala-ASF-CR] Bump Kudu version to latest Kudu master

2017-02-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5929 Change subject: Bump Kudu version to latest Kudu master .. Bump Kudu version to latest Kudu master Change-Id:

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. Patch Set 2: After discussing with Dan on the Kudu team, we can make this simpler by

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#5). Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. IMPALA-4828: Alter Kudu schema outside Impala may crash on read Creating a table in Impala,

[Impala-ASF-CR] IMPALA-4738: STDDEV SAMP should return NULL for single record input

2017-02-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4738: STDDEV_SAMP should return NULL for single record input .. Patch Set 3: Code-Review+2 (2 comments) Thanks! Please let John know that the existing

[Impala-ASF-CR] IMPALA-4880: Clarify synchronization policy for 'done ' in KuduScanNode

2017-02-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4880: Clarify synchronization policy for 'done_' in KuduScanNode .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5494

[Impala-ASF-CR] IMPALA-4738: STDDEV SAMP should return NULL for single record input

2017-02-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4738: STDDEV_SAMP should return NULL for single record input .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5800 To

[Impala-ASF-CR] Bump Kudu version to latest Kudu master

2017-02-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to latest Kudu master .. Patch Set 1: Ran a private test run. -- To view, visit http://gerrit.cloudera.org:8080/5929 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-01-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5840 Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. IMPALA-4828: Alter Kudu schema outside Impala may

[Impala-ASF-CR] IMPALA-4738: STDDEV SAMP should return NULL for single record input

2017-02-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4738: STDDEV_SAMP should return NULL for single record input .. Patch Set 2: Code-Review+2 (2 comments) please let john know we should doc this change

[Impala-ASF-CR] IMPALA-4853: Skip test kudu dml reporting if Kudu is not supported.

2017-02-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4853: Skip test_kudu_dml_reporting if Kudu is not supported. .. Patch Set 1: Code-Review+2 whoops, thanks David! -- To view, visit

[Impala-ASF-CR] IMPALA-4801: fix heap use after free for MemTracker

2017-01-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4801: fix heap use after free for MemTracker .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5772 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4801: fix heap use after free for MemTracker

2017-01-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4801: fix heap use after free for MemTracker .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4738: STDDEV SAMP should return NULL for single record input

2017-01-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4738: STDDEV_SAMP should return NULL for single record input .. Patch Set 1: (1 comment) I think you need a new finalize function to separate stddev

[Impala-ASF-CR] Add "Known Issues" item for IMPALA-4828.

2017-01-27 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Add "Known Issues" item for IMPALA-4828. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5807 To unsubscribe, visit

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/5649/11/docs/topics/impala_create_table.xml File

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/5649/10/docs/topics/impala_kudu.xml File

[Impala-ASF-CR] IMPALA-4566: Set Kudu vlog level independently of Impala vlog

2017-01-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has abandoned this change. Change subject: IMPALA-4566: Set Kudu vlog level independently of Impala vlog .. Abandoned Not gonna bother unless we see more specific needs for this -- To view, visit

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 6: (18 comments) http://gerrit.cloudera.org:8080/#/c/5649/6/docs/shared/impala_common.xml File

[Impala-ASF-CR] Updates to DML statements for Impala + Kudu

2017-01-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Updates to DML statements for Impala + Kudu .. Patch Set 3: the pdf doesn't seem to include the recent changes, can you update it? -- To view, visit

[Impala-ASF-CR] IMPALA-4738: STDDEV SAMP should return NULL for single record input

2017-01-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4738: STDDEV_SAMP should return NULL for single record input .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4829: Change default Kudu read behavior for "RYW"

2017-01-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5802 Change subject: IMPALA-4829: Change default Kudu read behavior for "RYW" .. IMPALA-4829: Change default Kudu read behavior for "RYW"

[Impala-ASF-CR] Updates to DML statements for Impala + Kudu

2017-01-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Updates to DML statements for Impala + Kudu .. Patch Set 4: (17 comments) http://gerrit.cloudera.org:8080/#/c/5646/3/docs/topics/impala_delete.xml File

[Impala-ASF-CR] Updates to DML statements for Impala + Kudu

2017-01-27 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Updates to DML statements for Impala + Kudu .. Patch Set 5: Code-Review+2 (2 comments) Please just address my comment about arbitrary, otherwise looks good-

[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization

2017-02-21 Thread Matthew Jacobs (Code Review)
Hello Impala Public Jenkins, Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6056 to look at the new patch set (#6). Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization

[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization

2017-02-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. Patch Set 6: Code-Review+2 fixed a python test that failed, I had missed it locally because my local

[Impala-ASF-CR] Avoid including Boost cmake support from system path

2017-02-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Avoid including Boost cmake support from system path .. Patch Set 1: David's review https://gerrit.cloudera.org/#/c/5994/2 -- To view, visit

[Impala-ASF-CR] Avoid including Boost cmake support from system path

2017-02-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Avoid including Boost cmake support from system path .. Patch Set 1: Hm David posted this as well but it looks like we never got it in. I'm guessing he's busy

[Impala-ASF-CR] kudu: fix uninitialized variable usage warning

2017-02-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: kudu: fix uninitialized variable usage warning .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6098 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization

2017-02-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. Patch Set 4: python tests don't handle this yet, need to wait for a patch from kudu that avoids DFATAL

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-17 Thread Matthew Jacobs (Code Review)
Hello Thomas Tauber-Marshall, Sailesh Mukil, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5840 to look at the new patch set (#9). Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. Patch Set 9: Code-Review+2 fixed spelling and carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization

2017-02-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6056/3/be/src/rpc/authentication.cc File

[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization

2017-02-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#4). Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. IMPALA-4934: Disable Kudu OpenSSL initialization Bumps the Kudu version to include the change to the client

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-16 Thread Matthew Jacobs (Code Review)
Hello Thomas Tauber-Marshall, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5840 to look at the new patch set (#8). Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. Patch Set 7: (2 comments)

[Impala-ASF-CR] PREVIEW: IMPALA-3742: partitions INSERTs into Kudu tables

2017-02-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: PREVIEW: IMPALA-3742: partitions INSERTs into Kudu tables .. Patch Set 1: (6 comments) just some high level comments for now since this is WIP. would you

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 2: (2 comments)

[Impala-ASF-CR] Three misc webpage changes

2017-02-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Three misc webpage changes .. Patch Set 1: Code-Review+1 seems fine but I don't really know jquery -- To view, visit http://gerrit.cloudera.org:8080/6045 To

[Impala-ASF-CR] IMPALA-4959: Avoid picking up the system's boost cmake module

2017-02-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4959: Avoid picking up the system's boost cmake module .. Patch Set 3: yup thanks for pinging about that, I just submitted it for gvm -- To view,

[Impala-ASF-CR] IMPALA-4987: Skip test rows availability when testing over a network.

2017-02-24 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4987: Skip test_rows_availability when testing over a network. .. Patch Set 1: Code-Review+1 (1 comment) seems like a flaky test in general...

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6025/6/be/src/exprs/aggregate-functions-ir.cc

[Impala-ASF-CR] Three misc webpage changes

2017-02-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Three misc webpage changes .. Patch Set 1: Code-Review+2 > Thanks for the reviews! > > > seems fine but I don't really know jquery > > If it makes it

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 6: (3 comments) I'm still not convinced the new paths are necessarily, e.g. the case I

[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization

2017-02-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization .. Patch Set 5: Code-Review+2 had to bump the client version one more time to get another change in Kudu --

[Impala-ASF-CR] build: don't look in system paths for kudu client

2017-02-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: build: don't look in system paths for kudu client .. Patch Set 1: I submit it, it doesn't get kicked off automatically -- To view, visit

[Impala-ASF-CR] Make sure impala doesn't pickup the system's boost cmake module

2017-02-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Make sure impala doesn't pickup the system's boost cmake module .. Patch Set 2: I filed https://issues.cloudera.org/browse/IMPALA-4959 Please just add that to

[Impala-ASF-CR] IMPALA-4934: Disable Kudu OpenSSL initialization

2017-02-21 Thread Matthew Jacobs (Code Review)
Hello Impala Public Jenkins, Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6056 to look at the new patch set (#5). Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization

[Impala-ASF-CR] build: don't look in system paths for kudu client

2017-02-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: build: don't look in system paths for kudu client .. Patch Set 1: Code-Review+2 assuming this passes real builds -- To view, visit

[Impala-ASF-CR] IMPALA-4839: Remove implicit 'localhost' for KUDU MASTER HOSTS

2017-02-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5877 To

[Impala-ASF-CR] IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu

2017-02-09 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu .. Patch Set 1: (1 comment) Nice! I think it looks good, just a comment about some additional test cases

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. Patch Set 6: Code-Review+1 carrying Sailesh's +1 -- To view, visit

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-10 Thread Matthew Jacobs (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5840 to look at the new patch set (#6). Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5840/5//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4839: Remove implicit 'localhost' for KUDU MASTER HOSTS

2017-02-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5877 To

[Impala-ASF-CR] Make sure impala doesn't pickup the system's boost cmake module

2017-02-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Make sure impala doesn't pickup the system's boost cmake module .. Patch Set 1: Seems reasonable to me too, thanks for the fix. Just curious, where did you

[Impala-ASF-CR] IMPALA-4931: Update squeasel to include patch to disable SSL init

2017-02-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4931: Update squeasel to include patch to disable SSL init .. Patch Set 1: > I'm not too clear on how this CMAKE option would get affected > because

[Impala-ASF-CR] IMPALA-4931: Update squeasel to include patch to disable SSL init

2017-02-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6006 Change subject: IMPALA-4931: Update squeasel to include patch to disable SSL init .. IMPALA-4931: Update squeasel to include patch to

[Impala-ASF-CR] IMPALA-4933, IMPALA-4931: Simplify SSL initialization on startup

2017-02-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4933, IMPALA-4931: Simplify SSL initialization on startup .. Patch Set 2: private job succeeded -- To view, visit http://gerrit.cloudera.org:8080/6027

[Impala-ASF-CR] IMPALA-4933, IMPALA-4931: Simplify SSL initialization on startup

2017-02-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-4933, IMPALA-4931: Simplify SSL initialization on startup .. IMPALA-4933, IMPALA-4931: Simplify SSL initialization on startup OpenSSL initialization

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-02-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 15: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5649 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-15 Thread Matthew Jacobs (Code Review)
Hello Thomas Tauber-Marshall, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5840 to look at the new patch set (#7). Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read

[Impala-ASF-CR] IMPALA-4931: Update squeasel to include patch to disable SSL init

2017-02-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4931: Update squeasel to include patch to disable SSL init .. Patch Set 2: Code-Review+2 removed the old cmake line and rebased -- To view, visit

[Impala-ASF-CR] IMPALA-4931: Update squeasel to include patch to disable SSL init

2017-02-15 Thread Matthew Jacobs (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6006 to look at the new patch set (#2). Change subject: IMPALA-4931: Update squeasel to include patch to disable SSL init

[Impala-ASF-CR] Revert "IMPALA-4829: Change default Kudu read behavior for "RYW""

2017-02-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Revert "IMPALA-4829: Change default Kudu read behavior for "RYW"" .. Patch Set 3: Code-Review+2 rebase -- To view, visit

[Impala-ASF-CR] IMPALA-4933: Force thrift to initialize SSL on process startup

2017-02-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6027 Change subject: IMPALA-4933: Force thrift to initialize SSL on process startup .. IMPALA-4933: Force thrift to initialize SSL on

[Impala-ASF-CR] IMPALA-4933: Force thrift to initialize SSL on process startup

2017-02-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4933: Force thrift to initialize SSL on process startup .. Patch Set 1: Running jenkins job now, will also deploy to a secure cluster for additional

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 1: I'll do a CR later tonight or tmr morning. -- To view, visit

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kutil library to the build.

2017-01-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kutil library to the build. .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5715/1/CMakeLists.txt File

[native-toolchain-CR] IMPALA-5002: Associate toolchain build scripts/flags with built packages

2017-03-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has submitted this change and it was merged. Change subject: IMPALA-5002: Associate toolchain build scripts/flags with built packages .. IMPALA-5002: Associate toolchain build scripts/flags with built packages

[Impala-ASF-CR] IMPALA-4616: Add missing Kudu column options

2017-03-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6220 Change subject: IMPALA-4616: Add missing Kudu column options .. IMPALA-4616: Add missing Kudu column options Adds support for missing

[Impala-ASF-CR] IMPALA-4810: add DECIMAL test case to strict mode tests

2017-02-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4810: add DECIMAL test case to strict_mode tests .. Patch Set 2: Code-Review+2 Looks good to me, thanks for adding these. -- To view, visit

[Impala-ASF-CR] IMPALA-4983: Set toolchain version to include LZ4 build flags

2017-02-27 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4983: Set toolchain version to include LZ4 build flags .. Patch Set 1: Code-Review+2 Ok, I filed https://issues.cloudera.org/browse/IMPALA-5002 to

[native-toolchain-CR] Add a script to build Kudu using existing toolchain artifacts

2017-02-27 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6167 Change subject: Add a script to build Kudu using existing toolchain artifacts .. Add a script to build Kudu using existing toolchain

[Impala-ASF-CR] IMPALA-5001: Redownload dependencies if toolchain ID changes

2017-02-27 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5001: Redownload dependencies if toolchain ID changes .. Patch Set 1: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-4983: Set toolchain version to include LZ4 build flags

2017-02-27 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4983: Set toolchain version to include LZ4 build flags .. Patch Set 1: This does raise an interesting limitation of how we version the toolchain

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-09-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 1: (28 comments) Ok, here's a bit to get started. Just made my way through most of

[Impala-ASF-CR] IMPALA-3718: Support subset of functional-query for Kudu

2016-09-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3718: Support subset of functional-query for Kudu .. Patch Set 4: Code-Review+2 Fixed the commit msg, carrying the +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4111: backend death tests should not produce minidumps

2016-09-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4111: backend death tests should not produce minidumps .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads

2016-09-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Patch Set 3: (5 comments)

[Impala-ASF-CR] Bump Kudu version to 1.0-RC1 and add support for new OSes

2016-09-15 Thread Matthew Jacobs (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4420 to look at the new patch set (#2). Change subject: Bump Kudu version to 1.0-RC1 and add support for new OSes

[Impala-ASF-CR] IMPALA-4111: backend death tests should not produce minidumps

2016-09-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4111: backend death tests should not produce minidumps .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4353 To

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4516/3/be/src/rpc/rpc-trace.cc File

[Impala-ASF-CR] IMPALA-3504: UDF for current timestamp in UTC

2016-09-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3504: UDF for current timestamp in UTC .. Patch Set 7: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4490/7/be/src/exprs/expr-test.cc

[Impala-ASF-CR] IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend

2016-09-24 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend .. Patch Set 13: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4213: Fix Kudu predicates that need constant folding

2016-10-05 Thread Matthew Jacobs (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4613 to look at the new patch set (#4). Change subject: IMPALA-4213: Fix Kudu predicates that need constant folding ..

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 3: (14 comments) next batch... I'm probably about 1/2 way through.

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 3: (11 comments) Not even close to done but want to start giving you feedback in

[Impala-ASF-CR] IMPALA-4213: Fix Kudu predicates that need constant folding

2016-10-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4213: Fix Kudu predicates that need constant folding .. Patch Set 4: Code-Review+2 Carrying Alex's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node

2016-10-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node .. Patch Set 1: (1 comment) Thanks Dan, 1 more below...

[Impala-ASF-CR] IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node

2016-10-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node .. Patch Set 1: Thanks, Dan. In that case: Anuj, it looks like we

[Impala-ASF-CR] IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend

2016-10-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend .. Patch Set 18: (2 comments)

  1   2   3   4   5   6   7   8   9   10   >