[Impala-ASF-CR] IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node

2016-10-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4639

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/4327/6/testdata/datasets/tpcds/tpcds_kudu_template.sql

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4327/6/testdata/datasets/tpcds/tpcds_kudu_template.sql

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. IMPALA-4134,IMPALA-3704: Kudu INSERT improvements 1.) IMPALA-4134: Use Kudu AUTO FLUSH Improves performance o

[Impala-ASF-CR] IMPALA-3718: Add test cancellation tests for Kudu

2016-10-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-3718: Add test_cancellation tests for Kudu .. IMPALA-3718: Add test_cancellation tests for Kudu Additional functional tests for Kudu. Change-Id: Icf3d3853

[Impala-ASF-CR] IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node

2016-10-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node .. Patch Set 4: Code-Review+2 Thanks for fixing that. Can you just su

[Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads

2016-10-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/4371/9/be/src/util/runtime-profile-coun

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#3). Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. IMPALA-4134,IMPALA-3704: Kudu INSERT improvements 1.) IMPALA-4134: Use Kudu AUTO FLUSH Improves performance o

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4728/2/be/src/exec/kudu-table-sink.cc File b

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4327 To unsubscribe, visit http://gerr

[Impala-ASF-CR] IMPALA-1169: Admission control info on the debug webpage

2016-10-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the debug webpage .. Patch Set 1: (7 comments) Nice! This will be useful to a lot of people. http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-4301: Fix IGNORE NULLS with subquery rewriting.

2016-10-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4301: Fix IGNORE NULLS with subquery rewriting. .. Patch Set 4: (2 comments) I think this makes sense. I mention an alternative inline, I'm OK either wa

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/4728/2/be/src/exec/kudu-table-sink.cc File b

[Impala-ASF-CR] IMPALA-4301: Fix IGNORE NULLS with subquery rewriting.

2016-10-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4301: Fix IGNORE NULLS with subquery rewriting. .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4732 To unsubscribe, vis

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4728/2/be/src/exec/kudu-table-sink.cc File be

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#4). Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. IMPALA-4134,IMPALA-3704: Kudu INSERT improvements 1.) IMPALA-4134: Use Kudu AUTO FLUSH Improves performance o

[Impala-ASF-CR] IMPALA-4120: Incorrect results with LEAD() analytic function

2016-10-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4120: Incorrect results with LEAD() analytic function .. Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/4740/2/be/src/exec/analytic-eval-

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4728/4/be/src/exec/kudu-table-sink.cc File be

[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping

2016-10-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4771 To unsubscribe,

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 2: (9 comments) As we discussed in person, we should call out how this should beh

[Impala-ASF-CR] IMPALA-4120: Incorrect results with LEAD() analytic function

2016-10-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4120: Incorrect results with LEAD() analytic function .. Patch Set 3: Code-Review+1 (1 comment) Thanks! It'll be good to run this through the query gene

[Impala-ASF-CR] IMPALA-3788: Support for Kudu 'read-your-writes' consistency

2016-10-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/4779 Change subject: IMPALA-3788: Support for Kudu 'read-your-writes' consistency .. IMPALA-3788: Support for Kudu 'read-your-writes' consist

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-20 Thread Matthew Jacobs (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4728 to look at the new patch set (#5). Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. IMPALA-4134,IM

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 5: Code-Review+1 Made the change Alex suggested and rebased. Carrying Alex's +1 -- To view, vis

[Impala-ASF-CR] IMPALA-3718: Add test cancellation tests for Kudu

2016-10-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3718: Add test_cancellation tests for Kudu .. Patch Set 3: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/4700 To unsubscribe,

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-21 Thread Matthew Jacobs (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4728 to look at the new patch set (#6). Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. IMPALA-4134,IM

[Impala-ASF-CR] IMPALA-3788: Support for Kudu 'read-your-writes' consistency

2016-10-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-3788: Support for Kudu 'read-your-writes' consistency .. IMPALA-3788: Support for Kudu 'read-your-writes' consistency Kudu provides an API to get/set a 'la

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 3: (9 comments) even w/o the new section, how does compute stats behave? http://

[Impala-ASF-CR] IMPALA-4335: Don't send 0-row batches to sink

2016-10-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4335: Don't send 0-row batches to sink .. Patch Set 1: Code-Review+1 (1 comment) Thanks. Not sure why it doesn't repro for you, Michael Brown repro'd th

[Impala-ASF-CR] IMPALA-4335: Don't send 0-row batches to sink

2016-10-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4335: Don't send 0-row batches to sink .. Patch Set 2: Code-Review+2 Thanks. I verified it fixed case w/ the KuduScanNode. -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-24 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 6: (8 comments) http://gerrit.cloudera.org:8080/#/c/4728/6/be/src/exec/kudu-table-sink.cc File b

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-24 Thread Matthew Jacobs (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4728 to look at the new patch set (#7). Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. IMPALA-4134,IM

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-24 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#7). Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. IMPALA-4134,IMPALA-3704: Kudu INSERT improvements 1.) IMPALA-4134: Use Kudu AUTO FLUSH Improves performance o

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-24 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4728/6/be/src/exec/kudu-table-sink.cc File be

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-24 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4728/6/be/src/exec/kudu-table-sink.cc File be

[Impala-ASF-CR] IMPALA-3788: Support for Kudu 'read-your-writes' consistency

2016-10-24 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#3). Change subject: IMPALA-3788: Support for Kudu 'read-your-writes' consistency .. IMPALA-3788: Support for Kudu 'read-your-writes' consistency Kudu provides an API to get/set a 'la

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-24 Thread Matthew Jacobs (Code Review)
Hello Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4728 to look at the new patch set (#8). Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. IMP

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-24 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 8: Code-Review+2 (1 comment) rebased and addressed dan's comment. carrying his +2. http://gerri

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-24 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 4: (3 comments) Thanks, almost there. You should be able to test the AC tests wel

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-24 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 4: Also I had a previous question about how COMPUTE STATS behaves. -- To view, v

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 5: Thanks! Do the exhaustive AC tests pass? -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4756/5/be/src/service/impala-s

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4756 To unsubs

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4047 To unsubscribe, visit http://ge

[Impala-ASF-CR] IMPALA-3788: Support for Kudu 'read-your-writes' consistency

2016-10-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3788: Support for Kudu 'read-your-writes' consistency .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/4779/3/be/src/service/impala-serv

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-10-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/4849 Change subject: IMPALA-3771: Expose kudu client timeout and set default .. IMPALA-3771: Expose kudu client timeout and set default The

[Impala-ASF-CR] IMPALA-3788: Support for Kudu 'read-your-writes' consistency

2016-10-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#4). Change subject: IMPALA-3788: Support for Kudu 'read-your-writes' consistency .. IMPALA-3788: Support for Kudu 'read-your-writes' consistency Kudu provides an API to get/set a 'la

[Impala-ASF-CR] IMPALA-3788: Support for Kudu 'read-your-writes' consistency

2016-10-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3788: Support for Kudu 'read-your-writes' consistency .. Patch Set 5: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/4779 To un

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/4047/14/fe/src/main/java/org/apache/impala/analysis/

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/4047/15/fe/src/main/java/org/apache/impala/analysis/

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/4047/15/fe/src/main/java/org/apache/impala/analysis/

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 16: Code-Review+2 Thanks! -- To view, visit http://gerrit.cloudera.org:8080/4047 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-10-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-3771: Expose kudu client timeout and set default .. IMPALA-3771: Expose kudu client timeout and set default The Kudu client timeout was too low for Impala

[Impala-ASF-CR] IMPALA-4379: Throw if Kudu table created with var/char

2016-10-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/4857 Change subject: IMPALA-4379: Throw if Kudu table created with var/char .. IMPALA-4379: Throw if Kudu table created with var/char Creati

[Impala-ASF-CR] IMPALA-4379: Throw if Kudu table created with var/char

2016-10-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4379: Throw if Kudu table created with var/char .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4857/1//COMMIT_MSG Commit Message: PS1

[Impala-ASF-CR] IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test

2016-10-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test .. Patch Set 1: Code-Review+2 (1 comment) Looks good. Can we remove the kudu_mast

[Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads

2016-10-27 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Patch Set 10: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4371 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test

2016-10-27 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4860/1/testdata/d

[Impala-ASF-CR] IMPALA-4379: Throw if Kudu table created with var/char

2016-10-27 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4379: Throw if Kudu table created with var/char .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4857/1//COMMIT_MSG Commit Message: PS1,

[Impala-ASF-CR] IMPALA-4379: Fix and test Kudu table type checking

2016-10-27 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-4379: Fix and test Kudu table type checking .. IMPALA-4379: Fix and test Kudu table type checking Creating Kudu tables shouldn't allow types not supported

[Impala-ASF-CR] IMPALA-4384: NPE when cols list has trailing comma

2016-10-27 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/4869 Change subject: IMPALA-4384: NPE when cols list has trailing comma .. IMPALA-4384: NPE when cols list has trailing comma The changes to

[Impala-ASF-CR] IMPALA-3346: DeepCopy() Kudu rows into Impala tuples.

2016-10-27 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3346: DeepCopy() Kudu rows into Impala tuples. .. Patch Set 1: nice! As we discussed - do you wanna remove the varchar handling? Even though my change

[Impala-ASF-CR] IMPALA-4379: Fix and test Kudu table type checking

2016-10-27 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4379: Fix and test Kudu table type checking .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4857/2/fe/src/main/java/org/apache/impala/s

[Impala-ASF-CR] IMPALA-3346: DeepCopy() Kudu rows into Impala tuples.

2016-10-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3346: DeepCopy() Kudu rows into Impala tuples. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4862/3//COMMIT_MSG Commit Message: Line

[Impala-ASF-CR] IMPALA-4379: Fix and test Kudu table type checking

2016-10-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4379: Fix and test Kudu table type checking .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4857/2/testdata/workloads/functional-query/q

[Impala-ASF-CR] IMPALA-3346: DeepCopy() Kudu rows into Impala tuples.

2016-10-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3346: DeepCopy() Kudu rows into Impala tuples. .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4862/4/be/src/exec/kudu-sca

[Impala-ASF-CR] IMPALA-4377: Add detailed error log when a UdfExecutorTest fails.

2016-10-29 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4377: Add detailed error log when a UdfExecutorTest fails. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4881 To unsu

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-10-29 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 2: (1 comment) Not a real review yet, I just thought of this in another context and wanted

[Impala-ASF-CR] IMPALA-4377: Fix Java UDF-arg buffer use-after-free in UdfExecutorTest.

2016-10-29 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4377: Fix Java UDF-arg buffer use-after-free in UdfExecutorTest. .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4881/2/f

[Impala-ASF-CR] IMPALA-4379: Fix and test Kudu table type checking, follow up

2016-10-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/4894 Change subject: IMPALA-4379: Fix and test Kudu table type checking, follow up .. IMPALA-4379: Fix and test Kudu table type checking, fol

[Impala-ASF-CR] IMPALA-4411: Kudu inserts violate lock ordering and could deadlock

2016-10-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/4895 Change subject: IMPALA-4411: Kudu inserts violate lock ordering and could deadlock .. IMPALA-4411: Kudu inserts violate lock ordering a

[Impala-ASF-CR] IMPALA-4409: respect lock order in QueryExecState::CancelInternal()

2016-10-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4409: respect lock order in QueryExecState::CancelInternal() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4896/1/be/src/service/quer

[Impala-ASF-CR] IMPALA-4411: Kudu inserts violate lock ordering and could deadlock

2016-10-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4411: Kudu inserts violate lock ordering and could deadlock .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4895/1/be/src/service/query

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-10-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/4849/2/be/src/exec/kudu-table-sink.cc

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-10-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#3). Change subject: IMPALA-3771: Expose kudu client timeout and set default .. IMPALA-3771: Expose kudu client timeout and set default The Kudu client timeout was too low for Impala

[Impala-ASF-CR] IMPALA-4409: respect lock order in QueryExecState::CancelInternal()

2016-11-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4409: respect lock order in QueryExecState::CancelInternal() .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4896 To un

[Impala-ASF-CR] IMPALA-4411: Kudu inserts violate lock ordering and could deadlock

2016-11-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4411: Kudu inserts violate lock ordering and could deadlock .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4895/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4411: Kudu inserts violate lock ordering and could deadlock

2016-11-01 Thread Matthew Jacobs (Code Review)
Hello Henry Robinson, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4895 to look at the new patch set (#2). Change subject: IMPALA-4411: Kudu inserts violate lock ordering and could deadlock .

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#4). Change subject: IMPALA-3771: Expose kudu client timeout and set default .. IMPALA-3771: Expose kudu client timeout and set default The Kudu client timeout was too low for Impala

[Impala-ASF-CR] IMPALA-4411: Kudu inserts violate lock ordering and could deadlock

2016-11-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4411: Kudu inserts violate lock ordering and could deadlock .. Patch Set 2: Code-Review+2 carrying +2 -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-3710: Kudu DML should ignore conflicts by default

2016-11-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/4911 Change subject: IMPALA-3710: Kudu DML should ignore conflicts by default .. IMPALA-3710: Kudu DML should ignore conflicts by default Re

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4873/2/tests/comparis

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 3: (5 comments) nice! http://gerrit.cloudera.org:8080/#/c/4856/3/fe/src/test/java/org/apa

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4856/3/fe/src/test/java/org/apache/impa

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4856/3/fe/src/test/java/org/apache/impa

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4873/2/tests/compariso

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4873 T

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/4856/3/testdata/workloads/functional-q

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4849/4/be/src/exec/kudu-util.cc File b

[Impala-ASF-CR] IMPALA-4411: Kudu inserts violate lock ordering and could deadlock

2016-11-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4411: Kudu inserts violate lock ordering and could deadlock .. Patch Set 3: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/489

[Impala-ASF-CR] IMPALA-4384: NPE when cols list has trailing comma

2016-11-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4384: NPE when cols list has trailing comma .. Patch Set 2: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/4869 To unsubscribe,

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4936/1/tests/comparison/leopard/controll

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4936 To unsubscribe, visi

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-11-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 16: (2 comments) The build is unblocked so you can try to get this in, but I think you'll have to rebas

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-11-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/4047/16/fe/src/test/java/org/apache/impala/analysis/

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 4: I made the changes to address Lars' comments but I'll update the review after I get ano

[Impala-ASF-CR] IMPALA-3710: Kudu DML should ignore conflicts by default

2016-11-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3710: Kudu DML should ignore conflicts by default .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4911/1/be/src/exec/kudu-table-sink.h

[Impala-ASF-CR] IMPALA-3710: Kudu DML should ignore conflicts by default

2016-11-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-3710: Kudu DML should ignore conflicts by default .. IMPALA-3710: Kudu DML should ignore conflicts by default Removes the non-standard IGNORE syntax that w

[Impala-ASF-CR] IMPALA-3710: Kudu DML should ignore conflicts by default

2016-11-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3710: Kudu DML should ignore conflicts by default .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4911/2/fe/src/main/cup/sql-parser.cup

[Impala-ASF-CR] IMPALA-4379: Fix and test Kudu table type checking, follow up

2016-11-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4379: Fix and test Kudu table type checking, follow up .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4894/1/fe/src/main/java/org/apac

<    1   2   3   4   5   6   7   8   9   10   >