Hello Greg Rahn,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7916
to look at the new patch set (#7).
Change subject: IMPALA-3437: DECIMAL_V2: avoid implicit decimal->double
conversion
Hello Michael Ho, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7408
to look at the new patch set (#9).
Change subject: IMPALA-5417: make I/O buffer queue fixed-size
..
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5417: make I/O buffer queue fixed-size
..
Patch Set 9: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/7408
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: Bump LLVM to 3.9.1 and CMake to 3.8.2
..
Patch Set 1:
I will wait until both the Impala and toolchain changes are +2ed before
rebasing and merging together.
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8075
Change subject: Bump LLVM to 3.9.1 and CMake to 3.8.2
..
Bump LLVM to 3.9.1 and CMake to 3.8.2
LLVM required a newer CMake version than
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication
..
Patch Set 5:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5417: make I/O buffer queue fixed-size
..
Patch Set 7:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7408/7/be/src/runtime/disk-io-mgr-scan-range.cc
Hello Michael Ho, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7408
to look at the new patch set (#8).
Change subject: IMPALA-5417: make I/O buffer queue fixed-size
..
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4513: Promote integer types for ABS()
..
Patch Set 5:
Ping?
--
To view, visit http://gerrit.cloudera.org:8080/8004
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5908: Allow SET to unset modified query options.
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8070/1/be/src/service/query-options.cc
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5908: Allow SET to unset modified query options.
..
Patch Set 1:
(4 comments)
Makes sense to me. Had some minor comments but I'd also like someone else
Tim Armstrong has submitted this change and it was merged.
Change subject: IMPALA-5905: build-all-flag-combinations addendum
..
IMPALA-5905: build-all-flag-combinations addendum
Running the script under Jenkins revealed a
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5905: build-all-flag-combinations addendum
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8061
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5926 : Avoid printing expensive stack when closing a
session
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8060
To
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8061
Change subject: IMPALA-5905: build-all-flag-combinations addendum
..
IMPALA-5905: build-all-flag-combinations addendum
Running the
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3360: Codegen inserting into runtime filters
..
Patch Set 1:
(4 comments)
Nice to see this getting fixed.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
..
Patch Set 3: Code-Review+1
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5844: use a MemPool for expr local allocations
..
Patch Set 6:
(2 comments)
Tim Armstrong has uploaded a new patch set (#6).
Change subject: IMPALA-5844: use a MemPool for expr local allocations
..
IMPALA-5844: use a MemPool for expr local allocations
Local allocations in expressions have the following
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3437: DECIMAL_V2: avoid implicit decimal->double
conversion
..
Patch Set 6:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3437: DECIMAL_V2: avoid implicit decimal->double
conversion
..
Patch Set 5:
(10 comments)
Hello Greg Rahn,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7916
to look at the new patch set (#6).
Change subject: IMPALA-3437: DECIMAL_V2: avoid implicit decimal->double
conversion
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5905: add script for all-build-options job
..
Patch Set 3: Code-Review+2 Verified+1
Carry +2. Verified manually by running locally (no point in running
Tim Armstrong has submitted this change and it was merged.
Change subject: IMPALA-5905: add script for all-build-options job
..
IMPALA-5905: add script for all-build-options job
This checks in a modified version of the job
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5905: add script for all-build-options job
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8043/1/bin/all-build-options.sh
File
Hello Jim Apple,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8043
to look at the new patch set (#3).
Change subject: IMPALA-5905: add script for all-build-options job
..
IMPALA-5905:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
Patch Set 11: Code-Review+1
The stricter invariant makes sense to me.
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
..
Patch Set 2:
(3 comments)
It's a bit unfortunate that we have to pull in this much code to
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
Patch Set 10:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8011/10/be/src/exec/scanner-context.cc
Tim Armstrong has uploaded a new patch set (#2).
Change subject: IMPALA-5905: add script for all-build-options job
..
IMPALA-5905: add script for all-build-options job
This checks in a modified version of the job script for
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5905: add script for all-build-options job
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8043/1/bin/all-build-options.sh
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3437: DECIMAL_V2: avoid implicit decimal->double
conversion
..
Patch Set 5:
Updated with some additional tests to get more exhaustive coverage of the
Hello Greg Rahn,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7916
to look at the new patch set (#5).
Change subject: IMPALA-3437: DECIMAL_V2: avoid implicit decimal->double
conversion
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8043
Change subject: IMPALA-5905: add script for all-build-options job
..
IMPALA-5905: add script for all-build-options job
This checks in a
Tim Armstrong has uploaded a new patch set (#2).
Change subject: IMPALA-5860: upgrade to LLVM 3.9.1
..
IMPALA-5860: upgrade to LLVM 3.9.1
LLVM made a few API changes:
* Misc minor changes to function and type signatures
* The
Tim Armstrong has uploaded a new patch set (#2).
Change subject: IMPALA-3877: support unpatched LLVM
..
IMPALA-3877: support unpatched LLVM
The p1 patch we use for LLVM avoided merging of structurally
identical Struct types in
Tim Armstrong has posted comments on this change.
Change subject: [DOCS] Explain Boost setting needed for 96-bit timestamps
..
Patch Set 2: Code-Review-1
I think that the documented solution is not the correct solution to the
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
Patch Set 9: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/8011
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
Patch Set 8:
(2 comments)
Tim Armstrong has uploaded a new patch set (#4).
Change subject: PREVIEW: IMPALA-3437: DECIMAL_V2: avoid implicit
decimal->double conversion
..
PREVIEW: IMPALA-3437: DECIMAL_V2: avoid implicit decimal->double conversion
This
Tim Armstrong has uploaded a new patch set (#3).
Change subject: PREVIEW: IMPALA-3437: DECIMAL_V2: avoid implicit
decimal->double conversion
..
PREVIEW: IMPALA-3437: DECIMAL_V2: avoid implicit decimal->double conversion
This
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5912: fix crash in trunc(..., "WW") in release build
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8015/1//COMMIT_MSG
Commit Message:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3642: Adding backend addresses to error statuses for
some scratch failures.
..
Patch Set 3: Code-Review+2
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3642: Adding backend addresses to error statuses for
some scratch failures.
..
Patch Set 2: Code-Review+2
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3897 Codegen null-aware constant in
PHJ::ProcessBuildBatch()
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7849
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
Patch Set 6:
(5 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication
..
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7438/4//COMMIT_MSG
Commit Message:
Line
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5199: prevent hang on empty row batch exchange
..
Patch Set 2:
Yeah I think there are some fundamental problems with the current parallel
startup logic
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4856: Port data stream service to KRPC
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8023/1/be/src/runtime/krpc-data-stream-mgr.h
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5912: fix crash in trunc(..., "WW") in release build
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8015/1//COMMIT_MSG
Commit Message:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
Patch Set 5:
Yeah we could probably add an error code like DISK_IO_MGR_ERROR and use it for
the
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8011/5/be/src/exec/scanner-context.cc
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5890: Abort queries if scanner hits IO errors
..
Patch Set 4:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/8011/3//COMMIT_MSG
Commit Message:
Line
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4513: Promote integer types for ABS()
..
Patch Set 5:
test_exprs failed:
22:20:21 ] TestExprs.test_exprs[exec_option: {'batch_size': 0, 'num_nodes':
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8015
Change subject: IMPALA-5912: fix crash in trunc(..., "WW") in release build
..
IMPALA-5912: fix crash in trunc(..., "WW") in release
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4513: Promote integer types for ABS()
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8004
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4513: Promote integer types for ABS()
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8004
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4513: Promote integer types for ABS()
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8004/3/be/src/exprs/expr-test.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5199: prevent hang on empty row batch exchange
..
Patch Set 2:
The query is definitely cancellable but I'm not sure how a user would
necessarily know
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4513: Promote integer types for ABS()
..
Patch Set 3:
(2 comments)
Looks good to me modulo a couple of minor tweaks.
The same bug can't apply to
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5199: prevent hang on empty row batch exchange
..
Patch Set 2:
I think there is a fundamental problem with the "closed streams cache"
mechanism and
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5199: prevent hang on empty row batch exchange
..
Patch Set 2:
That seems pretty rare but possible.
In the common case where the limit is at the top
Tim Armstrong has uploaded a new patch set (#2).
Change subject: IMPALA-5199: prevent hang on empty row batch exchange
..
IMPALA-5199: prevent hang on empty row batch exchange
The error path where delivery of "eos" fails now
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8005
Change subject: IMPALA-5199: prevent hang on empty row batch exchange
..
IMPALA-5199: prevent hang on empty row batch exchange
The
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5867: Fix bugs parsing 2-digit year
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7910
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5867: Fix bugs parsing 2-digit year
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7910
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5317: add DATE_TRUNC() function
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7313
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5317: add DATE_TRUNC() function
..
Patch Set 3: Code-Review+2
I was able to look at this with fresh eyes. Looks good, I will start the merge.
--
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5902: add ThreadSanitizer build
..
Patch Set 3: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/7977
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5902: add ThreadSanitizer build
..
Patch Set 1:
Filed IMPALA-5905
--
To view, visit http://gerrit.cloudera.org:8080/7977
To unsubscribe, visit
Tim Armstrong has uploaded a new patch set (#2).
Change subject: IMPALA-5902: add ThreadSanitizer build
..
IMPALA-5902: add ThreadSanitizer build
This is sufficient to get Impala to come up and run queries with
thread sanitizer
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5902: add ThreadSanitizer build
..
Patch Set 1:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/7977/1/be/src/common/init.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5888: free other local allocations in Parquet
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7933
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5888: free other local allocations in Parquet
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7933/2/be/src/exec/hdfs-parquet-scanner.cc
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7977
Change subject: IMPALA-5902: add ThreadSanitizer build
..
IMPALA-5902: add ThreadSanitizer build
This is sufficient to get Impala to
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5867: Fix bugs parsing 2-digit year
..
Patch Set 3:
(1 comment)
One reason that this is a lot safer than the old code is that all of the data
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5885: free runtime filter allocations in Parquet
..
Patch Set 5: Code-Review+2
rebased
--
To view, visit http://gerrit.cloudera.org:8080/7931
To
Tim Armstrong has posted comments on this change.
Change subject: [PREVIEW] Use native allocation while building catalog updates
..
Patch Set 1:
Alex explained to me that this doesn't actually increase the peak memory usage,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5885: free runtime filter allocations in Parquet
..
Patch Set 3:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5885: free runtime filter allocations in Parquet
..
Patch Set 3:
(1 comment)
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7931
to look at the new patch set (#4).
Change subject: IMPALA-5885: free runtime filter allocations in Parquet
..
Tim Armstrong has uploaded a new patch set (#2).
Change subject: IMPALA-5891: fix PeriodicCounterUpdater initialization
..
IMPALA-5891: fix PeriodicCounterUpdater initialization
Avoid running static destructors and constructors
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5867: Fix bugs parsing 2-digit year
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7910
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: [PREVIEW] Use native allocation while building catalog updates
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7955/1/be/src/catalog/catalog.cc
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4826: Fix error during a scan on repeated root schema in
Parquet.
..
Patch Set 3:
Any more comments Lars?
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5867: Fix bugs parsing 2-digit year
..
Patch Set 1:
(2 comments)
Thanks for the explanations. I think I follow the code now. Just had a couple
of minor
Tim Armstrong has uploaded a new patch set (#2).
Change subject: IMPALA-5888: free other local allocations in Parquet
..
IMPALA-5888: free other local allocations in Parquet
Testing:
I wasn't able to produce any abnormal memory
Tim Armstrong has uploaded a new patch set (#3).
Change subject: IMPALA-5885: free runtime filter allocations in Parquet
..
IMPALA-5885: free runtime filter allocations in Parquet
This fixes the parquet scanner to free local
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5867: Fix bugs parsing 2-digit year
..
Patch Set 1:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/7910/1/be/src/runtime/timestamp-parse-util.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4826: Fix error during a scan on repeated root schema in
Parquet.
..
Patch Set 3: Code-Review+1
Thanks for running the tests and letting us know - the
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4826: Fix wrong scan result on repeated root schema in
Parquet.
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7870
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5855: reserve enough memory for preaggs
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7871
To unsubscribe, visit
Hello Impala Public Jenkins, Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7871
to look at the new patch set (#6).
Change subject: IMPALA-5855: reserve enough memory for preaggs
Tim Armstrong has abandoned this change.
Change subject: IMPALA-3877: support unpatched LLVM
..
Abandoned
Didn't mean to push
--
To view, visit http://gerrit.cloudera.org:8080/7836
To unsubscribe, visit
Tim Armstrong has uploaded a new patch set (#3).
Change subject: IMPALA-3877: support unpatched LLVM
..
IMPALA-3877: support unpatched LLVM
The p1 patch we use for LLVM avoided merging of structurally
identical Struct types in
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5855: reserve enough memory for preaggs
..
Patch Set 5: Code-Review+2
fix tests
--
To view, visit http://gerrit.cloudera.org:8080/7871
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5855: reserve enough memory for preaggs
..
Patch Set 4: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/7871
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5750: Catch exceptions from boost thread creation
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7730
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5750: Catch exceptions from boost thread creation
..
Patch Set 5: Code-Review+1
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5857: avoid invalid free of hedged read metrics
..
Patch Set 1:
(1 comment)
501 - 600 of 2851 matches
Mail list logo
