Hello Bharath Vissapragada,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4941
to look at the new patch set (#3).
Change subject: IMPALA-4266: Java udf returning string can give incorrect
results
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4266: Java udf returning string can give incorrect
results
..
Patch Set 4: Code-Review+1
Carry +1
--
To view, visit
Hello Bharath Vissapragada, Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4941
to look at the new patch set (#4).
Change subject: IMPALA-4266: Java udf returning string can give incorrect
results
Tim Armstrong has posted comments on this change.
Change subject: Add "Effective Coding Practices" doc to site
..
Patch Set 2:
I can see it being a blog post. Mainly I didn't think it fit on the wiki since
it should be a
Hello Lars Volker, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4938
to look at the new patch set (#2).
Change subject: IMPALA-4391: fix dropped statuses in scanners
..
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4391: fix dropped statuses in scanners
..
Patch Set 2: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/4938
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs
..
Patch Set 1:
(1 comment)
An additional high-level comment
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4877/4/be/src/exprs/expr-test.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting
classes.
..
Patch Set 2:
(5 comments)
The overall approach looks sane - had a few high-level
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3676,4321: Use clang as a static analysis tool
..
Patch Set 1:
(23 comments)
http://gerrit.cloudera.org:8080/#/c/4758/2/be/CMakeLists.txt
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3676,4321: Use clang as a static analysis tool
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4758/1/be/src/util/aligned-new.h
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4269: Codegen merging exchange node
..
Patch Set 1: Code-Review+2
Change is a straightforward application of an existing pattern and I'm
confident we
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3676,4321: Use clang as a static analysis tool
..
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4758/2/be/CMakeLists.txt
File
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4698
Change subject: IMPALA-4277: bump Hadoop component versions except for Hadoop
itself
..
IMPALA-4277: bump Hadoop component versions
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3943: Address post-merge comments.
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4696
To unsubscribe, visit
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4701
Change subject: IMPALA-4277: temporary hack to avoid compile errors for HDFS
block location API
..
IMPALA-4277: temporary hack to avoid
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4259: build Impala without any test cluster setup.
..
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4685/5/buildall.sh
File buildall.sh:
Hello David Knupp,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4685
to look at the new patch set (#6).
Change subject: IMPALA-4259: build Impala without any test cluster setup.
..
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()
..
Patch Set 3:
(8 comments)
Looking good, just some small things then I'll +1.
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4771
Change subject: IMPALA-3211: provide toolchain build id for bootstrapping
..
IMPALA-3211: provide toolchain build id for bootstrapping
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4768
Change subject: IMPALA-4241: remove spurious child queries event
..
IMPALA-4241: remove spurious child queries event
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4770
Change subject: IMPALA-3872: allow providing PyPi mirror for python packages
..
IMPALA-3872: allow providing PyPi mirror for python
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3211: provide toolchain build id for bootstrapping
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4771/1/bin/bootstrap_toolchain.py
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4300: Speed up BloomFilter::Or with SIMD
..
Patch Set 1:
(4 comments)
LGTM, just want to make sure the comment is a little clearer.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3884: Support TYPE_TIMESTAMP for
HashTableCtx::CodegenAssignNullValue()
..
Patch Set 2: Code-Review+2
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4300: Speed up BloomFilter::Or with SIMD
..
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4813/3//COMMIT_MSG
Commit
Tim Armstrong has posted comments on this change.
Change subject: Add distcc infrastructure.
..
Patch Set 1:
(6 comments)
Thanks for doing this
http://gerrit.cloudera.org:8080/#/c/4820/1/bin/distcc/distcc.sh
File
Tim Armstrong has posted comments on this change.
Change subject: Impala-3342: Adding thread counters to measure time spent
during plan fragment execution
..
Patch Set 5:
(2 comments)
Tim Armstrong has abandoned this change.
Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as
a table
..
Abandoned
I need to make time to polish this up and put out a version for review.
--
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3.
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4582
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: Remove Llama dependency
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4739/1/common/thrift/metrics.json
File common/thrift/metrics.json:
Hello Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4698
to look at the new patch set (#3).
Change subject: IMPALA-4277: bump Hadoop component versions except for Hadoop
itself
Tim Armstrong has submitted this change and it was merged.
Change subject: IMPALA-4277: bump Hadoop component versions except for Hadoop
itself
..
IMPALA-4277: bump Hadoop component versions except for Hadoop itself
The Hive
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4277: bump Hadoop component versions except for Hadoop
itself
..
Patch Set 3: Code-Review+2 Verified+1
Rebase. Confirmed that it compiles, but can't run
Tim Armstrong has submitted this change and it was merged.
Change subject: IMPALA-4277: temporary hack to avoid compile errors for HDFS
block location API
..
IMPALA-4277: temporary hack to avoid compile errors for HDFS block
Hello Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4701
to look at the new patch set (#2).
Change subject: IMPALA-4277: temporary hack to avoid compile errors for HDFS
block location API
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4277: allow overriding of Hive/Hadoop versions/locations
..
Patch Set 2:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/4720/2/bin/impala-config.sh
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4277: temporary hack to avoid compile errors for HDFS
block location API
..
Patch Set 1:
(1 comment)
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4748
Change subject: IMPALA-4277: don't use deprecated s3:// filesystem
..
IMPALA-4277: don't use deprecated s3:// filesystem
Support was
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4830
Change subject: IMPALA-4350: Crash with vlog level 2 in hash join node
..
IMPALA-4350: Crash with vlog level 2 in hash join node
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3211: provide toolchain build id for bootstrapping
..
Patch Set 4: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/4771
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4223: Handle truncated file read from HDFS cache
..
Patch Set 1:
(1 comment)
The change makes sense and we should get it in regardless, but could this
Tim Armstrong has posted comments on this change.
Change subject: Removed dead join inversion code from Analyzer.
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4827
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions
..
Patch Set 7:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: Remove seemingly incorrect DCHECK-s.
..
Patch Set 1:
(1 comment)
I agree that this looks like a bug.
http://gerrit.cloudera.org:8080/#/c/4835/1//COMMIT_MSG
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4350: Crash with vlog level 2 in hash join node
..
Patch Set 2: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/4830
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions
..
Patch Set 4:
(13 comments)
Tim Armstrong has uploaded a new patch set (#6).
Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions
..
IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions
This change enables codegen
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions
..
Patch Set 6:
Rebased onto the codegen interface changes.
--
To view, visit
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4785
Change subject: IMPALA-4339: ensure coredumps end up in IMPALA_HOME
..
IMPALA-4339: ensure coredumps end up in IMPALA_HOME
Change-Id:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4023: don't attach buffered tuple streams to batches
..
Patch Set 8:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4448/8//COMMIT_MSG
Commit Message:
Hello Internal Jenkins, Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4448
to look at the new patch set (#9).
Change subject: IMPALA-4023: don't attach buffered tuple streams to batches
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4241: remove spurious child queries event
..
Patch Set 2: Code-Review+2
carry +2
--
To view, visit http://gerrit.cloudera.org:8080/4768
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3884: Support TYPE_TIMESTAMP for
HashTableCtx::CodegenAssignNullValue()
..
Patch Set 1:
(6 comments)
Tim Armstrong has posted comments on this change.
Change subject: Add distcc infrastructure.
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4820
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: Add distcc infrastructure.
..
Patch Set 2:
Would be good to send out an email to dev@ once this goes in
--
To view, visit http://gerrit.cloudera.org:8080/4820
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions
..
Patch Set 6:
(7 comments)
Tim Armstrong has uploaded a new patch set (#7).
Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions
..
IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions
This change enables codegen
Tim Armstrong has uploaded a new patch set (#7).
Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions
..
IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions
This change enables codegen
Tim Armstrong has posted comments on this change.
Change subject: Add all build targets to CMake and speed up builds
..
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4790/1/bin/make_impala.sh
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3211: provide toolchain build id for bootstrapping
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4771/2/bin/impala-config.sh
File
Tim Armstrong has uploaded a new patch set (#3).
Change subject: IMPALA-3211: provide toolchain build id for bootstrapping
..
IMPALA-3211: provide toolchain build id for bootstrapping
Testing:
Ran a private build, which
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4339: ensure coredumps end up in IMPALA_HOME
..
Patch Set 2: Code-Review+2
Rebase, carry +2
--
To view, visit http://gerrit.cloudera.org:8080/4785
To
Tim Armstrong has uploaded a new patch set (#2).
Change subject: Add all build targets to CMake and speed up builds
..
Add all build targets to CMake and speed up builds
Use CMake's dependency resolution always instead of
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4778
Change subject: IMPALA-4277: remove references for unsupported s3/s3n connectors
..
IMPALA-4277: remove references for unsupported
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4277: remove references for unsupported s3/s3n connectors
..
Patch Set 1:
(1 comment)
Carry +1
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3342: Add thread counters to monitor plan fragment
execution
..
Patch Set 6:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4633/6//COMMIT_MSG
Commit
Tim Armstrong has posted comments on this change.
Change subject: Remove Llama dependency
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4739
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: Remove Llama dependency
..
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4739/2/common/thrift/ImpalaInternalService.thrift
File
Tim Armstrong has uploaded a new patch set (#3).
Change subject: IMPALA-4277: allow overriding of Hive/Hadoop versions/locations
..
IMPALA-4277: allow overriding of Hive/Hadoop versions/locations
This is to help with
Hello Jim Apple,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4494
to look at the new patch set (#14).
Change subject: IMPALA-4123: Fast bit unpacking
..
IMPALA-4123: Fast bit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4123: Fast bit unpacking
..
Patch Set 15: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/4494
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4123: Fast bit unpacking
..
Patch Set 15:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4494/11/be/src/util/bit-packing-test.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4023: don't attach buffered tuple streams to batches
..
Patch Set 8:
Not really - flush_resources without need_to_return implies 2a, whereas
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4023: don't attach buffered tuple streams to batches
..
Patch Set 8:
Another way of looking at it is that ignoring flush_resources is a resource
Tim Armstrong has submitted this change and it was merged.
Change subject: IMPALA-4277: remove references for unsupported s3/s3n connectors
..
IMPALA-4277: remove references for unsupported s3/s3n connectors
We only support
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4277: remove references for unsupported s3/s3n connectors
..
Patch Set 2: Code-Review+2 Verified+1
--
To view, visit
Hello Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4748
to look at the new patch set (#2).
Change subject: IMPALA-4277: remove references for unsupported s3/s3n connectors
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4277: remove references for unsupported s3/s3n connectors
..
Patch Set 1:
(2 comments)
Tim Armstrong has uploaded a new patch set (#2).
Change subject: IMPALA-3420: use gold by default
..
IMPALA-3420: use gold by default
Also pass the flag that enables ld.gold directly to the
compiler. This is understood by both
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3342: Add thread counters to monitor plan fragment
execution
..
Patch Set 6:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4633/6//COMMIT_MSG
Commit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3.
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4582
To unsubscribe, visit
Hello Michael Ho, Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5211
to look at the new patch set (#2).
Change subject: IMPALA-4525: fix crash when codegen mem limit exceeded
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4535: Remove 'auto' from parameter list
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5214
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4525: fix crash when codegen mem limit exceeded
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5211/2/be/src/service/fe-support.cc
File
Tim Armstrong has uploaded a new patch set (#2).
Change subject: IMPALA-1430: enable codegen for native UDAs
..
IMPALA-1430: enable codegen for native UDAs
This uses the existing infrastructure for codegening builtin UDAs and
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu
14.04.
..
Patch Set 2:
(2 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 19: Code-Review+2
Carry the +2
--
To view, visit http://gerrit.cloudera.org:8080/4863
To
Tim Armstrong has uploaded a new patch set (#3).
Change subject: IMPALA-1430: enable codegen for native UDAs
..
IMPALA-1430: enable codegen for native UDAs
This uses the existing infrastructure for codegening builtin UDAs and
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5161
Change subject: IMPALA-1430: enable codegen for native UDAs
..
IMPALA-1430: enable codegen for native UDAs
This uses the existing
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5165
Change subject: IMPALA-3200: move bufferpool under runtime
..
IMPALA-3200: move bufferpool under runtime
It is arguably a subcomponent
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3200: Implement suballocator for splitting buffers
..
Patch Set 5:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4478: Initial Kudu client mem tracking for sink
..
Patch Set 1: Code-Review+1
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory
..
Patch Set 13:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4956/13/be/src/codegen/llvm-codegen.h
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4518: CopyStringVal() doesn't copy null string
..
Patch Set 1: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5198/1//COMMIT_MSG
Commit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3200: move bufferpool under runtime
..
Patch Set 3: Code-Review+2
The Cmake script didn't handle be tests living in a subdirectory - fixed it.
--
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory
..
Patch Set 11:
(9 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory
..
Patch Set 12: Code-Review+1
Carry +1
--
To view, visit http://gerrit.cloudera.org:8080/4956
To
Hello Michael Ho,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4956
to look at the new patch set (#12).
Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory
..
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory
..
Patch Set 13: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4956
To unsubscribe,
301 - 400 of 2851 matches
Mail list logo
