[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5722: Fix string to decimal cast .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7517 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5722: Fix string to decimal cast .. IMPALA-5722: Fix string to decimal cast When converting a string to a decimal, we didn't handle the

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5722: Fix string to decimal cast .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/956/ -- To view, visit

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-28 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-5722: Fix string to decimal cast .. IMPALA-5722: Fix string to decimal cast When converting a string to a decimal, we didn't handle the case where the

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-28 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5722: Fix string to decimal cast .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7517 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5722: Fix string to decimal cast .. Patch Set 2: Code-Review+1 Looks good to me. Will give Jim a chance to weigh in if he has further comments. -- To

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-28 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5722: Fix string to decimal cast .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7517/1/be/src/runtime/decimal-test.cc File

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-28 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-5722: Fix string to decimal cast .. IMPALA-5722: Fix string to decimal cast When converting a string to a decimal, we didn't handle the case where the

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5722: Fix string to decimal cast .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7517/1/be/src/util/decimal-util.h File

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5722: Fix string to decimal cast .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7517/1/be/src/util/string-parser.h File

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-27 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-5722: Fix string to decimal cast .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7517/1/be/src/util/string-parser.h File

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-27 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5722: Fix string to decimal cast .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7517/1/be/src/util/decimal-util.h File

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5722: Fix string to decimal cast .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7517/1/be/src/runtime/decimal-test.cc File

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-26 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/7517 Change subject: IMPALA-5722: Fix string to decimal cast .. IMPALA-5722: Fix string to decimal cast When converting a string to a