[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. IMPALA-4207: test infra: move Hive options from connection to cluste

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 3: Private data load is green after 6.5 hours http://sandbox.jenkins

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Ishaan Joshi (Code Review)
Ishaan Joshi has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 3: Code-Review+2 Didn't realise it was a build blocker. Regardless, t

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 3: Oh and the diff is much larger now due to having made requested cl

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 3: Code-Review+1 (2 comments) done; carry +1 Trying to fix a build

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Michael Brown (Code Review)
Hello Sahil Takiar, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4555 to look at the new patch set (#3). Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Ishaan Joshi (Code Review)
Ishaan Joshi has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4555/2/tests/compa

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4555/1/tests/

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 2: Code-Review+1 I updated the commit message to list the testing don

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Michael Brown (Code Review)
Hello Sahil Takiar, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4555 to look at the new patch set (#2). Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 1: > Just curious, what are the other modules that use cli_options? A

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 1: Code-Review+1 It looks like this job: http://sandbox.jenkins.cloude

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 1: Code-Review+1 Just curious, what are the other modules that use cli

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 1: Lots of testing to do yet. -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/4555 Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. IMPALA-4207: test infra: move Hive opti