[kudu-CR] security: generate certs on the tserver, sign them on the master

Hello Dan Burkert, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5766 to look at the new patch set (#3). Change subject: security: generate certs on the tserver, sign them on the master

[kudu-CR](gh-pages) Fix 1.2.0 release date

Todd Lipcon has submitted this change and it was merged. Change subject: Fix 1.2.0 release date .. Fix 1.2.0 release date Change-Id: I8a908078f5b37eba305088c250adc0f499fd9256 Reviewed-on: http://gerrit.cloudera.org:8080/5789

[kudu-CR](gh-pages) Fix 1.2.0 release date

Todd Lipcon has posted comments on this change. Change subject: Fix 1.2.0 release date .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5789 To unsubscribe, visit

[kudu-CR](gh-pages) Fix 1.2.0 release date

Alexey Serbin has posted comments on this change. Change subject: Fix 1.2.0 release date .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5789 To unsubscribe, visit

[kudu-CR](gh-pages) Fix 1.2.0 release date

Adar Dembo has posted comments on this change. Change subject: Fix 1.2.0 release date .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5789 To unsubscribe, visit

[kudu-CR](gh-pages) Fix 1.2.0 release date

Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5789 to review the following change. Change subject: Fix 1.2.0 release date .. Fix 1.2.0 release date

[kudu-CR] TLS-negotiation [7/n]: Add TLS helper classes for handling tunneled TLS handshakes

Dan Burkert has posted comments on this change. Change subject: TLS-negotiation [7/n]: Add TLS helper classes for handling tunneled TLS handshakes .. Patch Set 6: (11 comments)

[kudu-CR] TLS-negotiation [8/n]: TLS negotiation

Dan Burkert has posted comments on this change. Change subject: TLS-negotiation [8/n]: TLS negotiation .. Patch Set 6: (9 comments) Not ready to review just yet http://gerrit.cloudera.org:8080/#/c/5762/5//COMMIT_MSG Commit

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

Dan Burkert has posted comments on this change. Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation .. Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/5760/7/src/kudu/rpc/reactor.cc File

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5760 to look at the new patch set (#8). Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation ..

[kudu-CR] TLS-negotiation [7/n]: Add TLS helper classes for handling tunneled TLS handshakes

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5761 to look at the new patch set (#7). Change subject: TLS-negotiation [7/n]: Add TLS helper classes for handling tunneled TLS handshakes

[kudu-CR] TLS-negotiation [8/n]: TLS negotiation

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5762 to look at the new patch set (#7). Change subject: TLS-negotiation [8/n]: TLS negotiation .. TLS-negotiation

[kudu-CR] Remove some unused class members

Dan Burkert has posted comments on this change. Change subject: Remove some unused class members .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5782 To unsubscribe, visit

[kudu-CR] security: generate certs on the tserver, sign them on the master

Todd Lipcon has posted comments on this change. Change subject: security: generate certs on the tserver, sign them on the master .. Patch Set 2: (3 comments)

[kudu-CR] rpc: move connection header send/receive into negotiation.cc

Todd Lipcon has abandoned this change. Change subject: rpc: move connection header send/receive into negotiation.cc .. Abandoned Dan's patch series obviates this -- To view, visit http://gerrit.cloudera.org:8080/4959 To

[kudu-CR] Remove some unused class members

Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5782 to look at the new patch set (#2). Change subject: Remove some unused class members .. Remove some

[kudu-CR] Control mutex stack walking in DEBUG mode with a gflag

Adar Dembo has posted comments on this change. Change subject: Control mutex stack walking in DEBUG mode with a gflag .. Patch Set 2: (2 comments) OK, let's move forward with the new gflag then. Still two small things to

[kudu-CR] Add Google Breakpad support to Kudu

Adar Dembo has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 24: > I don't see any reason why the client would link these symbols. Maybe it's because of the static variable

[kudu-CR] Add Google Breakpad support to Kudu

Adar Dembo has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 24: Code-Review+2 Looks good. The test failure in client_symbol-test.sh is likely because we need to hide the

[kudu-CR] WIP [openssl util] method to extract public part of RSA key

Alexey Serbin has posted comments on this change. Change subject: WIP [openssl_util] method to extract public part of RSA key .. Patch Set 1: (2 comments)

[kudu-CR] [security] separated OpenSSL wrappers from CA

Alexey Serbin has submitted this change and it was merged. Change subject: [security] separated OpenSSL wrappers from CA .. [security] separated OpenSSL wrappers from CA Moved common wrappers around OpenSSL objects from

[kudu-CR] WIP [openssl util] method to extract public part of RSA key

Todd Lipcon has posted comments on this change. Change subject: WIP [openssl_util] method to extract public part of RSA key .. Patch Set 1: (2 comments)

[kudu-CR] WIP [openssl util] method to extract public part of RSA key

Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5783 Change subject: WIP [openssl_util] method to extract public part of RSA key .. WIP [openssl_util] method to extract public part of RSA

[kudu-CR] WIP: KUDU-1713: add a client Partitioner API

Adar Dembo has posted comments on this change. Change subject: WIP: KUDU-1713: add a client Partitioner API .. Patch Set 2: (2 comments) Just reviewing the new API...

[kudu-CR] [security] separated OpenSSL wrappers from CA

Dan Burkert has posted comments on this change. Change subject: [security] separated OpenSSL wrappers from CA .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5779 To unsubscribe, visit

[kudu-CR] [security] separated OpenSSL wrappers from CA

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5779 to look at the new patch set (#4). Change subject: [security] separated OpenSSL wrappers from CA .. [security]

[kudu-CR] [security] separated OpenSSL wrappers from CA

Alexey Serbin has posted comments on this change. Change subject: [security] separated OpenSSL wrappers from CA .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5779/3/src/kudu/security/openssl_traits.h File

[kudu-CR] [security] separated OpenSSL wrappers from CA

Dan Burkert has posted comments on this change. Change subject: [security] separated OpenSSL wrappers from CA .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5779/3/src/kudu/security/openssl_traits.h File

[kudu-CR] [security] separated OpenSSL wrappers from CA

Alexey Serbin has posted comments on this change. Change subject: [security] separated OpenSSL wrappers from CA .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5779/3/src/kudu/security/openssl_traits.h File

[kudu-CR] WIP: KUDU-1713: add a client Partitioner API

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5775 to look at the new patch set (#2). Change subject: WIP: KUDU-1713: add a client Partitioner API .. WIP: KUDU-1713:

[kudu-CR] Use C++11 constructor deletion for DISALLOW COPY AND ASSIGN

Todd Lipcon has submitted this change and it was merged. Change subject: Use C++11 constructor deletion for DISALLOW_COPY_AND_ASSIGN .. Use C++11 constructor deletion for DISALLOW_COPY_AND_ASSIGN Change-Id:

[kudu-CR] [security] separated OpenSSL wrappers from CA

Dan Burkert has posted comments on this change. Change subject: [security] separated OpenSSL wrappers from CA .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5779/3/src/kudu/security/openssl_traits.h File

[kudu-CR] Remove some unused class members

Dan Burkert has posted comments on this change. Change subject: Remove some unused class members .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5782/1/src/kudu/tools/ksck.h File

[kudu-CR] [security] separated OpenSSL wrappers from CA

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5779 to look at the new patch set (#3). Change subject: [security] separated OpenSSL wrappers from CA .. [security]

[kudu-CR] [security] separated OpenSSL wrappers from CA

Dan Burkert has posted comments on this change. Change subject: [security] separated OpenSSL wrappers from CA .. Patch Set 2: > My concern was that there is some code in TLS socket layer which would need > openssl_util.h, but

[kudu-CR] Use C++11 constructor deletion for DISALLOW COPY AND ASSIGN

Dan Burkert has posted comments on this change. Change subject: Use C++11 constructor deletion for DISALLOW_COPY_AND_ASSIGN .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5781 To unsubscribe,

[kudu-CR] Remove some unused class members

Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5782 to review the following change. Change subject: Remove some unused class members .. Remove some unused class members

[kudu-CR] Use C++11 constructor deletion for DISALLOW COPY AND ASSIGN

Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5781 to review the following change. Change subject: Use C++11 constructor deletion for DISALLOW_COPY_AND_ASSIGN .. Use

[kudu-CR] [security] separated OpenSSL wrappers from CA

Alexey Serbin has posted comments on this change. Change subject: [security] separated OpenSSL wrappers from CA .. Patch Set 2: > Did you consider putting all of this in openssl_util.h? Seems like > an appropriate place for

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

Todd Lipcon has posted comments on this change. Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation .. Patch Set 7: Code-Review+2 (1 comment)

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5760 to look at the new patch set (#7). Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation ..

[kudu-CR] TLS-negotiation [7/n]: Add TLS helper classes for handling tunneled TLS handshakes

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5761 to look at the new patch set (#6). Change subject: TLS-negotiation [7/n]: Add TLS helper classes for handling tunneled TLS handshakes

[kudu-CR] WIP: KUDU-1848. in-memory dictionary for binary columns

Hello Dan Burkert, Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5780 to review the following change. Change subject: WIP: KUDU-1848. in-memory dictionary for binary columns

[kudu-CR] [security] separated OpenSSL wrappers from CA

Dan Burkert has posted comments on this change. Change subject: [security] separated OpenSSL wrappers from CA .. Patch Set 2: Did you consider putting all of this in openssl_util.h? Seems like an appropriate place for it

[kudu-CR] KUDU-1835 (part 2): enable WAL compression

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1835 (part 2): enable WAL compression .. Patch Set 8: (7 comments) http://gerrit.cloudera.org:8080/#/c/5736/8/src/kudu/consensus/log.cc File

[kudu-CR] Fix dependencies for util compression target

Todd Lipcon has submitted this change and it was merged. Change subject: Fix dependencies for util_compression target .. Fix dependencies for util_compression target A few dependencies were missing which caused build failures

[kudu-CR] [security] separated OpenSSL wrappers from CA

Alexey Serbin has posted comments on this change. Change subject: [security] separated OpenSSL wrappers from CA .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5779/1/src/kudu/security/openssl_traits.h File

[kudu-CR] [security] separated OpenSSL wrappers from CA

Alexey Serbin has uploaded a new patch set (#2). Change subject: [security] separated OpenSSL wrappers from CA .. [security] separated OpenSSL wrappers from CA Moved common wrappers around OpenSSL objects into a separate

[kudu-CR] Fix dependencies for util compression target

Alexey Serbin has posted comments on this change. Change subject: Fix dependencies for util_compression target .. Patch Set 1: Code-Review+2 LGTM: verified by building the project on my macbook; ProductName:Mac OS X

[kudu-CR] [security] separated OpenSSL wrappers from CA

Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5779 Change subject: [security] separated OpenSSL wrappers from CA .. [security] separated OpenSSL wrappers from CA Moved common wrappers

[kudu-CR] Add Google Breakpad support to Kudu

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#24). Change subject: Add Google Breakpad support to Kudu .. Add Google Breakpad