[kudu-CR] [thirdparty] fix build-thirdparty.sh for bash 3.x

2017-01-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5832 Change subject: [thirdparty] fix build-thirdparty.sh for bash 3.x .. [thirdparty] fix build-thirdparty.sh for bash 3.x The fall-through

[kudu-CR] Control mutex stack walking in DEBUG mode with a gflag

2017-01-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Control mutex stack walking in DEBUG mode with a gflag .. Patch Set 12: Verified+1 Overriding Jenkins due to flaky tests -- To view, visit

[kudu-CR] wal: Include standard prefix on glog lines

2017-01-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: wal: Include standard prefix on glog lines .. Patch Set 4: Verified+1 Overriding Jenkins on flaky ClientTest.TestWriteWithDeadTabletServer -- To view, visit

[kudu-CR] [security] method to extract public part of an RSA key

2017-01-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] method to extract public part of an RSA key .. Patch Set 11: Verified+1 Unrelated breakage: 20:11:23 CMake Error at CMakeLists.txt:917

[kudu-CR] [security] method to extract public part of an RSA key

2017-01-30 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5783 to look at the new patch set (#11). Change subject: [security] method to extract public part of an RSA key ..

[kudu-CR] consensus peers-test: Call FsManager::Open() in SetUp()

2017-01-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: consensus_peers-test: Call FsManager::Open() in SetUp() .. Patch Set 1: Verified+1 Overriding unrelated test failure (raft_consensus-itest) -- To view, visit

[kudu-CR] [security] do actual token signing/verification

2017-01-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] do actual token signing/verification .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5812/2/src/kudu/security/token_signing_key.cc

[kudu-CR] [security] do actual token signing/verification

2017-01-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] do actual token signing/verification .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/5812/6/src/kudu/security/token_signing_key.cc

[kudu-CR] KUDU-1691 - [python] Updated Column Encoding Types

2017-01-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1691 - [python] Updated Column Encoding Types .. Patch Set 3: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4824 To

[kudu-CR] KUDU-1691 - [python] Updated Column Encoding Types

2017-01-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1691 - [python] Updated Column Encoding Types .. KUDU-1691 - [python] Updated Column Encoding Types GROUP_VARINT encoding has been depricated and as

[kudu-CR] Make delete table-test less flaky

2017-01-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Make delete_table-test less flaky .. Patch Set 2: Verified+1 Overriding Jenkins due to flakiness of unrelated tests -- To view, visit

[kudu-CR] KUDU-1853. Tablet copy: Don't orphan blocks on failure

2017-01-30 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: KUDU-1853. Tablet copy: Don't orphan blocks on failure .. KUDU-1853. Tablet copy: Don't orphan blocks on failure Previously, if a tablet copy failed we

[kudu-CR] Control mutex stack walking in DEBUG mode with a gflag

2017-01-30 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5741 to look at the new patch set (#12). Change subject: Control mutex stack walking in DEBUG mode with a gflag ..

[kudu-CR] Control mutex stack walking in DEBUG mode with a gflag

2017-01-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Control mutex stack walking in DEBUG mode with a gflag .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/5741/10//COMMIT_MSG Commit Message:

[kudu-CR] WIP: Add a new TIMESTAMP type

2017-01-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: Add a new TIMESTAMP type .. Patch Set 3: (38 comments) http://gerrit.cloudera.org:8080/#/c/5819/3/src/kudu/client/scan_batch.h File

[kudu-CR] thirdparty: Clean up thirdparty prefix from previous builds

2017-01-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: thirdparty: Clean up thirdparty prefix from previous builds .. Patch Set 3: Verified+1 Overriding Jenkins due to a flaky test. I submitted a patch for the

[kudu-CR] thirdparty: Clean up thirdparty prefix from previous builds

2017-01-30 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: thirdparty: Clean up thirdparty prefix from previous builds .. thirdparty: Clean up thirdparty prefix from previous builds If we are rebuilding thirdparty

[kudu-CR] consensus peers-test: Call FsManager::Open() in SetUp()

2017-01-30 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/5831 Change subject: consensus_peers-test: Call FsManager::Open() in SetUp() .. consensus_peers-test: Call FsManager::Open() in SetUp() This

[kudu-CR] Make delete table-test less flaky

2017-01-30 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new patch set (#2). Change subject: Make delete_table-test less flaky .. Make delete_table-test less flaky Add AssertEventually to this DeleteTablet() call so it doesn't race against the completion of

[kudu-CR] Make delete table-test less flaky

2017-01-30 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/5830 Change subject: Make delete_table-test less flaky .. Make delete_table-test less flaky Add AssertEventually to this DeleteTablet() call so

[kudu-CR] KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV

2017-01-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV .. KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV The

[kudu-CR] KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV

2017-01-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV .. Patch Set 2: Verified+1 Test failure was the libboost issue that David's working on

[kudu-CR] KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV

2017-01-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5822 To

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-01-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5820/1/src/kudu/security/init.cc

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-01-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5820/1/src/kudu/security/init.cc

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-01-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5820/1/src/kudu/security/init.cc

[kudu-CR] KUDU-1853. Tablet copy: Don't orphan blocks on failure

2017-01-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1853. Tablet copy: Don't orphan blocks on failure .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5799 To unsubscribe, visit

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-01-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5820/1/src/kudu/security/init.cc

[kudu-CR] thirdparty: Clean up thirdparty prefix from previous builds

2017-01-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: thirdparty: Clean up thirdparty prefix from previous builds .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5826 To unsubscribe,

[kudu-CR] KUDU-1853. Tablet copy: Don't orphan blocks on failure

2017-01-30 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5799 to look at the new patch set (#6). Change subject: KUDU-1853. Tablet copy: Don't orphan blocks on failure ..

[kudu-CR] KUDU-1853. Tablet copy: Don't orphan blocks on failure

2017-01-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1853. Tablet copy: Don't orphan blocks on failure .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-01-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 1: (13 comments) http://gerrit.cloudera.org:8080/#/c/5820/1//COMMIT_MSG Commit

[kudu-CR] thirdparty: Clean up thirdparty prefix from previous builds

2017-01-30 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5826 to look at the new patch set (#3). Change subject: thirdparty: Clean up thirdparty prefix from previous builds ..

[kudu-CR] thirdparty: Clean up thirdparty prefix from previous builds

2017-01-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: thirdparty: Clean up thirdparty prefix from previous builds .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5826/2/thirdparty/build-thirdparty.sh

[kudu-CR] wal: Include standard prefix on glog lines

2017-01-30 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5827 to look at the new patch set (#3). Change subject: wal: Include standard prefix on glog lines .. wal: Include

[kudu-CR] [security] sign/verify data using RSA key pair

2017-01-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] sign/verify data using RSA key pair .. Patch Set 10: (9 comments) http://gerrit.cloudera.org:8080/#/c/5805/10/src/kudu/security/crypto-test.cc File

[kudu-CR] thirdparty: Clean up thirdparty prefix from previous builds

2017-01-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: thirdparty: Clean up thirdparty prefix from previous builds .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5826/2/thirdparty/build-thirdparty.sh

[kudu-CR] thirdparty: Clean up thirdparty prefix from previous builds

2017-01-30 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new patch set (#2). Change subject: thirdparty: Clean up thirdparty prefix from previous builds .. thirdparty: Clean up thirdparty prefix from previous builds If we are rebuilding thirdparty anyway,

[kudu-CR] thirdparty: Clean up thirdparty prefix from previous builds

2017-01-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: thirdparty: Clean up thirdparty prefix from previous builds .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5826/1/thirdparty/build-thirdparty.sh

[kudu-CR] [security] sign/verify data using RSA key pair

2017-01-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] sign/verify data using RSA key pair .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5805/2/src/kudu/security/openssl_util.cc File

[kudu-CR] [security] sign/verify data using RSA key pair

2017-01-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] sign/verify data using RSA key pair .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5805/2/src/kudu/security/openssl_util.cc File

[kudu-CR] [security] introduced crypto-test

2017-01-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] introduced crypto-test .. Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/5798/10/src/kudu/security/crypto-test.cc File

[kudu-CR] [security] method to extract public part of RSA key

2017-01-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] method to extract public part of RSA key .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/5783/10//COMMIT_MSG Commit Message: PS10,

[kudu-CR] Fix flakiness of TestConnectionCache

2017-01-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix flakiness of TestConnectionCache .. Patch Set 1: (1 comment)

[kudu-CR] Fix flakiness of TestConnectionCache

2017-01-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix flakiness of TestConnectionCache .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1835 (part 2): enable WAL compression

2017-01-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1835 (part 2): enable WAL compression .. KUDU-1835 (part 2): enable WAL compression This enables compression of the entries in the WAL. To test the

[kudu-CR] rpc: allow using encrypted private key for SSL

2017-01-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: allow using encrypted private key for SSL .. Patch Set 1: For Kudu's usage, we're a little less interested in this specifically and more interested in the

[kudu-CR] Fix flakiness of TestConnectionCache

2017-01-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix flakiness of TestConnectionCache .. Patch Set 2: Code-Review+2 Could you open a jira (or find it if it already exists) for having the Java client test infra

[kudu-CR] [security] introduced crypto-test

2017-01-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] introduced crypto-test .. Patch Set 10: Verified+1 Clearing unrelated failure of org.apache.kudu.client.TestLeaderFailover.testFailover test -- To

[kudu-CR] [security] method to extract public part of RSA key

2017-01-30 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5783 to look at the new patch set (#10). Change subject: [security] method to extract public part of RSA key ..

[kudu-CR] Initial draft of release notes and doc updates for 1.2

2017-01-30 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: Initial draft of release notes and doc updates for 1.2 .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/5604/4/docs/release_notes.adoc File

[kudu-CR] Fix flakiness of TestConnectionCache

2017-01-30 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Fix flakiness of TestConnectionCache .. Patch Set 1: Todd, since you're out sick I pushed a new rev over yours. Your variable naming was very C++ and not

[kudu-CR] Fix flakiness of TestConnectionCache

2017-01-30 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5803 to look at the new patch set (#2). Change subject: Fix flakiness of TestConnectionCache .. Fix flakiness of

[kudu-CR] rpc: allow using encrypted private key for SSL

2017-01-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: rpc: allow using encrypted private key for SSL .. Patch Set 1: Just checking in on the ETA for this patch. -- To view, visit

[kudu-CR] [security] method to extract public part of RSA key

2017-01-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#9). Change subject: [security] method to extract public part of RSA key .. [security] method to extract public part of RSA key Added a method to get the public part of an RSA

[kudu-CR] [security] sign/verify data using RSA key pair

2017-01-30 Thread Alexey Serbin (Code Review)
Hello Dan Burkert, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5805 to look at the new patch set (#9). Change subject: [security] sign/verify data using RSA key pair .. [security]

[kudu-CR] [security] do actual token signing/verification

2017-01-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#5). Change subject: [security] do actual token signing/verification .. [security] do actual token signing/verification Replaced temporary stub sign/verify calls with calls of actual