[kudu-CR] Allow to pad UNIXTIME MICROS slots in scan results

2017-04-12 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6623 to look at the new patch set (#4). Change subject: Allow to pad UNIXTIME_MICROS slots in scan results .. Allow to

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-12 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/6574/13/src/kudu/client/scan_batch.h File

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-12 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Allow to get the raw data from a KuduScanBatch .. Allow to get the raw data from a KuduScanBatch This allows to fetch both the direct and the

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-12 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch .. Patch Set 13: -Code-Review Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6574 To

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-12 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch .. Patch Set 13: Code-Review+2 Unrelated failure of: RaftConsensusITest.TestKUDU_597 -- To view, visit

[kudu-CR] Allow to pad UNIXTIME MICROS slots in scan results

2017-04-12 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6623 to look at the new patch set (#3). Change subject: Allow to pad UNIXTIME_MICROS slots in scan results .. Allow to

[kudu-CR] WIP: Expose a way to set "advanced" non-types scan options

2017-04-12 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6624 to look at the new patch set (#3). Change subject: WIP: Expose a way to set "advanced" non-types scan options ..

[kudu-CR] WIP: Expose a way to set "advanced" non-types scan options

2017-04-12 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: WIP: Expose a way to set "advanced" non-types scan options .. WIP: Expose a way to set "advanced" non-types scan options This adds a new method to

[kudu-CR] Allow to pad UNIXTIME MICROS slots in scan results

2017-04-12 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: Allow to pad UNIXTIME_MICROS slots in scan results .. Allow to pad UNIXTIME_MICROS slots in scan results This changes the wire protocol to, upon request,

[kudu-CR] WIP: Expose a way to set "advanced" non-types scan options

2017-04-12 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/6624 Change subject: WIP: Expose a way to set "advanced" non-types scan options .. WIP: Expose a way to set "advanced" non-types scan

[kudu-CR] Allow to pad UNIXTIME MICROS slows in scan results

2017-04-12 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/6623 Change subject: Allow to pad UNIXTIME_MICROS slows in scan results .. Allow to pad UNIXTIME_MICROS slows in scan results This

[kudu-CR](branch-1.3.x) Release notes for 1.3.1

2017-04-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Release notes for 1.3.1 .. Release notes for 1.3.1 I chose not to move 1.3.0 release notes to "prior version" since the release notes for the dot-release

[kudu-CR](branch-1.3.x) Release notes for 1.3.1

2017-04-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Release notes for 1.3.1 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6622 To unsubscribe, visit

[kudu-CR](branch-1.3.x) Release notes for 1.3.1

2017-04-12 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6622 to look at the new patch set (#2). Change subject: Release notes for 1.3.1 .. Release notes for 1.3.1 I

[kudu-CR](branch-1.3.x) Release notes for 1.3.1

2017-04-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Release notes for 1.3.1 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6622/1/docs/release_notes.adoc File docs/release_notes.adoc: PS1, Line

[kudu-CR](branch-1.3.x) Bump version to 1.3.1

2017-04-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Bump version to 1.3.1 .. Bump version to 1.3.1 Change-Id: I57a62725cd407f81044d1b9c40af30cc337cfaa5 Reviewed-on: http://gerrit.cloudera.org:8080/6621

[kudu-CR](branch-1.3.x) Release notes for 1.3.1

2017-04-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Release notes for 1.3.1 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6622/1/docs/release_notes.adoc File docs/release_notes.adoc: PS1, Line

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch .. Patch Set 13: Code-Review+2 (1 comment)

[kudu-CR](branch-1.3.x) Release notes for 1.3.1

2017-04-12 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Release notes for 1.3.1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6622 To unsubscribe, visit

[kudu-CR](branch-1.3.x) Release notes for 1.3.1

2017-04-12 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6622 to review the following change. Change subject: Release notes for 1.3.1 .. Release notes for 1.3.1 I chose

[kudu-CR](branch-1.3.x) Bump version to 1.3.1

2017-04-12 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Bump version to 1.3.1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6621 To unsubscribe, visit

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-12 Thread David Ribeiro Alves (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6574 to look at the new patch set (#13). Change subject: Allow to get the raw data from a KuduScanBatch

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-12 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/6574/11/src/kudu/client/client-test.cc

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-12 Thread David Ribeiro Alves (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6574 to look at the new patch set (#12). Change subject: Allow to get the raw data from a KuduScanBatch

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch .. Patch Set 11: (1 comment) Looks good to me overall, just one little question to clarify on the

[kudu-CR] Add CLANG ALWAYS COLOR option to ccache-clang wrappers

2017-04-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add CLANG_ALWAYS_COLOR option to ccache-clang wrappers .. Patch Set 1: > ah, I didnt realize we had that. Mind if I change cmakelists to > also pick that up from

[kudu-CR](branch-1.3.x) Bump version to 1.3.1

2017-04-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/6621 Change subject: Bump version to 1.3.1 .. Bump version to 1.3.1 Change-Id: I57a62725cd407f81044d1b9c40af30cc337cfaa5 --- M

[kudu-CR] WIP: simplify MemTracker and move process throttling elsewhere

2017-04-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: simplify MemTracker and move process throttling elsewhere .. Patch Set 1: Yea, I agree that all three of those things may disappear. I just wanted to do

[kudu-CR] Add CLANG ALWAYS COLOR option to ccache-clang wrappers

2017-04-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add CLANG_ALWAYS_COLOR option to ccache-clang wrappers .. Patch Set 1: ah, I didnt realize we had that. Mind if I change cmakelists to also pick that up from the

[kudu-CR] Add CLANG ALWAYS COLOR option to ccache-clang wrappers

2017-04-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add CLANG_ALWAYS_COLOR option to ccache-clang wrappers .. Patch Set 1: Isn't this what our KUDU_FORCE_COLOR_DIAGNOSTICS cmake variable is for? -- To view, visit

[kudu-CR] WIP: simplify MemTracker and move process throttling elsewhere

2017-04-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: WIP: simplify MemTracker and move process throttling elsewhere .. Patch Set 1: Not sure exactly what your plan is, so I'll just list the things that I found

[kudu-CR] log block manager: corruptor test utility

2017-04-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log block manager: corruptor test utility .. Patch Set 5: Verified+1 Unrelated test failure. -- To view, visit http://gerrit.cloudera.org:8080/6582 To

[kudu-CR] Add CLANG ALWAYS COLOR option to ccache-clang wrappers

2017-04-12 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6619 to review the following change. Change subject: Add CLANG_ALWAYS_COLOR option to ccache-clang wrappers

[kudu-CR] WIP: simplify MemTracker and move process throttling elsewhere

2017-04-12 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6620 to review the following change. Change subject: WIP: simplify MemTracker and move process throttling elsewhere

[kudu-CR] KUDU-1965: Allow user provided TLS certificates to work with KRPC

2017-04-12 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1965: Allow user provided TLS certificates to work with KRPC .. KUDU-1965: Allow user provided TLS certificates to work with KRPC This patch adds a

[kudu-CR] fs: generate report during Open

2017-04-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: fs: generate report during Open .. Patch Set 4: (15 comments) http://gerrit.cloudera.org:8080/#/c/6581/4//COMMIT_MSG Commit Message: PS4, Line 9: This patch

[kudu-CR] java: add a stress test for short-lived clients

2017-04-12 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: add a stress test for short-lived clients .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6615 To unsubscribe, visit

[kudu-CR] java: add a stress test for short-lived clients

2017-04-12 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: java: add a stress test for short-lived clients .. java: add a stress test for short-lived clients This simulates an Impala frontend-like workload

[kudu-CR] java: add a stress test for short-lived clients

2017-04-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: java: add a stress test for short-lived clients .. Patch Set 1: Code-Review+1 nice -- To view, visit http://gerrit.cloudera.org:8080/6615 To unsubscribe,

[kudu-CR] WIP: release WritableLogSegment buffers when log is idle

2017-04-12 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6611 to look at the new patch set (#2). Change subject: WIP: release WritableLogSegment buffers when log is idle ..

[kudu-CR](branch-1.3.x) KUDU-1968. Aborted tablet copies delete live blocks

2017-04-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1968. Aborted tablet copies delete live blocks .. KUDU-1968. Aborted tablet copies delete live blocks This patch reverts "KUDU-1853. Tablet copy:

[kudu-CR] KUDU-1965: Allow user provided TLS certificates to work with KRPC

2017-04-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1965: Allow user provided TLS certificates to work with KRPC .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6594 To

[kudu-CR](branch-1.3.x) KUDU-1968. Aborted tablet copies delete live blocks

2017-04-12 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1968. Aborted tablet copies delete live blocks .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6614 To unsubscribe,

[kudu-CR](branch-1.3.x) KUDU-1968. Aborted tablet copies delete live blocks

2017-04-12 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6614 to review the following change. Change subject: KUDU-1968. Aborted tablet copies delete live blocks

[kudu-CR] KUDU-1965: Allow user provided TLS certificates to work with KRPC

2017-04-12 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6594 to look at the new patch set (#5). Change subject: KUDU-1965: Allow user provided TLS certificates to work with KRPC

[kudu-CR] KUDU-1965: Allow user provided TLS certificates to work with KRPC

2017-04-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1965: Allow user provided TLS certificates to work with KRPC .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-1965: Allow user provided TLS certificates to work with KRPC

2017-04-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1965: Allow user provided TLS certificates to work with KRPC .. Patch Set 4: (1 comment) looks good, except for small nit on the diagram

[kudu-CR] KUDU-1968. Aborted tablet copies delete live blocks

2017-04-12 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1968. Aborted tablet copies delete live blocks .. KUDU-1968. Aborted tablet copies delete live blocks This patch reverts "KUDU-1853. Tablet

[kudu-CR] KUDU-1968. Aborted tablet copies delete live blocks

2017-04-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1968. Aborted tablet copies delete live blocks .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6613 To unsubscribe, visit

[kudu-CR] KUDU-1968. Aborted tablet copies delete live blocks

2017-04-12 Thread Jean-Daniel Cryans (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6613 to look at the new patch set (#2). Change subject: KUDU-1968. Aborted tablet copies delete live blocks

[kudu-CR] Revert "KUDU-1853. Tablet copy: Don't orphan blocks on failure"

2017-04-12 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Revert "KUDU-1853. Tablet copy: Don't orphan blocks on failure" .. Patch Set 1: Code-Review-2 Getting a quick unit test run, Todd is filing a jira so we'll

[kudu-CR] Revert "KUDU-1853. Tablet copy: Don't orphan blocks on failure"

2017-04-12 Thread Jean-Daniel Cryans (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6613 to review the following change. Change subject: Revert "KUDU-1853. Tablet copy: Don't orphan blocks on failure" ..

[kudu-CR] fs: generate report during Open

2017-04-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: fs: generate report during Open .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6581/5/src/kudu/fs/fs_report.h File src/kudu/fs/fs_report.h:

[kudu-CR] Allow to release an rpc transfer's data

2017-04-12 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6592 to look at the new patch set (#8). Change subject: Allow to release an rpc transfer's data .. Allow to release an

[kudu-CR] WIP: release WritableLogSegment buffers when log is idle

2017-04-12 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6611 to review the following change. Change subject: WIP: release WritableLogSegment buffers when log is idle