[kudu-CR] WIP: clock: add a built-in NTP client implementation

2017-08-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: clock: add a built-in NTP client implementation .. Patch Set 6: did a rebase and another rev with a few more docs but still not a high quality patch. needs

[kudu-CR] WIP: clock: add a built-in NTP client implementation

2017-08-17 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7477 to look at the new patch set (#6). Change subject: WIP: clock: add a built-in NTP client implementation .. WIP:

[kudu-CR] KUDU-1942. Kerberos fails to log in on hostnames with capital letters

2017-08-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital letters .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7693/2//COMMIT_MSG

[kudu-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-08-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 4: (2 comments)

[kudu-CR] disk failure: add persistent disk states

2017-08-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/7270/15//COMMIT_MSG Commit Message: Line 11: failed

[kudu-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-08-17 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7687 to look at the new patch set (#4). Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

[kudu-CR] KUDU-2032 (part 2): propagate master hostnames into client

2017-08-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2032 (part 2): propagate master hostnames into client .. Patch Set 2: (3 comments)

[kudu-CR] disk failure: add persistent disk states

2017-08-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 15: (30 comments) Made it further in. Todd should review this too, since he was in that meeting we had to

[kudu-CR] KUDU-1726: Avoid fsync-per-block in tablet copy

2017-08-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy .. Patch Set 1: (8 comments) Mike should probably review this too.

[kudu-CR] KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout

2017-08-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout .. KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout Previously, when

[kudu-CR] KUDU-2032 (part 2): propagate master hostnames into client

2017-08-17 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7692 to look at the new patch set (#3). Change subject: KUDU-2032 (part 2): propagate master hostnames into client ..

[kudu-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-08-17 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7687 to look at the new patch set (#3). Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

[kudu-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-08-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 2: (5 comments)

[kudu-CR] KUDU-1942. Kerberos fails to log in on hostnames with capital letters

2017-08-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital letters .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7693/2//COMMIT_MSG Commit

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-2101 Include a table summary at the bottom

2017-08-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2101 Include a table summary at the bottom .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/7707/1/src/kudu/tools/ksck.cc File

[kudu-CR] KUDU-1489: move tablet metadata

2017-08-17 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7617 to look at the new patch set (#2). Change subject: KUDU-1489: move tablet metadata .. KUDU-1489: move tablet

[kudu-CR] consensus: Improve contract for API to fetch last-logged op id

2017-08-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: Improve contract for API to fetch last-logged op id .. Patch Set 1: (11 comments)

[kudu-CR] [iwyu] first pass

2017-08-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [iwyu] first pass .. Patch Set 18: (41 comments) Good job on trimming the pragmas, looking much better now.

[kudu-CR] KUDU-1407: reassign failed tablets

2017-08-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1407: reassign failed tablets .. Patch Set 11: (3 comments)

[kudu-CR] KUDU-1407: reassign failed tablets

2017-08-17 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7440 to look at the new patch set (#12). Change subject: KUDU-1407: reassign failed tablets .. KUDU-1407: reassign

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 19: (14 comments) I think I reviewed everything, but I'm curious to see how this will evolve

[kudu-CR] rpc: some small cleanup in ConnectionId

2017-08-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: rpc: some small cleanup in ConnectionId .. rpc: some small cleanup in ConnectionId Change-Id: I0788052f8c943ef102f3f551a85a8b219c65c361 Reviewed-on:

[kudu-CR] KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout

2017-08-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7599 To

[kudu-CR] KUDU-1407: reassign failed tablets

2017-08-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1407: reassign failed tablets .. Patch Set 7: (7 comments) http://gerrit.cloudera.org:8080/#/c/7440/7/src/kudu/client/scanner-internal.cc File

[kudu-CR] KUDU-1407: reassign failed tablets

2017-08-17 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7440 to look at the new patch set (#11). Change subject: KUDU-1407: reassign failed tablets .. KUDU-1407: reassign

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-17 Thread Mike Percy (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6960 to look at the new patch set (#7). Change subject: KUDU-871. Support tombstoned voting

[kudu-CR] consensus: Tablet copy should clear last-logged opid from superblock

2017-08-17 Thread Mike Percy (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7718 to review the following change. Change subject: consensus: Tablet copy should clear last-logged opid from superblock

[kudu-CR] consensus: Improve contract for API to fetch last-logged op id

2017-08-17 Thread Mike Percy (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7717 to review the following change. Change subject: consensus: Improve contract for API to fetch last-logged op id

[kudu-CR] [docs] Deprecate Java 7 and Spark 1

2017-08-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [docs] Deprecate Java 7 and Spark 1 .. Patch Set 1: Oh and https://github.com/apache/kudu/tree/master/java#system-requirements -- To view, visit

[kudu-CR] [docs] Deprecate Java 7 and Spark 1

2017-08-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [docs] Deprecate Java 7 and Spark 1 .. Patch Set 1: Can you add a note to http://kudu.apache.org/docs/installation.html#build_java_client ? -- To view,

[kudu-CR] KUDU-1407: reassign failed tablets

2017-08-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1407: reassign failed tablets .. Patch Set 10: (6 comments) http://gerrit.cloudera.org:8080/#/c/7440/7/src/kudu/client/scanner-internal.cc File

[kudu-CR] [docs] Deprecate Java 7 and Spark 1

2017-08-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [docs] Deprecate Java 7 and Spark 1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7699 To unsubscribe, visit

[kudu-CR] KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout

2017-08-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout .. Patch Set 5: The verification failure may be infra related. Not sure if I have the

[kudu-CR] KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout

2017-08-17 Thread Michael Ho (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7599 to look at the new patch set (#5). Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout

[kudu-CR] KUDU-2101 Include a table summary at the bottom

2017-08-17 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/7707 Change subject: KUDU-2101 Include a table summary at the bottom .. KUDU-2101 Include a table summary at the bottom This add a table

[kudu-CR] disk failure: add persistent disk states

2017-08-17 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#15). Change subject: disk failure: add persistent disk states .. disk failure: add

[kudu-CR] Add tablet state summary metrics and fix KUDU-2044

2017-08-17 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7618 to look at the new patch set (#4). Change subject: Add tablet state summary metrics and fix KUDU-2044 .. Add

[kudu-CR] KUDU-1942. Kerberos fails to log in on hostnames with capital letters

2017-08-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital letters .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7693/2//COMMIT_MSG

[kudu-CR] KUDU-1942. Kerberos fails to log in on hostnames with capital letters

2017-08-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital letters .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7693/2//COMMIT_MSG Commit

[kudu-CR] KUDU-1942. Kerberos fails to log in on hostnames with capital letters

2017-08-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital letters .. Patch Set 2: Code-Review+1 LGTM after Alexey's comments have been addressed. -- To

[kudu-CR] Add tablet state summary metrics and fix KUDU-2044

2017-08-17 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add tablet state summary metrics and fix KUDU-2044 .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7618/2//COMMIT_MSG Commit Message: PS2,

[kudu-CR] security: only lookup hostname if HOST substitution is required

2017-08-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: security: only lookup hostname if _HOST substitution is required .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7694 To

[kudu-CR] Add tablet state summary metrics and fix KUDU-2044

2017-08-17 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7618 to look at the new patch set (#3). Change subject: Add tablet state summary metrics and fix KUDU-2044 .. Add

[kudu-CR] [gitignore] added *.autosave

2017-08-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [gitignore] added *.autosave .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7702 To unsubscribe, visit

[kudu-CR] [gitignore] added *.autosave

2017-08-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [gitignore] added *.autosave .. [gitignore] added *.autosave Change-Id: I99457244f007c757eb1a5a0aba235d8e33e4460e Reviewed-on:

[kudu-CR] [java] Update outdated dependencies

2017-08-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java] Update outdated dependencies .. [java] Update outdated dependencies Includes the following version updates: - Avro 1.8.1 -> 1.8.2 - Flume

[kudu-CR] [iwyu] first pass

2017-08-17 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4738 to look at the new patch set (#18). Change subject: [iwyu] first pass .. [iwyu] first pass Updated C++ source

[kudu-CR] KUDU-2032 (part 2): propagate master hostnames into client

2017-08-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2032 (part 2): propagate master hostnames into client .. Patch Set 2: (1 comment) looks good to me, just a nit

[kudu-CR] disk failure: add persistent disk states

2017-08-17 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#14). Change subject: disk failure: add persistent disk states .. disk failure: add

[kudu-CR] [gitignore] added *.autosave

2017-08-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/7702 Change subject: [gitignore] added *.autosave .. [gitignore] added *.autosave Change-Id: I99457244f007c757eb1a5a0aba235d8e33e4460e --- M

[kudu-CR] [iwyu] first pass

2017-08-17 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4738 to look at the new patch set (#17). Change subject: [iwyu] first pass .. [iwyu] first pass Updated C++ source

[kudu-CR] KUDU-1726: Avoid fsync-per-block in tablet copy

2017-08-17 Thread Hao Hao (Code Review)
Hao Hao has uploaded a new change for review. http://gerrit.cloudera.org:8080/7701 Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy .. KUDU-1726: Avoid fsync-per-block in tablet copy This patch incorporates

[kudu-CR] KUDU-1726: Avoid fsync-per-block in tablet copy

2017-08-17 Thread Hao Hao (Code Review)
Hao Hao has abandoned this change. Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7700 To unsubscribe, visit

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-17 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7207 to look at the new patch set (#19). Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. KUDU-1943:

[kudu-CR] KUDU-1726: Avoid fsync-per-block in tablet copy

2017-08-17 Thread Hao Hao (Code Review)
Hao Hao has uploaded a new patch set (#2). Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy .. KUDU-1726: Avoid fsync-per-block in tablet copy This patch incorporates BlockTransaction API with tablet copy, to

[kudu-CR] KUDU-1726: Avoid fsync-per-block in tablet copy

2017-08-17 Thread Hao Hao (Code Review)
Hao Hao has uploaded a new change for review. http://gerrit.cloudera.org:8080/7700 Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy .. KUDU-1726: Avoid fsync-per-block in tablet copy This patch incorporates