[kudu-CR] rename suicide on eio flag to crash on eio

2017-09-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: rename suicide_on_eio flag to crash_on_eio .. Patch Set 2: Rebased! -- To view, visit http://gerrit.cloudera.org:8080/7994 To unsubscribe, visit

[kudu-CR] KUDU-1788. Increase Raft RPC timeout to 30sec to avoid fruitless retries.

2017-09-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1788. Increase Raft RPC timeout to 30sec to avoid fruitless retries. .. Patch Set 1: Seems this different timing may have exposed a new TSAN warning. Will

[kudu-CR] rename suicide on eio flag to crash on eio

2017-09-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rename suicide_on_eio flag to crash_on_eio .. Patch Set 1: Code-Review+2 lgtm but I guess needs to be rebased -- To view, visit

[kudu-CR](gh-pages) Update website for 1.5.0 release

2017-09-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Update website for 1.5.0 release .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8013/1/releases/index.md File releases/index.md: Line 12: *

[kudu-CR] KUDU-1807 (part 2): stop calling IsCreateInProgress in GetTableSchema

2017-09-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1807 (part 2): stop calling IsCreateInProgress in GetTableSchema .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-1807 (part 1): ban GetTableSchema for table createdness in clients

2017-09-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1807 (part 1): ban GetTableSchema for table createdness in clients .. Patch Set 1: Code-Review+1 (1 comment) didn't look in great detail but on board with

[kudu-CR] KUDU-1788. Increase Raft RPC timeout to 30sec to avoid fruitless retries.

2017-09-11 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8037 to review the following change. Change subject: KUDU-1788. Increase Raft RPC timeout to 30sec to avoid fruitless retries.

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-09-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Kudu Consistency Blog Post Pt1 .. Patch Set 12: Code-Review+1 My nits were minor, mostly punctuation. Content/structure-wise I think it's fine -- To view, visit

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-09-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Kudu Consistency Blog Post Pt1 .. Patch Set 12: (17 comments) http://gerrit.cloudera.org:8080/#/c/7019/11/_posts/2017-08-21-kudu-consistency-pt1.md File

[kudu-CR] docs: clarify steps for removing master from multi-master deployment

2017-09-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: docs: clarify steps for removing master from multi-master deployment .. Patch Set 2: (6 comments)

[kudu-CR] docs: clarify steps for removing master from multi-master deployment

2017-09-11 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8032 to look at the new patch set (#2). Change subject: docs: clarify steps for removing master from multi-master deployment

[kudu-CR] docs: split disk failure from disk config changes

2017-09-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: docs: split disk failure from disk config changes .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7984 To unsubscribe, visit

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2125: Tablet copy client does not retry on failures .. Patch Set 8: (1 comment)

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2125: Tablet copy client does not retry on failures .. Patch Set 8: (1 comment)

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2125: Tablet copy client does not retry on failures .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-11 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8016 to look at the new patch set (#8). Change subject: KUDU-2125: Tablet copy client does not retry on failures ..

[kudu-CR] docs: split disk failure from disk config changes

2017-09-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: docs: split disk failure from disk config changes .. Patch Set 4: Fair point, took your suggestion and kept both. I've seen a few questions about changing disk

[kudu-CR] docs: split disk failure from disk config changes

2017-09-11 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7984 to look at the new patch set (#4). Change subject: docs: split disk failure from disk config changes .. docs:

[kudu-CR] KUDU-1807 (part 2): stop calling IsCreateInProgress in GetTableSchema

2017-09-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1807 (part 2): stop calling IsCreateInProgress in GetTableSchema .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8027/1//COMMIT_MSG Commit

[kudu-CR] docs: omit discussing disk failure in admin docs

2017-09-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: docs: omit discussing disk failure in admin docs .. Patch Set 3: I'm not in favor of removing the 'Recovering from Disk Failure' section. disk failure recovery

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2125: Tablet copy client does not retry on failures .. Patch Set 7: (3 comments)

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2125: Tablet copy client does not retry on failures .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-11 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8016 to look at the new patch set (#7). Change subject: KUDU-2125: Tablet copy client does not retry on failures ..

[kudu-CR] Add a simple benchmark to create 1M blocks and reopen LBM

2017-09-11 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a simple benchmark to create 1M blocks and reopen LBM .. Patch Set 1: it'd be awesome to have somethings like this for actual tablets. likely out of

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-11 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8016 to look at the new patch set (#6). Change subject: KUDU-2125: Tablet copy client does not retry on failures ..

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2125: Tablet copy client does not retry on failures .. Patch Set 4: (11 comments) http://gerrit.cloudera.org:8080/#/c/8016/4//COMMIT_MSG Commit Message:

[kudu-CR] docs: clarify steps for removing master from multi-master deployment

2017-09-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: docs: clarify steps for removing master from multi-master deployment .. Patch Set 1: (2 comments)

[kudu-CR] docs: clarify steps for removing master from multi-master deployment

2017-09-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: docs: clarify steps for removing master from multi-master deployment .. Patch Set 1: (4 comments)

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2125: Tablet copy client does not retry on failures .. Patch Set 4: (10 comments) http://gerrit.cloudera.org:8080/#/c/8016/4//COMMIT_MSG Commit Message:

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-11 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8016 to look at the new patch set (#5). Change subject: KUDU-2125: Tablet copy client does not retry on failures ..

[kudu-CR] docs: clarify steps for removing master from multi-master deployment

2017-09-11 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/8032 Change subject: docs: clarify steps for removing master from multi-master deployment .. docs: clarify steps for removing master from

[kudu-CR] docs: omit discussing disk failure in admin docs

2017-09-11 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7984 to look at the new patch set (#3). Change subject: docs: omit discussing disk failure in admin docs .. docs: omit

[kudu-CR] KUDU-1807 (part 1): ban GetTableSchema for table createdness in clients

2017-09-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1807 (part 1): ban GetTableSchema for table createdness in clients .. Patch Set 1: (8 comments)

[kudu-CR] [tests] de-flaking catalog manager tsk-itest

2017-09-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [tests] de-flaking catalog_manager_tsk-itest .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8017/1//COMMIT_MSG Commit Message: > OK, here the

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-2125: Tablet copy client does not retry on failures .. Patch Set 4: (1 comment)

[kudu-CR] [tests] de-flaking catalog manager tsk-itest

2017-09-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [tests] de-flaking catalog_manager_tsk-itest .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8017/1//COMMIT_MSG Commit Message: > Did you try

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-09-11 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#12). Change subject: Kudu Consistency Blog Post Pt1 .. Kudu Consistency Blog Post Pt1 This is the first part of multi-part blog post series about consistency in Kudu. It's hard

[kudu-CR] [docs] fixup releasing git instructions

2017-09-11 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7876 to look at the new patch set (#3). Change subject: [docs] fixup releasing git instructions .. [docs] fixup

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-09-11 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#11). Change subject: Kudu Consistency Blog Post Pt1 .. Kudu Consistency Blog Post Pt1 This is the first part of multi-part blog post series about consistency in Kudu. It's hard

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-09-11 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Kudu Consistency Blog Post Pt1 .. Patch Set 10: (37 comments) http://gerrit.cloudera.org:8080/#/c/7019/10/_posts/2017-08-21-kudu-consistency-pt1.md File

[kudu-CR] KUDU-1807 (part 2): stop calling IsCreateInProgress in GetTableSchema

2017-09-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1807 (part 2): stop calling IsCreateInProgress in GetTableSchema .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8027/1//COMMIT_MSG Commit

[kudu-CR] Add tablet state summary metrics

2017-09-11 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add tablet state summary metrics .. Patch Set 7: No worries just don't want it to seem like I'm negligent and I don't bother to run IWYU before I post a new

[kudu-CR] Add tablet state summary metrics

2017-09-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Add tablet state summary metrics .. Patch Set 7: > IWYU gives very different (even contradictory) results on OS X v. > in the Jenkins build :( Sorry for the

[kudu-CR] Add tablet state summary metrics

2017-09-11 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add tablet state summary metrics .. Patch Set 7: IWYU gives very different (even contradictory) results on OS X v. in the Jenkins build :( -- To view, visit

[kudu-CR] Add tablet state summary metrics

2017-09-11 Thread Will Berkeley (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7980 to look at the new patch set (#7). Change subject: Add tablet state summary metrics .. Add tablet

[kudu-CR] KUDU-2125: Tablet copy client does not retry on failures

2017-09-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2125: Tablet copy client does not retry on failures .. Patch Set 4: retriggered; failure seemingly due to KUDU-1736 -- To view, visit

[kudu-CR] Add tablet state summary metrics

2017-09-11 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add tablet state summary metrics .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/7980/5/src/kudu/integration-tests/tablet_copy-itest.cc File

[kudu-CR] Add tablet state summary metrics

2017-09-11 Thread Will Berkeley (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7980 to look at the new patch set (#6). Change subject: Add tablet state summary metrics .. Add tablet