[kudu-CR] KUDU-2202 avoid block ID reuse for missing dirs

2017-11-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8465 ) Change subject: KUDU-2202 avoid block ID reuse for missing dirs .. Patch Set 7: (3 comments)

[kudu-CR] KUDU-2202 avoid block ID reuse for missing dirs

2017-11-03 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8465 to look at the new patch set (#8). Change subject: KUDU-2202 avoid block ID reuse for missing dirs

[kudu-CR] KUDU-2202 avoid block ID reuse for missing dirs

2017-11-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8465 ) Change subject: KUDU-2202 avoid block ID reuse for missing dirs .. Patch Set 7: (3 comments) Looks good, just some nits on comments.

[kudu-CR] tool: new action for updating the set of data directories (take 2)

2017-11-03 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8352 ) Change subject: tool: new action for updating the set of data directories (take 2) .. Removed reviewer Kudu Jenkins with the

[kudu-CR] tool: new action for updating the set of data directories (take 2)

2017-11-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8352 ) Change subject: tool: new action for updating the set of data directories (take 2) .. Patch Set 8: Verified+1 Overriding Jenkins,

[kudu-CR] fs: replace CreateDirWithMissing with env util calls

2017-11-03 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8469 ) Change subject: fs: replace CreateDirWithMissing with env_util calls .. fs: replace CreateDirWithMissing with env_util calls

[kudu-CR] fs: replace CreateDirWithMissing with env util calls

2017-11-03 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8469 ) Change subject: fs: replace CreateDirWithMissing with env_util calls .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] fs: replace CreateDirWithMissing with env util calls

2017-11-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8469 ) Change subject: fs: replace CreateDirWithMissing with env_util calls .. Patch Set 1: Verified+1 Overriding Jenkins, unrelated test

[kudu-CR] KUDU-2202 avoid block ID reuse for missing dirs

2017-11-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8465 ) Change subject: KUDU-2202 avoid block ID reuse for missing dirs .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-2202 avoid block ID reuse for missing dirs

2017-11-03 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8465 to look at the new patch set (#7). Change subject: KUDU-2202 avoid block ID reuse for missing dirs

[kudu-CR] fs: replace CreateDirWithMissing with env util calls

2017-11-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8469 ) Change subject: fs: replace CreateDirWithMissing with env_util calls .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2202 avoid block ID reuse for missing dirs

2017-11-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8465 ) Change subject: KUDU-2202 avoid block ID reuse for missing dirs .. Patch Set 5: (6 comments)

[kudu-CR] KUDU-2202 avoid block ID reuse for missing dirs

2017-11-03 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8465 to look at the new patch set (#6). Change subject: KUDU-2202 avoid block ID reuse for missing dirs

[kudu-CR] tool: new action for updating the set of data directories (take 2)

2017-11-03 Thread Adar Dembo (Code Review)
Hello Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8352 to look at the new patch set (#8). Change subject: tool: new action for updating the set of data directories (take 2)

[kudu-CR] fs: replace CreateDirWithMissing with env util calls

2017-11-03 Thread Adar Dembo (Code Review)
Hello Andrew Wong, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8469 to review the following change. Change subject: fs: replace CreateDirWithMissing with env_util calls ..

[kudu-CR] tool: new actions for adding and removing data directories

2017-11-03 Thread Adar Dembo (Code Review)
Adar Dembo has restored this change. ( http://gerrit.cloudera.org:8080/8352 ) Change subject: tool: new actions for adding and removing data directories .. Restored -- To view, visit http://gerrit.cloudera.org:8080/8352 To

[kudu-CR] KUDU-2202 avoid block ID reuse for missing dirs

2017-11-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8465 ) Change subject: KUDU-2202 avoid block ID reuse for missing dirs .. Patch Set 5: (7 comments)

[kudu-CR] KUDU-2202 avoid block ID reuse for missing dirs

2017-11-03 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8465 to look at the new patch set (#5). Change subject: KUDU-2202 avoid block ID reuse for missing dirs

[kudu-CR] KUDU-2202 avoid block ID reuse for missing dirs

2017-11-03 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8465 to look at the new patch set (#4). Change subject: KUDU-2202 avoid block ID reuse for missing dirs

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-11-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: mvcc: allow tablet shutdown without completing txs .. Patch Set 22: > Patch Set 22: > > (1 comment) Yeah, I think that

[kudu-CR] WIP: test and fixes for tls socket EINTR issues

2017-11-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#4) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/8462 ) Change subject: WIP: test and fixes for tls socket EINTR issues .. WIP: test and fixes

[kudu-CR] KUDU-2202 avoid block ID reuse for missing dirs

2017-11-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8465 ) Change subject: KUDU-2202 avoid block ID reuse for missing dirs .. Patch Set 3: (10 comments)

[kudu-CR] KUDU-2202 avoid block ID reuse for missing dirs

2017-11-03 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8465 to look at the new patch set (#3). Change subject: KUDU-2202 avoid block ID reuse for missing dirs

[kudu-CR] more

2017-11-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/8468 ) Change subject: more .. Abandoned forgot to rebase -- To view, visit http://gerrit.cloudera.org:8080/8468 To unsubscribe, visit

[kudu-CR] WIP: test and fixes for tls socket EINTR issues

2017-11-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#3) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/8462 ) Change subject: WIP: test and fixes for tls socket EINTR issues .. WIP: test and fixes

[kudu-CR] more

2017-11-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8468 Change subject: more .. more Change-Id: I04b0aaf96731bb67eb47f61280b0e1d617e6a9e9 --- M src/kudu/security/tls_socket-test.cc M

[kudu-CR] KUDU-2202 avoid block ID reuse for missing dirs

2017-11-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8465 ) Change subject: KUDU-2202 avoid block ID reuse for missing dirs .. Patch Set 2: (5 comments)

[kudu-CR] KUDU-2202 avoid block ID reuse for missing dirs

2017-11-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8465 ) Change subject: KUDU-2202 avoid block ID reuse for missing dirs .. Patch Set 1: (11 comments) I think it would also be nice to have an

[kudu-CR] KUDU-2202 avoid block ID reuse for missing dirs

2017-11-03 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8465 to look at the new patch set (#2). Change subject: KUDU-2202 avoid block ID reuse for missing dirs ..

[kudu-CR] KUDU-2202 avoid block ID reuse for missing dirs

2017-11-03 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8465 Change subject: KUDU-2202 avoid block ID reuse for missing dirs .. KUDU-2202 avoid block ID reuse for missing dirs The block manager is

[kudu-CR] WIP: test and fixes for tls socket EINTR issues

2017-11-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8462 ) Change subject: WIP: test and fixes for tls socket EINTR issues .. Patch Set 1: (1 comment)

[kudu-CR] WIP: test and fixes for tls socket EINTR issues

2017-11-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8462 ) Change subject: WIP: test and fixes for tls socket EINTR issues .. Patch Set 1: (1 comment)

[kudu-CR] WIP: test and fixes for tls socket EINTR issues

2017-11-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8462 ) Change subject: WIP: test and fixes for tls socket EINTR issues .. Patch Set 1: (10 comments) Great! It seems I should have wrote

[kudu-CR] cmake: require Java in non-test builds

2017-11-03 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8460 ) Change subject: cmake: require Java in non-test builds .. cmake: require Java in non-test builds The mini-HMS is being built as

[kudu-CR] installation.adoc: add flex dependency

2017-11-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8463 ) Change subject: installation.adoc: add flex dependency .. Patch Set 1: (3 comments)

[kudu-CR] WIP: test and fixes for tls socket EINTR issues

2017-11-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8462 ) Change subject: WIP: test and fixes for tls socket EINTR issues .. Patch Set 1: (4 comments)

[kudu-CR] installation.adoc: add flex dependency

2017-11-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8463 ) Change subject: installation.adoc: add flex dependency .. Patch Set 1: Maybe add to the preflight.py script in thirdparty as well? --

[kudu-CR] installation.adoc: add flex dependency

2017-11-03 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8463 to review the following change. Change subject: installation.adoc: add flex dependency .. installation.adoc: add flex

[kudu-CR] WIP: test and fixes for tls socket EINTR issues

2017-11-03 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8462 to review the following change. Change subject: WIP: test and fixes for tls socket EINTR issues .. WIP: test and

[kudu-CR] Revert "KUDU-2191 (3/n): Add mini HMS option to external mini cluster"

2017-11-03 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has abandoned this change. ( http://gerrit.cloudera.org:8080/8457 ) Change subject: Revert "KUDU-2191 (3/n): Add mini HMS option to external mini cluster" .. Abandoned https://gerrit.cloudera.org/#/c/8460/

[kudu-CR] Revert "KUDU-2191 (2/n): Hive Metastore client"

2017-11-03 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has abandoned this change. ( http://gerrit.cloudera.org:8080/8458 ) Change subject: Revert "KUDU-2191 (2/n): Hive Metastore client" .. Abandoned https://gerrit.cloudera.org/#/c/8460/ supersedes -- To view,

[kudu-CR] cmake: require Java in non-test builds

2017-11-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8460 ) Change subject: cmake: require Java in non-test builds .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] cfile set: don't reset BloomFileReader on error

2017-11-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8440 ) Change subject: cfile_set: don't reset BloomFileReader on error .. Patch Set 4: Verified+1 Andrew meant to add a +1 Verified, not a +1

[kudu-CR] cfile set: don't reset BloomFileReader on error

2017-11-03 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8440 ) Change subject: cfile_set: don't reset BloomFileReader on error .. cfile_set: don't reset BloomFileReader on error There is a

[kudu-CR] cfile set: don't reset BloomFileReader on error

2017-11-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8440 ) Change subject: cfile_set: don't reset BloomFileReader on error .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] cfile set: don't reset BloomFileReader on error

2017-11-03 Thread Adar Dembo (Code Review)
Adar Dembo has removed a vote on this change. Change subject: cfile_set: don't reset BloomFileReader on error .. Removed Code-Review+1 by Andrew Wong -- To view, visit http://gerrit.cloudera.org:8080/8440

[kudu-CR] [tls socket] workaround for TLS short read

2017-11-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8328 ) Change subject: [tls_socket] workaround for TLS short read .. Patch Set 3: (4 comments)

[kudu-CR] cmake: require Java in non-test builds

2017-11-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8460 ) Change subject: cmake: require Java in non-test builds .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] cmake: require Java in non-test builds

2017-11-03 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8460 to look at the new patch set (#2). Change subject: cmake: require Java in non-test builds

[kudu-CR] cmake: require Java in non-test builds

2017-11-03 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8460 to review the following change. Change subject: cmake: require Java in non-test builds .. cmake:

[kudu-CR] [tls socket] workaround for TLS short read

2017-11-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8328 ) Change subject: [tls_socket] workaround for TLS short read .. Patch Set 3: (4 comments)

[kudu-CR] Revert "KUDU-2191 (2/n): Hive Metastore client"

2017-11-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8458 ) Change subject: Revert "KUDU-2191 (2/n): Hive Metastore client" .. Patch Set 2: (2 comments)

[kudu-CR] Revert "KUDU-2191 (2/n): Hive Metastore client"

2017-11-03 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/8458 ) Change subject: Revert "KUDU-2191 (2/n): Hive Metastore client" .. Patch Set 1: (1 comment)

[kudu-CR] Revert "KUDU-2191 (2/n): Hive Metastore client"

2017-11-03 Thread Jean-Daniel Cryans (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8458 to look at the new patch set (#2). Change subject: Revert "KUDU-2191 (2/n): Hive Metastore client"

[kudu-CR] Revert "KUDU-2191 (2/n): Hive Metastore client"

2017-11-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8458 ) Change subject: Revert "KUDU-2191 (2/n): Hive Metastore client" .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-1578. Hybrid clock should ride over brief interruptions in NTP service

2017-11-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8451 ) Change subject: KUDU-1578. Hybrid clock should ride over brief interruptions in NTP service .. Patch Set 4: Code-Review+2 (1 comment)

[kudu-CR] Revert "KUDU-2191 (2/n): Hive Metastore client"

2017-11-03 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has reverted this change. ( http://gerrit.cloudera.org:8080/8458 ) Change subject: Revert "KUDU-2191 (2/n): Hive Metastore client" .. Uploaded patch set 1. -- To view, visit

[kudu-CR] Revert "KUDU-2191 (3/n): Add mini HMS option to external mini cluster"

2017-11-03 Thread Jean-Daniel Cryans (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8457 to review the following change. Change subject: Revert "KUDU-2191 (3/n): Add mini HMS option to external mini cluster"

[kudu-CR] Revert "KUDU-2191 (2/n): Hive Metastore client"

2017-11-03 Thread Jean-Daniel Cryans (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8458 to review the following change. Change subject: Revert "KUDU-2191 (2/n): Hive Metastore client"

[kudu-CR] Revert "KUDU-2191 (3/n): Add mini HMS option to external mini cluster"

2017-11-03 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has reverted this change. ( http://gerrit.cloudera.org:8080/8457 ) Change subject: Revert "KUDU-2191 (3/n): Add mini HMS option to external mini cluster" .. Uploaded patch set 1. -- To view, visit